Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CHIP error constant defines to be consistent and accurate #1640

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Improve CHIP error constant defines to be consistent and accurate #1640

merged 1 commit into from
Jul 17, 2020

Conversation

yufengwangca
Copy link
Contributor

Problem
Lack of error constant defines for persistent storage access, some error constant names are not consistent in naming

Summary of Changes

  • Align CHIP error constant name with consistent naming convention
  • Add CHIP error constants for persistent file access

* Align CHIP error constant name in consistent naming convention
* Add CHIP error constants for persistent file access
@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize
.debug_str,0,167
.debug_macro,0,56
[Unmapped],0,1


@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize
.debug_str,0,167
.debug_macro,0,56
[Unmapped],0,1


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize


@andy31415 andy31415 merged commit cbc90a0 into project-chip:master Jul 17, 2020
@yufengwangca yufengwangca deleted the pr/linux/error branch July 17, 2020 19:33
@woody-apple
Copy link
Contributor

/pullapprove-test

version: 3

# https://developer.github.com/v3/previews/#draft-pull-requests
github_api_version: "shadow-cat-preview"

############################################################
#  Conditions
############################################################

pullapprove_conditions:
    ############################################################
    #  Required status checks
    ############################################################
    - condition: "'*restyle*' in statuses.successful"
      unmet_status: "failure"
      explanation: "Style must be inline before reviewing can be complete"

    ############################################################
    #  License Checks
    ############################################################
    - condition: "'*license/cla*' in statuses.successful"
      unmet_status: "pending"
      explanation: "CLA must be agreed to by all contributors"

    ############################################################
    #  Draft PRs
    ############################################################
    - condition: "'WIP' not in title"
      unmet_status: "pending"
      explanation: "Work in progress"

    - condition: "not draft"
      unmet_status: "pending"
      explanation: "Work in progress"

    ############################################################
    #  Conditions to Skip Review
    ############################################################
    - condition: "base.ref == 'master'"
      unmet_status: "success"
      explanation: "Review not required unless merging to master"

    ############################################################
    #  Bypass reviews
    ############################################################
    - "'hotfix' not in labels"

############################################################
#  Notifications
############################################################

notifications:
    ############################################################
    #  New contributors
    ############################################################
    - when: pull_request.opened
      if: "author_association == 'FIRST_TIME_CONTRIBUTOR'"
      comment: |
          Hey @{{ author }}, thanks for the PR! The review will start once
          the tests and CI checks have passed. If they don't, please review
          the logs and try to fix the issues (ask for help if you can't
          figure it out). A reviewer will be assigned once the tests are
          passing and they'll walk you through getting the PR finished
          and merged.

groups:
    ############################################################
    #  Base Required Reviewers
    ############################################################
    shared-reviewers-amazon:
      type: optional
      conditions:
        - files.include('*')
      reviewers:
        teams: [reviewers-amazon]
    shared-reviewers-apple:
      type: optional
      conditions:
        - files.include('*')
      reviewers:
        teams: [reviewers-apple]
    shared-reviewers-comcast:
      type: optional
      conditions:
        - files.include('*')
      reviewers:
        teams: [reviewers-comcast]
    shared-reviewers-google:
      type: optional
      conditions:
        - files.include('*')
      reviewers:
        teams: [reviewers-google]
    shared-reviewers-samsung:
      type: optional
      conditions:
        - files.include('*')
      reviewers:
        teams: [reviewers-samsung]

    required-reviewers:
        description: >
            [Required
            Reviewers](https://github.com/project-chip/connectedhomeip/blob/master/CONTRIBUTING.md#review-requirements)
            This is the main group of required reviews for general pull
            requests.
        type: required
        requirements:
          - len(groups.approved.include('shared-reviewers-*')) >= 3
        reviews:
          required: 0

kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
…oject-chip#1640)

* Align CHIP error constant name in consistent naming convention
* Add CHIP error constants for persistent file access
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
…oject-chip#1640)

* Align CHIP error constant name in consistent naming convention
* Add CHIP error constants for persistent file access
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request Mar 18, 2024
…R-3232 Refactored ICD defines within AppTask.cpp of sensor,on-off plug, sl-newlight

Merge in WMN_TOOLS/matter from cherry-pick/sensor_icd to RC_2.3.0-1.3-alpha.3

Squashed commit of the following:

commit 0309b0949a935f2cbf138af12f4b1fb6d5ea6e36
Author: Curtis Rahman <[email protected]>
Date:   Wed Mar 13 20:32:16 2024 +0000

    Pull request project-chip#1631: MATTER-3232  ICD consumption Follow-up

    Merge in WMN_TOOLS/matter from bugfix/icd_consumption_followup to silabs

    Squashed commit of the following:

    commit d78d7afecb669362013822d0321dacf410ca0b31
    Author: Curtis Rahman <[email protected]>
    Date:   Fri Mar 8 15:56:36 2024 -0500

        Updated template ICD defines

commit d877165f26ba40cf82c9062780cb19ef281a1996
Author: Curtis Rahman <[email protected]>
Date:   Fri Mar 8 18:35:22 2024 +0000

    Pull request project-chip#1627: MATTER-3232 Refactored ICD defines within AppTask.cpp of sensor,on-off plug, sl-newlight

    Merge in WMN_TOOLS/matter from bugfix/sensor_power_consumption to silabs

    Squashed commit of the following:

    commit 3538f7ee78452a5785a45059f9d91e2a5917ef0f
    Author: Curtis Rahman <[email protected]>
    Date:   Fri Mar 8 13:04:35 2024 -0500

        Updated refactored ICD defines within AppTask.cpp of sensor,on-off plug, sl-newlight
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
…R-3232 Refactored ICD defines within AppTask.cpp of sensor,on-off plug, sl-newlight

Merge in WMN_TOOLS/matter from cherry-pick/sensor_icd to RC_2.3.0-1.3-alpha.3

Squashed commit of the following:

commit 0309b0949a935f2cbf138af12f4b1fb6d5ea6e36
Author: Curtis Rahman <[email protected]>
Date:   Wed Mar 13 20:32:16 2024 +0000

    Pull request project-chip#1631: MATTER-3232  ICD consumption Follow-up

    Merge in WMN_TOOLS/matter from bugfix/icd_consumption_followup to silabs

    Squashed commit of the following:

    commit d78d7afecb669362013822d0321dacf410ca0b31
    Author: Curtis Rahman <[email protected]>
    Date:   Fri Mar 8 15:56:36 2024 -0500

        Updated template ICD defines

commit d877165f26ba40cf82c9062780cb19ef281a1996
Author: Curtis Rahman <[email protected]>
Date:   Fri Mar 8 18:35:22 2024 +0000

    Pull request project-chip#1627: MATTER-3232 Refactored ICD defines within AppTask.cpp of sensor,on-off plug, sl-newlight

    Merge in WMN_TOOLS/matter from bugfix/sensor_power_consumption to silabs

    Squashed commit of the following:

    commit 3538f7ee78452a5785a45059f9d91e2a5917ef0f
    Author: Curtis Rahman <[email protected]>
    Date:   Fri Mar 8 13:04:35 2024 -0500

        Updated refactored ICD defines within AppTask.cpp of sensor,on-off plug, sl-newlight
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants