-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CHIP error constant defines to be consistent and accurate #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Align CHIP error constant name in consistent naming convention * Add CHIP error constants for persistent file access
yufengwangca
requested review from
andy31415,
anush-apple,
BroderickCarlin,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk,
saurabhst and
woody-apple
as code owners
July 17, 2020 17:39
saurabhst
approved these changes
Jul 17, 2020
Size increase report for "gn_nrf-example-build"
Full report output
|
Size increase report for "gn_linux-example-build"
Full report output
|
Size increase report for "nrf-example-build"
Full report output
|
Size increase report for "linux-example-build"
Full report output
|
Size increase report for "esp32-example-build"
Full report output
|
BroderickCarlin
approved these changes
Jul 17, 2020
andy31415
approved these changes
Jul 17, 2020
/pullapprove-test
|
kedars
pushed a commit
to kedars/connectedhomeip
that referenced
this pull request
Jul 21, 2020
…oject-chip#1640) * Align CHIP error constant name in consistent naming convention * Add CHIP error constants for persistent file access
kedars
pushed a commit
to kedars/connectedhomeip
that referenced
this pull request
Jul 21, 2020
…oject-chip#1640) * Align CHIP error constant name in consistent naming convention * Add CHIP error constants for persistent file access
jmartinez-silabs
pushed a commit
to SiliconLabs/matter
that referenced
this pull request
Mar 18, 2024
…R-3232 Refactored ICD defines within AppTask.cpp of sensor,on-off plug, sl-newlight Merge in WMN_TOOLS/matter from cherry-pick/sensor_icd to RC_2.3.0-1.3-alpha.3 Squashed commit of the following: commit 0309b0949a935f2cbf138af12f4b1fb6d5ea6e36 Author: Curtis Rahman <[email protected]> Date: Wed Mar 13 20:32:16 2024 +0000 Pull request project-chip#1631: MATTER-3232 ICD consumption Follow-up Merge in WMN_TOOLS/matter from bugfix/icd_consumption_followup to silabs Squashed commit of the following: commit d78d7afecb669362013822d0321dacf410ca0b31 Author: Curtis Rahman <[email protected]> Date: Fri Mar 8 15:56:36 2024 -0500 Updated template ICD defines commit d877165f26ba40cf82c9062780cb19ef281a1996 Author: Curtis Rahman <[email protected]> Date: Fri Mar 8 18:35:22 2024 +0000 Pull request project-chip#1627: MATTER-3232 Refactored ICD defines within AppTask.cpp of sensor,on-off plug, sl-newlight Merge in WMN_TOOLS/matter from bugfix/sensor_power_consumption to silabs Squashed commit of the following: commit 3538f7ee78452a5785a45059f9d91e2a5917ef0f Author: Curtis Rahman <[email protected]> Date: Fri Mar 8 13:04:35 2024 -0500 Updated refactored ICD defines within AppTask.cpp of sensor,on-off plug, sl-newlight
rcasallas-silabs
pushed a commit
to rcasallas-silabs/connectedhomeip
that referenced
this pull request
Jun 20, 2024
…R-3232 Refactored ICD defines within AppTask.cpp of sensor,on-off plug, sl-newlight Merge in WMN_TOOLS/matter from cherry-pick/sensor_icd to RC_2.3.0-1.3-alpha.3 Squashed commit of the following: commit 0309b0949a935f2cbf138af12f4b1fb6d5ea6e36 Author: Curtis Rahman <[email protected]> Date: Wed Mar 13 20:32:16 2024 +0000 Pull request project-chip#1631: MATTER-3232 ICD consumption Follow-up Merge in WMN_TOOLS/matter from bugfix/icd_consumption_followup to silabs Squashed commit of the following: commit d78d7afecb669362013822d0321dacf410ca0b31 Author: Curtis Rahman <[email protected]> Date: Fri Mar 8 15:56:36 2024 -0500 Updated template ICD defines commit d877165f26ba40cf82c9062780cb19ef281a1996 Author: Curtis Rahman <[email protected]> Date: Fri Mar 8 18:35:22 2024 +0000 Pull request project-chip#1627: MATTER-3232 Refactored ICD defines within AppTask.cpp of sensor,on-off plug, sl-newlight Merge in WMN_TOOLS/matter from bugfix/sensor_power_consumption to silabs Squashed commit of the following: commit 3538f7ee78452a5785a45059f9d91e2a5917ef0f Author: Curtis Rahman <[email protected]> Date: Fri Mar 8 13:04:35 2024 -0500 Updated refactored ICD defines within AppTask.cpp of sensor,on-off plug, sl-newlight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Lack of error constant defines for persistent storage access, some error constant names are not consistent in naming
Summary of Changes