-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restyle Add support for nRF Connect SDK #1638
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Nordic platform layer of CHIP is based on nRF5 SDK. This commit is the first step needed to replace it with nRF Connect SDK based on Zephyr RTOS. While the old platform layer remains unchanged, add a CMake helper file which allows to build the entire CHIP using the NCS/Zephyr build system.
Rewrite everything which doesn't depend on the CHIP platform layers using the NCS/Zephyr API. This includes functionality of the sample app related to LEDs, buttons, timers, message queues and logging.
Implement PlatformManagerImpl for nRF Connect SDK based on generic implementation for Zephyr RTOS. Also provide initial implementation of functions to retrieve system time using Zephyr API and add Zephyr-based logging backend. The code compiles, but it requires other components to be tested.
This commit adds empty implementations of base platform functions.
This commit enables the OT stack in the Zephyr application. The ThreadStackManager allows the CHIP stack to control the state of the stack embedded into the Zephyr. It is required that all calls to this class are to be made from a cooperative task priority.
Make necessary changes to build CHIP Inet library using Zephyr networking API. Zephyr provides BSD-like socket interface, however a few things are missing: - some socket-related functions are not available, e.g. getsockname, recvmsg etc. Implement required replacements. - some constants are not available. In particular, some options passed to the setsockopt function must have been made optional. In case e.g. explicit multicast group management is needed we will have find another ways to implement that in Zephyr. - the whole ifaddrs library doesn't exist in Zephyr, so all the interface/address enumeration code must have been implemented for Zephyr. - disable TCP end point for nRF Connect SDK platform for now as it will require further changes.
Co-authored-by: Rafał Kuźnia <[email protected]>
Size increase report for "gn_nrf-example-build"
Full report output
|
Size increase report for "gn_linux-example-build"
Full report output
|
Size increase report for "nrf-example-build"
Full report output
|
Size increase report for "linux-example-build"
Full report output
|
Size increase report for "esp32-example-build"
Full report output
|
jmartinez-silabs
pushed a commit
to SiliconLabs/matter
that referenced
this pull request
Mar 18, 2024
…R-3235 Cherry-pick: Fix gendiag network interface attribute (project-chip#32390) Merge in WMN_TOOLS/matter from cherry-pick/fix_gendiag_network_interface to RC_2.3.0-1.3-alpha.3 Squashed commit of the following: commit 933bdcd4d196d5d0ec9c18933a54ebb28450c679 Author: Junior Martinez <[email protected]> Date: Tue Mar 5 20:40:01 2024 +0000 Pull request project-chip#1610: MATTER-3235 Cherry-pick: Fix gendiag network interface attribute (project-chip#32390) Merge in WMN_TOOLS/matter from cherry-pick/fix_gendiag_networkinterace to RC_2.3.0-1.3 Squashed commit of the following: commit 247758db24fd10d49d8376b561905aae96b2cbaf Author: Junior Martinez <[email protected]> Date: Fri Mar 1 20:02:29 2024 -0500 Fix gendiag network interface attribute (project-chip#32390)
rcasallas-silabs
pushed a commit
to rcasallas-silabs/connectedhomeip
that referenced
this pull request
Jun 20, 2024
…R-3235 Cherry-pick: Fix gendiag network interface attribute (project-chip#32390) Merge in WMN_TOOLS/matter from cherry-pick/fix_gendiag_network_interface to RC_2.3.0-1.3-alpha.3 Squashed commit of the following: commit 933bdcd4d196d5d0ec9c18933a54ebb28450c679 Author: Junior Martinez <[email protected]> Date: Tue Mar 5 20:40:01 2024 +0000 Pull request project-chip#1610: MATTER-3235 Cherry-pick: Fix gendiag network interface attribute (project-chip#32390) Merge in WMN_TOOLS/matter from cherry-pick/fix_gendiag_networkinterace to RC_2.3.0-1.3 Squashed commit of the following: commit 247758db24fd10d49d8376b561905aae96b2cbaf Author: Junior Martinez <[email protected]> Date: Fri Mar 1 20:02:29 2024 -0500 Fix gendiag network interface attribute (project-chip#32390)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A duplicate of #1494 with additional commits that automatically address
incorrect style, created by Restyled.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.
The following Restylers made fixes:
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Expand for example instructions
NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.
Sorry if this was unexpected. To disable it, see our documentation.