Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Add support for nRF Connect SDK #1638

Closed
wants to merge 11 commits into from
Closed

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Jul 17, 2020

A duplicate of #1494 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • whitespace

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

Damian-Nordic and others added 11 commits July 17, 2020 16:20
Currently Nordic platform layer of CHIP is based on nRF5
SDK. This commit is the first step needed to replace it
with nRF Connect SDK based on Zephyr RTOS. While the old
platform layer remains unchanged, add a CMake helper file
which allows to build the entire CHIP using the NCS/Zephyr
build system.
Rewrite everything which doesn't depend on the CHIP platform
layers using the NCS/Zephyr API. This includes functionality
of the sample app related to LEDs, buttons, timers, message
queues and logging.
Implement PlatformManagerImpl for nRF Connect SDK based on
generic implementation for Zephyr RTOS. Also provide initial
implementation of functions to retrieve system time using
Zephyr API and add Zephyr-based logging backend.

The code compiles, but it requires other components to be
tested.
This commit adds empty implementations of base platform functions.
This commit enables the OT stack in the Zephyr application.
The ThreadStackManager allows the CHIP stack to control the
state of the stack embedded into the Zephyr.
It is required that all calls to this class are to be made
from a cooperative task priority.
Make necessary changes to build CHIP Inet library using
Zephyr networking API. Zephyr provides BSD-like socket
interface, however a few things are missing:

- some socket-related functions are not available, e.g.
  getsockname, recvmsg etc. Implement required
  replacements.
- some constants are not available. In particular, some
  options passed to the setsockopt function must have been
  made optional. In case e.g. explicit multicast group
  management is needed we will have find another ways
  to implement that in Zephyr.
- the whole ifaddrs library doesn't exist in Zephyr, so
  all the interface/address enumeration code must have been
  implemented for Zephyr.
- disable TCP end point for nRF Connect SDK platform for
  now as it will require further changes.
@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize
.debug_str,0,38
.debug_line,0,7
.debug_macro,0,7
.debug_info,0,5
[Unmapped],0,-3
.debug_abbrev,0,-82


@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
chip-standalone-demo.out .text -16 -16
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize
.debug_loc,0,446
.debug_info,0,294
.debug_ranges,0,160
.debug_str,0,117
.debug_line,0,52
.debug_macro,0,14
[Unmapped],0,14
.text,-16,-16
.debug_abbrev,0,-161


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize
.debug_info,0,4
[Unmapped],0,2
.debug_line,0,1
.debug_abbrev,0,-43


jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request Mar 18, 2024
…R-3235 Cherry-pick: Fix gendiag network interface attribute (project-chip#32390)

Merge in WMN_TOOLS/matter from cherry-pick/fix_gendiag_network_interface to RC_2.3.0-1.3-alpha.3

Squashed commit of the following:

commit 933bdcd4d196d5d0ec9c18933a54ebb28450c679
Author: Junior Martinez <[email protected]>
Date:   Tue Mar 5 20:40:01 2024 +0000

    Pull request project-chip#1610: MATTER-3235 Cherry-pick: Fix gendiag network interface attribute (project-chip#32390)

    Merge in WMN_TOOLS/matter from cherry-pick/fix_gendiag_networkinterace to RC_2.3.0-1.3

    Squashed commit of the following:

    commit 247758db24fd10d49d8376b561905aae96b2cbaf
    Author: Junior Martinez <[email protected]>
    Date:   Fri Mar 1 20:02:29 2024 -0500

        Fix gendiag network interface attribute (project-chip#32390)
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
…R-3235 Cherry-pick: Fix gendiag network interface attribute (project-chip#32390)

Merge in WMN_TOOLS/matter from cherry-pick/fix_gendiag_network_interface to RC_2.3.0-1.3-alpha.3

Squashed commit of the following:

commit 933bdcd4d196d5d0ec9c18933a54ebb28450c679
Author: Junior Martinez <[email protected]>
Date:   Tue Mar 5 20:40:01 2024 +0000

    Pull request project-chip#1610: MATTER-3235 Cherry-pick: Fix gendiag network interface attribute (project-chip#32390)

    Merge in WMN_TOOLS/matter from cherry-pick/fix_gendiag_networkinterace to RC_2.3.0-1.3

    Squashed commit of the following:

    commit 247758db24fd10d49d8376b561905aae96b2cbaf
    Author: Junior Martinez <[email protected]>
    Date:   Fri Mar 1 20:02:29 2024 -0500

        Fix gendiag network interface attribute (project-chip#32390)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants