Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IM] Fix verious corner cases for event chunking #16346

Merged
merged 8 commits into from
Mar 29, 2022
Merged

[IM] Fix verious corner cases for event chunking #16346

merged 8 commits into from
Mar 29, 2022

Conversation

erjiaqing
Copy link
Contributor

Problem

There are some corner cases when reading events and attributes at the same time.

  • What if attribute data used all buffers, and we cannot try to encode anything?

    We need to reserve a few bytes so we can at least check if we can encode anything.

  • What if we have encoded some attributes, and the event is too large to fit into the remaining space.

    We should not skip it in this case, let's wait for next chunk.

  • We may miss one event between chunks (increasing counter by mistake)

    Do not increase aEventMin when buffer is too small to fit current event data, it should be reported in the next chunk.

  • When attributes is followed by a series of chunks of events, OnReportEnd will not be called.

    Record a transaction wide mIsAttributeReportIBsPresent to deliver OnReportEnd() at the end of report.

Change overview

The cases above is fixed, and is verified by the tests added.

Testing

src/controller/tests/TestReadChunking.cpp

@github-actions
Copy link

github-actions bot commented Mar 17, 2022 •
edited
Loading

PR #16346: Size comparison from 4f22a79 to c8f5707

Increases (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 4f22a79 c8f5707 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603426 603554 128 0.0
.app_xip_area 510524 510652 128 0.0
lock cyw930739m2evb_01 (read/write) 561222 561350 128 0.0
.app_xip_area 469848 469976 128 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571026 571154 128 0.0
.app_xip_area 470004 470132 128 0.0
efr32 lighting-app BRD4161A (read only) 920956 921132 176 0.0
.text 920948 921124 176 0.0
BRD4161A+rpc (read only) 949760 949936 176 0.0
.text 949752 949928 176 0.0
window-app BRD4161A (read only) 851708 851868 160 0.0
.text 851700 851860 160 0.0
esp32 all-clusters-app c3devkit (read only) 961334 961474 140 0.0
.flash.text 961334 961474 140 0.0
m5stack (read only) 1017311 1017487 176 0.0
.flash.text 1011927 1012103 176 0.0
k32w light k32w061+release (read/write) 700112 700240 128 0.0
.text 614792 614920 128 0.0
lock k32w061+release (read/write) 700408 700552 144 0.0
.text 615076 615220 144 0.0
linux chip-tool-ipv6only arm64 (read only) 9754764 9755388 624 0.0
.text 8212468 8213092 624 0.0
thermostat-no-ble arm64 (read only) 2220292 2220932 640 0.0
.text 1862496 1863136 640 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2352364 2353012 648 0.0
.text 1314964 1315612 648 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154847 1154975 128 0.0
text 787424 787564 140 0.0
p6 all-clusters-app default (read/write) 2491760 2491920 160 0.0
.text 1450024 1450184 160 0.0
light-app default (read/write) 2395528 2395704 176 0.0
.text 1353792 1353968 176 0.0
lock-app default (read/write) 2359072 2359248 176 0.0
.text 1317336 1317512 176 0.0
telink lighting-app tlsr9518adk80d (read/write) 894946 895098 152 0.0
text 632808 632956 148 0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 4f22a79 c8f5707 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603426 603554 128 0.0
.app_xip_area 510524 510652 128 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561222 561350 128 0.0
.app_xip_area 469848 469976 128 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571026 571154 128 0.0
.app_xip_area 470004 470132 128 0.0
.bss 83464 83464 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920956 921132 176 0.0
(read/write) 128752 128752 0 0.0
.bss 126744 126744 0 0.0
.data 2008 2008 0 0.0
.text 920948 921124 176 0.0
BRD4161A+rpc (read only) 949760 949936 176 0.0
(read/write) 144712 144712 0 0.0
.bss 142520 142520 0 0.0
.data 2188 2188 0 0.0
.text 949752 949928 176 0.0
window-app BRD4161A (read only) 851708 851868 160 0.0
(read/write) 126704 126704 0 0.0
.bss 124840 124840 0 0.0
.data 1864 1864 0 0.0
.text 851700 851860 160 0.0
esp32 all-clusters-app c3devkit (read only) 961334 961474 140 0.0
(read/write) 1394818 1394818 0 0.0
.dram0.bss 64048 64048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197672 197672 0 0.0
.flash.text 961334 961474 140 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017311 1017487 176 0.0
(read/write) 462484 462484 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 227056 227056 0 0.0
.flash.text 1011927 1012103 176 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 700112 700240 128 0.0
.bss 77632 77632 0 0.0
.data 1888 1888 0 0.0
.text 614792 614920 128 0.0
lock k32w061+release (read/write) 700408 700552 144 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615076 615220 144 0.0
linux chip-tool-ipv6only arm64 (read only) 9754764 9755388 624 0.0
(read/write) 475505 475505 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371288 371288 0 0.0
.dynamic 560 560 0 0.0
.got 55264 55264 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492308 492308 0 0.0
.text 8212468 8213092 624 0.0
thermostat-no-ble arm64 (read only) 2220292 2220932 640 0.0
(read/write) 149809 149809 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137732 137732 0 0.0
.text 1862496 1863136 640 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352364 2353012 648 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1314964 1315612 648 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154847 1154975 128 0.0
bss 146724 146724 0 0.0
rodata 145536 145536 0 0.0
text 787424 787564 140 0.0
p6 all-clusters-app default (read/write) 2491760 2491920 160 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1450024 1450184 160 0.0
light-app default (read/write) 2395528 2395704 176 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1353792 1353968 176 0.0
lock-app default (read/write) 2359072 2359248 176 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317336 1317512 176 0.0
telink lighting-app tlsr9518adk80d (read/write) 894946 895098 152 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 632808 632956 148 0.0

@erjiaqing
Copy link
Contributor Author

/rebase

@woody-apple woody-apple force-pushed the im/fix-event-chunking branch from c8f5707 to 50bb769 Compare March 18, 2022 09:41
@github-actions
Copy link

github-actions bot commented Mar 18, 2022 •
edited
Loading

PR #16346: Size comparison from f68cca0 to 50bb769

Increases (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section f68cca0 50bb769 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603610 603738 128 0.0
.app_xip_area 510708 510836 128 0.0
lock cyw930739m2evb_01 (read/write) 561398 561526 128 0.0
.app_xip_area 470024 470152 128 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571114 571242 128 0.0
.app_xip_area 470092 470220 128 0.0
efr32 lighting-app BRD4161A (read only) 921448 921608 160 0.0
.text 921440 921600 160 0.0
BRD4161A+rpc (read only) 950252 950428 176 0.0
.text 950244 950420 176 0.0
window-app BRD4161A (read only) 852008 852184 176 0.0
.text 852000 852176 176 0.0
esp32 all-clusters-app c3devkit (read only) 961538 961678 140 0.0
.flash.text 961538 961678 140 0.0
m5stack (read only) 1017691 1017859 168 0.0
.flash.text 1012307 1012475 168 0.0
k32w light k32w061+release (read/write) 700580 700724 144 0.0
.text 615260 615404 144 0.0
lock k32w061+release (read/write) 700716 700844 128 0.0
.text 615384 615512 128 0.0
linux chip-tool-ipv6only arm64 (read only) 9767676 9768300 624 0.0
.text 8222692 8223316 624 0.0
thermostat-no-ble arm64 (read only) 2221604 2222228 624 0.0
.text 1863584 1864208 624 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2352876 2353460 584 0.0
.text 1315476 1316060 584 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155287 1155431 144 0.0
text 787640 787776 136 0.0
p6 all-clusters-app default (read/write) 2492200 2492360 160 0.0
.text 1450464 1450624 160 0.0
light-app default (read/write) 2395768 2395928 160 0.0
.text 1354032 1354192 160 0.0
lock-app default (read/write) 2359312 2359472 160 0.0
.text 1317576 1317736 160 0.0
telink lighting-app tlsr9518adk80d (read/write) 895346 895498 152 0.0
text 633008 633156 148 0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section f68cca0 50bb769 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603610 603738 128 0.0
.app_xip_area 510708 510836 128 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561398 561526 128 0.0
.app_xip_area 470024 470152 128 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571114 571242 128 0.0
.app_xip_area 470092 470220 128 0.0
.bss 83464 83464 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921448 921608 160 0.0
(read/write) 128752 128752 0 0.0
.bss 126744 126744 0 0.0
.data 2008 2008 0 0.0
.text 921440 921600 160 0.0
BRD4161A+rpc (read only) 950252 950428 176 0.0
(read/write) 144708 144708 0 0.0
.bss 142520 142520 0 0.0
.data 2188 2188 0 0.0
.text 950244 950420 176 0.0
window-app BRD4161A (read only) 852008 852184 176 0.0
(read/write) 126704 126704 0 0.0
.bss 124840 124840 0 0.0
.data 1864 1864 0 0.0
.text 852000 852176 176 0.0
esp32 all-clusters-app c3devkit (read only) 961538 961678 140 0.0
(read/write) 1395034 1395034 0 0.0
.dram0.bss 64048 64048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197888 197888 0 0.0
.flash.text 961538 961678 140 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017691 1017859 168 0.0
(read/write) 462892 462892 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 227464 227464 0 0.0
.flash.text 1012307 1012475 168 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 700580 700724 144 0.0
.bss 77632 77632 0 0.0
.data 1888 1888 0 0.0
.text 615260 615404 144 0.0
lock k32w061+release (read/write) 700716 700844 128 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615384 615512 128 0.0
linux chip-tool-ipv6only arm64 (read only) 9767676 9768300 624 0.0
(read/write) 476113 476113 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371824 371824 0 0.0
.dynamic 560 560 0 0.0
.got 55328 55328 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493620 493620 0 0.0
.text 8222692 8223316 624 0.0
thermostat-no-ble arm64 (read only) 2221604 2222228 624 0.0
(read/write) 149809 149809 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137956 137956 0 0.0
.text 1863584 1864208 624 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352876 2353460 584 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1315476 1316060 584 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155287 1155431 144 0.0
bss 146724 146724 0 0.0
rodata 145768 145768 0 0.0
text 787640 787776 136 0.0
p6 all-clusters-app default (read/write) 2492200 2492360 160 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1450464 1450624 160 0.0
light-app default (read/write) 2395768 2395928 160 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1354032 1354192 160 0.0
lock-app default (read/write) 2359312 2359472 160 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317576 1317736 160 0.0
telink lighting-app tlsr9518adk80d (read/write) 895346 895498 152 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 633008 633156 148 0.0

bzbarsky-apple
bzbarsky-apple reviewed Mar 19, 2022
View reviewed changes
src/app/ReadClient.h Outdated Show resolved Hide resolved
src/app/reporting/Engine.cpp Outdated Show resolved Hide resolved
src/app/reporting/Engine.cpp Show resolved Hide resolved
src/app/reporting/Engine.cpp Show resolved Hide resolved
src/app/reporting/Engine.cpp Outdated Show resolved Hide resolved
bzbarsky-apple
bzbarsky-apple approved these changes Mar 22, 2022
View reviewed changes
src/app/reporting/Engine.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Mar 29, 2022 •
edited
Loading

PR #16346: Size comparison from 514af46 to 406b657

Increases (16 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 514af46 406b657 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 605498 605658 160 0.0
.app_xip_area 512428 512588 160 0.0
lock cyw930739m2evb_01 (read/write) 563286 563454 168 0.0
.app_xip_area 471744 471912 168 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575546 575714 168 0.0
.app_xip_area 474356 474524 168 0.0
efr32 lighting-app BRD4161A (read only) 926664 926856 192 0.0
.text 926656 926848 192 0.0
BRD4161A+rpc (read only) 955480 955656 176 0.0
.text 955472 955648 176 0.0
window-app BRD4161A (read only) 856052 856228 176 0.0
.text 856044 856220 176 0.0
k32w light k32w061+release (read/write) 704320 704480 160 0.0
.text 618836 618996 160 0.0
lock k32w061+release (read/write) 703428 703588 160 0.0
.text 617928 618088 160 0.0
linux chip-tool-ipv6only arm64 (read only) 9849660 9850316 656 0.0
.text 8301972 8302628 656 0.0
thermostat-no-ble arm64 (read only) 2275348 2275988 640 0.0
.text 1911952 1912592 640 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2355708 2356356 648 0.0
.text 1318308 1318956 648 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1143459 1143619 160 0.0
text 783316 783480 164 0.0
p6 all-clusters-app default (read/write) 2498448 2498640 192 0.0
.text 1456712 1456904 192 0.0
light-app default (read/write) 2400896 2401072 176 0.0
.text 1359160 1359336 176 0.0
lock-app default (read/write) 2364400 2364592 192 0.0
.text 1322664 1322856 192 0.0
telink lighting-app tlsr9518adk80d (read/write) 787556 787740 184 0.0
text 557952 558132 180 0.0
Full report (16 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 514af46 406b657 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 605498 605658 160 0.0
.app_xip_area 512428 512588 160 0.0
.bss 75816 75816 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563286 563454 168 0.0
.app_xip_area 471744 471912 168 0.0
.bss 74320 74320 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575546 575714 168 0.0
.app_xip_area 474356 474524 168 0.0
.bss 83648 83648 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 926664 926856 192 0.0
(read/write) 128952 128952 0 0.0
.bss 126952 126952 0 0.0
.data 1996 1996 0 0.0
.text 926656 926848 192 0.0
BRD4161A+rpc (read only) 955480 955656 176 0.0
(read/write) 144904 144904 0 0.0
.bss 142728 142728 0 0.0
.data 2176 2176 0 0.0
.text 955472 955648 176 0.0
window-app BRD4161A (read only) 856052 856228 176 0.0
(read/write) 126912 126912 0 0.0
.bss 125040 125040 0 0.0
.data 1872 1872 0 0.0
.text 856044 856220 176 0.0
k32w light k32w061+release (read/write) 704320 704480 160 0.0
.bss 77808 77808 0 0.0
.data 1876 1876 0 0.0
.text 618836 618996 160 0.0
lock k32w061+release (read/write) 703428 703588 160 0.0
.bss 77784 77784 0 0.0
.data 1916 1916 0 0.0
.text 617928 618088 160 0.0
linux chip-tool-ipv6only arm64 (read only) 9849660 9850316 656 0.0
(read/write) 473713 473713 0 0.0
.bss 40737 40737 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372656 372656 0 0.0
.dynamic 560 560 0 0.0
.got 55368 55368 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 494468 494468 0 0.0
.text 8301972 8302628 656 0.0
thermostat-no-ble arm64 (read only) 2275348 2275988 640 0.0
(read/write) 148369 148369 0 0.0
.bss 62817 62817 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4504 4504 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 140036 140036 0 0.0
.text 1911952 1912592 640 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2355708 2356356 648 0.0
.bss 184860 184860 0 0.0
.data 5760 5760 0 0.0
.text 1318308 1318956 648 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1143459 1143619 160 0.0
bss 142892 142892 0 0.0
rodata 142364 142364 0 0.0
text 783316 783480 164 0.0
p6 all-clusters-app default (read/write) 2498448 2498640 192 0.0
.bss 118280 118280 0 0.0
.data 2640 2640 0 0.0
.text 1456712 1456904 192 0.0
light-app default (read/write) 2400896 2401072 176 0.0
.bss 111752 111752 0 0.0
.data 2496 2496 0 0.0
.text 1359160 1359336 176 0.0
lock-app default (read/write) 2364400 2364592 192 0.0
.bss 111496 111496 0 0.0
.data 2456 2456 0 0.0
.text 1322664 1322856 192 0.0
telink lighting-app tlsr9518adk80d (read/write) 787556 787740 184 0.0
bss 70092 70092 0 0.0
noinit 40416 40416 0 0.0
text 557952 558132 180 0.0

@github-actions
Copy link

github-actions bot commented Mar 29, 2022 •
edited
Loading

PR #16346: Size comparison from 514af46 to f4751ee

Increases (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 514af46 f4751ee change % change
cyw30739 light cyw930739m2evb_01 (read/write) 605498 605658 160 0.0
.app_xip_area 512428 512588 160 0.0
lock cyw930739m2evb_01 (read/write) 563286 563454 168 0.0
.app_xip_area 471744 471912 168 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575546 575714 168 0.0
.app_xip_area 474356 474524 168 0.0
efr32 lighting-app BRD4161A (read only) 926664 926856 192 0.0
.text 926656 926848 192 0.0
BRD4161A+rpc (read only) 955480 955656 176 0.0
.text 955472 955648 176 0.0
window-app BRD4161A (read only) 856052 856228 176 0.0
.text 856044 856220 176 0.0
esp32 all-clusters-app c3devkit (read only) 966788 966964 176 0.0
.flash.text 966788 966964 176 0.0
k32w light k32w061+release (read/write) 704320 704480 160 0.0
.text 618836 618996 160 0.0
lock k32w061+release (read/write) 703428 703588 160 0.0
.text 617928 618088 160 0.0
linux all-clusters-app debug (read only) 2526169 2526921 752 0.0
.text 2145794 2146546 752 0.0
bridge-app debug+rpc (read only) 1765389 1766141 752 0.0
.text 1505349 1506101 752 0.0
chip-tool debug (read only) 10228469 10229237 768 0.0
.text 8924805 8925573 768 0.0
chip-tool-ipv6only arm64 (read only) 9849660 9850316 656 0.0
.text 8301972 8302628 656 0.0
door-lock-app debug (read only) 2017217 2017969 752 0.0
.text 1686130 1686882 752 0.0
lighting-app debug+rpc (read only) 2191665 2192417 752 0.0
.text 1857138 1857890 752 0.0
ota-provider-app debug (read only) 1958057 1958809 752 0.0
.text 1639074 1639826 752 0.0
ota-requestor-app debug (read only) 1985649 1986401 752 0.0
.text 1669538 1670290 752 0.0
shell debug (read only) 2441801 2442553 752 0.0
.text 2074818 2075570 752 0.0
thermostat-no-ble arm64 (read only) 2275348 2275988 640 0.0
.text 1911952 1912592 640 0.0
tv-app debug (read only) 2691473 2692241 768 0.0
.text 2310786 2311554 768 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2355708 2356356 648 0.0
.text 1318308 1318956 648 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1143459 1143619 160 0.0
text 783316 783480 164 0.0
p6 all-clusters-app default (read/write) 2498448 2498640 192 0.0
.text 1456712 1456904 192 0.0
light-app default (read/write) 2400896 2401072 176 0.0
.text 1359160 1359336 176 0.0
lock-app default (read/write) 2364400 2364592 192 0.0
.text 1322664 1322856 192 0.0
telink lighting-app tlsr9518adk80d (read/write) 787556 787740 184 0.0
text 557952 558132 180 0.0
Decreases (1 build for esp32)
platform target config section 514af46 f4751ee change % change
esp32 all-clusters-app m5stack (read only) 1023211 1023055 -156 -0.0
.flash.text 1017827 1017671 -156 -0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 514af46 f4751ee change % change
cyw30739 light cyw930739m2evb_01 (read/write) 605498 605658 160 0.0
.app_xip_area 512428 512588 160 0.0
.bss 75816 75816 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563286 563454 168 0.0
.app_xip_area 471744 471912 168 0.0
.bss 74320 74320 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575546 575714 168 0.0
.app_xip_area 474356 474524 168 0.0
.bss 83648 83648 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 926664 926856 192 0.0
(read/write) 128952 128952 0 0.0
.bss 126952 126952 0 0.0
.data 1996 1996 0 0.0
.text 926656 926848 192 0.0
BRD4161A+rpc (read only) 955480 955656 176 0.0
(read/write) 144904 144904 0 0.0
.bss 142728 142728 0 0.0
.data 2176 2176 0 0.0
.text 955472 955648 176 0.0
window-app BRD4161A (read only) 856052 856228 176 0.0
(read/write) 126912 126912 0 0.0
.bss 125040 125040 0 0.0
.data 1872 1872 0 0.0
.text 856044 856220 176 0.0
esp32 all-clusters-app c3devkit (read only) 966788 966964 176 0.0
(read/write) 1394810 1394810 0 0.0
.dram0.bss 62240 62240 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 199456 199456 0 0.0
.flash.text 966788 966964 176 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1023211 1023055 -156 -0.0
(read/write) 462572 462572 0 0.0
.dram0.bss 67768 67768 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228944 228944 0 0.0
.flash.text 1017827 1017671 -156 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 704320 704480 160 0.0
.bss 77808 77808 0 0.0
.data 1876 1876 0 0.0
.text 618836 618996 160 0.0
lock k32w061+release (read/write) 703428 703588 160 0.0
.bss 77784 77784 0 0.0
.data 1916 1916 0 0.0
.text 617928 618088 160 0.0
linux all-clusters-app debug (read only) 2526169 2526921 752 0.0
(read/write) 143352 143352 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78920 78920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 216549 216549 0 0.0
.text 2145794 2146546 752 0.0
bridge-app debug+rpc (read only) 1765389 1766141 752 0.0
(read/write) 89520 89520 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144684 144684 0 0.0
.text 1505349 1506101 752 0.0
chip-tool debug (read only) 10228469 10229237 768 0.0
(read/write) 355656 355656 0 0.0
.bss 22464 22464 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 326008 326008 0 0.0
.dynamic 608 608 0 0.0
.got 4824 4824 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 519125 519125 0 0.0
.text 8924805 8925573 768 0.0
chip-tool-ipv6only arm64 (read only) 9849660 9850316 656 0.0
(read/write) 473713 473713 0 0.0
.bss 40737 40737 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372656 372656 0 0.0
.dynamic 560 560 0 0.0
.got 55368 55368 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 494468 494468 0 0.0
.text 8301972 8302628 656 0.0
door-lock-app debug (read only) 2017217 2017969 752 0.0
(read/write) 116896 116896 0 0.0
.bss 47648 47648 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181276 181276 0 0.0
.text 1686130 1686882 752 0.0
lighting-app debug+rpc (read only) 2191665 2192417 752 0.0
(read/write) 123888 123888 0 0.0
.bss 48928 48928 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175356 175356 0 0.0
.text 1857138 1857890 752 0.0
ota-provider-app debug (read only) 1958057 1958809 752 0.0
(read/write) 112688 112688 0 0.0
.bss 47584 47584 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58184 58184 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 167115 167115 0 0.0
.text 1639074 1639826 752 0.0
ota-requestor-app debug (read only) 1985649 1986401 752 0.0
(read/write) 115912 115912 0 0.0
.bss 48512 48512 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60440 60440 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 163236 163236 0 0.0
.text 1669538 1670290 752 0.0
shell debug (read only) 2441801 2442553 752 0.0
(read/write) 147368 147368 0 0.0
.bss 67304 67304 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73568 73568 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 210034 210034 0 0.0
.text 2074818 2075570 752 0.0
thermostat-no-ble arm64 (read only) 2275348 2275988 640 0.0
(read/write) 148369 148369 0 0.0
.bss 62817 62817 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4504 4504 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 140036 140036 0 0.0
.text 1911952 1912592 640 0.0
tv-app debug (read only) 2691473 2692241 768 0.0
(read/write) 247520 247520 0 0.0
.bss 164288 164288 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74048 74048 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206059 206059 0 0.0
.text 2310786 2311554 768 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2355708 2356356 648 0.0
.bss 184860 184860 0 0.0
.data 5760 5760 0 0.0
.text 1318308 1318956 648 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1143459 1143619 160 0.0
bss 142892 142892 0 0.0
rodata 142364 142364 0 0.0
text 783316 783480 164 0.0
p6 all-clusters-app default (read/write) 2498448 2498640 192 0.0
.bss 118280 118280 0 0.0
.data 2640 2640 0 0.0
.text 1456712 1456904 192 0.0
light-app default (read/write) 2400896 2401072 176 0.0
.bss 111752 111752 0 0.0
.data 2496 2496 0 0.0
.text 1359160 1359336 176 0.0
lock-app default (read/write) 2364400 2364592 192 0.0
.bss 111496 111496 0 0.0
.data 2456 2456 0 0.0
.text 1322664 1322856 192 0.0
telink lighting-app tlsr9518adk80d (read/write) 787556 787740 184 0.0
bss 70092 70092 0 0.0
noinit 40416 40416 0 0.0
text 557952 558132 180 0.0

@github-actions
Copy link

github-actions bot commented Mar 29, 2022 •
edited
Loading

PR #16346: Size comparison from 514af46 to ff11ff7

Increases (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 514af46 ff11ff7 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 605498 605658 160 0.0
.app_xip_area 512428 512588 160 0.0
lock cyw930739m2evb_01 (read/write) 563286 563454 168 0.0
.app_xip_area 471744 471912 168 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575546 575714 168 0.0
.app_xip_area 474356 474524 168 0.0
efr32 lighting-app BRD4161A (read only) 926664 926856 192 0.0
.text 926656 926848 192 0.0
BRD4161A+rpc (read only) 955480 955656 176 0.0
.text 955472 955648 176 0.0
window-app BRD4161A (read only) 856052 856228 176 0.0
.text 856044 856220 176 0.0
esp32 all-clusters-app c3devkit (read only) 966788 966964 176 0.0
.flash.text 966788 966964 176 0.0
k32w light k32w061+release (read/write) 704320 704480 160 0.0
.text 618836 618996 160 0.0
lock k32w061+release (read/write) 703428 703588 160 0.0
.text 617928 618088 160 0.0
linux all-clusters-app debug (read only) 2526169 2526921 752 0.0
.text 2145794 2146546 752 0.0
bridge-app debug+rpc (read only) 1765389 1766141 752 0.0
.text 1505349 1506101 752 0.0
chip-tool debug (read only) 10228469 10229237 768 0.0
.text 8924805 8925573 768 0.0
chip-tool-ipv6only arm64 (read only) 9849660 9850316 656 0.0
.text 8301972 8302628 656 0.0
door-lock-app debug (read only) 2017217 2017969 752 0.0
.text 1686130 1686882 752 0.0
lighting-app debug+rpc (read only) 2191665 2192417 752 0.0
.text 1857138 1857890 752 0.0
ota-provider-app debug (read only) 1958057 1958809 752 0.0
.text 1639074 1639826 752 0.0
ota-requestor-app debug (read only) 1985649 1986401 752 0.0
.text 1669538 1670290 752 0.0
shell debug (read only) 2441801 2442553 752 0.0
.text 2074818 2075570 752 0.0
thermostat-no-ble arm64 (read only) 2275348 2275988 640 0.0
.text 1911952 1912592 640 0.0
tv-app debug (read only) 2691473 2692241 768 0.0
.text 2310786 2311554 768 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2355708 2356356 648 0.0
.text 1318308 1318956 648 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1143459 1143619 160 0.0
text 783316 783480 164 0.0
p6 all-clusters-app default (read/write) 2498448 2498640 192 0.0
.text 1456712 1456904 192 0.0
light-app default (read/write) 2400896 2401072 176 0.0
.text 1359160 1359336 176 0.0
lock-app default (read/write) 2364400 2364592 192 0.0
.text 1322664 1322856 192 0.0
telink lighting-app tlsr9518adk80d (read/write) 787556 787740 184 0.0
text 557952 558132 180 0.0
Decreases (1 build for esp32)
platform target config section 514af46 ff11ff7 change % change
esp32 all-clusters-app m5stack (read only) 1023211 1023055 -156 -0.0
.flash.text 1017827 1017671 -156 -0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 514af46 ff11ff7 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 605498 605658 160 0.0
.app_xip_area 512428 512588 160 0.0
.bss 75816 75816 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563286 563454 168 0.0
.app_xip_area 471744 471912 168 0.0
.bss 74320 74320 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575546 575714 168 0.0
.app_xip_area 474356 474524 168 0.0
.bss 83648 83648 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 926664 926856 192 0.0
(read/write) 128952 128952 0 0.0
.bss 126952 126952 0 0.0
.data 1996 1996 0 0.0
.text 926656 926848 192 0.0
BRD4161A+rpc (read only) 955480 955656 176 0.0
(read/write) 144904 144904 0 0.0
.bss 142728 142728 0 0.0
.data 2176 2176 0 0.0
.text 955472 955648 176 0.0
window-app BRD4161A (read only) 856052 856228 176 0.0
(read/write) 126912 126912 0 0.0
.bss 125040 125040 0 0.0
.data 1872 1872 0 0.0
.text 856044 856220 176 0.0
esp32 all-clusters-app c3devkit (read only) 966788 966964 176 0.0
(read/write) 1394810 1394810 0 0.0
.dram0.bss 62240 62240 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 199456 199456 0 0.0
.flash.text 966788 966964 176 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1023211 1023055 -156 -0.0
(read/write) 462572 462572 0 0.0
.dram0.bss 67768 67768 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228944 228944 0 0.0
.flash.text 1017827 1017671 -156 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 704320 704480 160 0.0
.bss 77808 77808 0 0.0
.data 1876 1876 0 0.0
.text 618836 618996 160 0.0
lock k32w061+release (read/write) 703428 703588 160 0.0
.bss 77784 77784 0 0.0
.data 1916 1916 0 0.0
.text 617928 618088 160 0.0
linux all-clusters-app debug (read only) 2526169 2526921 752 0.0
(read/write) 143352 143352 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78920 78920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 216549 216549 0 0.0
.text 2145794 2146546 752 0.0
bridge-app debug+rpc (read only) 1765389 1766141 752 0.0
(read/write) 89520 89520 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144684 144684 0 0.0
.text 1505349 1506101 752 0.0
chip-tool debug (read only) 10228469 10229237 768 0.0
(read/write) 355656 355656 0 0.0
.bss 22464 22464 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 326008 326008 0 0.0
.dynamic 608 608 0 0.0
.got 4824 4824 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 519125 519125 0 0.0
.text 8924805 8925573 768 0.0
chip-tool-ipv6only arm64 (read only) 9849660 9850316 656 0.0
(read/write) 473713 473713 0 0.0
.bss 40737 40737 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372656 372656 0 0.0
.dynamic 560 560 0 0.0
.got 55368 55368 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 494468 494468 0 0.0
.text 8301972 8302628 656 0.0
door-lock-app debug (read only) 2017217 2017969 752 0.0
(read/write) 116896 116896 0 0.0
.bss 47648 47648 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181276 181276 0 0.0
.text 1686130 1686882 752 0.0
lighting-app debug+rpc (read only) 2191665 2192417 752 0.0
(read/write) 123888 123888 0 0.0
.bss 48928 48928 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175356 175356 0 0.0
.text 1857138 1857890 752 0.0
ota-provider-app debug (read only) 1958057 1958809 752 0.0
(read/write) 112688 112688 0 0.0
.bss 47584 47584 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58184 58184 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 167115 167115 0 0.0
.text 1639074 1639826 752 0.0
ota-requestor-app debug (read only) 1985649 1986401 752 0.0
(read/write) 115912 115912 0 0.0
.bss 48512 48512 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60440 60440 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 163236 163236 0 0.0
.text 1669538 1670290 752 0.0
shell debug (read only) 2441801 2442553 752 0.0
(read/write) 147368 147368 0 0.0
.bss 67304 67304 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73568 73568 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 210034 210034 0 0.0
.text 2074818 2075570 752 0.0
thermostat-no-ble arm64 (read only) 2275348 2275988 640 0.0
(read/write) 148369 148369 0 0.0
.bss 62817 62817 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4504 4504 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 140036 140036 0 0.0
.text 1911952 1912592 640 0.0
tv-app debug (read only) 2691473 2692241 768 0.0
(read/write) 247520 247520 0 0.0
.bss 164288 164288 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74048 74048 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206059 206059 0 0.0
.text 2310786 2311554 768 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2355708 2356356 648 0.0
.bss 184860 184860 0 0.0
.data 5760 5760 0 0.0
.text 1318308 1318956 648 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1143459 1143619 160 0.0
bss 142892 142892 0 0.0
rodata 142364 142364 0 0.0
text 783316 783480 164 0.0
p6 all-clusters-app default (read/write) 2498448 2498640 192 0.0
.bss 118280 118280 0 0.0
.data 2640 2640 0 0.0
.text 1456712 1456904 192 0.0
light-app default (read/write) 2400896 2401072 176 0.0
.bss 111752 111752 0 0.0
.data 2496 2496 0 0.0
.text 1359160 1359336 176 0.0
lock-app default (read/write) 2364400 2364592 192 0.0
.bss 111496 111496 0 0.0
.data 2456 2456 0 0.0
.text 1322664 1322856 192 0.0
telink lighting-app tlsr9518adk80d (read/write) 787556 787740 184 0.0
bss 70092 70092 0 0.0
noinit 40416 40416 0 0.0
text 557952 558132 180 0.0

@erjiaqing erjiaqing merged commit 74beee2 into project-chip:master Mar 29, 2022
@erjiaqing erjiaqing deleted the im/fix-event-chunking branch March 29, 2022 15:42
rochaferraz pushed a commit to rochaferraz/connectedhomeip that referenced this pull request Mar 31, 2022
@erjiaqing @andy31415
@bzbarsky-apple @rochaferraz
[IM] Fix verious corner cases for event chunking (project-chip#16346)
cf7ffce 
* [IM] Fix verious corner cases for event chunking

* Fix typo

* Lift timeout by 5 min

* Update src/app/reporting/Engine.cpp

Co-authored-by: Boris Zbarsky <[email protected]>

* Make test a bit faster

* Fix

* Cleanup

Co-authored-by: Andrei Litvin <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@erjiaqing @andy31415
@bzbarsky-apple @andrei-menzopol
[IM] Fix verious corner cases for event chunking (project-chip#16346)
24f0412 
* [IM] Fix verious corner cases for event chunking

* Fix typo

* Lift timeout by 5 min

* Update src/app/reporting/Engine.cpp

Co-authored-by: Boris Zbarsky <[email protected]>

* Make test a bit faster

* Fix

* Cleanup

Co-authored-by: Andrei Litvin <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app controller github review - approved workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erjiaqing @yunhanw-google @bzbarsky-apple @andy31415