Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clang variant to host builds #16325

Merged
merged 10 commits into from
Mar 18, 2022
Merged

Add clang variant to host builds #16325

merged 10 commits into from
Mar 18, 2022

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Mar 16, 2022 •
edited
Loading

Problem

Need clang variant explicit in build_examples:

  • fuzzer, asan and msan require clang
  • running clang_tidy generally wants clang-compatible output

Change overview

Add clang variants, better dependency definitions for types

Testing

Manually inspected targets
Ran:

./scripts/build/build_examples.py --target linux-x64-all-clusters-no-ble-asan-libfuzzer-clang build

to test a compile

@restyled-io restyled-io bot mentioned this pull request Mar 16, 2022
Closed
@github-actions
Copy link

github-actions bot commented Mar 16, 2022 •
edited
Loading

PR #16325: Size comparison from 0c43841 to f04808d

Increases (8 builds for esp32, linux, mbed, p6)
platform target config section 0c43841 f04808d change % change
esp32 all-clusters-app c3devkit (read only) 961006 961044 38 0.0
(read/write) 1394690 1394706 16 0.0
.flash.rodata 197544 197560 16 0.0
.flash.text 961006 961044 38 0.0
m5stack (read only) 1017043 1017055 12 0.0
(read/write) 462364 462380 16 0.0
.flash.rodata 226936 226952 16 0.0
.flash.text 1011659 1011671 12 0.0
linux chip-tool-ipv6only arm64 (read only) 9753444 9753604 160 0.0
.rodata 492348 492364 16 0.0
.text 8211204 8211348 144 0.0
thermostat-no-ble arm64 (read only) 2219164 2219292 128 0.0
.rodata 137660 137676 16 0.0
.text 1861536 1861648 112 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2351980 2352068 88 0.0
.text 1314580 1314668 88 0.0
p6 all-clusters-app default (read/write) 2491232 2491280 48 0.0
.text 1449496 1449544 48 0.0
light-app default (read/write) 2395088 2395136 48 0.0
.text 1353352 1353400 48 0.0
lock-app default (read/write) 2358632 2358680 48 0.0
.text 1316896 1316944 48 0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0c43841 f04808d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603122 603122 0 0.0
.app_xip_area 510220 510220 0 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560910 560910 0 0.0
.app_xip_area 469536 469536 0 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570794 570794 0 0.0
.app_xip_area 469772 469772 0 0.0
.bss 83464 83464 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920572 920572 0 0.0
(read/write) 128752 128752 0 0.0
.bss 126744 126744 0 0.0
.data 2008 2008 0 0.0
.text 920564 920564 0 0.0
BRD4161A+rpc (read only) 949392 949392 0 0.0
(read/write) 144712 144712 0 0.0
.bss 142520 142520 0 0.0
.data 2188 2188 0 0.0
.text 949384 949384 0 0.0
window-app BRD4161A (read only) 851336 851336 0 0.0
(read/write) 126704 126704 0 0.0
.bss 124840 124840 0 0.0
.data 1864 1864 0 0.0
.text 851328 851328 0 0.0
esp32 all-clusters-app c3devkit (read only) 961006 961044 38 0.0
(read/write) 1394690 1394706 16 0.0
.dram0.bss 64048 64048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197544 197560 16 0.0
.flash.text 961006 961044 38 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017043 1017055 12 0.0
(read/write) 462364 462380 16 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 226936 226952 16 0.0
.flash.text 1011659 1011671 12 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699800 699800 0 0.0
.bss 77632 77632 0 0.0
.data 1888 1888 0 0.0
.text 614480 614480 0 0.0
lock k32w061+release (read/write) 700096 700096 0 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 614764 614764 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9753444 9753604 160 0.0
(read/write) 475473 475473 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371256 371256 0 0.0
.dynamic 560 560 0 0.0
.got 55264 55264 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492348 492364 16 0.0
.text 8211204 8211348 144 0.0
thermostat-no-ble arm64 (read only) 2219164 2219292 128 0.0
(read/write) 149777 149777 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75696 75696 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137660 137676 16 0.0
.text 1861536 1861648 112 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351980 2352068 88 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1314580 1314668 88 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154487 1154487 0 0.0
bss 146724 146724 0 0.0
rodata 145432 145432 0 0.0
text 787180 787180 0 0.0
p6 all-clusters-app default (read/write) 2491232 2491280 48 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1449496 1449544 48 0.0
light-app default (read/write) 2395088 2395136 48 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1353352 1353400 48 0.0
lock-app default (read/write) 2358632 2358680 48 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1316896 1316944 48 0.0
telink lighting-app tlsr9518adk80d (read/write) 894566 894566 0 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 632492 632492 0 0.0

@andy31415 andy31415 force-pushed the add_clang_variant_to_host_builds branch from f04808d to 34da06b Compare March 17, 2022 13:38
@andy31415 andy31415 marked this pull request as ready for review March 17, 2022 13:38
@github-actions
Copy link

github-actions bot commented Mar 17, 2022 •
edited
Loading

PR #16325: Size comparison from 4f22a79 to 34da06b

Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 4f22a79 34da06b change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603426 603426 0 0.0
.app_xip_area 510524 510524 0 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561222 561222 0 0.0
.app_xip_area 469848 469848 0 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571026 571026 0 0.0
.app_xip_area 470004 470004 0 0.0
.bss 83464 83464 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920956 920956 0 0.0
(read/write) 128752 128752 0 0.0
.bss 126744 126744 0 0.0
.data 2008 2008 0 0.0
.text 920948 920948 0 0.0
BRD4161A+rpc (read only) 949760 949760 0 0.0
(read/write) 144712 144712 0 0.0
.bss 142520 142520 0 0.0
.data 2188 2188 0 0.0
.text 949752 949752 0 0.0
window-app BRD4161A (read only) 851708 851708 0 0.0
(read/write) 126704 126704 0 0.0
.bss 124840 124840 0 0.0
.data 1864 1864 0 0.0
.text 851700 851700 0 0.0
esp32 all-clusters-app c3devkit (read only) 961334 961334 0 0.0
(read/write) 1394818 1394818 0 0.0
.dram0.bss 64048 64048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197672 197672 0 0.0
.flash.text 961334 961334 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017311 1017311 0 0.0
(read/write) 462484 462484 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 227056 227056 0 0.0
.flash.text 1011927 1011927 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 700112 700112 0 0.0
.bss 77632 77632 0 0.0
.data 1888 1888 0 0.0
.text 614792 614792 0 0.0
lock k32w061+release (read/write) 700408 700408 0 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615076 615076 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9754764 9754764 0 0.0
(read/write) 475505 475505 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371288 371288 0 0.0
.dynamic 560 560 0 0.0
.got 55264 55264 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492308 492308 0 0.0
.text 8212468 8212468 0 0.0
thermostat-no-ble arm64 (read only) 2220292 2220292 0 0.0
(read/write) 149809 149809 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137732 137732 0 0.0
.text 1862496 1862496 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352364 2352364 0 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1314964 1314964 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154847 1154847 0 0.0
bss 146724 146724 0 0.0
rodata 145536 145536 0 0.0
text 787424 787424 0 0.0
p6 all-clusters-app default (read/write) 2491760 2491760 0 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1450024 1450024 0 0.0
light-app default (read/write) 2395528 2395528 0 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1353792 1353792 0 0.0
lock-app default (read/write) 2359072 2359072 0 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317336 1317336 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 894946 894946 0 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 632808 632808 0 0.0

@andy31415 andy31415 mentioned this pull request Mar 17, 2022
Merged
@github-actions
Copy link

github-actions bot commented Mar 17, 2022 •
edited
Loading

PR #16325: Size comparison from 4f22a79 to a45f79c

Increases (7 builds for esp32, linux, nrfconnect, p6, telink)
platform target config section 4f22a79 a45f79c change % change
esp32 all-clusters-app c3devkit (read only) 961334 961358 24 0.0
.flash.text 961334 961358 24 0.0
m5stack (read only) 1017311 1017511 200 0.0
(read/write) 462484 462660 176 0.0
.flash.rodata 227056 227232 176 0.1
.flash.text 1011927 1012127 200 0.0
linux chip-tool-ipv6only arm64 (read only) 9754764 9764284 9520 0.1
(read/write) 475505 476113 608 0.1
.data.rel.ro 371288 371824 536 0.1
.got 55264 55328 64 0.1
.rodata 492308 492996 688 0.1
.text 8212468 8219924 7456 0.1
thermostat-no-ble arm64 (read only) 2220292 2220324 32 0.0
.text 1862496 1862528 32 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 787424 787432 8 0.0
p6 all-clusters-app default (read/write) 2491760 2491776 16 0.0
.text 1450024 1450040 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 894946 894970 24 0.0
text 632808 632832 24 0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 4f22a79 a45f79c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603426 603426 0 0.0
.app_xip_area 510524 510524 0 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561222 561222 0 0.0
.app_xip_area 469848 469848 0 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571026 571026 0 0.0
.app_xip_area 470004 470004 0 0.0
.bss 83464 83464 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920956 920956 0 0.0
(read/write) 128752 128752 0 0.0
.bss 126744 126744 0 0.0
.data 2008 2008 0 0.0
.text 920948 920948 0 0.0
BRD4161A+rpc (read only) 949760 949760 0 0.0
(read/write) 144712 144712 0 0.0
.bss 142520 142520 0 0.0
.data 2188 2188 0 0.0
.text 949752 949752 0 0.0
window-app BRD4161A (read only) 851708 851708 0 0.0
(read/write) 126704 126704 0 0.0
.bss 124840 124840 0 0.0
.data 1864 1864 0 0.0
.text 851700 851700 0 0.0
esp32 all-clusters-app c3devkit (read only) 961334 961358 24 0.0
(read/write) 1394818 1394818 0 0.0
.dram0.bss 64048 64048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197672 197672 0 0.0
.flash.text 961334 961358 24 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017311 1017511 200 0.0
(read/write) 462484 462660 176 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 227056 227232 176 0.1
.flash.text 1011927 1012127 200 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 700112 700112 0 0.0
.bss 77632 77632 0 0.0
.data 1888 1888 0 0.0
.text 614792 614792 0 0.0
lock k32w061+release (read/write) 700408 700408 0 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615076 615076 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9754764 9764284 9520 0.1
(read/write) 475505 476113 608 0.1
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371288 371824 536 0.1
.dynamic 560 560 0 0.0
.got 55264 55328 64 0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492308 492996 688 0.1
.text 8212468 8219924 7456 0.1
thermostat-no-ble arm64 (read only) 2220292 2220324 32 0.0
(read/write) 149809 149809 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137732 137732 0 0.0
.text 1862496 1862528 32 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352364 2352364 0 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1314964 1314964 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154847 1154847 0 0.0
bss 146724 146724 0 0.0
rodata 145536 145536 0 0.0
text 787424 787432 8 0.0
p6 all-clusters-app default (read/write) 2491760 2491776 16 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1450024 1450040 16 0.0
light-app default (read/write) 2395528 2395528 0 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1353792 1353792 0 0.0
lock-app default (read/write) 2359072 2359072 0 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317336 1317336 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 894946 894970 24 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 632808 632832 24 0.0

@github-actions
Copy link

github-actions bot commented Mar 17, 2022 •
edited
Loading

PR #16325: Size comparison from 4f22a79 to 09f7c8e

Increases (7 builds for esp32, linux, nrfconnect, p6, telink)
platform target config section 4f22a79 09f7c8e change % change
esp32 all-clusters-app c3devkit (read only) 961334 961358 24 0.0
.flash.text 961334 961358 24 0.0
m5stack (read only) 1017311 1017511 200 0.0
(read/write) 462484 462660 176 0.0
.flash.rodata 227056 227232 176 0.1
.flash.text 1011927 1012127 200 0.0
linux chip-tool-ipv6only arm64 (read only) 9754764 9764284 9520 0.1
(read/write) 475505 476113 608 0.1
.data.rel.ro 371288 371824 536 0.1
.got 55264 55328 64 0.1
.rodata 492308 492996 688 0.1
.text 8212468 8219924 7456 0.1
thermostat-no-ble arm64 (read only) 2220292 2220324 32 0.0
.text 1862496 1862528 32 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 787424 787432 8 0.0
p6 all-clusters-app default (read/write) 2491760 2491776 16 0.0
.text 1450024 1450040 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 894946 894970 24 0.0
text 632808 632832 24 0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 4f22a79 09f7c8e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603426 603426 0 0.0
.app_xip_area 510524 510524 0 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561222 561222 0 0.0
.app_xip_area 469848 469848 0 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571026 571026 0 0.0
.app_xip_area 470004 470004 0 0.0
.bss 83464 83464 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920956 920956 0 0.0
(read/write) 128752 128752 0 0.0
.bss 126744 126744 0 0.0
.data 2008 2008 0 0.0
.text 920948 920948 0 0.0
BRD4161A+rpc (read only) 949760 949760 0 0.0
(read/write) 144712 144712 0 0.0
.bss 142520 142520 0 0.0
.data 2188 2188 0 0.0
.text 949752 949752 0 0.0
window-app BRD4161A (read only) 851708 851708 0 0.0
(read/write) 126704 126704 0 0.0
.bss 124840 124840 0 0.0
.data 1864 1864 0 0.0
.text 851700 851700 0 0.0
esp32 all-clusters-app c3devkit (read only) 961334 961358 24 0.0
(read/write) 1394818 1394818 0 0.0
.dram0.bss 64048 64048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197672 197672 0 0.0
.flash.text 961334 961358 24 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017311 1017511 200 0.0
(read/write) 462484 462660 176 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 227056 227232 176 0.1
.flash.text 1011927 1012127 200 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 700112 700112 0 0.0
.bss 77632 77632 0 0.0
.data 1888 1888 0 0.0
.text 614792 614792 0 0.0
lock k32w061+release (read/write) 700408 700408 0 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615076 615076 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9754764 9764284 9520 0.1
(read/write) 475505 476113 608 0.1
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371288 371824 536 0.1
.dynamic 560 560 0 0.0
.got 55264 55328 64 0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492308 492996 688 0.1
.text 8212468 8219924 7456 0.1
thermostat-no-ble arm64 (read only) 2220292 2220324 32 0.0
(read/write) 149809 149809 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137732 137732 0 0.0
.text 1862496 1862528 32 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352364 2352364 0 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1314964 1314964 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154847 1154847 0 0.0
bss 146724 146724 0 0.0
rodata 145536 145536 0 0.0
text 787424 787432 8 0.0
p6 all-clusters-app default (read/write) 2491760 2491776 16 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1450024 1450040 16 0.0
light-app default (read/write) 2395528 2395528 0 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1353792 1353792 0 0.0
lock-app default (read/write) 2359072 2359072 0 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317336 1317336 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 894946 894970 24 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 632808 632832 24 0.0

@github-actions
Copy link

github-actions bot commented Mar 18, 2022 •
edited
Loading

PR #16325: Size comparison from f68cca0 to b1b5724

Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section f68cca0 b1b5724 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603610 603610 0 0.0
.app_xip_area 510708 510708 0 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561398 561398 0 0.0
.app_xip_area 470024 470024 0 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571114 571114 0 0.0
.app_xip_area 470092 470092 0 0.0
.bss 83464 83464 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921448 921448 0 0.0
(read/write) 128752 128752 0 0.0
.bss 126744 126744 0 0.0
.data 2008 2008 0 0.0
.text 921440 921440 0 0.0
BRD4161A+rpc (read only) 950252 950252 0 0.0
(read/write) 144708 144708 0 0.0
.bss 142520 142520 0 0.0
.data 2188 2188 0 0.0
.text 950244 950244 0 0.0
window-app BRD4161A (read only) 852008 852008 0 0.0
(read/write) 126704 126704 0 0.0
.bss 124840 124840 0 0.0
.data 1864 1864 0 0.0
.text 852000 852000 0 0.0
esp32 all-clusters-app c3devkit (read only) 961538 961538 0 0.0
(read/write) 1395034 1395034 0 0.0
.dram0.bss 64048 64048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197888 197888 0 0.0
.flash.text 961538 961538 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017691 1017691 0 0.0
(read/write) 462892 462892 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 227464 227464 0 0.0
.flash.text 1012307 1012307 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 700580 700580 0 0.0
.bss 77632 77632 0 0.0
.data 1888 1888 0 0.0
.text 615260 615260 0 0.0
lock k32w061+release (read/write) 700716 700716 0 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615384 615384 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9767676 9767676 0 0.0
(read/write) 476113 476113 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371824 371824 0 0.0
.dynamic 560 560 0 0.0
.got 55328 55328 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493620 493620 0 0.0
.text 8222692 8222692 0 0.0
thermostat-no-ble arm64 (read only) 2221604 2221604 0 0.0
(read/write) 149809 149809 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137956 137956 0 0.0
.text 1863584 1863584 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352876 2352876 0 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1315476 1315476 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155287 1155287 0 0.0
bss 146724 146724 0 0.0
rodata 145768 145768 0 0.0
text 787640 787640 0 0.0
p6 all-clusters-app default (read/write) 2492200 2492200 0 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1450464 1450464 0 0.0
light-app default (read/write) 2395768 2395768 0 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1354032 1354032 0 0.0
lock-app default (read/write) 2359312 2359312 0 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317576 1317576 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 895346 895346 0 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 633008 633008 0 0.0

@boring-cyborg boring-cyborg bot added the app label Mar 18, 2022
@github-actions
Copy link

github-actions bot commented Mar 18, 2022 •
edited
Loading

PR #16325: Size comparison from f68cca0 to d156e81

Increases (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section f68cca0 d156e81 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603610 603874 264 0.0
.app_xip_area 510708 510972 264 0.1
lock cyw930739m2evb_01 (read/write) 561398 561654 256 0.0
.app_xip_area 470024 470280 256 0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571114 571506 392 0.1
.app_xip_area 470092 470484 392 0.1
.bss 83464 83488 24 0.0
efr32 lighting-app BRD4161A (read only) 921448 921992 544 0.1
(read/write) 128752 128760 8 0.0
.bss 126744 126768 24 0.0
.text 921440 921984 544 0.1
BRD4161A+rpc (read only) 950252 950812 560 0.1
(read/write) 144708 144712 4 0.0
.bss 142520 142544 24 0.0
.text 950244 950804 560 0.1
window-app BRD4161A (read only) 852008 852296 288 0.0
(read/write) 126704 126712 8 0.0
.bss 124840 124848 8 0.0
.text 852000 852288 288 0.0
esp32 all-clusters-app c3devkit (read only) 961538 961856 318 0.0
(read/write) 1395034 1395066 32 0.0
.flash.rodata 197888 197920 32 0.0
.flash.text 961538 961856 318 0.0
m5stack (read only) 1017691 1017939 248 0.0
(read/write) 462892 462924 32 0.0
.flash.rodata 227464 227496 32 0.0
.flash.text 1012307 1012555 248 0.0
k32w light k32w061+release (read/write) 700580 701104 524 0.1
.bss 77632 77656 24 0.0
.text 615260 615780 520 0.1
lock k32w061+release (read/write) 700716 700964 248 0.0
.text 615384 615632 248 0.0
linux chip-tool-ipv6only arm64 (read only) 9767676 9768076 400 0.0
.text 8222692 8223092 400 0.0
thermostat-no-ble arm64 (read only) 2221604 2222724 1120 0.1
.rodata 137956 137988 32 0.0
.text 1863584 1864672 1088 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2352876 2353164 288 0.0
.text 1315476 1315764 288 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155287 1155763 476 0.0
rodata 145768 145892 124 0.1
text 787640 787992 352 0.0
p6 all-clusters-app default (read/write) 2492200 2492496 296 0.0
.text 1450464 1450760 296 0.0
light-app default (read/write) 2395768 2396080 312 0.0
.text 1354032 1354344 312 0.0
lock-app default (read/write) 2359312 2359624 312 0.0
.text 1317576 1317888 312 0.0
telink lighting-app tlsr9518adk80d (read/write) 895346 895702 356 0.0
text 633008 633326 318 0.1
Decreases (4 builds for cyw30739, efr32, k32w)
platform target config section f68cca0 d156e81 change % change
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 .data 520 500 -20 -3.8
efr32 lighting-app BRD4161A .data 2008 1988 -20 -1.0
BRD4161A+rpc .data 2188 2168 -20 -0.9
k32w light k32w061+release .data 1888 1868 -20 -1.1
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section f68cca0 d156e81 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603610 603874 264 0.0
.app_xip_area 510708 510972 264 0.1
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561398 561654 256 0.0
.app_xip_area 470024 470280 256 0.1
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571114 571506 392 0.1
.app_xip_area 470092 470484 392 0.1
.bss 83464 83488 24 0.0
.data 520 500 -20 -3.8
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921448 921992 544 0.1
(read/write) 128752 128760 8 0.0
.bss 126744 126768 24 0.0
.data 2008 1988 -20 -1.0
.text 921440 921984 544 0.1
BRD4161A+rpc (read only) 950252 950812 560 0.1
(read/write) 144708 144712 4 0.0
.bss 142520 142544 24 0.0
.data 2188 2168 -20 -0.9
.text 950244 950804 560 0.1
window-app BRD4161A (read only) 852008 852296 288 0.0
(read/write) 126704 126712 8 0.0
.bss 124840 124848 8 0.0
.data 1864 1864 0 0.0
.text 852000 852288 288 0.0
esp32 all-clusters-app c3devkit (read only) 961538 961856 318 0.0
(read/write) 1395034 1395066 32 0.0
.dram0.bss 64048 64048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197888 197920 32 0.0
.flash.text 961538 961856 318 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017691 1017939 248 0.0
(read/write) 462892 462924 32 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 227464 227496 32 0.0
.flash.text 1012307 1012555 248 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 700580 701104 524 0.1
.bss 77632 77656 24 0.0
.data 1888 1868 -20 -1.1
.text 615260 615780 520 0.1
lock k32w061+release (read/write) 700716 700964 248 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615384 615632 248 0.0
linux chip-tool-ipv6only arm64 (read only) 9767676 9768076 400 0.0
(read/write) 476113 476113 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371824 371824 0 0.0
.dynamic 560 560 0 0.0
.got 55328 55328 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493620 493620 0 0.0
.text 8222692 8223092 400 0.0
thermostat-no-ble arm64 (read only) 2221604 2222724 1120 0.1
(read/write) 149809 149809 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137956 137988 32 0.0
.text 1863584 1864672 1088 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352876 2353164 288 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1315476 1315764 288 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155287 1155763 476 0.0
bss 146724 146724 0 0.0
rodata 145768 145892 124 0.1
text 787640 787992 352 0.0
p6 all-clusters-app default (read/write) 2492200 2492496 296 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1450464 1450760 296 0.0
light-app default (read/write) 2395768 2396080 312 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1354032 1354344 312 0.0
lock-app default (read/write) 2359312 2359624 312 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317576 1317888 312 0.0
telink lighting-app tlsr9518adk80d (read/write) 895346 895702 356 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 633008 633326 318 0.1

@andy31415
Copy link
Contributor Author

fast track: has been up for a while, generally just changes build variants (the most disruptive being the rename required for libfuzzing and some clang ordering)

@andy31415 andy31415 merged commit 894f373 into project-chip:master Mar 18, 2022
@andy31415 andy31415 mentioned this pull request Mar 18, 2022
Closed
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@andy31415 @andrei-menzopol
Add clang variant to host builds (project-chip#16325)
59d0078 
* Make clang variant as a requirement for asan/tsan builds, add support for required variants for build systems

* Restyle

* Also update workflows

* Adjust test group ordering since we have placed clang as a last variant

* More moving of chip tool variants to make the options in yaml file make sense

* add missin $ for var specifier

* Add clang variant to tsan

* Asan/tsan not limited by clang, so updated as such

* Restyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app examples fast track github review - pending scripts workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy31415 @bzbarsky-apple