Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use clang-tidy to modernize-use-override #16307

Merged
merged 2 commits into from
Mar 17, 2022
Merged

use clang-tidy to modernize-use-override #16307

merged 2 commits into from
Mar 17, 2022

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Mar 16, 2022 •
edited
Loading

Problem

Override not consistently used. Generally it seems mostly destructors (not too bad) but a few instances in methods also seem off (redundant virtual and missing override)

Change overview

Ran:

./.environment/cipd/packages/pigweed/bin/run-clang-tidy -p ./out/linux-x64-chip-tool-clang/ -fix -checks modernize-use-override 'connectedhomeip/src/'

Testing

Automated tool ran. Visually this looks ok. CI can validate.

@restyled-io restyled-io bot mentioned this pull request Mar 16, 2022
Closed
@github-actions
Copy link

github-actions bot commented Mar 16, 2022 •
edited
Loading

PR #16307: Size comparison from 645b03b to bf9c583

Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 645b03b bf9c583 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603282 603282 0 0.0
.app_xip_area 510380 510380 0 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561070 561070 0 0.0
.app_xip_area 469696 469696 0 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570954 570954 0 0.0
.app_xip_area 469932 469932 0 0.0
.bss 83464 83464 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920740 920740 0 0.0
(read/write) 128752 128752 0 0.0
.bss 126744 126744 0 0.0
.data 2008 2008 0 0.0
.text 920732 920732 0 0.0
BRD4161A+rpc (read only) 949544 949544 0 0.0
(read/write) 144712 144712 0 0.0
.bss 142520 142520 0 0.0
.data 2188 2188 0 0.0
.text 949536 949536 0 0.0
window-app BRD4161A (read only) 851488 851488 0 0.0
(read/write) 126712 126712 0 0.0
.bss 124848 124848 0 0.0
.data 1864 1864 0 0.0
.text 851480 851480 0 0.0
esp32 all-clusters-app c3devkit (read only) 961162 961162 0 0.0
(read/write) 1394690 1394690 0 0.0
.dram0.bss 64048 64048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197544 197544 0 0.0
.flash.text 961162 961162 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017251 1017251 0 0.0
(read/write) 462364 462364 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 226936 226936 0 0.0
.flash.text 1011867 1011867 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699960 699960 0 0.0
.bss 77632 77632 0 0.0
.data 1888 1888 0 0.0
.text 614640 614640 0 0.0
lock k32w061+release (read/write) 700256 700256 0 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 614924 614924 0 0.0
linux all-clusters-app debug (read only) 2471121 2471121 0 0.0
(read/write) 146544 146544 0 0.0
.bss 60736 60736 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78808 78808 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 210853 210853 0 0.0
.text 2096914 2096914 0 0.0
bridge-app debug+rpc (read only) 1747453 1747453 0 0.0
(read/write) 92720 92720 0 0.0
.bss 47784 47784 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 37904 37904 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 143564 143564 0 0.0
.text 1488773 1488773 0 0.0
chip-tool debug (read only) 10127373 10127373 0 0.0
(read/write) 357720 357720 0 0.0
.bss 25728 25728 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 324864 324864 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 515669 515669 0 0.0
.text 8830373 8830373 0 0.0
chip-tool-ipv6only arm64 (read only) 9754132 9754132 0 0.0
(read/write) 475473 475473 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371256 371256 0 0.0
.dynamic 560 560 0 0.0
.got 55264 55264 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492348 492348 0 0.0
.text 8211892 8211892 0 0.0
door-lock-app debug (read only) 1998585 1998585 0 0.0
(read/write) 120192 120192 0 0.0
.bss 51008 51008 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62808 62808 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 179740 179740 0 0.0
.text 1669282 1669282 0 0.0
lighting-app debug+rpc (read only) 2130201 2130201 0 0.0
(read/write) 125512 125512 0 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66760 66760 0 0.0
.dynamic 608 608 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 172316 172316 0 0.0
.text 1801298 1801298 0 0.0
ota-provider-app debug (read only) 1933633 1933633 0 0.0
(read/write) 116016 116016 0 0.0
.bss 50912 50912 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 58168 58168 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 165739 165739 0 0.0
.text 1616226 1616226 0 0.0
ota-requestor-app debug (read only) 1963417 1963417 0 0.0
(read/write) 118984 118984 0 0.0
.bss 51904 51904 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 60232 60232 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 161764 161764 0 0.0
.text 1649762 1649762 0 0.0
shell debug (read only) 2421345 2421345 0 0.0
(read/write) 150600 150600 0 0.0
.bss 70664 70664 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73440 73440 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 208850 208850 0 0.0
.text 2055890 2055890 0 0.0
thermostat-no-ble arm64 (read only) 2219868 2219868 0 0.0
(read/write) 149777 149777 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75696 75696 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137660 137660 0 0.0
.text 1862240 1862240 0 0.0
tv-app debug (read only) 2669889 2669889 0 0.0
(read/write) 251192 251192 0 0.0
.bss 167904 167904 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 74152 74152 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 205621 205621 0 0.0
.text 2289538 2289538 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352172 2352172 0 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1314772 1314772 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154647 1154647 0 0.0
bss 146724 146724 0 0.0
rodata 145432 145432 0 0.0
text 787340 787340 0 0.0
p6 all-clusters-app default (read/write) 2491392 2491392 0 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1449656 1449656 0 0.0
light-app default (read/write) 2395248 2395248 0 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1353512 1353512 0 0.0
lock-app default (read/write) 2358792 2358792 0 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317056 1317056 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 894566 894566 0 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 632492 632492 0 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restyle?

@andy31415
Copy link
Contributor Author

/rebase

@woody-apple woody-apple force-pushed the modernize_use_override branch from a16f22f to 23e8835 Compare March 16, 2022 21:52
@github-actions
Copy link

github-actions bot commented Mar 16, 2022 •
edited
Loading

PR #16307: Size comparison from ba133af to 23e8835

Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ba133af 23e8835 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603418 603418 0 0.0
.app_xip_area 510516 510516 0 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561206 561206 0 0.0
.app_xip_area 469832 469832 0 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571010 571010 0 0.0
.app_xip_area 469988 469988 0 0.0
.bss 83464 83464 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920940 920940 0 0.0
(read/write) 128752 128752 0 0.0
.bss 126744 126744 0 0.0
.data 2008 2008 0 0.0
.text 920932 920932 0 0.0
BRD4161A+rpc (read only) 949744 949744 0 0.0
(read/write) 144712 144712 0 0.0
.bss 142520 142520 0 0.0
.data 2188 2188 0 0.0
.text 949736 949736 0 0.0
window-app BRD4161A (read only) 851692 851692 0 0.0
(read/write) 126704 126704 0 0.0
.bss 124840 124840 0 0.0
.data 1864 1864 0 0.0
.text 851684 851684 0 0.0
esp32 all-clusters-app c3devkit (read only) 961328 961328 0 0.0
(read/write) 1394818 1394818 0 0.0
.dram0.bss 64048 64048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197672 197672 0 0.0
.flash.text 961328 961328 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017295 1017295 0 0.0
(read/write) 462484 462484 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 227056 227056 0 0.0
.flash.text 1011911 1011911 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 700096 700096 0 0.0
.bss 77632 77632 0 0.0
.data 1888 1888 0 0.0
.text 614776 614776 0 0.0
lock k32w061+release (read/write) 700392 700392 0 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615060 615060 0 0.0
linux all-clusters-app debug (read only) 2471889 2471889 0 0.0
(read/write) 146576 146576 0 0.0
.bss 60736 60736 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78840 78840 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 210981 210981 0 0.0
.text 2097458 2097458 0 0.0
bridge-app debug+rpc (read only) 1748173 1748173 0 0.0
(read/write) 92752 92752 0 0.0
.bss 47784 47784 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 143660 143660 0 0.0
.text 1489301 1489301 0 0.0
chip-tool debug (read only) 10128093 10128093 0 0.0
(read/write) 357752 357752 0 0.0
.bss 25728 25728 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 324896 324896 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 515765 515765 0 0.0
.text 8830901 8830901 0 0.0
chip-tool-ipv6only arm64 (read only) 9754676 9754676 0 0.0
(read/write) 475505 475505 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371288 371288 0 0.0
.dynamic 560 560 0 0.0
.got 55264 55264 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492460 492460 0 0.0
.text 8212228 8212228 0 0.0
door-lock-app debug (read only) 1999321 1999321 0 0.0
(read/write) 120224 120224 0 0.0
.bss 51008 51008 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 179836 179836 0 0.0
.text 1669826 1669826 0 0.0
lighting-app debug+rpc (read only) 2130969 2130969 0 0.0
(read/write) 125544 125544 0 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66792 66792 0 0.0
.dynamic 608 608 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 172444 172444 0 0.0
.text 1801842 1801842 0 0.0
ota-provider-app debug (read only) 1934385 1934385 0 0.0
(read/write) 116048 116048 0 0.0
.bss 50912 50912 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 58200 58200 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 165867 165867 0 0.0
.text 1616754 1616754 0 0.0
ota-requestor-app debug (read only) 1964185 1964185 0 0.0
(read/write) 119016 119016 0 0.0
.bss 51904 51904 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 161892 161892 0 0.0
.text 1650306 1650306 0 0.0
shell debug (read only) 2422081 2422081 0 0.0
(read/write) 150632 150632 0 0.0
.bss 70664 70664 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73472 73472 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 208946 208946 0 0.0
.text 2056434 2056434 0 0.0
thermostat-no-ble arm64 (read only) 2220364 2220364 0 0.0
(read/write) 149809 149809 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137772 137772 0 0.0
.text 1862528 1862528 0 0.0
tv-app debug (read only) 2670641 2670641 0 0.0
(read/write) 251224 251224 0 0.0
.bss 167904 167904 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 74184 74184 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 205749 205749 0 0.0
.text 2290066 2290066 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352364 2352364 0 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1314964 1314964 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154799 1154799 0 0.0
bss 146724 146724 0 0.0
rodata 145536 145536 0 0.0
text 787376 787376 0 0.0
p6 all-clusters-app default (read/write) 2491648 2491648 0 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1449912 1449912 0 0.0
light-app default (read/write) 2395512 2395512 0 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1353776 1353776 0 0.0
lock-app default (read/write) 2359056 2359056 0 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317320 1317320 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 894938 894938 0 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 632758 632758 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit d80d593 into project-chip:master Mar 17, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@andy31415 @andrei-menzopol
use clang-tidy to modernize-use-override (project-chip#16307)
24a87f1 
* use clang-tidy to modernize-use-override

* Restyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller crypto inet lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andy31415 @bzbarsky-apple @Damian-Nordic