Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added logic to have a max retry count for providers returning a BUSY state #16294

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Added logic to have a max retry count for providers returning a BUSY state #16294

merged 1 commit into from
Mar 18, 2022

Conversation

harsha-rajendran
Copy link
Contributor

@harsha-rajendran harsha-rajendran commented Mar 16, 2022 •
edited
Loading

Problem

Fixes #15691

Change overview

If an OTA provider returns a BUSY response, then it will be retried a MAX_RETRY_COUNT number of times before moving on. This will prevent the Requestor from being stuck on a single OTA provider forever.
With these changes, the QueryImage logic now tries the entire list of providers until either an OTA succeeds or the end-of-list is reached. Upon failure, the 24 hours timer kicks back in.
The last used provider is also cleared on every reboot to ensure a clean-slate beginning and this will also ensure that the list is always traversed from the beginning to the end, deterministically.

Testing

  • Tested to ensure that the requestor moves on after hitting the max retry count.
  • Ran the ota_test script on Linux.

Damian-Nordic
Damian-Nordic approved these changes Mar 16, 2022
View reviewed changes
scripts/tests/ota_test.sh Show resolved Hide resolved
@harsha-rajendran
Copy link
Contributor Author

Added logic, based on our discussion this morning- @carol-apple @selissia .

@github-actions
Copy link

github-actions bot commented Mar 16, 2022 •
edited
Loading

PR #16294: Size comparison from f73db2f to 052d29f

Increases (5 builds for cyw30739, k32w, linux, nrfconnect)
platform target config section f73db2f 052d29f change % change
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 .bss 83464 83488 24 0.0
k32w light k32w061+release .bss 77632 77656 24 0.0
linux chip-tool-ipv6only arm64 .rodata 492348 492364 16 0.0
thermostat-no-ble arm64 .rodata 137660 137676 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 145432 145500 68 0.0
Decreases (12 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6)
platform target config section f73db2f 052d29f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603282 603122 -160 -0.0
.app_xip_area 510380 510220 -160 -0.0
lock cyw930739m2evb_01 (read/write) 561070 560910 -160 -0.0
.app_xip_area 469696 469536 -160 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570954 570834 -120 -0.0
.app_xip_area 469932 469812 -120 -0.0
.data 520 500 -20 -3.8
k32w light k32w061+release (read/write) 699960 699948 -12 -0.0
.data 1888 1868 -20 -1.1
.text 614640 614624 -16 -0.0
lock k32w061+release (read/write) 700256 700096 -160 -0.0
.text 614924 614764 -160 -0.0
linux chip-tool-ipv6only arm64 (read only) 9754100 9753604 -496 -0.0
.text 8211860 8211348 -512 -0.0
thermostat-no-ble arm64 (read only) 2219868 2219292 -576 -0.0
.text 1862240 1861648 -592 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2352172 2352068 -104 -0.0
.text 1314772 1314668 -104 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154647 1154587 -60 -0.0
text 787340 787212 -128 -0.0
p6 all-clusters-app default (read/write) 2491392 2491280 -112 -0.0
.text 1449656 1449544 -112 -0.0
light-app default (read/write) 2395248 2395136 -112 -0.0
.text 1353512 1353400 -112 -0.0
lock-app default (read/write) 2358792 2358680 -112 -0.0
.text 1317056 1316944 -112 -0.0
Full report (13 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section f73db2f 052d29f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603282 603122 -160 -0.0
.app_xip_area 510380 510220 -160 -0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561070 560910 -160 -0.0
.app_xip_area 469696 469536 -160 -0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570954 570834 -120 -0.0
.app_xip_area 469932 469812 -120 -0.0
.bss 83464 83488 24 0.0
.data 520 500 -20 -3.8
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 699960 699948 -12 -0.0
.bss 77632 77656 24 0.0
.data 1888 1868 -20 -1.1
.text 614640 614624 -16 -0.0
lock k32w061+release (read/write) 700256 700096 -160 -0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 614924 614764 -160 -0.0
linux chip-tool-ipv6only arm64 (read only) 9754100 9753604 -496 -0.0
(read/write) 475473 475473 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371256 371256 0 0.0
.dynamic 560 560 0 0.0
.got 55264 55264 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492348 492364 16 0.0
.text 8211860 8211348 -512 -0.0
thermostat-no-ble arm64 (read only) 2219868 2219292 -576 -0.0
(read/write) 149777 149777 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75696 75696 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137660 137676 16 0.0
.text 1862240 1861648 -592 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352172 2352068 -104 -0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1314772 1314668 -104 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154647 1154587 -60 -0.0
bss 146724 146724 0 0.0
rodata 145432 145500 68 0.0
text 787340 787212 -128 -0.0
p6 all-clusters-app default (read/write) 2491392 2491280 -112 -0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1449656 1449544 -112 -0.0
light-app default (read/write) 2395248 2395136 -112 -0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1353512 1353400 -112 -0.0
lock-app default (read/write) 2358792 2358680 -112 -0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317056 1316944 -112 -0.0
telink lighting-app tlsr9518adk80d (read/write) 894566 894566 0 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 632492 632492 0 0.0

@harsha-rajendran harsha-rajendran force-pushed the Implement-provider-retry-count branch from 2d91a4b to e7e66f8 Compare March 17, 2022 20:54
@harsha-rajendran
Copy link
Contributor Author

Squashed and rebased.

@github-actions
Copy link

github-actions bot commented Mar 17, 2022 •
edited
Loading

PR #16294: Size comparison from 84c150a to e7e66f8

Increases (6 builds for cyw30739, efr32, k32w, linux, nrfconnect)
platform target config section 84c150a e7e66f8 change % change
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571026 571154 128 0.0
.app_xip_area 470004 470132 128 0.0
.bss 83464 83488 24 0.0
efr32 lighting-app BRD4161A (read only) 920956 921196 240 0.0
(read/write) 128752 128756 4 0.0
.bss 126744 126768 24 0.0
.text 920948 921188 240 0.0
BRD4161A+rpc (read only) 949760 950000 240 0.0
.bss 142520 142544 24 0.0
.text 949752 949992 240 0.0
k32w light k32w061+release (read/write) 700112 700380 268 0.0
.bss 77632 77656 24 0.0
.text 614792 615056 264 0.0
linux ota-requestor-app debug .rodata 161860 161956 96 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154847 1155063 216 0.0
rodata 145536 145624 88 0.1
text 787432 787564 132 0.0
Decreases (5 builds for cyw30739, efr32, k32w, linux)
platform target config section 84c150a e7e66f8 change % change
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 .data 520 500 -20 -3.8
efr32 lighting-app BRD4161A .data 2008 1988 -20 -1.0
BRD4161A+rpc .data 2188 2168 -20 -0.9
k32w light k32w061+release .data 1888 1868 -20 -1.1
linux ota-requestor-app debug (read only) 1964169 1964153 -16 -0.0
.text 1650322 1650210 -112 -0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 84c150a e7e66f8 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603426 603426 0 0.0
.app_xip_area 510524 510524 0 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561222 561222 0 0.0
.app_xip_area 469848 469848 0 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571026 571154 128 0.0
.app_xip_area 470004 470132 128 0.0
.bss 83464 83488 24 0.0
.data 520 500 -20 -3.8
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920956 921196 240 0.0
(read/write) 128752 128756 4 0.0
.bss 126744 126768 24 0.0
.data 2008 1988 -20 -1.0
.text 920948 921188 240 0.0
BRD4161A+rpc (read only) 949760 950000 240 0.0
(read/write) 144712 144712 0 0.0
.bss 142520 142544 24 0.0
.data 2188 2168 -20 -0.9
.text 949752 949992 240 0.0
window-app BRD4161A (read only) 851708 851708 0 0.0
(read/write) 126704 126704 0 0.0
.bss 124840 124840 0 0.0
.data 1864 1864 0 0.0
.text 851700 851700 0 0.0
esp32 all-clusters-app c3devkit (read only) 961358 961358 0 0.0
(read/write) 1394818 1394818 0 0.0
.dram0.bss 64048 64048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197672 197672 0 0.0
.flash.text 961358 961358 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017511 1017511 0 0.0
(read/write) 462660 462660 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 227232 227232 0 0.0
.flash.text 1012127 1012127 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 700112 700380 268 0.0
.bss 77632 77656 24 0.0
.data 1888 1868 -20 -1.1
.text 614792 615056 264 0.0
lock k32w061+release (read/write) 700408 700408 0 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615076 615076 0 0.0
linux all-clusters-app debug (read only) 2471969 2471969 0 0.0
(read/write) 146576 146576 0 0.0
.bss 60736 60736 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78840 78840 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 210949 210949 0 0.0
.text 2097570 2097570 0 0.0
bridge-app debug+rpc (read only) 1748173 1748173 0 0.0
(read/write) 92752 92752 0 0.0
.bss 47784 47784 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 143628 143628 0 0.0
.text 1489333 1489333 0 0.0
chip-tool debug (read only) 10139581 10139581 0 0.0
(read/write) 358264 358264 0 0.0
.bss 25728 25728 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 325408 325408 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 516725 516725 0 0.0
.text 8840277 8840277 0 0.0
chip-tool-ipv6only arm64 (read only) 9764284 9764284 0 0.0
(read/write) 476113 476113 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371824 371824 0 0.0
.dynamic 560 560 0 0.0
.got 55328 55328 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492996 492996 0 0.0
.text 8219924 8219924 0 0.0
door-lock-app debug (read only) 1999337 1999337 0 0.0
(read/write) 120224 120224 0 0.0
.bss 51008 51008 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 179836 179836 0 0.0
.text 1669842 1669842 0 0.0
lighting-app debug+rpc (read only) 2130937 2130937 0 0.0
(read/write) 125544 125544 0 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66792 66792 0 0.0
.dynamic 608 608 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 172412 172412 0 0.0
.text 1801842 1801842 0 0.0
ota-provider-app debug (read only) 1934369 1934369 0 0.0
(read/write) 116048 116048 0 0.0
.bss 50912 50912 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 58200 58200 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 165835 165835 0 0.0
.text 1616770 1616770 0 0.0
ota-requestor-app debug (read only) 1964169 1964153 -16 -0.0
(read/write) 119016 119016 0 0.0
.bss 51904 51904 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 161860 161956 96 0.1
.text 1650322 1650210 -112 -0.0
shell debug (read only) 2422129 2422129 0 0.0
(read/write) 150632 150632 0 0.0
.bss 70664 70664 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73472 73472 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 208882 208882 0 0.0
.text 2056546 2056546 0 0.0
thermostat-no-ble arm64 (read only) 2220324 2220324 0 0.0
(read/write) 149809 149809 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137732 137732 0 0.0
.text 1862528 1862528 0 0.0
tv-app debug (read only) 2670673 2670673 0 0.0
(read/write) 251224 251224 0 0.0
.bss 167904 167904 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 74184 74184 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 205717 205717 0 0.0
.text 2290130 2290130 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352364 2352364 0 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1314964 1314964 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154847 1155063 216 0.0
bss 146724 146724 0 0.0
rodata 145536 145624 88 0.1
text 787432 787564 132 0.0
p6 all-clusters-app default (read/write) 2491776 2491776 0 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1450040 1450040 0 0.0
light-app default (read/write) 2395528 2395528 0 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1353792 1353792 0 0.0
lock-app default (read/write) 2359072 2359072 0 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317336 1317336 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 894970 894970 0 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 632832 632832 0 0.0

@harsha-rajendran
Fixes project-chip#15691
d9c9377 
Added logic to have a max retry count for providers returning a BUSY state.
Added logic not to traverse the default ota list more than once only in the case of QueryImageStatus of NOT_AVAILABLE.
Cleared the last used provider on reboot to ensure determinism in provider-selection.
@harsha-rajendran harsha-rajendran force-pushed the Implement-provider-retry-count branch from e7e66f8 to d9c9377 Compare March 18, 2022 00:17
@github-actions
Copy link

github-actions bot commented Mar 18, 2022 •
edited
Loading

PR #16294: Size comparison from c4d81c8 to d9c9377

Increases (5 builds for cyw30739, efr32, k32w, nrfconnect)
platform target config section c4d81c8 d9c9377 change % change
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571050 571178 128 0.0
.app_xip_area 470028 470156 128 0.0
.bss 83464 83488 24 0.0
efr32 lighting-app BRD4161A (read only) 921384 921624 240 0.0
(read/write) 128752 128760 8 0.0
.bss 126744 126768 24 0.0
.text 921376 921616 240 0.0
BRD4161A+rpc (read only) 950188 950428 240 0.0
(read/write) 144708 144712 4 0.0
.bss 142520 142544 24 0.0
.text 950180 950420 240 0.0
k32w light k32w061+release (read/write) 700516 700784 268 0.0
.bss 77632 77656 24 0.0
.text 615196 615460 264 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155239 1155455 216 0.0
rodata 145768 145856 88 0.1
text 787588 787724 136 0.0
Decreases (4 builds for cyw30739, efr32, k32w)
platform target config section c4d81c8 d9c9377 change % change
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 .data 520 500 -20 -3.8
efr32 lighting-app BRD4161A .data 2008 1988 -20 -1.0
BRD4161A+rpc .data 2188 2168 -20 -0.9
k32w light k32w061+release .data 1888 1868 -20 -1.1
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c4d81c8 d9c9377 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603538 603538 0 0.0
.app_xip_area 510636 510636 0 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561326 561326 0 0.0
.app_xip_area 469952 469952 0 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571050 571178 128 0.0
.app_xip_area 470028 470156 128 0.0
.bss 83464 83488 24 0.0
.data 520 500 -20 -3.8
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921384 921624 240 0.0
(read/write) 128752 128760 8 0.0
.bss 126744 126768 24 0.0
.data 2008 1988 -20 -1.0
.text 921376 921616 240 0.0
BRD4161A+rpc (read only) 950188 950428 240 0.0
(read/write) 144708 144712 4 0.0
.bss 142520 142544 24 0.0
.data 2188 2168 -20 -0.9
.text 950180 950420 240 0.0
window-app BRD4161A (read only) 851944 851944 0 0.0
(read/write) 126704 126704 0 0.0
.bss 124840 124840 0 0.0
.data 1864 1864 0 0.0
.text 851936 851936 0 0.0
esp32 all-clusters-app c3devkit (read only) 961498 961498 0 0.0
(read/write) 1395034 1395034 0 0.0
.dram0.bss 64048 64048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197888 197888 0 0.0
.flash.text 961498 961498 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017639 1017639 0 0.0
(read/write) 462892 462892 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 227464 227464 0 0.0
.flash.text 1012255 1012255 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 700516 700784 268 0.0
.bss 77632 77656 24 0.0
.data 1888 1868 -20 -1.1
.text 615196 615460 264 0.0
lock k32w061+release (read/write) 700652 700652 0 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615320 615320 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9765964 9765964 0 0.0
(read/write) 476113 476113 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371824 371824 0 0.0
.dynamic 560 560 0 0.0
.got 55328 55328 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493620 493620 0 0.0
.text 8220980 8220980 0 0.0
thermostat-no-ble arm64 (read only) 2221092 2221092 0 0.0
(read/write) 149809 149809 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137956 137956 0 0.0
.text 1863072 1863072 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352508 2352508 0 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1315108 1315108 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155239 1155455 216 0.0
bss 146724 146724 0 0.0
rodata 145768 145856 88 0.1
text 787588 787724 136 0.0
p6 all-clusters-app default (read/write) 2492120 2492120 0 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1450384 1450384 0 0.0
light-app default (read/write) 2395704 2395704 0 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1353968 1353968 0 0.0
lock-app default (read/write) 2359248 2359248 0 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317512 1317512 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 895306 895306 0 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 632968 632968 0 0.0

@harsha-rajendran harsha-rajendran merged commit 57eddeb into project-chip:master Mar 18, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@harsha-rajendran @andrei-menzopol
Fixes project-chip#15691 (project-chip#16294)
bf46960 
Added logic to have a max retry count for providers returning a BUSY state.
Added logic not to traverse the default ota list more than once only in the case of QueryImageStatus of NOT_AVAILABLE.
Cleared the last used provider on reboot to ensure determinism in provider-selection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carol-apple carol-apple carol-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@selissia selissia Awaiting requested review from selissia

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Provider retry count
5 participants
@harsha-rajendran @woody-apple @selissia @carol-apple @Damian-Nordic