Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EFR32 fix lock app build #1628

Merged
merged 2 commits into from
Jul 16, 2020
Merged

EFR32 fix lock app build #1628

merged 2 commits into from
Jul 16, 2020

Conversation

jepenven-silabs
Copy link
Contributor

Problem

EFR32 lock app example didn't build with make.

Summary of Changes

  • Update Make file to link mbedtls.a directly from EFR32 SDK
  • Add ConfigurationManagerImp.cpp to the build list in makefile.am

fixes #1627

@CLAassistant
Copy link

CLAassistant commented Jul 16, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

andy31415
andy31415 approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems GN build still needs some additional fixes.

@jepenven-silabs
Revert changes to BUILD.gn
59fefb0 
- Since the EFR32 platform doesn't support GN build as for now, revert
  those changes
@andy31415
Copy link
Contributor

@jepenven-silabs could you file a Github issue to add efr32 to gn builds as well?

I believe we are on the path to try to get full equivalence between bn and autotools.

@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize

@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize

@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize

@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

@andy31415 andy31415 merged commit cc040a2 into project-chip:master Jul 16, 2020
@jepenven-silabs
Copy link
Contributor Author

@andy31415 the issue is #1634

kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
@jepenven-silabs @kedars
EFR32 fix lock app build (project-chip#1628)
5ae414d 
* EFR32 fix lock app build

* Revert changes to BUILD.gn

- Since the EFR32 platform doesn't support GN build as for now, revert
  those changes
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
@jepenven-silabs @kedars
EFR32 fix lock app build (project-chip#1628)
bf11b41 
* EFR32 fix lock app build

* Revert changes to BUILD.gn

- Since the EFR32 platform doesn't support GN build as for now, revert
  those changes
@jepenven-silabs jepenven-silabs deleted the efr32-update-lock-app branch August 31, 2020 18:42
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request Mar 18, 2024
@mkardous-silabs
Merge pull request project-chip#1628 in WMN_TOOLS/matter from cherry-…
e254d67 
…pick/device-argument to RC_2.3.0-1.3-alpha.3

Auto-Merge: Pull request project-chip#1628: [AUTO] Cherry-Pick Pull request project-chip#1592: Provision: Added 'device' argument.

Merge in WMN_TOOLS/matter from cherry-pick/device-argument to RC_2.3.0-1.3-alpha.3

Squashed commit of the following:

commit e65b44b0bdc456b7db4554580bdf7aebedab0b3d
Author: Ricardo Casallas <[email protected]>
Date:   Wed Feb 28 19:17:42 2024 +0000

    Pull request project-chip#1592: Provision: Added 'device' argument.

    Merge in WMN_TOOLS/matter from feature/provision_device_argument to RC_2.3.0-1.3

    Squashed commit of the following:

    commit 9f713da2c653c0400954ec14a40b45631a64cf3b
    Author: Ricardo Casallas <[email protected]>
    Date:   Tue Feb 27 11:56:04 2024 -0500

        Provision: Added 'device' argument.
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
@mkardous-silabs
Merge pull request project-chip#1628 in WMN_TOOLS/matter from cherry-…
fa95650 
…pick/device-argument to RC_2.3.0-1.3-alpha.3

Auto-Merge: Pull request project-chip#1628: [AUTO] Cherry-Pick Pull request project-chip#1592: Provision: Added 'device' argument.

Merge in WMN_TOOLS/matter from cherry-pick/device-argument to RC_2.3.0-1.3-alpha.3

Squashed commit of the following:

commit e65b44b0bdc456b7db4554580bdf7aebedab0b3d
Author: Ricardo Casallas <[email protected]>
Date:   Wed Feb 28 19:17:42 2024 +0000

    Pull request project-chip#1592: Provision: Added 'device' argument.

    Merge in WMN_TOOLS/matter from feature/provision_device_argument to RC_2.3.0-1.3

    Squashed commit of the following:

    commit 9f713da2c653c0400954ec14a40b45631a64cf3b
    Author: Ricardo Casallas <[email protected]>
    Date:   Tue Feb 27 11:56:04 2024 -0500

        Provision: Added 'device' argument.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BroderickCarlin BroderickCarlin BroderickCarlin approved these changes

@saurabhst saurabhst saurabhst approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EFR32 lock app example build fail
5 participants
@jepenven-silabs @CLAassistant @andy31415 @saurabhst @BroderickCarlin