Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Group] Configure Chip-tool's GroupDataProvider #16232

Merged
merged 4 commits into from
Mar 17, 2022
Merged

[Group] Configure Chip-tool's GroupDataProvider #16232

merged 4 commits into from
Mar 17, 2022

Conversation

jepenven-silabs
Copy link
Contributor

Problem

Fix #1818

Change overview

Added minimal commands to configure Chip-Tool's GroupDataProvider so Group Messages can be send

  • Add/Remove Group
  • Add/Remove Keyset
  • Bind/Unbind Keyset to Group
  • Show available Groups
  • Show available Keyset

Testing

Manual Test with Chip-Tool

@restyled-io restyled-io bot mentioned this pull request Mar 15, 2022
Closed
@github-actions
Copy link

github-actions bot commented Mar 15, 2022 •
edited
Loading

PR #16232: Size comparison from 0b64326 to e1f6759

Full report (3 builds for mbed, nrfconnect, telink)
platform target config section 0b64326 e1f6759 change % change
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352756 2352756 0 0.0
.bss 186652 186652 0 0.0
.data 5752 5752 0 0.0
.text 1315356 1315356 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154011 1154011 0 0.0
bss 146644 146644 0 0.0
rodata 145276 145276 0 0.0
text 786976 786976 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 893770 893770 0 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 631868 631868 0 0.0

@jepenven-silabs jepenven-silabs force-pushed the chip_tool_configure_controller_group_data_provider branch from e1f6759 to 9a90bf1 Compare March 15, 2022 17:23
@boring-cyborg boring-cyborg bot added the github label Mar 15, 2022
@jepenven-silabs jepenven-silabs force-pushed the chip_tool_configure_controller_group_data_provider branch from 9a90bf1 to 2c1875a Compare March 15, 2022 17:31
@github-actions
Copy link

github-actions bot commented Mar 15, 2022 •
edited
Loading

PR #16232: Size comparison from eac433a to 2c1875a

Full report (14 builds for cyw30739, efr32, k32w, mbed, nrfconnect, p6, telink)
platform target config section eac433a 2c1875a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602578 602578 0 0.0
.app_xip_area 509756 509756 0 0.0
.bss 75576 75576 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560430 560430 0 0.0
.app_xip_area 469136 469136 0 0.0
.bss 74080 74080 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570498 570498 0 0.0
.app_xip_area 469556 469556 0 0.0
.bss 83384 83384 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919652 919652 0 0.0
(read/write) 128672 128672 0 0.0
.bss 126664 126664 0 0.0
.data 2008 2008 0 0.0
.text 919644 919644 0 0.0
BRD4161A+rpc (read only) 948440 948440 0 0.0
(read/write) 144632 144632 0 0.0
.bss 142440 142440 0 0.0
.data 2188 2188 0 0.0
.text 948432 948432 0 0.0
window-app BRD4161A (read only) 850392 850392 0 0.0
(read/write) 126632 126632 0 0.0
.bss 124768 124768 0 0.0
.data 1864 1864 0 0.0
.text 850384 850384 0 0.0
k32w light k32w061+release (read/write) 699340 699340 0 0.0
.bss 77560 77560 0 0.0
.data 1888 1888 0 0.0
.text 614092 614092 0 0.0
lock k32w061+release (read/write) 699644 699644 0 0.0
.bss 77552 77552 0 0.0
.data 1908 1908 0 0.0
.text 614384 614384 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352756 2352756 0 0.0
.bss 186652 186652 0 0.0
.data 5752 5752 0 0.0
.text 1315356 1315356 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154011 1154011 0 0.0
bss 146644 146644 0 0.0
rodata 145276 145276 0 0.0
text 786976 786976 0 0.0
p6 all-clusters-app default (read/write) 2492152 2492152 0 0.0
.bss 120080 120080 0 0.0
.data 2632 2632 0 0.0
.text 1450416 1450416 0 0.0
light-app default (read/write) 2396000 2396000 0 0.0
.bss 113544 113544 0 0.0
.data 2488 2488 0 0.0
.text 1354264 1354264 0 0.0
lock-app default (read/write) 2359544 2359544 0 0.0
.bss 113288 113288 0 0.0
.data 2448 2448 0 0.0
.text 1317808 1317808 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 893770 893770 0 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 631868 631868 0 0.0

@github-actions
Copy link

github-actions bot commented Mar 15, 2022 •
edited
Loading

PR #16232: Size comparison from eac433a to 1200aac

Increases (21 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect)
platform target config section eac433a 1200aac change % change
cyw30739 light cyw930739m2evb_01 .bss 75576 75648 72 0.1
lock cyw930739m2evb_01 .bss 74080 74152 72 0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 .bss 83384 83456 72 0.1
efr32 lighting-app BRD4161A (read only) 919652 919700 48 0.0
(read/write) 128672 128752 80 0.1
.bss 126664 126744 80 0.1
.text 919644 919692 48 0.0
BRD4161A+rpc (read only) 948440 948488 48 0.0
(read/write) 144632 144712 80 0.1
.bss 142440 142520 80 0.1
.text 948432 948480 48 0.0
window-app BRD4161A (read only) 850392 850456 64 0.0
(read/write) 126632 126712 80 0.1
.bss 124768 124848 80 0.1
.text 850384 850448 64 0.0
esp32 all-clusters-app m5stack (read/write) 462180 462188 8 0.0
.flash.rodata 226752 226760 8 0.0
k32w light k32w061+release .bss 77560 77624 64 0.1
lock k32w061+release .bss 77552 77616 64 0.1
linux all-clusters-app debug (read only) 2465305 2465449 144 0.0
.text 2091314 2091458 144 0.0
bridge-app debug+rpc (read only) 1749837 1750077 240 0.0
.text 1490917 1491157 240 0.0
chip-tool debug (read only) 10095661 10108437 12776 0.1
(read/write) 357680 358192 512 0.1
.data.rel.ro 324864 325376 512 0.2
.got 4776 4784 8 0.2
.rodata 515189 516181 992 0.2
.text 8799221 8809797 10576 0.1
chip-tool-ipv6only arm64 (read only) 9728580 9739500 10920 0.1
(read/write) 475441 476161 720 0.2
.data.rel.ro 371232 371888 656 0.2
.got 55264 55328 64 0.1
.rodata 492252 492924 672 0.1
.text 8186452 8195076 8624 0.1
door-lock-app debug (read only) 1984465 1984609 144 0.0
.text 1657106 1657250 144 0.0
lighting-app debug+rpc (read only) 2116041 2116185 144 0.0
.text 1789122 1789266 144 0.0
ota-provider-app debug (read only) 1919545 1919673 128 0.0
.text 1604050 1604178 128 0.0
ota-requestor-app debug (read only) 1949329 1949473 144 0.0
.text 1637586 1637730 144 0.0
shell debug (read only) 2411465 2411593 128 0.0
.text 2047778 2047906 128 0.0
thermostat-no-ble arm64 (read only) 2207324 2207484 160 0.0
.text 1851184 1851344 160 0.0
tv-app debug (read only) 2656289 2656433 144 0.0
.text 2277954 2278098 144 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154011 1154071 60 0.0
bss 146644 146724 80 0.1
Decreases (13 builds for cyw30739, esp32, k32w, mbed, nrfconnect, p6, telink)
platform target config section eac433a 1200aac change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602578 602562 -16 -0.0
.app_xip_area 509756 509668 -88 -0.0
lock cyw930739m2evb_01 (read/write) 560430 560422 -8 -0.0
.app_xip_area 469136 469056 -80 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570498 570490 -8 -0.0
.app_xip_area 469556 469476 -80 -0.0
esp32 all-clusters-app c3devkit (read only) 961514 961466 -48 -0.0
.flash.text 961514 961466 -48 -0.0
m5stack (read only) 1017123 1016983 -140 -0.0
.flash.text 1011739 1011599 -140 -0.0
k32w light k32w061+release (read/write) 699340 699324 -16 -0.0
.text 614092 614012 -80 -0.0
lock k32w061+release (read/write) 699644 699628 -16 -0.0
.text 614384 614304 -80 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2352756 2352692 -64 -0.0
.text 1315356 1315292 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 145276 145272 -4 -0.0
text 786976 786916 -60 -0.0
p6 all-clusters-app default (read/write) 2492152 2492136 -16 -0.0
.text 1450416 1450400 -16 -0.0
light-app default (read/write) 2396000 2395984 -16 -0.0
.text 1354264 1354248 -16 -0.0
lock-app default (read/write) 2359544 2359528 -16 -0.0
.text 1317808 1317792 -16 -0.0
telink lighting-app tlsr9518adk80d (read/write) 893770 893762 -8 -0.0
text 631868 631860 -8 -0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section eac433a 1200aac change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602578 602562 -16 -0.0
.app_xip_area 509756 509668 -88 -0.0
.bss 75576 75648 72 0.1
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560430 560422 -8 -0.0
.app_xip_area 469136 469056 -80 -0.0
.bss 74080 74152 72 0.1
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570498 570490 -8 -0.0
.app_xip_area 469556 469476 -80 -0.0
.bss 83384 83456 72 0.1
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919652 919700 48 0.0
(read/write) 128672 128752 80 0.1
.bss 126664 126744 80 0.1
.data 2008 2008 0 0.0
.text 919644 919692 48 0.0
BRD4161A+rpc (read only) 948440 948488 48 0.0
(read/write) 144632 144712 80 0.1
.bss 142440 142520 80 0.1
.data 2188 2188 0 0.0
.text 948432 948480 48 0.0
window-app BRD4161A (read only) 850392 850456 64 0.0
(read/write) 126632 126712 80 0.1
.bss 124768 124848 80 0.1
.data 1864 1864 0 0.0
.text 850384 850448 64 0.0
esp32 all-clusters-app c3devkit (read only) 961514 961466 -48 -0.0
(read/write) 1394978 1394978 0 0.0
.dram0.bss 64056 64056 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197816 197816 0 0.0
.flash.text 961514 961466 -48 -0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017123 1016983 -140 -0.0
(read/write) 462180 462188 8 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 226752 226760 8 0.0
.flash.text 1011739 1011599 -140 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699340 699324 -16 -0.0
.bss 77560 77624 64 0.1
.data 1888 1888 0 0.0
.text 614092 614012 -80 -0.0
lock k32w061+release (read/write) 699644 699628 -16 -0.0
.bss 77552 77616 64 0.1
.data 1908 1908 0 0.0
.text 614384 614304 -80 -0.0
linux all-clusters-app debug (read only) 2465305 2465449 144 0.0
(read/write) 146352 146352 0 0.0
.bss 60640 60640 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78728 78728 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 210757 210757 0 0.0
.text 2091314 2091458 144 0.0
bridge-app debug+rpc (read only) 1749837 1750077 240 0.0
(read/write) 92912 92912 0 0.0
.bss 47752 47752 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 38128 38128 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 143372 143372 0 0.0
.text 1490917 1491157 240 0.0
chip-tool debug (read only) 10095661 10108437 12776 0.1
(read/write) 357680 358192 512 0.1
.bss 25696 25696 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 324864 325376 512 0.2
.dynamic 608 608 0 0.0
.got 4776 4784 8 0.2
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 515189 516181 992 0.2
.text 8799221 8809797 10576 0.1
chip-tool-ipv6only arm64 (read only) 9728580 9739500 10920 0.1
(read/write) 475441 476161 720 0.2
.bss 44017 44017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371232 371888 656 0.2
.dynamic 560 560 0 0.0
.got 55264 55328 64 0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492252 492924 672 0.1
.text 8186452 8195076 8624 0.1
door-lock-app debug (read only) 1984465 1984609 144 0.0
(read/write) 119776 119776 0 0.0
.bss 50944 50944 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 178460 178460 0 0.0
.text 1657106 1657250 144 0.0
lighting-app debug+rpc (read only) 2116041 2116185 144 0.0
(read/write) 125160 125160 0 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66408 66408 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 171004 171004 0 0.0
.text 1789122 1789266 144 0.0
ota-provider-app debug (read only) 1919545 1919673 128 0.0
(read/write) 115568 115568 0 0.0
.bss 50848 50848 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 57816 57816 0 0.0
.dynamic 608 608 0 0.0
.got 4360 4360 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 164491 164491 0 0.0
.text 1604050 1604178 128 0.0
ota-requestor-app debug (read only) 1949329 1949473 144 0.0
(read/write) 118568 118568 0 0.0
.bss 51840 51840 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 59880 59880 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 160516 160516 0 0.0
.text 1637586 1637730 144 0.0
shell debug (read only) 2411465 2411593 128 0.0
(read/write) 150184 150184 0 0.0
.bss 70600 70600 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73088 73088 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 207538 207538 0 0.0
.text 2047778 2047906 128 0.0
thermostat-no-ble arm64 (read only) 2207324 2207484 160 0.0
(read/write) 149377 149377 0 0.0
.bss 65649 65649 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75368 75368 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 136828 136828 0 0.0
.text 1851184 1851344 160 0.0
tv-app debug (read only) 2656289 2656433 144 0.0
(read/write) 250776 250776 0 0.0
.bss 167840 167840 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 73800 73800 0 0.0
.dynamic 592 592 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 204277 204277 0 0.0
.text 2277954 2278098 144 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352756 2352692 -64 -0.0
.bss 186652 186652 0 0.0
.data 5752 5752 0 0.0
.text 1315356 1315292 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154011 1154071 60 0.0
bss 146644 146724 80 0.1
rodata 145276 145272 -4 -0.0
text 786976 786916 -60 -0.0
p6 all-clusters-app default (read/write) 2492152 2492136 -16 -0.0
.bss 120080 120080 0 0.0
.data 2632 2632 0 0.0
.text 1450416 1450400 -16 -0.0
light-app default (read/write) 2396000 2395984 -16 -0.0
.bss 113544 113544 0 0.0
.data 2488 2488 0 0.0
.text 1354264 1354248 -16 -0.0
lock-app default (read/write) 2359544 2359528 -16 -0.0
.bss 113288 113288 0 0.0
.data 2448 2448 0 0.0
.text 1317808 1317792 -16 -0.0
telink lighting-app tlsr9518adk80d (read/write) 893770 893762 -8 -0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 631868 631860 -8 -0.0

bzbarsky-apple
bzbarsky-apple requested changes Mar 16, 2022
View reviewed changes
examples/chip-tool/commands/group/Commands.h Outdated Show resolved Hide resolved
examples/chip-tool/commands/group/Commands.h Show resolved Hide resolved
examples/chip-tool/commands/group/Commands.h Outdated Show resolved Hide resolved
examples/chip-tool/commands/group/Commands.h Outdated Show resolved Hide resolved
examples/chip-tool/commands/group/Commands.h Outdated Show resolved Hide resolved
examples/chip-tool/commands/group/Commands.h Outdated Show resolved Hide resolved
examples/chip-tool/commands/group/Commands.h Outdated Show resolved Hide resolved
examples/chip-tool/commands/group/Commands.h Outdated Show resolved Hide resolved
examples/chip-tool/README.md Outdated Show resolved Hide resolved
examples/chip-tool/commands/group/Commands.h Outdated Show resolved Hide resolved
bzbarsky-apple
bzbarsky-apple approved these changes Mar 17, 2022
View reviewed changes
examples/chip-tool/commands/group/Commands.h Outdated Show resolved Hide resolved
examples/chip-tool/commands/group/Commands.h Outdated Show resolved Hide resolved
@jepenven-silabs jepenven-silabs merged commit 84c150a into project-chip:master Mar 17, 2022
ArekBalysNordic pushed a commit to ArekBalysNordic/connectedhomeip that referenced this pull request Mar 18, 2022
@jepenven-silabs @ArekBalysNordic
[Group] Configure Chip-tool's GroupDataProvider (project-chip#16232)
1958e47 
* Configure Chip-tool's GroupDataProvider
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@jepenven-silabs @andrei-menzopol
[Group] Configure Chip-tool's GroupDataProvider (project-chip#16232)
998e179 
* Configure Chip-tool's GroupDataProvider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
examples github lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chip-Tool Group support
4 participants
@jepenven-silabs @woody-apple @bzbarsky-apple @jmartinez-silabs