Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGTM - Except block directly handles BaseException. #1622

Merged
merged 1 commit into from
Jul 20, 2020
Merged

LGTM - Except block directly handles BaseException. #1622

merged 1 commit into from
Jul 20, 2020

Conversation

vivien-apple
Copy link
Contributor

Problem

Let SystemExit and KeyboardInterrupt propagate correctly.

@lgtm-com
Copy link

lgtm-com bot commented Jul 16, 2020

This pull request fixes 1 alert when merging 4a4084a into bca8b6e - view on LGTM.com

fixed alerts:

  • 1 for Except block handles 'BaseException'

@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize

@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

@woody-apple woody-apple merged commit cc1a054 into project-chip:master Jul 20, 2020
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request Mar 18, 2024
@CuRahman @mkardous-silabs
Pull request project-chip#1622: Port commander fixes
12e2179 
Merge in WMN_TOOLS/matter from port_commander_fixes to RC_2.3.0-1.3-alpha.3

Squashed commit of the following:

commit 13b749c3a62555c9f448759954acd8d5e8b501e7
Author: Curtis Rahman <[email protected]>
Date:   Thu Mar 7 16:15:06 2024 -0500

    Check out tag vs. branch

commit 02d6aef152aaa91e9fca9c94a992edd6f8d2a15e
Author: Curtis Rahman <[email protected]>
Date:   Fri Mar 1 19:15:32 2024 +0000

    Pull request project-chip#1600: [MATTER-3226] Update commander to checkout latest released in build/sanity/SQA

    Merge in WMN_TOOLS/matter from feature/update_commander_smg to silabs

    Squashed commit of the following:

    commit 31c61d92bb9b6a69714f01acc8d6b46fe470855b
    Author: Curtis Rahman <[email protected]>
    Date:   Tue Feb 27 13:47:25 2024 -0500

        Changed to checkout latest commander in both build and sanity/SQA
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
@CuRahman @mkardous-silabs
Pull request project-chip#1622: Port commander fixes
2b6af17 
Merge in WMN_TOOLS/matter from port_commander_fixes to RC_2.3.0-1.3-alpha.3

Squashed commit of the following:

commit 13b749c3a62555c9f448759954acd8d5e8b501e7
Author: Curtis Rahman <[email protected]>
Date:   Thu Mar 7 16:15:06 2024 -0500

    Check out tag vs. branch

commit 02d6aef152aaa91e9fca9c94a992edd6f8d2a15e
Author: Curtis Rahman <[email protected]>
Date:   Fri Mar 1 19:15:32 2024 +0000

    Pull request project-chip#1600: [MATTER-3226] Update commander to checkout latest released in build/sanity/SQA

    Merge in WMN_TOOLS/matter from feature/update_commander_smg to silabs

    Squashed commit of the following:

    commit 31c61d92bb9b6a69714f01acc8d6b46fe470855b
    Author: Curtis Rahman <[email protected]>
    Date:   Tue Feb 27 13:47:25 2024 -0500

        Changed to checkout latest commander in both build and sanity/SQA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@BroderickCarlin BroderickCarlin BroderickCarlin approved these changes

@andy31415 andy31415 andy31415 approved these changes

@mspang mspang mspang approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vivien-apple @mspang @andy31415 @BroderickCarlin @woody-apple