Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup OperationalCredentials if the fail-safe timer expires #16212

Merged
merged 4 commits into from
Mar 18, 2022
Merged

Cleanup OperationalCredentials if the fail-safe timer expires #16212

merged 4 commits into from
Mar 18, 2022

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

  • According to the latest spec update, we need to do the following cleanups in OperationalCredentials cluster if the fail-safe timer expires:

  • If an AddNOC or UpdateNOC command has been successfully invoked, terminate all CASE sessions associated with the Fabric whose Fabric Index is recorded in the Fail-Safe context

  • If an UpdateNOC command had been successfully invoked, revert the state of operational key pair, NOC and ICAC for that Fabric to the state prior to the Fail-Safe timer being armed, for the Fabric Index that was the subject of the UpdateNOC command.

  • If an AddNOC command had been successfully invoked, achieve the equivalent effect of invoking the RemoveFabric command against the Fabric Index stored in the Fail-Safe Context for the Fabric Index that was the subject of the AddNOC command. This SHALL remove all associations to that Fabric including all fabric-scoped data, and MAY possibly factory-reset the device depending on current device state. This SHALL only apply to Fabrics added during the fail-safe period as the result of the AddNOC command.

  • Remove any RCACs added by the AddTrustedRootCertificate command that are not currently referenced by any entry in the Fabrics attribute.

Change overview

Cleanup OperationalCredentials if the fail-safe timer expires

Testing

How was this tested? (at least one bullet point required)

  • Inject kCommissioningComplete event with failure and confirm related cleanups have been done from log

@github-actions
Copy link

github-actions bot commented Mar 15, 2022 •
edited
Loading

PR #16212: Size comparison from b18b03a to 1f0af5a

Increases above 0.2%:

platform target config section b18b03a 1f0af5a change % change
linux bridge-app debug+rpc .rodata 143308 143628 320 0.2
door-lock-app debug .rodata 178396 178780 384 0.2
Increases (25 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b18b03a 1f0af5a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602578 602850 272 0.0
.app_xip_area 509756 510028 272 0.1
lock cyw930739m2evb_01 (read/write) 560430 560710 280 0.0
.app_xip_area 469136 469416 280 0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570498 570674 176 0.0
.app_xip_area 469556 469732 176 0.0
efr32 lighting-app BRD4161A (read only) 919652 919884 232 0.0
.text 919644 919876 232 0.0
BRD4161A+rpc (read only) 948440 948672 232 0.0
.text 948432 948664 232 0.0
window-app BRD4161A (read only) 850392 850724 332 0.0
(read/write) 126632 126640 8 0.0
.bss 124768 124776 8 0.0
.text 850384 850716 332 0.0
esp32 all-clusters-app c3devkit (read only) 961388 961612 224 0.0
(read/write) 1394938 1394970 32 0.0
.flash.rodata 197776 197808 32 0.0
.flash.text 961388 961612 224 0.0
m5stack (read only) 1017011 1017091 80 0.0
(read/write) 462148 462180 32 0.0
.flash.rodata 226720 226752 32 0.0
.flash.text 1011627 1011707 80 0.0
k32w light k32w061+release (read/write) 699340 699516 176 0.0
.text 614092 614268 176 0.0
lock k32w061+release (read/write) 699644 699916 272 0.0
.text 614384 614656 272 0.0
linux all-clusters-app debug (read only) 2465225 2465945 720 0.0
.rodata 210693 210725 32 0.0
.text 2091298 2091986 688 0.0
bridge-app debug+rpc (read only) 1749757 1751021 1264 0.1
(read/write) 92912 92976 64 0.1
.bss 47752 47816 64 0.1
.data.rel.ro 38128 38136 8 0.0
.rodata 143308 143628 320 0.2
.text 1490901 1491845 944 0.1
door-lock-app debug (read only) 1984385 1985729 1344 0.1
.data.rel.ro 62456 62472 16 0.0
.rodata 178396 178780 384 0.2
.text 1657090 1658050 960 0.1
lighting-app debug+rpc (read only) 2115961 2116969 1008 0.0
.rodata 170940 171004 64 0.0
.text 1789106 1790050 944 0.1
ota-provider-app debug (read only) 1918537 1919465 928 0.0
.rodata 164267 164299 32 0.0
.text 1603266 1604162 896 0.1
ota-requestor-app debug (read only) 1949249 1949969 720 0.0
.rodata 160452 160484 32 0.0
.text 1637570 1638258 688 0.0
shell debug (read only) 2411385 2412121 736 0.0
.rodata 207474 207506 32 0.0
.text 2047762 2048466 704 0.0
thermostat-no-ble arm64 (read only) 2207236 2207988 752 0.0
.rodata 136756 136788 32 0.0
.text 1851168 1851888 720 0.0
tv-app debug (read only) 2656097 2656849 752 0.0
.rodata 204213 204245 32 0.0
.text 2277826 2278546 720 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2352756 2353044 288 0.0
.text 1315356 1315644 288 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154011 1154187 176 0.0
rodata 145276 145308 32 0.0
text 786976 787120 144 0.0
p6 all-clusters-app default (read/write) 2492152 2492384 232 0.0
.text 1450416 1450648 232 0.0
light-app default (read/write) 2396000 2396336 336 0.0
.text 1354264 1354600 336 0.0
lock-app default (read/write) 2359544 2359896 352 0.0
.text 1317808 1318160 352 0.0
telink lighting-app tlsr9518adk80d (read/write) 893770 894014 244 0.0
text 631868 632078 210 0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b18b03a 1f0af5a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602578 602850 272 0.0
.app_xip_area 509756 510028 272 0.1
.bss 75576 75576 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560430 560710 280 0.0
.app_xip_area 469136 469416 280 0.1
.bss 74080 74080 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570498 570674 176 0.0
.app_xip_area 469556 469732 176 0.0
.bss 83384 83384 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919652 919884 232 0.0
(read/write) 128672 128672 0 0.0
.bss 126664 126664 0 0.0
.data 2008 2008 0 0.0
.text 919644 919876 232 0.0
BRD4161A+rpc (read only) 948440 948672 232 0.0
(read/write) 144632 144632 0 0.0
.bss 142440 142440 0 0.0
.data 2188 2188 0 0.0
.text 948432 948664 232 0.0
window-app BRD4161A (read only) 850392 850724 332 0.0
(read/write) 126632 126640 8 0.0
.bss 124768 124776 8 0.0
.data 1864 1864 0 0.0
.text 850384 850716 332 0.0
esp32 all-clusters-app c3devkit (read only) 961388 961612 224 0.0
(read/write) 1394938 1394970 32 0.0
.dram0.bss 64056 64056 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197776 197808 32 0.0
.flash.text 961388 961612 224 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017011 1017091 80 0.0
(read/write) 462148 462180 32 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 226720 226752 32 0.0
.flash.text 1011627 1011707 80 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699340 699516 176 0.0
.bss 77560 77560 0 0.0
.data 1888 1888 0 0.0
.text 614092 614268 176 0.0
lock k32w061+release (read/write) 699644 699916 272 0.0
.bss 77552 77552 0 0.0
.data 1908 1908 0 0.0
.text 614384 614656 272 0.0
linux all-clusters-app debug (read only) 2465225 2465945 720 0.0
(read/write) 146352 146352 0 0.0
.bss 60640 60640 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78728 78728 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 210693 210725 32 0.0
.text 2091298 2091986 688 0.0
bridge-app debug+rpc (read only) 1749757 1751021 1264 0.1
(read/write) 92912 92976 64 0.1
.bss 47752 47816 64 0.1
.data 1952 1952 0 0.0
.data.rel.ro 38128 38136 8 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 143308 143628 320 0.2
.text 1490901 1491845 944 0.1
chip-tool debug (read only) 10095037 10095037 0 0.0
(read/write) 357680 357680 0 0.0
.bss 25696 25696 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 324864 324864 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514997 514997 0 0.0
.text 8798789 8798789 0 0.0
chip-tool-ipv6only arm64 (read only) 9728092 9728092 0 0.0
(read/write) 475425 475425 0 0.0
.bss 44017 44017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371232 371232 0 0.0
.dynamic 560 560 0 0.0
.got 55256 55256 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492196 492196 0 0.0
.text 8186052 8186052 0 0.0
door-lock-app debug (read only) 1984385 1985729 1344 0.1
(read/write) 119776 119776 0 0.0
.bss 50944 50944 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62456 62472 16 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 178396 178780 384 0.2
.text 1657090 1658050 960 0.1
lighting-app debug+rpc (read only) 2115961 2116969 1008 0.0
(read/write) 125160 125160 0 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66408 66408 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 170940 171004 64 0.0
.text 1789106 1790050 944 0.1
ota-provider-app debug (read only) 1918537 1919465 928 0.0
(read/write) 115536 115536 0 0.0
.bss 50816 50816 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 57816 57816 0 0.0
.dynamic 608 608 0 0.0
.got 4360 4360 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 164267 164299 32 0.0
.text 1603266 1604162 896 0.1
ota-requestor-app debug (read only) 1949249 1949969 720 0.0
(read/write) 118568 118568 0 0.0
.bss 51840 51840 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 59880 59880 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 160452 160484 32 0.0
.text 1637570 1638258 688 0.0
shell debug (read only) 2411385 2412121 736 0.0
(read/write) 150184 150184 0 0.0
.bss 70600 70600 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73088 73088 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 207474 207506 32 0.0
.text 2047762 2048466 704 0.0
thermostat-no-ble arm64 (read only) 2207236 2207988 752 0.0
(read/write) 149377 149377 0 0.0
.bss 65649 65649 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75368 75368 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 136756 136788 32 0.0
.text 1851168 1851888 720 0.0
tv-app debug (read only) 2656097 2656849 752 0.0
(read/write) 250776 250776 0 0.0
.bss 167840 167840 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 73800 73800 0 0.0
.dynamic 592 592 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 204213 204245 32 0.0
.text 2277826 2278546 720 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352756 2353044 288 0.0
.bss 186652 186652 0 0.0
.data 5752 5752 0 0.0
.text 1315356 1315644 288 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154011 1154187 176 0.0
bss 146644 146644 0 0.0
rodata 145276 145308 32 0.0
text 786976 787120 144 0.0
p6 all-clusters-app default (read/write) 2492152 2492384 232 0.0
.bss 120080 120080 0 0.0
.data 2632 2632 0 0.0
.text 1450416 1450648 232 0.0
light-app default (read/write) 2396000 2396336 336 0.0
.bss 113544 113544 0 0.0
.data 2488 2488 0 0.0
.text 1354264 1354600 336 0.0
lock-app default (read/write) 2359544 2359896 352 0.0
.bss 113288 113288 0 0.0
.data 2448 2448 0 0.0
.text 1317808 1318160 352 0.0
telink lighting-app tlsr9518adk80d (read/write) 893770 894014 244 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 631868 632078 210 0.0

@restyled-io restyled-io bot mentioned this pull request Mar 17, 2022
Closed
@github-actions
Copy link

github-actions bot commented Mar 17, 2022 •
edited
Loading

PR #16212: Size comparison from d80d593 to 7e182c9

Increases (17 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d80d593 7e182c9 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603418 603578 160 0.0
.app_xip_area 510516 510676 160 0.0
lock cyw930739m2evb_01 (read/write) 561206 561366 160 0.0
.app_xip_area 469832 469992 160 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571010 571170 160 0.0
.app_xip_area 469988 470148 160 0.0
efr32 lighting-app BRD4161A (read only) 920940 921156 216 0.0
.text 920932 921148 216 0.0
BRD4161A+rpc (read only) 949744 949976 232 0.0
.text 949736 949968 232 0.0
window-app BRD4161A (read only) 851692 851900 208 0.0
(read/write) 126704 126712 8 0.0
.bss 124840 124848 8 0.0
.text 851684 851892 208 0.0
esp32 all-clusters-app c3devkit (read only) 961328 961526 198 0.0
(read/write) 1394818 1394850 32 0.0
.flash.rodata 197672 197704 32 0.0
.flash.text 961328 961526 198 0.0
m5stack (read only) 1017295 1017439 144 0.0
(read/write) 462484 462516 32 0.0
.flash.rodata 227056 227088 32 0.0
.flash.text 1011911 1012055 144 0.0
k32w light k32w061+release (read/write) 700096 700256 160 0.0
.text 614776 614936 160 0.0
lock k32w061+release (read/write) 700392 700560 168 0.0
.text 615060 615228 168 0.0
linux thermostat-no-ble arm64 (read only) 2220364 2221068 704 0.0
.rodata 137772 137804 32 0.0
.text 1862528 1863200 672 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2352364 2352524 160 0.0
.text 1314964 1315124 160 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154799 1154943 144 0.0
rodata 145536 145568 32 0.0
text 787376 787496 120 0.0
p6 all-clusters-app default (read/write) 2491648 2491864 216 0.0
.text 1449912 1450128 216 0.0
light-app default (read/write) 2395512 2395720 208 0.0
.text 1353776 1353984 208 0.0
lock-app default (read/write) 2359056 2359264 208 0.0
.text 1317320 1317528 208 0.0
telink lighting-app tlsr9518adk80d (read/write) 894938 895166 228 0.0
text 632758 632950 192 0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d80d593 7e182c9 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603418 603578 160 0.0
.app_xip_area 510516 510676 160 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561206 561366 160 0.0
.app_xip_area 469832 469992 160 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571010 571170 160 0.0
.app_xip_area 469988 470148 160 0.0
.bss 83464 83464 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920940 921156 216 0.0
(read/write) 128752 128752 0 0.0
.bss 126744 126744 0 0.0
.data 2008 2008 0 0.0
.text 920932 921148 216 0.0
BRD4161A+rpc (read only) 949744 949976 232 0.0
(read/write) 144712 144712 0 0.0
.bss 142520 142520 0 0.0
.data 2188 2188 0 0.0
.text 949736 949968 232 0.0
window-app BRD4161A (read only) 851692 851900 208 0.0
(read/write) 126704 126712 8 0.0
.bss 124840 124848 8 0.0
.data 1864 1864 0 0.0
.text 851684 851892 208 0.0
esp32 all-clusters-app c3devkit (read only) 961328 961526 198 0.0
(read/write) 1394818 1394850 32 0.0
.dram0.bss 64048 64048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197672 197704 32 0.0
.flash.text 961328 961526 198 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017295 1017439 144 0.0
(read/write) 462484 462516 32 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 227056 227088 32 0.0
.flash.text 1011911 1012055 144 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 700096 700256 160 0.0
.bss 77632 77632 0 0.0
.data 1888 1888 0 0.0
.text 614776 614936 160 0.0
lock k32w061+release (read/write) 700392 700560 168 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615060 615228 168 0.0
linux chip-tool-ipv6only arm64 (read only) 9754676 9754676 0 0.0
(read/write) 475505 475505 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371288 371288 0 0.0
.dynamic 560 560 0 0.0
.got 55264 55264 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492460 492460 0 0.0
.text 8212228 8212228 0 0.0
thermostat-no-ble arm64 (read only) 2220364 2221068 704 0.0
(read/write) 149809 149809 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137772 137804 32 0.0
.text 1862528 1863200 672 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352364 2352524 160 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1314964 1315124 160 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154799 1154943 144 0.0
bss 146724 146724 0 0.0
rodata 145536 145568 32 0.0
text 787376 787496 120 0.0
p6 all-clusters-app default (read/write) 2491648 2491864 216 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1449912 1450128 216 0.0
light-app default (read/write) 2395512 2395720 208 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1353776 1353984 208 0.0
lock-app default (read/write) 2359056 2359264 208 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317320 1317528 208 0.0
telink lighting-app tlsr9518adk80d (read/write) 894938 895166 228 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 632758 632950 192 0.0

@github-actions
Copy link

github-actions bot commented Mar 17, 2022 •
edited
Loading

PR #16212: Size comparison from cd08938 to 6a5f06b

Increases (12 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section cd08938 6a5f06b change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603426 603586 160 0.0
.app_xip_area 510524 510684 160 0.0
lock cyw930739m2evb_01 (read/write) 561222 561382 160 0.0
.app_xip_area 469848 470008 160 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571018 571178 160 0.0
.app_xip_area 469996 470156 160 0.0
k32w light k32w061+release (read/write) 700096 700256 160 0.0
.text 614776 614936 160 0.0
lock k32w061+release (read/write) 700408 700560 152 0.0
.text 615076 615228 152 0.0
linux thermostat-no-ble arm64 (read only) 2220292 2220980 688 0.0
.rodata 137732 137764 32 0.0
.text 1862496 1863152 656 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2352364 2352524 160 0.0
.text 1314964 1315124 160 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154847 1155007 160 0.0
rodata 145536 145568 32 0.0
text 787436 787564 128 0.0
p6 all-clusters-app default (read/write) 2491760 2491976 216 0.0
.text 1450024 1450240 216 0.0
light-app default (read/write) 2395528 2395736 208 0.0
.text 1353792 1354000 208 0.0
lock-app default (read/write) 2359072 2359280 208 0.0
.text 1317336 1317544 208 0.0
telink lighting-app tlsr9518adk80d (read/write) 894962 895190 228 0.0
text 632820 633016 196 0.0
Full report (13 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section cd08938 6a5f06b change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603426 603586 160 0.0
.app_xip_area 510524 510684 160 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561222 561382 160 0.0
.app_xip_area 469848 470008 160 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571018 571178 160 0.0
.app_xip_area 469996 470156 160 0.0
.bss 83464 83464 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 700096 700256 160 0.0
.bss 77632 77632 0 0.0
.data 1888 1888 0 0.0
.text 614776 614936 160 0.0
lock k32w061+release (read/write) 700408 700560 152 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615076 615228 152 0.0
linux chip-tool-ipv6only arm64 (read only) 9754764 9754764 0 0.0
(read/write) 475505 475505 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371288 371288 0 0.0
.dynamic 560 560 0 0.0
.got 55264 55264 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492308 492308 0 0.0
.text 8212468 8212468 0 0.0
thermostat-no-ble arm64 (read only) 2220292 2220980 688 0.0
(read/write) 149809 149809 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137732 137764 32 0.0
.text 1862496 1863152 656 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352364 2352524 160 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1314964 1315124 160 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154847 1155007 160 0.0
bss 146724 146724 0 0.0
rodata 145536 145568 32 0.0
text 787436 787564 128 0.0
p6 all-clusters-app default (read/write) 2491760 2491976 216 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1450024 1450240 216 0.0
light-app default (read/write) 2395528 2395736 208 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1353792 1354000 208 0.0
lock-app default (read/write) 2359072 2359280 208 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317336 1317544 208 0.0
telink lighting-app tlsr9518adk80d (read/write) 894962 895190 228 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 632820 633016 196 0.0

@github-actions
Copy link

github-actions bot commented Mar 17, 2022 •
edited
Loading

PR #16212: Size comparison from cd08938 to d5c3a38

Increases (25 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section cd08938 d5c3a38 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603426 603570 144 0.0
.app_xip_area 510524 510668 144 0.0
lock cyw930739m2evb_01 (read/write) 561222 561358 136 0.0
.app_xip_area 469848 469984 136 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571018 571170 152 0.0
.app_xip_area 469996 470148 152 0.0
efr32 lighting-app BRD4161A (read only) 920956 921156 200 0.0
.text 920948 921148 200 0.0
BRD4161A+rpc (read only) 949760 949960 200 0.0
.text 949752 949952 200 0.0
window-app BRD4161A (read only) 851708 851908 200 0.0
.text 851700 851900 200 0.0
esp32 all-clusters-app c3devkit (read only) 961346 961528 182 0.0
(read/write) 1394818 1394850 32 0.0
.flash.rodata 197672 197704 32 0.0
.flash.text 961346 961528 182 0.0
m5stack (read only) 1017307 1017439 132 0.0
(read/write) 462484 462516 32 0.0
.flash.rodata 227056 227088 32 0.0
.flash.text 1011923 1012055 132 0.0
k32w light k32w061+release (read/write) 700096 700240 144 0.0
.text 614776 614920 144 0.0
lock k32w061+release (read/write) 700408 700560 152 0.0
.text 615076 615228 152 0.0
linux all-clusters-app debug (read only) 2471921 2472545 624 0.0
.rodata 210949 210981 32 0.0
.text 2097522 2098114 592 0.0
bridge-app debug+rpc (read only) 1748173 1748829 656 0.0
.rodata 143628 143692 64 0.0
.text 1489333 1489925 592 0.0
door-lock-app debug (read only) 1999337 1999977 640 0.0
.rodata 179836 179868 32 0.0
.text 1669842 1670450 608 0.0
lighting-app debug+rpc (read only) 2130953 2131625 672 0.0
.rodata 172412 172476 64 0.0
.text 1801858 1802466 608 0.0
ota-provider-app debug (read only) 1934369 1934961 592 0.0
.rodata 165835 165867 32 0.0
.text 1616770 1617330 560 0.0
ota-requestor-app debug (read only) 1964169 1964793 624 0.0
.rodata 161860 161892 32 0.0
.text 1650322 1650914 592 0.0
shell debug (read only) 2422081 2422705 624 0.0
.rodata 208882 208914 32 0.0
.text 2056498 2057090 592 0.0
thermostat-no-ble arm64 (read only) 2220292 2220900 608 0.0
.rodata 137732 137764 32 0.0
.text 1862496 1863072 576 0.0
tv-app debug (read only) 2670609 2671249 640 0.0
.rodata 205717 205749 32 0.0
.text 2290066 2290674 608 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2352364 2352524 160 0.0
.text 1314964 1315124 160 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154847 1154991 144 0.0
rodata 145536 145568 32 0.0
text 787436 787548 112 0.0
p6 all-clusters-app default (read/write) 2491760 2491960 200 0.0
.text 1450024 1450224 200 0.0
light-app default (read/write) 2395528 2395736 208 0.0
.text 1353792 1354000 208 0.0
lock-app default (read/write) 2359072 2359264 192 0.0
.text 1317336 1317528 192 0.0
telink lighting-app tlsr9518adk80d (read/write) 894962 895182 220 0.0
text 632820 633002 182 0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section cd08938 d5c3a38 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603426 603570 144 0.0
.app_xip_area 510524 510668 144 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561222 561358 136 0.0
.app_xip_area 469848 469984 136 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571018 571170 152 0.0
.app_xip_area 469996 470148 152 0.0
.bss 83464 83464 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920956 921156 200 0.0
(read/write) 128752 128752 0 0.0
.bss 126744 126744 0 0.0
.data 2008 2008 0 0.0
.text 920948 921148 200 0.0
BRD4161A+rpc (read only) 949760 949960 200 0.0
(read/write) 144712 144712 0 0.0
.bss 142520 142520 0 0.0
.data 2188 2188 0 0.0
.text 949752 949952 200 0.0
window-app BRD4161A (read only) 851708 851908 200 0.0
(read/write) 126704 126704 0 0.0
.bss 124840 124840 0 0.0
.data 1864 1864 0 0.0
.text 851700 851900 200 0.0
esp32 all-clusters-app c3devkit (read only) 961346 961528 182 0.0
(read/write) 1394818 1394850 32 0.0
.dram0.bss 64048 64048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197672 197704 32 0.0
.flash.text 961346 961528 182 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017307 1017439 132 0.0
(read/write) 462484 462516 32 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 227056 227088 32 0.0
.flash.text 1011923 1012055 132 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 700096 700240 144 0.0
.bss 77632 77632 0 0.0
.data 1888 1888 0 0.0
.text 614776 614920 144 0.0
lock k32w061+release (read/write) 700408 700560 152 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615076 615228 152 0.0
linux all-clusters-app debug (read only) 2471921 2472545 624 0.0
(read/write) 146576 146576 0 0.0
.bss 60736 60736 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78840 78840 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 210949 210981 32 0.0
.text 2097522 2098114 592 0.0
bridge-app debug+rpc (read only) 1748173 1748829 656 0.0
(read/write) 92752 92752 0 0.0
.bss 47784 47784 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 143628 143692 64 0.0
.text 1489333 1489925 592 0.0
chip-tool debug (read only) 10128269 10128269 0 0.0
(read/write) 357752 357752 0 0.0
.bss 25728 25728 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 324896 324896 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 515733 515733 0 0.0
.text 8831109 8831109 0 0.0
chip-tool-ipv6only arm64 (read only) 9754764 9754764 0 0.0
(read/write) 475505 475505 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371288 371288 0 0.0
.dynamic 560 560 0 0.0
.got 55264 55264 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492308 492308 0 0.0
.text 8212468 8212468 0 0.0
door-lock-app debug (read only) 1999337 1999977 640 0.0
(read/write) 120224 120224 0 0.0
.bss 51008 51008 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 179836 179868 32 0.0
.text 1669842 1670450 608 0.0
lighting-app debug+rpc (read only) 2130953 2131625 672 0.0
(read/write) 125544 125544 0 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66792 66792 0 0.0
.dynamic 608 608 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 172412 172476 64 0.0
.text 1801858 1802466 608 0.0
ota-provider-app debug (read only) 1934369 1934961 592 0.0
(read/write) 116048 116048 0 0.0
.bss 50912 50912 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 58200 58200 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 165835 165867 32 0.0
.text 1616770 1617330 560 0.0
ota-requestor-app debug (read only) 1964169 1964793 624 0.0
(read/write) 119016 119016 0 0.0
.bss 51904 51904 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 161860 161892 32 0.0
.text 1650322 1650914 592 0.0
shell debug (read only) 2422081 2422705 624 0.0
(read/write) 150632 150632 0 0.0
.bss 70664 70664 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73472 73472 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 208882 208914 32 0.0
.text 2056498 2057090 592 0.0
thermostat-no-ble arm64 (read only) 2220292 2220900 608 0.0
(read/write) 149809 149809 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137732 137764 32 0.0
.text 1862496 1863072 576 0.0
tv-app debug (read only) 2670609 2671249 640 0.0
(read/write) 251224 251224 0 0.0
.bss 167904 167904 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 74184 74184 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 205717 205749 32 0.0
.text 2290066 2290674 608 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352364 2352524 160 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1314964 1315124 160 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154847 1154991 144 0.0
bss 146724 146724 0 0.0
rodata 145536 145568 32 0.0
text 787436 787548 112 0.0
p6 all-clusters-app default (read/write) 2491760 2491960 200 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1450024 1450224 200 0.0
light-app default (read/write) 2395528 2395736 208 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1353792 1354000 208 0.0
lock-app default (read/write) 2359072 2359264 192 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317336 1317528 192 0.0
telink lighting-app tlsr9518adk80d (read/write) 894962 895182 220 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 632820 633002 182 0.0

@github-actions
Copy link

github-actions bot commented Mar 17, 2022 •
edited
Loading

PR #16212: Size comparison from e5c5a9e to 4d32ccc

Increases (25 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section e5c5a9e 4d32ccc change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603426 603570 144 0.0
.app_xip_area 510524 510668 144 0.0
lock cyw930739m2evb_01 (read/write) 561222 561366 144 0.0
.app_xip_area 469848 469992 144 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571026 571170 144 0.0
.app_xip_area 470004 470148 144 0.0
efr32 lighting-app BRD4161A (read only) 920956 921156 200 0.0
.text 920948 921148 200 0.0
BRD4161A+rpc (read only) 949760 949960 200 0.0
.text 949752 949952 200 0.0
window-app BRD4161A (read only) 851708 851908 200 0.0
.text 851700 851900 200 0.0
esp32 all-clusters-app c3devkit (read only) 961334 961508 174 0.0
(read/write) 1394818 1394850 32 0.0
.flash.rodata 197672 197704 32 0.0
.flash.text 961334 961508 174 0.0
m5stack (read only) 1017487 1017559 72 0.0
(read/write) 462660 462692 32 0.0
.flash.rodata 227232 227264 32 0.0
.flash.text 1012103 1012175 72 0.0
k32w light k32w061+release (read/write) 700112 700256 144 0.0
.text 614792 614936 144 0.0
lock k32w061+release (read/write) 700408 700560 152 0.0
.text 615076 615228 152 0.0
linux all-clusters-app debug (read only) 2471921 2472433 512 0.0
.rodata 210949 210981 32 0.0
.text 2097522 2098002 480 0.0
bridge-app debug+rpc (read only) 1748173 1748717 544 0.0
.rodata 143628 143692 64 0.0
.text 1489333 1489813 480 0.0
door-lock-app debug (read only) 1999337 1999865 528 0.0
.rodata 179836 179868 32 0.0
.text 1669842 1670338 496 0.0
lighting-app debug+rpc (read only) 2130937 2131497 560 0.0
.rodata 172412 172476 64 0.0
.text 1801842 1802338 496 0.0
ota-provider-app debug (read only) 1934369 1934865 496 0.0
.rodata 165835 165867 32 0.0
.text 1616770 1617234 464 0.0
ota-requestor-app debug (read only) 1964169 1964697 528 0.0
.rodata 161860 161892 32 0.0
.text 1650322 1650818 496 0.0
shell debug (read only) 2422081 2422609 528 0.0
.rodata 208882 208914 32 0.0
.text 2056498 2056994 496 0.0
thermostat-no-ble arm64 (read only) 2220292 2220772 480 0.0
.rodata 137732 137764 32 0.0
.text 1862496 1862944 448 0.0
tv-app debug (read only) 2670609 2671137 528 0.0
.rodata 205717 205749 32 0.0
.text 2290066 2290562 496 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2352364 2352524 160 0.0
.text 1314964 1315124 160 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154847 1154991 144 0.0
rodata 145536 145568 32 0.0
text 787424 787536 112 0.0
p6 all-clusters-app default (read/write) 2491760 2491960 200 0.0
.text 1450024 1450224 200 0.0
light-app default (read/write) 2395528 2395720 192 0.0
.text 1353792 1353984 192 0.0
lock-app default (read/write) 2359072 2359264 192 0.0
.text 1317336 1317528 192 0.0
telink lighting-app tlsr9518adk80d (read/write) 894946 895158 212 0.0
text 632808 632982 174 0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section e5c5a9e 4d32ccc change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603426 603570 144 0.0
.app_xip_area 510524 510668 144 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561222 561366 144 0.0
.app_xip_area 469848 469992 144 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571026 571170 144 0.0
.app_xip_area 470004 470148 144 0.0
.bss 83464 83464 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920956 921156 200 0.0
(read/write) 128752 128752 0 0.0
.bss 126744 126744 0 0.0
.data 2008 2008 0 0.0
.text 920948 921148 200 0.0
BRD4161A+rpc (read only) 949760 949960 200 0.0
(read/write) 144712 144712 0 0.0
.bss 142520 142520 0 0.0
.data 2188 2188 0 0.0
.text 949752 949952 200 0.0
window-app BRD4161A (read only) 851708 851908 200 0.0
(read/write) 126704 126704 0 0.0
.bss 124840 124840 0 0.0
.data 1864 1864 0 0.0
.text 851700 851900 200 0.0
esp32 all-clusters-app c3devkit (read only) 961334 961508 174 0.0
(read/write) 1394818 1394850 32 0.0
.dram0.bss 64048 64048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197672 197704 32 0.0
.flash.text 961334 961508 174 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017487 1017559 72 0.0
(read/write) 462660 462692 32 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 227232 227264 32 0.0
.flash.text 1012103 1012175 72 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 700112 700256 144 0.0
.bss 77632 77632 0 0.0
.data 1888 1888 0 0.0
.text 614792 614936 144 0.0
lock k32w061+release (read/write) 700408 700560 152 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615076 615228 152 0.0
linux all-clusters-app debug (read only) 2471921 2472433 512 0.0
(read/write) 146576 146576 0 0.0
.bss 60736 60736 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78840 78840 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 210949 210981 32 0.0
.text 2097522 2098002 480 0.0
bridge-app debug+rpc (read only) 1748173 1748717 544 0.0
(read/write) 92752 92752 0 0.0
.bss 47784 47784 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 143628 143692 64 0.0
.text 1489333 1489813 480 0.0
chip-tool debug (read only) 10128269 10128269 0 0.0
(read/write) 357752 357752 0 0.0
.bss 25728 25728 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 324896 324896 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 515733 515733 0 0.0
.text 8831109 8831109 0 0.0
chip-tool-ipv6only arm64 (read only) 9754764 9754764 0 0.0
(read/write) 475505 475505 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371288 371288 0 0.0
.dynamic 560 560 0 0.0
.got 55264 55264 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492308 492308 0 0.0
.text 8212468 8212468 0 0.0
door-lock-app debug (read only) 1999337 1999865 528 0.0
(read/write) 120224 120224 0 0.0
.bss 51008 51008 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 179836 179868 32 0.0
.text 1669842 1670338 496 0.0
lighting-app debug+rpc (read only) 2130937 2131497 560 0.0
(read/write) 125544 125544 0 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66792 66792 0 0.0
.dynamic 608 608 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 172412 172476 64 0.0
.text 1801842 1802338 496 0.0
ota-provider-app debug (read only) 1934369 1934865 496 0.0
(read/write) 116048 116048 0 0.0
.bss 50912 50912 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 58200 58200 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 165835 165867 32 0.0
.text 1616770 1617234 464 0.0
ota-requestor-app debug (read only) 1964169 1964697 528 0.0
(read/write) 119016 119016 0 0.0
.bss 51904 51904 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 161860 161892 32 0.0
.text 1650322 1650818 496 0.0
shell debug (read only) 2422081 2422609 528 0.0
(read/write) 150632 150632 0 0.0
.bss 70664 70664 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73472 73472 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 208882 208914 32 0.0
.text 2056498 2056994 496 0.0
thermostat-no-ble arm64 (read only) 2220292 2220772 480 0.0
(read/write) 149809 149809 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137732 137764 32 0.0
.text 1862496 1862944 448 0.0
tv-app debug (read only) 2670609 2671137 528 0.0
(read/write) 251224 251224 0 0.0
.bss 167904 167904 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 74184 74184 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 205717 205749 32 0.0
.text 2290066 2290562 496 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352364 2352524 160 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1314964 1315124 160 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154847 1154991 144 0.0
bss 146724 146724 0 0.0
rodata 145536 145568 32 0.0
text 787424 787536 112 0.0
p6 all-clusters-app default (read/write) 2491760 2491960 200 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1450024 1450224 200 0.0
light-app default (read/write) 2395528 2395720 192 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1353792 1353984 192 0.0
lock-app default (read/write) 2359072 2359264 192 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317336 1317528 192 0.0
telink lighting-app tlsr9518adk80d (read/write) 894946 895158 212 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 632808 632982 174 0.0

@github-actions
Copy link

github-actions bot commented Mar 18, 2022 •
edited
Loading

PR #16212: Size comparison from c4d81c8 to 3f19e61

Increases (17 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c4d81c8 3f19e61 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603538 603682 144 0.0
.app_xip_area 510636 510780 144 0.0
lock cyw930739m2evb_01 (read/write) 561326 561470 144 0.0
.app_xip_area 469952 470096 144 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571050 571194 144 0.0
.app_xip_area 470028 470172 144 0.0
efr32 lighting-app BRD4161A (read only) 921384 921584 200 0.0
.text 921376 921576 200 0.0
BRD4161A+rpc (read only) 950188 950388 200 0.0
.text 950180 950380 200 0.0
window-app BRD4161A (read only) 851944 852136 192 0.0
.text 851936 852128 192 0.0
esp32 all-clusters-app c3devkit (read only) 961498 961672 174 0.0
(read/write) 1395034 1395066 32 0.0
.flash.rodata 197888 197920 32 0.0
.flash.text 961498 961672 174 0.0
m5stack (read only) 1017639 1017759 120 0.0
(read/write) 462892 462924 32 0.0
.flash.rodata 227464 227496 32 0.0
.flash.text 1012255 1012375 120 0.0
k32w light k32w061+release (read/write) 700516 700660 144 0.0
.text 615196 615340 144 0.0
lock k32w061+release (read/write) 700652 700788 136 0.0
.text 615320 615456 136 0.0
linux thermostat-no-ble arm64 (read only) 2221092 2221572 480 0.0
.rodata 137956 137988 32 0.0
.text 1863072 1863520 448 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2352508 2352668 160 0.0
.text 1315108 1315268 160 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155239 1155383 144 0.0
rodata 145768 145800 32 0.0
text 787588 787700 112 0.0
p6 all-clusters-app default (read/write) 2492120 2492320 200 0.0
.text 1450384 1450584 200 0.0
light-app default (read/write) 2395704 2395904 200 0.0
.text 1353968 1354168 200 0.0
lock-app default (read/write) 2359248 2359448 200 0.0
.text 1317512 1317712 200 0.0
telink lighting-app tlsr9518adk80d (read/write) 895306 895518 212 0.0
text 632968 633142 174 0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c4d81c8 3f19e61 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603538 603682 144 0.0
.app_xip_area 510636 510780 144 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561326 561470 144 0.0
.app_xip_area 469952 470096 144 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571050 571194 144 0.0
.app_xip_area 470028 470172 144 0.0
.bss 83464 83464 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921384 921584 200 0.0
(read/write) 128752 128752 0 0.0
.bss 126744 126744 0 0.0
.data 2008 2008 0 0.0
.text 921376 921576 200 0.0
BRD4161A+rpc (read only) 950188 950388 200 0.0
(read/write) 144708 144708 0 0.0
.bss 142520 142520 0 0.0
.data 2188 2188 0 0.0
.text 950180 950380 200 0.0
window-app BRD4161A (read only) 851944 852136 192 0.0
(read/write) 126704 126704 0 0.0
.bss 124840 124840 0 0.0
.data 1864 1864 0 0.0
.text 851936 852128 192 0.0
esp32 all-clusters-app c3devkit (read only) 961498 961672 174 0.0
(read/write) 1395034 1395066 32 0.0
.dram0.bss 64048 64048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197888 197920 32 0.0
.flash.text 961498 961672 174 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017639 1017759 120 0.0
(read/write) 462892 462924 32 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 227464 227496 32 0.0
.flash.text 1012255 1012375 120 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 700516 700660 144 0.0
.bss 77632 77632 0 0.0
.data 1888 1888 0 0.0
.text 615196 615340 144 0.0
lock k32w061+release (read/write) 700652 700788 136 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615320 615456 136 0.0
linux chip-tool-ipv6only arm64 (read only) 9765964 9765964 0 0.0
(read/write) 476113 476113 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371824 371824 0 0.0
.dynamic 560 560 0 0.0
.got 55328 55328 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493620 493620 0 0.0
.text 8220980 8220980 0 0.0
thermostat-no-ble arm64 (read only) 2221092 2221572 480 0.0
(read/write) 149809 149809 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137956 137988 32 0.0
.text 1863072 1863520 448 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352508 2352668 160 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1315108 1315268 160 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155239 1155383 144 0.0
bss 146724 146724 0 0.0
rodata 145768 145800 32 0.0
text 787588 787700 112 0.0
p6 all-clusters-app default (read/write) 2492120 2492320 200 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1450384 1450584 200 0.0
light-app default (read/write) 2395704 2395904 200 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1353968 1354168 200 0.0
lock-app default (read/write) 2359248 2359448 200 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317512 1317712 200 0.0
telink lighting-app tlsr9518adk80d (read/write) 895306 895518 212 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 632968 633142 174 0.0

@github-actions
Copy link

github-actions bot commented Mar 18, 2022 •
edited
Loading

PR #16212: Size comparison from c4d81c8 to fa86a57

Increases (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c4d81c8 fa86a57 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603538 603810 272 0.0
.app_xip_area 510636 510908 272 0.1
lock cyw930739m2evb_01 (read/write) 561326 561590 264 0.0
.app_xip_area 469952 470216 264 0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571050 571314 264 0.0
.app_xip_area 470028 470292 264 0.1
efr32 lighting-app BRD4161A (read only) 921384 921696 312 0.0
.text 921376 921688 312 0.0
BRD4161A+rpc (read only) 950188 950516 328 0.0
.text 950180 950508 328 0.0
window-app BRD4161A (read only) 851944 852232 288 0.0
(read/write) 126704 126712 8 0.0
.bss 124840 124848 8 0.0
.text 851936 852224 288 0.0
esp32 all-clusters-app c3devkit (read only) 961498 961774 276 0.0
(read/write) 1395034 1395066 32 0.0
.flash.rodata 197888 197920 32 0.0
.flash.text 961498 961774 276 0.0
m5stack (read only) 1017639 1017847 208 0.0
(read/write) 462892 462924 32 0.0
.flash.rodata 227464 227496 32 0.0
.flash.text 1012255 1012463 208 0.0
k32w light k32w061+release (read/write) 700516 700772 256 0.0
.text 615196 615452 256 0.0
lock k32w061+release (read/write) 700652 700900 248 0.0
.text 615320 615568 248 0.0
linux chip-tool-ipv6only arm64 (read only) 9765964 9767676 1712 0.0
.text 8220980 8222692 1712 0.0
thermostat-no-ble arm64 (read only) 2221092 2222308 1216 0.1
.rodata 137956 137988 32 0.0
.text 1863072 1864256 1184 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2352508 2353036 528 0.0
.text 1315108 1315636 528 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155239 1155479 240 0.0
rodata 145768 145800 32 0.0
text 787588 787796 208 0.0
p6 all-clusters-app default (read/write) 2492120 2492432 312 0.0
.text 1450384 1450696 312 0.0
light-app default (read/write) 2395704 2396000 296 0.0
.text 1353968 1354264 296 0.0
lock-app default (read/write) 2359248 2359544 296 0.0
.text 1317512 1317808 296 0.0
telink lighting-app tlsr9518adk80d (read/write) 895306 895622 316 0.0
text 632968 633244 276 0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c4d81c8 fa86a57 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603538 603810 272 0.0
.app_xip_area 510636 510908 272 0.1
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561326 561590 264 0.0
.app_xip_area 469952 470216 264 0.1
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571050 571314 264 0.0
.app_xip_area 470028 470292 264 0.1
.bss 83464 83464 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921384 921696 312 0.0
(read/write) 128752 128752 0 0.0
.bss 126744 126744 0 0.0
.data 2008 2008 0 0.0
.text 921376 921688 312 0.0
BRD4161A+rpc (read only) 950188 950516 328 0.0
(read/write) 144708 144708 0 0.0
.bss 142520 142520 0 0.0
.data 2188 2188 0 0.0
.text 950180 950508 328 0.0
window-app BRD4161A (read only) 851944 852232 288 0.0
(read/write) 126704 126712 8 0.0
.bss 124840 124848 8 0.0
.data 1864 1864 0 0.0
.text 851936 852224 288 0.0
esp32 all-clusters-app c3devkit (read only) 961498 961774 276 0.0
(read/write) 1395034 1395066 32 0.0
.dram0.bss 64048 64048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197888 197920 32 0.0
.flash.text 961498 961774 276 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017639 1017847 208 0.0
(read/write) 462892 462924 32 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 227464 227496 32 0.0
.flash.text 1012255 1012463 208 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 700516 700772 256 0.0
.bss 77632 77632 0 0.0
.data 1888 1888 0 0.0
.text 615196 615452 256 0.0
lock k32w061+release (read/write) 700652 700900 248 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615320 615568 248 0.0
linux chip-tool-ipv6only arm64 (read only) 9765964 9767676 1712 0.0
(read/write) 476113 476113 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371824 371824 0 0.0
.dynamic 560 560 0 0.0
.got 55328 55328 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493620 493620 0 0.0
.text 8220980 8222692 1712 0.0
thermostat-no-ble arm64 (read only) 2221092 2222308 1216 0.1
(read/write) 149809 149809 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137956 137988 32 0.0
.text 1863072 1864256 1184 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352508 2353036 528 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1315108 1315636 528 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155239 1155479 240 0.0
bss 146724 146724 0 0.0
rodata 145768 145800 32 0.0
text 787588 787796 208 0.0
p6 all-clusters-app default (read/write) 2492120 2492432 312 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1450384 1450696 312 0.0
light-app default (read/write) 2395704 2396000 296 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1353968 1354264 296 0.0
lock-app default (read/write) 2359248 2359544 296 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317512 1317808 296 0.0
telink lighting-app tlsr9518adk80d (read/write) 895306 895622 316 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 632968 633244 276 0.0

@yufengwangca yufengwangca merged commit 472c351 into project-chip:master Mar 18, 2022
@yufengwangca yufengwangca deleted the pr/opecred/cleanup branch March 18, 2022 15:26
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@yufengwangca @andrei-menzopol
Cleanup OperationalCredentials if the fail-safe timer expires (projec…
6259975 
…t-chip#16212)

* Cleanup OperationalCredentials if the fail-safe timer expires

* Address review comments

* Capture failSafeContext in CommissioningFailedTimerComplete event

* Clear things out from the CASESessionManager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux left review comments

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yufengwangca @tcarmelveilleux @yunhanw-google @bzbarsky-apple