Fix numRetries for subscription

[yunhanw-google]

Problem

See issue #16186

Change overview

-- clear the counter back to 0 on successful establishment of a subscription.

Testing

Manual testing, create subscription, restart responder, initiator retry with success and observe the log

[github-actions]

PR #16199: Size comparison from e6a96ac to 7c5d6b8

Increases (3 builds for linux)

platform	target	config	section	e6a96ac	7c5d6b8	change	% change
linux	chip-tool	debug	(read only)	10094989	10095037	48	0.0
			.text	8798741	8798789	48	0.0
	chip-tool-ipv6only	arm64	(read only)	9728060	9728092	32	0.0
			.text	8186020	8186052	32	0.0
	tv-app	debug	(read only)	2656065	2656097	32	0.0
			.text	2277794	2277826	32	0.0

Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)

platform	target	config	section	e6a96ac	7c5d6b8	change	% change
cyw30739	light	cyw930739m2evb_01	(read/write)	602578	602578	0	0.0
			.app_xip_area	509756	509756	0	0.0
			.bss	75576	75576	0	0.0
			.data	596	596	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	lock	cyw930739m2evb_01	(read/write)	560430	560430	0	0.0
			.app_xip_area	469136	469136	0	0.0
			.bss	74080	74080	0	0.0
			.data	560	560	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	570538	570538	0	0.0
			.app_xip_area	469596	469596	0	0.0
			.bss	83384	83384	0	0.0
			.data	520	520	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
efr32	lighting-app	BRD4161A	(read only)	918532	918532	0	0.0
			(read/write)	128656	128656	0	0.0
			.bss	126648	126648	0	0.0
			.data	2008	2008	0	0.0
			.text	918524	918524	0	0.0
		BRD4161A+rpc	(read only)	947336	947336	0	0.0
			(read/write)	144616	144616	0	0.0
			.bss	142424	142424	0	0.0
			.data	2188	2188	0	0.0
			.text	947328	947328	0	0.0
	window-app	BRD4161A	(read only)	850392	850392	0	0.0
			(read/write)	126632	126632	0	0.0
			.bss	124768	124768	0	0.0
			.data	1864	1864	0	0.0
			.text	850384	850384	0	0.0
esp32	all-clusters-app	c3devkit	(read only)	961388	961388	0	0.0
			(read/write)	1394938	1394938	0	0.0
			.dram0.bss	64056	64056	0	0.0
			.dram0.data	14188	14188	0	0.0
			.flash.rodata	197776	197776	0	0.0
			.flash.text	961388	961388	0	0.0
			.iram0.text	62016	62016	0	0.0
		m5stack	(read only)	1017011	1017011	0	0.0
			(read/write)	462148	462148	0	0.0
			.dram0.bss	69576	69576	0	0.0
			.dram0.data	34016	34016	0	0.0
			.flash.rodata	226720	226720	0	0.0
			.flash.text	1011627	1011627	0	0.0
			.iram0.text	123107	123107	0	0.0
k32w	light	k32w061+release	(read/write)	699388	699388	0	0.0
			.bss	77560	77560	0	0.0
			.data	1888	1888	0	0.0
			.text	614140	614140	0	0.0
	lock	k32w061+release	(read/write)	699644	699644	0	0.0
			.bss	77552	77552	0	0.0
			.data	1908	1908	0	0.0
			.text	614384	614384	0	0.0
linux	all-clusters-app	debug	(read only)	2465225	2465225	0	0.0
			(read/write)	146352	146352	0	0.0
			.bss	60640	60640	0	0.0
			.data	1264	1264	0	0.0
			.data.rel.ro	78728	78728	0	0.0
			.dynamic	592	592	0	0.0
			.got	4168	4168	0	0.0
			.init	27	27	0	0.0
			.init_array	936	936	0	0.0
			.rodata	210693	210693	0	0.0
			.text	2091298	2091298	0	0.0
	bridge-app	debug+rpc	(read only)	1749757	1749757	0	0.0
			(read/write)	92912	92912	0	0.0
			.bss	47752	47752	0	0.0
			.data	1952	1952	0	0.0
			.data.rel.ro	38128	38128	0	0.0
			.dynamic	592	592	0	0.0
			.got	3920	3920	0	0.0
			.init	27	27	0	0.0
			.init_array	544	544	0	0.0
			.rodata	143308	143308	0	0.0
			.text	1490901	1490901	0	0.0
	chip-tool	debug	(read only)	10094989	10095037	48	0.0
			(read/write)	357680	357680	0	0.0
			.bss	25696	25696	0	0.0
			.data	1072	1072	0	0.0
			.data.rel.ro	324864	324864	0	0.0
			.dynamic	608	608	0	0.0
			.got	4776	4776	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	514997	514997	0	0.0
			.text	8798741	8798789	48	0.0
	chip-tool-ipv6only	arm64	(read only)	9728060	9728092	32	0.0
			(read/write)	475425	475425	0	0.0
			.bss	44017	44017	0	0.0
			.data	1128	1128	0	0.0
			.data.rel.ro	371232	371232	0	0.0
			.dynamic	560	560	0	0.0
			.got	55256	55256	0	0.0
			.init	24	24	0	0.0
			.init_array	192	192	0	0.0
			.rodata	492196	492196	0	0.0
			.text	8186020	8186052	32	0.0
	door-lock-app	debug	(read only)	1984385	1984385	0	0.0
			(read/write)	119776	119776	0	0.0
			.bss	50944	50944	0	0.0
			.data	992	992	0	0.0
			.data.rel.ro	62456	62456	0	0.0
			.dynamic	592	592	0	0.0
			.got	4104	4104	0	0.0
			.init	27	27	0	0.0
			.init_array	664	664	0	0.0
			.rodata	178396	178396	0	0.0
			.text	1657090	1657090	0	0.0
	lighting-app	debug+rpc	(read only)	2115961	2115961	0	0.0
			(read/write)	125160	125160	0	0.0
			.bss	51776	51776	0	0.0
			.data	1472	1472	0	0.0
			.data.rel.ro	66408	66408	0	0.0
			.dynamic	608	608	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	736	736	0	0.0
			.rodata	170940	170940	0	0.0
			.text	1789106	1789106	0	0.0
	ota-provider-app	debug	(read only)	1917697	1917697	0	0.0
			(read/write)	115504	115504	0	0.0
			.bss	50816	50816	0	0.0
			.data	1256	1256	0	0.0
			.data.rel.ro	57816	57816	0	0.0
			.dynamic	608	608	0	0.0
			.got	4360	4360	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	163659	163659	0	0.0
			.text	1603058	1603058	0	0.0
	ota-requestor-app	debug	(read only)	1949265	1949265	0	0.0
			(read/write)	118568	118568	0	0.0
			.bss	51840	51840	0	0.0
			.data	1416	1416	0	0.0
			.data.rel.ro	59880	59880	0	0.0
			.dynamic	592	592	0	0.0
			.got	4152	4152	0	0.0
			.init	27	27	0	0.0
			.init_array	640	640	0	0.0
			.rodata	160292	160292	0	0.0
			.text	1637746	1637746	0	0.0
	shell	debug	(read only)	2411385	2411385	0	0.0
			(read/write)	150184	150184	0	0.0
			.bss	70600	70600	0	0.0
			.data	784	784	0	0.0
			.data.rel.ro	73088	73088	0	0.0
			.dynamic	592	592	0	0.0
			.got	4152	4152	0	0.0
			.init	27	27	0	0.0
			.init_array	920	920	0	0.0
			.rodata	207474	207474	0	0.0
			.text	2047762	2047762	0	0.0
	thermostat-no-ble	arm64	(read only)	2207236	2207236	0	0.0
			(read/write)	149377	149377	0	0.0
			.bss	65649	65649	0	0.0
			.data	1024	1024	0	0.0
			.data.rel.ro	75368	75368	0	0.0
			.dynamic	560	560	0	0.0
			.got	4352	4352	0	0.0
			.init	24	24	0	0.0
			.init_array	360	360	0	0.0
			.rodata	136756	136756	0	0.0
			.text	1851168	1851168	0	0.0
	tv-app	debug	(read only)	2656065	2656097	32	0.0
			(read/write)	250776	250776	0	0.0
			.bss	167840	167840	0	0.0
			.data	3104	3104	0	0.0
			.data.rel.ro	73800	73800	0	0.0
			.dynamic	592	592	0	0.0
			.got	4536	4536	0	0.0
			.init	27	27	0	0.0
			.init_array	880	880	0	0.0
			.rodata	204213	204213	0	0.0
			.text	2277794	2277826	32	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2352756	2352756	0	0.0
			.bss	186652	186652	0	0.0
			.data	5752	5752	0	0.0
			.text	1315356	1315356	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1154043	1154043	0	0.0
			bss	146644	146644	0	0.0
			rodata	145276	145276	0	0.0
			text	787016	787016	0	0.0
p6	all-clusters-app	default	(read/write)	2492152	2492152	0	0.0
			.bss	120080	120080	0	0.0
			.data	2632	2632	0	0.0
			.text	1450416	1450416	0	0.0
	light-app	default	(read/write)	2396000	2396000	0	0.0
			.bss	113544	113544	0	0.0
			.data	2488	2488	0	0.0
			.text	1354264	1354264	0	0.0
	lock-app	default	(read/write)	2359544	2359544	0	0.0
			.bss	113288	113288	0	0.0
			.data	2448	2448	0	0.0
			.text	1317808	1317808	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	893770	893770	0	0.0
			bss	87432	87432	0	0.0
			noinit	37160	37160	0	0.0
			text	631868	631868	0	0.0