[ReSubmitted][Chip-Cert] Prevent extra bytes to be encoded when converting key to chip-b64 #16121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chip-b64 Observed : - Existing code encodes bytes beyond the buffer actually containing the key. - The issue was sizeof(P256SerializedKeypair) that includes 'length' field as well as 'bytes' field. Changes : - Make use of serializedKeypair.Length() to retrieve actual key length - Clarify usage of buffer sizes vs actual used lengths - Additionally, do not assume that P256SerializedKeypair 'bytes' field is the first field of the data structure (i.e. has implicitly same address as the structure itself)
emargolis
approved these changes
Mar 11, 2022
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
msandstedt,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs and
vivien-apple
bzbarsky-apple
approved these changes
Mar 12, 2022
|
PR #16121: Size comparison from 86a8444 to 5b7d7b1 Full report (2 builds for mbed, nrfconnect)
|
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…chip-b64 (project-chip#16121) Observed : - Existing code encodes bytes beyond the buffer actually containing the key. - The issue was sizeof(P256SerializedKeypair) that includes 'length' field as well as 'bytes' field. Changes : - Make use of serializedKeypair.Length() to retrieve actual key length - Clarify usage of buffer sizes vs actual used lengths - Additionally, do not assume that P256SerializedKeypair 'bytes' field is the first field of the data structure (i.e. has implicitly same address as the structure itself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
key.
field as well as 'bytes' field.
Change overview
is the first field of the data structure (i.e. has implicitly same
address as the structure itself)
Testing
How was this tested? (at least one bullet point required)