[ota] Automatic NotifyUpdateApplied #16103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two methods to OTAImageProcessor: - IsFirstImageRun() to determine if the currently running image is executed for the first time - ConfirmCurrentImage() to confirm that the current image is stable and the update can be left permanently. Add storing and loading the current provider and the update token in OTARequestor. Then extend GenericOTARequestorDriver to automatically confirm the current image and send NotifyUpdateApplied command to the last provider.
|
PR #16103: Size comparison from ae514b6 to d80e54c Increases above 0.2%:
Increases (15 builds for cyw30739, efr32, k32w, mbed, nrfconnect)
Full report (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #16103: Size comparison from ae514b6 to 7a0a83d Increases above 0.2%:
Increases (15 builds for cyw30739, efr32, k32w, mbed, nrfconnect)
Full report (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
carol-apple
approved these changes
Mar 12, 2022
pullapprove
bot
requested review from
austinh0,
Byungjoo-Lee,
cecille,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
erjiaqing,
gjc13,
hawk248,
harsha-rajendran,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost and
kpschoedel
pullapprove
bot
requested review from
lazarkov,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
wbschiller,
xylophone21 and
yufengwangca
andy31415
approved these changes
Mar 14, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
* [ota] Automatic NotifyUpdateApplied Add two methods to OTAImageProcessor: - IsFirstImageRun() to determine if the currently running image is executed for the first time - ConfirmCurrentImage() to confirm that the current image is stable and the update can be left permanently. Add storing and loading the current provider and the update token in OTARequestor. Then extend GenericOTARequestorDriver to automatically confirm the current image and send NotifyUpdateApplied command to the last provider. * Fix build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
NotifyUpdateAppliedcommand is not sent automatically.Change overview
Add two methods to
OTAImageProcessor:IsFirstImageRun()to determine if the currently running image is executed for the first timeConfirmCurrentImage()to confirm that the current image is stable and the update can be left permanently.Add storing and loading the current provider and the update token in
OTARequestor.Then extend GenericOTARequestorDriver to automatically confirm the current image and send
NotifyUpdateAppliedcommand to the last provider.
Fixes #15404
Testing
Tested on nRF Connect platform that the full OTA succeeds and NotifyUpdateApplied is sent after applying an update.