Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GroupDataProvider: PersistentStorageDelegate Initialization #16079

Merged
merged 6 commits into from
Mar 12, 2022
Merged

GroupDataProvider: PersistentStorageDelegate Initialization #16079

merged 6 commits into from
Mar 12, 2022

Conversation

rcasallas-silabs
Copy link
Contributor

@rcasallas-silabs rcasallas-silabs commented Mar 10, 2022 •
edited
Loading

Problem

The storage delegate should be injected using the Init() method, instead of the constructor

Change overview

  • The storage delegate is now an argument of the GroupDataProvider::Init()
  • Group data provider implementation updated accordingly
  • Calls to the GroupDataProvider constructors, and Init() updated accordingly

Testing

Group, and Group Data Provider unit tests and YAML tests ran successfully.

@github-actions
Copy link

github-actions bot commented Mar 10, 2022 •
edited
Loading

PR #16079: Size comparison from 244969f to aa5013d

Increases (21 builds for cyw30739, esp32, k32w, linux, mbed, nrfconnect, telink)
platform target config section 244969f aa5013d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599122 599170 48 0.0
.app_xip_area 506704 506752 48 0.0
lock cyw930739m2evb_01 (read/write) 556994 557034 40 0.0
.app_xip_area 466112 466152 40 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566886 566926 40 0.0
.app_xip_area 466316 466356 40 0.0
esp32 all-clusters-app c3devkit (read only) 958454 958512 58 0.0
.flash.text 958454 958512 58 0.0
m5stack (read only) 1014051 1014079 28 0.0
.flash.text 1008667 1008695 28 0.0
k32w light k32w061+release (read/write) 695496 695544 48 0.0
.text 610620 610668 48 0.0
lock k32w061+release (read/write) 696340 696388 48 0.0
.text 611504 611552 48 0.0
linux all-clusters-app debug (read only) 2435393 2435601 208 0.0
.text 2066450 2066658 208 0.0
bridge-app debug+rpc (read only) 1740741 1740949 208 0.0
.text 1482645 1482853 208 0.0
chip-tool debug (read only) 10097253 10097445 192 0.0
.text 8800053 8800245 192 0.0
chip-tool-ipv6only arm64 (read only) 9730828 9731020 192 0.0
.text 8187556 8187748 192 0.0
door-lock-app debug (read only) 1955057 1955265 208 0.0
.text 1632338 1632546 208 0.0
lighting-app debug+rpc (read only) 2087193 2087401 208 0.0
.text 1765298 1765506 208 0.0
ota-provider-app debug (read only) 1888441 1888649 208 0.0
.text 1578466 1578674 208 0.0
ota-requestor-app debug (read only) 1916313 1916521 208 0.0
.text 1610194 1610402 208 0.0
shell debug (read only) 2401409 2401617 208 0.0
.text 2038930 2039138 208 0.0
thermostat-no-ble arm64 (read only) 2181156 2181380 224 0.0
.text 1829312 1829536 224 0.0
tv-app debug (read only) 2627081 2627289 208 0.0
.text 2253442 2253650 208 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2350900 2350964 64 0.0
.text 1313500 1313564 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152691 1152739 48 0.0
text 786680 786720 40 0.0
telink lighting-app tlsr9518adk80d (read/write) 889742 889790 48 0.0
text 628890 628944 54 0.0
Decreases (6 builds for efr32, p6)
platform target config section 244969f aa5013d change % change
efr32 lighting-app BRD4161A (read only) 920984 912808 -8176 -0.9
.text 920976 912800 -8176 -0.9
BRD4161A+rpc (read only) 949780 941620 -8160 -0.9
.text 949772 941612 -8160 -0.9
window-app BRD4161A (read only) 853524 845348 -8176 -1.0
.text 853516 845340 -8176 -1.0
p6 all-clusters-app default (read/write) 2495440 2487280 -8160 -0.3
.text 1453704 1445544 -8160 -0.6
light-app default (read/write) 2399472 2391296 -8176 -0.3
.text 1357736 1349560 -8176 -0.6
lock-app default (read/write) 2363016 2354840 -8176 -0.3
.text 1321280 1313104 -8176 -0.6
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 244969f aa5013d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599122 599170 48 0.0
.app_xip_area 506704 506752 48 0.0
.bss 75108 75108 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556994 557034 40 0.0
.app_xip_area 466112 466152 40 0.0
.bss 73612 73612 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566886 566926 40 0.0
.app_xip_area 466316 466356 40 0.0
.bss 82980 82980 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920984 912808 -8176 -0.9
(read/write) 128256 128256 0 0.0
.bss 126216 126216 0 0.0
.data 2040 2040 0 0.0
.text 920976 912800 -8176 -0.9
BRD4161A+rpc (read only) 949780 941620 -8160 -0.9
(read/write) 144212 144212 0 0.0
.bss 141992 141992 0 0.0
.data 2220 2220 0 0.0
.text 949772 941612 -8160 -0.9
window-app BRD4161A (read only) 853524 845348 -8176 -1.0
(read/write) 126220 126220 0 0.0
.bss 124304 124304 0 0.0
.data 1916 1916 0 0.0
.text 853516 845340 -8176 -1.0
esp32 all-clusters-app c3devkit (read only) 958454 958512 58 0.0
(read/write) 1393914 1393914 0 0.0
.dram0.bss 63576 63576 0 0.0
.dram0.data 14228 14228 0 0.0
.flash.rodata 197184 197184 0 0.0
.flash.text 958454 958512 58 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1014051 1014079 28 0.0
(read/write) 461140 461140 0 0.0
.dram0.bss 69096 69096 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226144 226144 0 0.0
.flash.text 1008667 1008695 28 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 695496 695544 48 0.0
.bss 77152 77152 0 0.0
.data 1924 1924 0 0.0
.text 610620 610668 48 0.0
lock k32w061+release (read/write) 696340 696388 48 0.0
.bss 77072 77072 0 0.0
.data 1964 1964 0 0.0
.text 611504 611552 48 0.0
linux all-clusters-app debug (read only) 2435393 2435601 208 0.0
(read/write) 145872 145872 0 0.0
.bss 60352 60352 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78424 78424 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 205957 205957 0 0.0
.text 2066450 2066658 208 0.0
bridge-app debug+rpc (read only) 1740741 1740949 208 0.0
(read/write) 92784 92784 0 0.0
.bss 47624 47624 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 38064 38064 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 142124 142124 0 0.0
.text 1482645 1482853 208 0.0
chip-tool debug (read only) 10097253 10097445 192 0.0
(read/write) 358168 358168 0 0.0
.bss 25640 25640 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 325352 325352 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514516 514516 0 0.0
.text 8800053 8800245 192 0.0
chip-tool-ipv6only arm64 (read only) 9730828 9731020 192 0.0
(read/write) 475905 475905 0 0.0
.bss 43953 43953 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 371664 371664 0 0.0
.dynamic 560 560 0 0.0
.got 55296 55296 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492148 492148 0 0.0
.text 8187556 8187748 192 0.0
door-lock-app debug (read only) 1955057 1955265 208 0.0
(read/write) 119296 119296 0 0.0
.bss 50656 50656 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 174076 174076 0 0.0
.text 1632338 1632546 208 0.0
lighting-app debug+rpc (read only) 2087193 2087401 208 0.0
(read/write) 124616 124616 0 0.0
.bss 51456 51456 0 0.0
.data 1536 1536 0 0.0
.data.rel.ro 66104 66104 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 166236 166236 0 0.0
.text 1765298 1765506 208 0.0
ota-provider-app debug (read only) 1888441 1888649 208 0.0
(read/write) 114896 114896 0 0.0
.bss 50464 50464 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 159251 159251 0 0.0
.text 1578466 1578674 208 0.0
ota-requestor-app debug (read only) 1916313 1916521 208 0.0
(read/write) 117992 117992 0 0.0
.bss 51552 51552 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 59512 59512 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 155244 155244 0 0.0
.text 1610194 1610402 208 0.0
shell debug (read only) 2401409 2401617 208 0.0
(read/write) 150088 150088 0 0.0
.bss 70472 70472 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73064 73064 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205906 205906 0 0.0
.text 2038930 2039138 208 0.0
thermostat-no-ble arm64 (read only) 2181156 2181380 224 0.0
(read/write) 148801 148801 0 0.0
.bss 65393 65393 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 75112 75112 0 0.0
.dynamic 560 560 0 0.0
.got 4272 4272 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133204 133204 0 0.0
.text 1829312 1829536 224 0.0
tv-app debug (read only) 2627081 2627289 208 0.0
(read/write) 250360 250360 0 0.0
.bss 167520 167520 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199549 199549 0 0.0
.text 2253442 2253650 208 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350900 2350964 64 0.0
.bss 186212 186212 0 0.0
.data 5792 5792 0 0.0
.text 1313500 1313564 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152691 1152739 48 0.0
bss 146208 146208 0 0.0
rodata 144556 144556 0 0.0
text 786680 786720 40 0.0
p6 all-clusters-app default (read/write) 2495440 2487280 -8160 -0.3
.bss 119640 119640 0 0.0
.data 2680 2680 0 0.0
.text 1453704 1445544 -8160 -0.6
light-app default (read/write) 2399472 2391296 -8176 -0.3
.bss 113104 113104 0 0.0
.data 2536 2536 0 0.0
.text 1357736 1349560 -8176 -0.6
lock-app default (read/write) 2363016 2354840 -8176 -0.3
.bss 112848 112848 0 0.0
.data 2496 2496 0 0.0
.text 1321280 1313104 -8176 -0.6
telink lighting-app tlsr9518adk80d (read/write) 889742 889790 48 0.0
bss 86968 86968 0 0.0
noinit 37160 37160 0 0.0
text 628890 628944 54 0.0

@rcasallas-silabs rcasallas-silabs force-pushed the group_data_provider_init branch 3 times, most recently from 2f032e1 to a43fb59 Compare March 11, 2022 12:40
@github-actions
Copy link

github-actions bot commented Mar 11, 2022 •
edited
Loading

PR #16079: Size comparison from ae514b6 to a43fb59

Increases (10 builds for cyw30739, esp32, k32w, linux, mbed)
platform target config section ae514b6 a43fb59 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599102 599154 52 0.0
.app_xip_area 506700 506760 60 0.0
lock cyw930739m2evb_01 (read/write) 556986 557046 60 0.0
.app_xip_area 466112 466180 68 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566766 566826 60 0.0
.app_xip_area 466228 466296 68 0.0
esp32 all-clusters-app c3devkit (read/write) 1393858 1393866 8 0.0
.flash.rodata 197144 197152 8 0.0
m5stack (read only) 1014127 1014195 68 0.0
.flash.rodata 226104 226112 8 0.0
.flash.text 1008743 1008811 68 0.0
k32w light k32w061+release (read/write) 695388 695448 60 0.0
.text 610548 610616 68 0.0
lock k32w061+release (read/write) 696360 696420 60 0.0
.text 611528 611596 68 0.0
linux chip-tool-ipv6only arm64 (read only) 9729660 9729964 304 0.0
(read/write) 475729 475745 16 0.0
.data.rel.ro 371520 371536 16 0.0
.text 8186868 8187124 256 0.0
thermostat-no-ble arm64 (read only) 2181588 2181908 320 0.0
.data.rel.ro 74968 74984 16 0.0
.text 1829984 1830256 272 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2351012 2351076 64 0.0
.text 1313612 1313676 64 0.0
Decreases (16 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section ae514b6 a43fb59 change % change
cyw30739 light cyw930739m2evb_01 .bss 75108 75100 -8 -0.0
lock cyw930739m2evb_01 .bss 73612 73604 -8 -0.0
ota-requestor cyw930739m2evb_01 .bss 82932 82924 -8 -0.0
efr32 lighting-app BRD4161A (read only) 921128 912832 -8296 -0.9
(read/write) 128232 128224 -8 -0.0
.bss 126176 126168 -8 -0.0
.text 921120 912824 -8296 -0.9
BRD4161A+rpc (read only) 949940 941660 -8280 -0.9
(read/write) 144184 144176 -8 -0.0
.bss 141952 141944 -8 -0.0
.text 949932 941652 -8280 -0.9
window-app BRD4161A (read only) 853732 845452 -8280 -1.0
(read/write) 126216 126208 -8 -0.0
.bss 124312 124304 -8 -0.0
.text 853724 845444 -8280 -1.0
esp32 all-clusters-app c3devkit (read only) 958524 958516 -8 -0.0
.dram0.bss 63584 63576 -8 -0.0
.flash.text 958524 958516 -8 -0.0
m5stack .dram0.bss 69104 69096 -8 -0.0
k32w light k32w061+release .bss 77112 77104 -8 -0.0
lock k32w061+release .bss 77080 77072 -8 -0.0
linux thermostat-no-ble arm64 .bss 65409 65393 -16 -0.0
mbed lock-app CY8CPROTO_062_4343W+release .bss 186212 186204 -8 -0.0
p6 all-clusters-app default (read/write) 2495680 2487384 -8296 -0.3
.bss 119640 119632 -8 -0.0
.text 1453944 1445648 -8296 -0.6
light-app default (read/write) 2399680 2391400 -8280 -0.3
.bss 113104 113096 -8 -0.0
.text 1357944 1349664 -8280 -0.6
lock-app default (read/write) 2363240 2354960 -8280 -0.4
.bss 112848 112840 -8 -0.0
.text 1321504 1313224 -8280 -0.6
telink lighting-app tlsr9518adk80d (read/write) 889766 889762 -4 -0.0
bss 86976 86968 -8 -0.0
text 628970 628966 -4 -0.0
Full report (17 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section ae514b6 a43fb59 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599102 599154 52 0.0
.app_xip_area 506700 506760 60 0.0
.bss 75108 75100 -8 -0.0
.data 640 640 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556986 557046 60 0.0
.app_xip_area 466112 466180 68 0.0
.bss 73612 73604 -8 -0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566766 566826 60 0.0
.app_xip_area 466228 466296 68 0.0
.bss 82932 82924 -8 -0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921128 912832 -8296 -0.9
(read/write) 128232 128224 -8 -0.0
.bss 126176 126168 -8 -0.0
.data 2052 2052 0 0.0
.text 921120 912824 -8296 -0.9
BRD4161A+rpc (read only) 949940 941660 -8280 -0.9
(read/write) 144184 144176 -8 -0.0
.bss 141952 141944 -8 -0.0
.data 2232 2232 0 0.0
.text 949932 941652 -8280 -0.9
window-app BRD4161A (read only) 853732 845452 -8280 -1.0
(read/write) 126216 126208 -8 -0.0
.bss 124312 124304 -8 -0.0
.data 1904 1904 0 0.0
.text 853724 845444 -8280 -1.0
esp32 all-clusters-app c3devkit (read only) 958524 958516 -8 -0.0
(read/write) 1393858 1393866 8 0.0
.dram0.bss 63584 63576 -8 -0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 197144 197152 8 0.0
.flash.text 958524 958516 -8 -0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1014127 1014195 68 0.0
(read/write) 461092 461092 0 0.0
.dram0.bss 69104 69096 -8 -0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 226104 226112 8 0.0
.flash.text 1008743 1008811 68 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 695388 695448 60 0.0
.bss 77112 77104 -8 -0.0
.data 1928 1928 0 0.0
.text 610548 610616 68 0.0
lock k32w061+release (read/write) 696360 696420 60 0.0
.bss 77080 77072 -8 -0.0
.data 1952 1952 0 0.0
.text 611528 611596 68 0.0
linux chip-tool-ipv6only arm64 (read only) 9729660 9729964 304 0.0
(read/write) 475729 475745 16 0.0
.bss 43953 43953 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 371520 371536 16 0.0
.dynamic 560 560 0 0.0
.got 55280 55280 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492148 492148 0 0.0
.text 8186868 8187124 256 0.0
thermostat-no-ble arm64 (read only) 2181588 2181908 320 0.0
(read/write) 148625 148625 0 0.0
.bss 65409 65393 -16 -0.0
.data 1024 1024 0 0.0
.data.rel.ro 74968 74984 16 0.0
.dynamic 560 560 0 0.0
.got 4256 4256 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133444 133444 0 0.0
.text 1829984 1830256 272 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351012 2351076 64 0.0
.bss 186212 186204 -8 -0.0
.data 5784 5784 0 0.0
.text 1313612 1313676 64 0.0
p6 all-clusters-app default (read/write) 2495680 2487384 -8296 -0.3
.bss 119640 119632 -8 -0.0
.data 2672 2672 0 0.0
.text 1453944 1445648 -8296 -0.6
light-app default (read/write) 2399680 2391400 -8280 -0.3
.bss 113104 113096 -8 -0.0
.data 2528 2528 0 0.0
.text 1357944 1349664 -8280 -0.6
lock-app default (read/write) 2363240 2354960 -8280 -0.4
.bss 112848 112840 -8 -0.0
.data 2488 2488 0 0.0
.text 1321504 1313224 -8280 -0.6
telink lighting-app tlsr9518adk80d (read/write) 889766 889762 -4 -0.0
bss 86976 86968 -8 -0.0
noinit 37160 37160 0 0.0
text 628970 628966 -4 -0.0

@rcasallas-silabs rcasallas-silabs changed the title GroupDataProvider: PersistentStorageDelegate passed on init() GroupDataProvider: PersistentStorageDelegate Initialization Mar 11, 2022
@github-actions
Copy link

github-actions bot commented Mar 11, 2022 •
edited
Loading

PR #16079: Size comparison from ae514b6 to 0032e69

Increases (10 builds for cyw30739, esp32, k32w, linux, mbed, nrfconnect)
platform target config section ae514b6 0032e69 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599102 599142 40 0.0
.app_xip_area 506700 506748 48 0.0
lock cyw930739m2evb_01 (read/write) 556986 557026 40 0.0
.app_xip_area 466112 466160 48 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566766 566806 40 0.0
.app_xip_area 466228 466276 48 0.0
esp32 all-clusters-app m5stack (read only) 1014127 1014143 16 0.0
.flash.text 1008743 1008759 16 0.0
k32w light k32w061+release (read/write) 695388 695428 40 0.0
.text 610548 610596 48 0.0
lock k32w061+release (read/write) 696360 696400 40 0.0
.text 611528 611576 48 0.0
linux chip-tool-ipv6only arm64 (read only) 9729660 9730028 368 0.0
.rodata 492148 492164 16 0.0
.text 8186868 8187220 352 0.0
thermostat-no-ble arm64 (read only) 2181588 2181972 384 0.0
.rodata 133444 133460 16 0.0
.text 1829984 1830352 368 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2351012 2351076 64 0.0
.text 1313612 1313676 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152643 1152675 32 0.0
text 786676 786716 40 0.0
Decreases (17 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ae514b6 0032e69 change % change
cyw30739 light cyw930739m2evb_01 .bss 75108 75100 -8 -0.0
lock cyw930739m2evb_01 .bss 73612 73604 -8 -0.0
ota-requestor cyw930739m2evb_01 .bss 82932 82924 -8 -0.0
efr32 lighting-app BRD4161A (read only) 921128 912968 -8160 -0.9
(read/write) 128232 128224 -8 -0.0
.bss 126176 126168 -8 -0.0
.text 921120 912960 -8160 -0.9
BRD4161A+rpc (read only) 949940 941780 -8160 -0.9
(read/write) 144184 144176 -8 -0.0
.bss 141952 141944 -8 -0.0
.text 949932 941772 -8160 -0.9
window-app BRD4161A (read only) 853732 845572 -8160 -1.0
(read/write) 126216 126208 -8 -0.0
.bss 124312 124304 -8 -0.0
.text 853724 845564 -8160 -1.0
esp32 all-clusters-app c3devkit (read only) 958524 958520 -4 -0.0
.dram0.bss 63584 63576 -8 -0.0
.flash.text 958524 958520 -4 -0.0
m5stack (read/write) 461092 461084 -8 -0.0
.dram0.bss 69104 69096 -8 -0.0
k32w light k32w061+release .bss 77112 77104 -8 -0.0
lock k32w061+release .bss 77080 77072 -8 -0.0
linux thermostat-no-ble arm64 (read/write) 148625 148609 -16 -0.0
.bss 65409 65393 -16 -0.0
mbed lock-app CY8CPROTO_062_4343W+release .bss 186212 186204 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 bss 146188 146180 -8 -0.0
p6 all-clusters-app default (read/write) 2495680 2487520 -8160 -0.3
.bss 119640 119632 -8 -0.0
.text 1453944 1445784 -8160 -0.6
light-app default (read/write) 2399680 2391520 -8160 -0.3
.bss 113104 113096 -8 -0.0
.text 1357944 1349784 -8160 -0.6
lock-app default (read/write) 2363240 2355080 -8160 -0.3
.bss 112848 112840 -8 -0.0
.text 1321504 1313344 -8160 -0.6
telink lighting-app tlsr9518adk80d (read/write) 889766 889758 -8 -0.0
bss 86976 86968 -8 -0.0
text 628970 628966 -4 -0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ae514b6 0032e69 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599102 599142 40 0.0
.app_xip_area 506700 506748 48 0.0
.bss 75108 75100 -8 -0.0
.data 640 640 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556986 557026 40 0.0
.app_xip_area 466112 466160 48 0.0
.bss 73612 73604 -8 -0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566766 566806 40 0.0
.app_xip_area 466228 466276 48 0.0
.bss 82932 82924 -8 -0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921128 912968 -8160 -0.9
(read/write) 128232 128224 -8 -0.0
.bss 126176 126168 -8 -0.0
.data 2052 2052 0 0.0
.text 921120 912960 -8160 -0.9
BRD4161A+rpc (read only) 949940 941780 -8160 -0.9
(read/write) 144184 144176 -8 -0.0
.bss 141952 141944 -8 -0.0
.data 2232 2232 0 0.0
.text 949932 941772 -8160 -0.9
window-app BRD4161A (read only) 853732 845572 -8160 -1.0
(read/write) 126216 126208 -8 -0.0
.bss 124312 124304 -8 -0.0
.data 1904 1904 0 0.0
.text 853724 845564 -8160 -1.0
esp32 all-clusters-app c3devkit (read only) 958524 958520 -4 -0.0
(read/write) 1393858 1393858 0 0.0
.dram0.bss 63584 63576 -8 -0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 197144 197144 0 0.0
.flash.text 958524 958520 -4 -0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1014127 1014143 16 0.0
(read/write) 461092 461084 -8 -0.0
.dram0.bss 69104 69096 -8 -0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 226104 226104 0 0.0
.flash.text 1008743 1008759 16 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 695388 695428 40 0.0
.bss 77112 77104 -8 -0.0
.data 1928 1928 0 0.0
.text 610548 610596 48 0.0
lock k32w061+release (read/write) 696360 696400 40 0.0
.bss 77080 77072 -8 -0.0
.data 1952 1952 0 0.0
.text 611528 611576 48 0.0
linux chip-tool-ipv6only arm64 (read only) 9729660 9730028 368 0.0
(read/write) 475729 475729 0 0.0
.bss 43953 43953 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 371520 371520 0 0.0
.dynamic 560 560 0 0.0
.got 55280 55280 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492148 492164 16 0.0
.text 8186868 8187220 352 0.0
thermostat-no-ble arm64 (read only) 2181588 2181972 384 0.0
(read/write) 148625 148609 -16 -0.0
.bss 65409 65393 -16 -0.0
.data 1024 1024 0 0.0
.data.rel.ro 74968 74968 0 0.0
.dynamic 560 560 0 0.0
.got 4256 4256 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133444 133460 16 0.0
.text 1829984 1830352 368 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351012 2351076 64 0.0
.bss 186212 186204 -8 -0.0
.data 5784 5784 0 0.0
.text 1313612 1313676 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152643 1152675 32 0.0
bss 146188 146180 -8 -0.0
rodata 144516 144516 0 0.0
text 786676 786716 40 0.0
p6 all-clusters-app default (read/write) 2495680 2487520 -8160 -0.3
.bss 119640 119632 -8 -0.0
.data 2672 2672 0 0.0
.text 1453944 1445784 -8160 -0.6
light-app default (read/write) 2399680 2391520 -8160 -0.3
.bss 113104 113096 -8 -0.0
.data 2528 2528 0 0.0
.text 1357944 1349784 -8160 -0.6
lock-app default (read/write) 2363240 2355080 -8160 -0.3
.bss 112848 112840 -8 -0.0
.data 2488 2488 0 0.0
.text 1321504 1313344 -8160 -0.6
telink lighting-app tlsr9518adk80d (read/write) 889766 889758 -8 -0.0
bss 86976 86968 -8 -0.0
noinit 37160 37160 0 0.0
text 628970 628966 -4 -0.0

bzbarsky-apple
bzbarsky-apple approved these changes Mar 11, 2022
View reviewed changes
src/credentials/GroupDataProvider.h Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Mar 11, 2022 •
edited
Loading

PR #16079: Size comparison from ae514b6 to 115fdf5

Increases (10 builds for cyw30739, esp32, k32w, linux, mbed, nrfconnect)
platform target config section ae514b6 115fdf5 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599102 599142 40 0.0
.app_xip_area 506700 506748 48 0.0
lock cyw930739m2evb_01 (read/write) 556986 557026 40 0.0
.app_xip_area 466112 466160 48 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566766 566806 40 0.0
.app_xip_area 466228 466276 48 0.0
esp32 all-clusters-app m5stack (read only) 1014127 1014143 16 0.0
.flash.text 1008743 1008759 16 0.0
k32w light k32w061+release (read/write) 695388 695428 40 0.0
.text 610548 610596 48 0.0
lock k32w061+release (read/write) 696360 696400 40 0.0
.text 611528 611576 48 0.0
linux chip-tool-ipv6only arm64 (read only) 9729660 9730028 368 0.0
.rodata 492148 492164 16 0.0
.text 8186868 8187220 352 0.0
thermostat-no-ble arm64 (read only) 2181588 2181972 384 0.0
.rodata 133444 133460 16 0.0
.text 1829984 1830352 368 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2351012 2351076 64 0.0
.text 1313612 1313676 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152643 1152675 32 0.0
text 786676 786716 40 0.0
Decreases (17 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ae514b6 115fdf5 change % change
cyw30739 light cyw930739m2evb_01 .bss 75108 75100 -8 -0.0
lock cyw930739m2evb_01 .bss 73612 73604 -8 -0.0
ota-requestor cyw930739m2evb_01 .bss 82932 82924 -8 -0.0
efr32 lighting-app BRD4161A (read only) 921128 912968 -8160 -0.9
(read/write) 128232 128224 -8 -0.0
.bss 126176 126168 -8 -0.0
.text 921120 912960 -8160 -0.9
BRD4161A+rpc (read only) 949940 941780 -8160 -0.9
(read/write) 144184 144176 -8 -0.0
.bss 141952 141944 -8 -0.0
.text 949932 941772 -8160 -0.9
window-app BRD4161A (read only) 853732 845572 -8160 -1.0
(read/write) 126216 126208 -8 -0.0
.bss 124312 124304 -8 -0.0
.text 853724 845564 -8160 -1.0
esp32 all-clusters-app c3devkit (read only) 958524 958520 -4 -0.0
.dram0.bss 63584 63576 -8 -0.0
.flash.text 958524 958520 -4 -0.0
m5stack (read/write) 461092 461084 -8 -0.0
.dram0.bss 69104 69096 -8 -0.0
k32w light k32w061+release .bss 77112 77104 -8 -0.0
lock k32w061+release .bss 77080 77072 -8 -0.0
linux thermostat-no-ble arm64 (read/write) 148625 148609 -16 -0.0
.bss 65409 65393 -16 -0.0
mbed lock-app CY8CPROTO_062_4343W+release .bss 186212 186204 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 bss 146188 146180 -8 -0.0
p6 all-clusters-app default (read/write) 2495680 2487520 -8160 -0.3
.bss 119640 119632 -8 -0.0
.text 1453944 1445784 -8160 -0.6
light-app default (read/write) 2399680 2391520 -8160 -0.3
.bss 113104 113096 -8 -0.0
.text 1357944 1349784 -8160 -0.6
lock-app default (read/write) 2363240 2355080 -8160 -0.3
.bss 112848 112840 -8 -0.0
.text 1321504 1313344 -8160 -0.6
telink lighting-app tlsr9518adk80d (read/write) 889766 889758 -8 -0.0
bss 86976 86968 -8 -0.0
text 628970 628966 -4 -0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ae514b6 115fdf5 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599102 599142 40 0.0
.app_xip_area 506700 506748 48 0.0
.bss 75108 75100 -8 -0.0
.data 640 640 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556986 557026 40 0.0
.app_xip_area 466112 466160 48 0.0
.bss 73612 73604 -8 -0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566766 566806 40 0.0
.app_xip_area 466228 466276 48 0.0
.bss 82932 82924 -8 -0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921128 912968 -8160 -0.9
(read/write) 128232 128224 -8 -0.0
.bss 126176 126168 -8 -0.0
.data 2052 2052 0 0.0
.text 921120 912960 -8160 -0.9
BRD4161A+rpc (read only) 949940 941780 -8160 -0.9
(read/write) 144184 144176 -8 -0.0
.bss 141952 141944 -8 -0.0
.data 2232 2232 0 0.0
.text 949932 941772 -8160 -0.9
window-app BRD4161A (read only) 853732 845572 -8160 -1.0
(read/write) 126216 126208 -8 -0.0
.bss 124312 124304 -8 -0.0
.data 1904 1904 0 0.0
.text 853724 845564 -8160 -1.0
esp32 all-clusters-app c3devkit (read only) 958524 958520 -4 -0.0
(read/write) 1393858 1393858 0 0.0
.dram0.bss 63584 63576 -8 -0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 197144 197144 0 0.0
.flash.text 958524 958520 -4 -0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1014127 1014143 16 0.0
(read/write) 461092 461084 -8 -0.0
.dram0.bss 69104 69096 -8 -0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 226104 226104 0 0.0
.flash.text 1008743 1008759 16 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 695388 695428 40 0.0
.bss 77112 77104 -8 -0.0
.data 1928 1928 0 0.0
.text 610548 610596 48 0.0
lock k32w061+release (read/write) 696360 696400 40 0.0
.bss 77080 77072 -8 -0.0
.data 1952 1952 0 0.0
.text 611528 611576 48 0.0
linux chip-tool-ipv6only arm64 (read only) 9729660 9730028 368 0.0
(read/write) 475729 475729 0 0.0
.bss 43953 43953 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 371520 371520 0 0.0
.dynamic 560 560 0 0.0
.got 55280 55280 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492148 492164 16 0.0
.text 8186868 8187220 352 0.0
thermostat-no-ble arm64 (read only) 2181588 2181972 384 0.0
(read/write) 148625 148609 -16 -0.0
.bss 65409 65393 -16 -0.0
.data 1024 1024 0 0.0
.data.rel.ro 74968 74968 0 0.0
.dynamic 560 560 0 0.0
.got 4256 4256 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133444 133460 16 0.0
.text 1829984 1830352 368 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351012 2351076 64 0.0
.bss 186212 186204 -8 -0.0
.data 5784 5784 0 0.0
.text 1313612 1313676 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152643 1152675 32 0.0
bss 146188 146180 -8 -0.0
rodata 144516 144516 0 0.0
text 786676 786716 40 0.0
p6 all-clusters-app default (read/write) 2495680 2487520 -8160 -0.3
.bss 119640 119632 -8 -0.0
.data 2672 2672 0 0.0
.text 1453944 1445784 -8160 -0.6
light-app default (read/write) 2399680 2391520 -8160 -0.3
.bss 113104 113096 -8 -0.0
.data 2528 2528 0 0.0
.text 1357944 1349784 -8160 -0.6
lock-app default (read/write) 2363240 2355080 -8160 -0.3
.bss 112848 112840 -8 -0.0
.data 2488 2488 0 0.0
.text 1321504 1313344 -8160 -0.6
telink lighting-app tlsr9518adk80d (read/write) 889766 889758 -8 -0.0
bss 86976 86968 -8 -0.0
noinit 37160 37160 0 0.0
text 628970 628966 -4 -0.0

@rcasallas-silabs rcasallas-silabs force-pushed the group_data_provider_init branch from 115fdf5 to dc93387 Compare March 11, 2022 23:36
@github-actions
Copy link

github-actions bot commented Mar 12, 2022 •
edited
Loading

PR #16079: Size comparison from 9cc0fb3 to dc93387

Increases (18 builds for cyw30739, esp32, k32w, linux, nrfconnect)
platform target config section 9cc0fb36 dc93387 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602482 602530 48 0.0
.app_xip_area 509652 509708 56 0.0
lock cyw930739m2evb_01 (read/write) 560342 560390 48 0.0
.app_xip_area 469040 469096 56 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 569962 570002 40 0.0
.app_xip_area 469012 469060 48 0.0
esp32 all-clusters-app m5stack (read only) 1016947 1016963 16 0.0
.flash.text 1011563 1011579 16 0.0
k32w light k32w061+release (read/write) 699012 699052 40 0.0
.text 613756 613804 48 0.0
lock k32w061+release (read/write) 699844 699884 40 0.0
.text 614576 614624 48 0.0
linux all-clusters-app debug (read only) 2464625 2465009 384 0.0
.text 2090610 2090994 384 0.0
bridge-app debug+rpc (read only) 1749189 1749589 400 0.0
.rodata 143340 143372 32 0.0
.text 1490213 1490581 368 0.0
chip-tool debug (read only) 10094093 10094493 400 0.0
.rodata 514933 514965 32 0.0
.text 8797909 8798277 368 0.0
chip-tool-ipv6only arm64 (read only) 9727420 9727788 368 0.0
.rodata 492228 492244 16 0.0
.text 8185348 8185700 352 0.0
door-lock-app debug (read only) 1983809 1984225 416 0.0
.rodata 178428 178460 32 0.0
.text 1656402 1656786 384 0.0
lighting-app debug+rpc (read only) 2115385 2115753 368 0.0
.text 1788418 1788786 368 0.0
ota-provider-app debug (read only) 1917121 1917489 368 0.0
.text 1602370 1602738 368 0.0
ota-requestor-app debug (read only) 1945377 1945745 368 0.0
.text 1634098 1634466 368 0.0
shell debug (read only) 2410433 2410849 416 0.0
.rodata 207442 207474 32 0.0
.text 2046754 2047138 384 0.0
thermostat-no-ble arm64 (read only) 2206596 2206980 384 0.0
.rodata 136804 136820 16 0.0
.text 1850480 1850848 368 0.0
tv-app debug (read only) 2655217 2655601 384 0.0
.text 2276834 2277218 384 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1156171 1156219 48 0.0
text 789164 789208 44 0.0
Decreases (23 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 9cc0fb36 dc93387 change % change
cyw30739 light cyw930739m2evb_01 .bss 75584 75576 -8 -0.0
lock cyw930739m2evb_01 .bss 74088 74080 -8 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 .bss 83392 83384 -8 -0.0
efr32 lighting-app BRD4161A (read only) 926304 918144 -8160 -0.9
(read/write) 128664 128656 -8 -0.0
.bss 126656 126648 -8 -0.0
.text 926296 918136 -8160 -0.9
BRD4161A+rpc (read only) 955092 946932 -8160 -0.9
(read/write) 144620 144612 -8 -0.0
.bss 142432 142424 -8 -0.0
.text 955084 946924 -8160 -0.9
window-app BRD4161A (read only) 858776 850616 -8160 -1.0
(read/write) 126640 126632 -8 -0.0
.bss 124776 124768 -8 -0.0
.text 858768 850608 -8160 -1.0
esp32 all-clusters-app c3devkit (read only) 961348 961344 -4 -0.0
.dram0.bss 64064 64056 -8 -0.0
.flash.text 961348 961344 -4 -0.0
m5stack (read/write) 462212 462204 -8 -0.0
.dram0.bss 69584 69576 -8 -0.0
k32w light k32w061+release .bss 77568 77560 -8 -0.0
lock k32w061+release .bss 77560 77552 -8 -0.0
linux all-clusters-app debug (read/write) 146416 146384 -32 -0.0
.bss 60672 60640 -32 -0.1
bridge-app debug+rpc (read/write) 92944 92912 -32 -0.0
.bss 47784 47752 -32 -0.1
door-lock-app debug (read/write) 119808 119776 -32 -0.0
.bss 50976 50944 -32 -0.1
ota-provider-app debug (read/write) 115568 115536 -32 -0.0
.bss 50848 50816 -32 -0.1
ota-requestor-app debug (read/write) 118568 118536 -32 -0.0
.bss 51872 51840 -32 -0.1
shell debug (read/write) 150216 150184 -32 -0.0
.bss 70632 70600 -32 -0.0
thermostat-no-ble arm64 (read/write) 149393 149377 -16 -0.0
.bss 65665 65649 -16 -0.0
tv-app debug (read/write) 250808 250776 -32 -0.0
.bss 167872 167840 -32 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 bss 146652 146644 -8 -0.0
p6 all-clusters-app default (read/write) 2500304 2492128 -8176 -0.3
.bss 120088 120080 -8 -0.0
.text 1458568 1450392 -8176 -0.6
light-app default (read/write) 2404152 2395992 -8160 -0.3
.bss 113552 113544 -8 -0.0
.text 1362416 1354256 -8160 -0.6
lock-app default (read/write) 2367696 2359536 -8160 -0.3
.bss 113296 113288 -8 -0.0
.text 1325960 1317800 -8160 -0.6
telink lighting-app tlsr9518adk80d bss 87440 87432 -8 -0.0
text 631884 631882 -2 -0.0
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 9cc0fb36 dc93387 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602482 602530 48 0.0
.app_xip_area 509652 509708 56 0.0
.bss 75584 75576 -8 -0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560342 560390 48 0.0
.app_xip_area 469040 469096 56 0.0
.bss 74088 74080 -8 -0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 569962 570002 40 0.0
.app_xip_area 469012 469060 48 0.0
.bss 83392 83384 -8 -0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 926304 918144 -8160 -0.9
(read/write) 128664 128656 -8 -0.0
.bss 126656 126648 -8 -0.0
.data 2008 2008 0 0.0
.text 926296 918136 -8160 -0.9
BRD4161A+rpc (read only) 955092 946932 -8160 -0.9
(read/write) 144620 144612 -8 -0.0
.bss 142432 142424 -8 -0.0
.data 2188 2188 0 0.0
.text 955084 946924 -8160 -0.9
window-app BRD4161A (read only) 858776 850616 -8160 -1.0
(read/write) 126640 126632 -8 -0.0
.bss 124776 124768 -8 -0.0
.data 1864 1864 0 0.0
.text 858768 850608 -8160 -1.0
esp32 all-clusters-app c3devkit (read only) 961348 961344 -4 -0.0
(read/write) 1394994 1394994 0 0.0
.dram0.bss 64064 64056 -8 -0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197832 197832 0 0.0
.flash.text 961348 961344 -4 -0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1016947 1016963 16 0.0
(read/write) 462212 462204 -8 -0.0
.dram0.bss 69584 69576 -8 -0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 226776 226776 0 0.0
.flash.text 1011563 1011579 16 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699012 699052 40 0.0
.bss 77568 77560 -8 -0.0
.data 1888 1888 0 0.0
.text 613756 613804 48 0.0
lock k32w061+release (read/write) 699844 699884 40 0.0
.bss 77560 77552 -8 -0.0
.data 1908 1908 0 0.0
.text 614576 614624 48 0.0
linux all-clusters-app debug (read only) 2464625 2465009 384 0.0
(read/write) 146416 146384 -32 -0.0
.bss 60672 60640 -32 -0.1
.data 1264 1264 0 0.0
.data.rel.ro 78728 78728 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 210693 210693 0 0.0
.text 2090610 2090994 384 0.0
bridge-app debug+rpc (read only) 1749189 1749589 400 0.0
(read/write) 92944 92912 -32 -0.0
.bss 47784 47752 -32 -0.1
.data 1952 1952 0 0.0
.data.rel.ro 38128 38128 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 143340 143372 32 0.0
.text 1490213 1490581 368 0.0
chip-tool debug (read only) 10094093 10094493 400 0.0
(read/write) 357680 357680 0 0.0
.bss 25696 25696 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 324864 324864 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514933 514965 32 0.0
.text 8797909 8798277 368 0.0
chip-tool-ipv6only arm64 (read only) 9727420 9727788 368 0.0
(read/write) 475425 475425 0 0.0
.bss 44017 44017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371232 371232 0 0.0
.dynamic 560 560 0 0.0
.got 55256 55256 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492228 492244 16 0.0
.text 8185348 8185700 352 0.0
door-lock-app debug (read only) 1983809 1984225 416 0.0
(read/write) 119808 119776 -32 -0.0
.bss 50976 50944 -32 -0.1
.data 992 992 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 178428 178460 32 0.0
.text 1656402 1656786 384 0.0
lighting-app debug+rpc (read only) 2115385 2115753 368 0.0
(read/write) 125160 125160 0 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66408 66408 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 170972 170972 0 0.0
.text 1788418 1788786 368 0.0
ota-provider-app debug (read only) 1917121 1917489 368 0.0
(read/write) 115568 115536 -32 -0.0
.bss 50848 50816 -32 -0.1
.data 1256 1256 0 0.0
.data.rel.ro 57816 57816 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 163691 163691 0 0.0
.text 1602370 1602738 368 0.0
ota-requestor-app debug (read only) 1945377 1945745 368 0.0
(read/write) 118568 118536 -32 -0.0
.bss 51872 51840 -32 -0.1
.data 1416 1416 0 0.0
.data.rel.ro 59848 59848 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 160068 160068 0 0.0
.text 1634098 1634466 368 0.0
shell debug (read only) 2410433 2410849 416 0.0
(read/write) 150216 150184 -32 -0.0
.bss 70632 70600 -32 -0.0
.data 784 784 0 0.0
.data.rel.ro 73088 73088 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 207442 207474 32 0.0
.text 2046754 2047138 384 0.0
thermostat-no-ble arm64 (read only) 2206596 2206980 384 0.0
(read/write) 149393 149377 -16 -0.0
.bss 65665 65649 -16 -0.0
.data 1024 1024 0 0.0
.data.rel.ro 75368 75368 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 136804 136820 16 0.0
.text 1850480 1850848 368 0.0
tv-app debug (read only) 2655217 2655601 384 0.0
(read/write) 250808 250776 -32 -0.0
.bss 167872 167840 -32 -0.0
.data 3104 3104 0 0.0
.data.rel.ro 73800 73800 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 204245 204245 0 0.0
.text 2276834 2277218 384 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1156171 1156219 48 0.0
bss 146652 146644 -8 -0.0
rodata 145220 145220 0 0.0
text 789164 789208 44 0.0
p6 all-clusters-app default (read/write) 2500304 2492128 -8176 -0.3
.bss 120088 120080 -8 -0.0
.data 2632 2632 0 0.0
.text 1458568 1450392 -8176 -0.6
light-app default (read/write) 2404152 2395992 -8160 -0.3
.bss 113552 113544 -8 -0.0
.data 2488 2488 0 0.0
.text 1362416 1354256 -8160 -0.6
lock-app default (read/write) 2367696 2359536 -8160 -0.3
.bss 113296 113288 -8 -0.0
.data 2448 2448 0 0.0
.text 1325960 1317800 -8160 -0.6
telink lighting-app tlsr9518adk80d (read/write) 893842 893842 0 0.0
bss 87440 87432 -8 -0.0
noinit 37160 37160 0 0.0
text 631884 631882 -2 -0.0

@tcarmelveilleux tcarmelveilleux merged commit 4638993 into project-chip:master Mar 12, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@rcasallas-silabs @tcarmelveilleux
@bzbarsky-apple @andrei-menzopol
GroupDataProvider: PersistentStorageDelegate Initialization (project-…
f98431e 
…chip#16079)

* Group Data Provider: PersistentStorageDelegate passed as init() argument.

* Group Data Provider: PersistentStorageDelegate: Review comments applied.

* Remove storage dependency on GroupDataProvider.h

* restyled

* Fix comment typo.

* Group Data Provider initialization: Rebased.

Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
@rcasallas-silabs rcasallas-silabs deleted the group_data_provider_init branch October 5, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@emargolis emargolis emargolis approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rcasallas-silabs @tcarmelveilleux @emargolis @bzbarsky-apple