Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chip-tool-darwin] Add a method to configure the path of the kvs to a… #16005

Merged
merged 1 commit into from
Mar 9, 2022
Merged

[chip-tool-darwin] Add a method to configure the path of the kvs to a… #16005

merged 1 commit into from
Mar 9, 2022

Conversation

vivien-apple
Copy link
Contributor

…void conflicts between chip-tool and chip-tool-darwin

Problem

chip-tool and chip-tool-darwin kvs store is saved at the same place. Add a method to chip-tool-darwin to configure where the kvs is stored to avoid conflicts.

Change overview

  • Add a method to the objective-c controller to configure the path

@vivien-apple vivien-apple self-assigned this Mar 9, 2022
@github-actions
Copy link

github-actions bot commented Mar 9, 2022 •
edited
Loading

PR #16005: Size comparison from 9bee828 to fa27a4d

Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 9bee828 fa27a4d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602114 602114 0 0.0
.app_xip_area 506632 506632 0 0.0
.bss 78172 78172 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560014 560014 0 0.0
.app_xip_area 466068 466068 0 0.0
.bss 76676 76676 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 582214 582214 0 0.0
.app_xip_area 478588 478588 0 0.0
.bss 86004 86004 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921392 921392 0 0.0
(read/write) 128872 128872 0 0.0
.bss 126800 126800 0 0.0
.data 2072 2072 0 0.0
.text 921384 921384 0 0.0
BRD4161A+rpc (read only) 950228 950228 0 0.0
(read/write) 144828 144828 0 0.0
.bss 142576 142576 0 0.0
.data 2252 2252 0 0.0
.text 950220 950220 0 0.0
window-app BRD4161A (read only) 854428 854428 0 0.0
(read/write) 126852 126852 0 0.0
.bss 124936 124936 0 0.0
.data 1916 1916 0 0.0
.text 854420 854420 0 0.0
esp32 all-clusters-app c3devkit (read only) 958612 958612 0 0.0
(read/write) 1393770 1393770 0 0.0
.dram0.bss 63576 63576 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 197056 197056 0 0.0
.flash.text 958612 958612 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1013671 1013671 0 0.0
(read/write) 461028 461028 0 0.0
.dram0.bss 69096 69096 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226032 226032 0 0.0
.flash.text 1008287 1008287 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 695272 695272 0 0.0
.bss 77736 77736 0 0.0
.data 1956 1956 0 0.0
.text 609780 609780 0 0.0
lock k32w061+release (read/write) 696876 696876 0 0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 611408 611408 0 0.0
linux all-clusters-app debug (read only) 2432353 2432353 0 0.0
(read/write) 145808 145808 0 0.0
.bss 60288 60288 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78424 78424 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 205573 205573 0 0.0
.text 2063794 2063794 0 0.0
bridge-app debug+rpc (read only) 1736981 1736981 0 0.0
(read/write) 92752 92752 0 0.0
.bss 47592 47592 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 38064 38064 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141804 141804 0 0.0
.text 1479205 1479205 0 0.0
chip-tool debug (read only) 9936613 9936613 0 0.0
(read/write) 356120 356120 0 0.0
.bss 25608 25608 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 323336 323336 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514260 514260 0 0.0
.text 8644469 8644469 0 0.0
chip-tool-ipv6only arm64 (read only) 9585244 9585244 0 0.0
(read/write) 472913 472913 0 0.0
.bss 43921 43921 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 369312 369312 0 0.0
.dynamic 560 560 0 0.0
.got 54680 54680 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 490308 490308 0 0.0
.text 8050804 8050804 0 0.0
door-lock-app debug (read only) 1951249 1951249 0 0.0
(read/write) 119232 119232 0 0.0
.bss 50592 50592 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173660 173660 0 0.0
.text 1628946 1628946 0 0.0
lighting-app debug+rpc (read only) 2083561 2083561 0 0.0
(read/write) 124552 124552 0 0.0
.bss 51392 51392 0 0.0
.data 1536 1536 0 0.0
.data.rel.ro 66104 66104 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 165852 165852 0 0.0
.text 1762050 1762050 0 0.0
ota-provider-app debug (read only) 1884137 1884137 0 0.0
(read/write) 114832 114832 0 0.0
.bss 50400 50400 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158931 158931 0 0.0
.text 1574482 1574482 0 0.0
ota-requestor-app debug (read only) 1906137 1906137 0 0.0
(read/write) 117544 117544 0 0.0
.bss 51456 51456 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 59176 59176 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 154220 154220 0 0.0
.text 1601858 1601858 0 0.0
shell debug (read only) 2398465 2398465 0 0.0
(read/write) 150024 150024 0 0.0
.bss 70408 70408 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73064 73064 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205458 205458 0 0.0
.text 2036434 2036434 0 0.0
thermostat-no-ble arm64 (read only) 2180012 2180012 0 0.0
(read/write) 148801 148801 0 0.0
.bss 65377 65377 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 75160 75160 0 0.0
.dynamic 560 560 0 0.0
.got 4240 4240 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133068 133068 0 0.0
.text 1828352 1828352 0 0.0
tv-app debug (read only) 2624361 2624361 0 0.0
(read/write) 250936 250936 0 0.0
.bss 168096 168096 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199485 199485 0 0.0
.text 2250786 2250786 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351804 2351804 0 0.0
.bss 186212 186212 0 0.0
.data 5792 5792 0 0.0
.text 1314404 1314404 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152383 1152383 0 0.0
bss 146832 146832 0 0.0
rodata 144328 144328 0 0.0
text 785956 785956 0 0.0
p6 all-clusters-app default (read/write) 2495712 2495712 0 0.0
.bss 119640 119640 0 0.0
.data 2680 2680 0 0.0
.text 1453976 1453976 0 0.0
light-app default (read/write) 2399096 2399096 0 0.0
.bss 113104 113104 0 0.0
.data 2536 2536 0 0.0
.text 1357360 1357360 0 0.0
lock-app default (read/write) 2362528 2362528 0 0.0
.bss 112848 112848 0 0.0
.data 2496 2496 0 0.0
.text 1320792 1320792 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 889646 889646 0 0.0
bss 86968 86968 0 0.0
noinit 37160 37160 0 0.0
text 628950 628950 0 0.0

andy31415
andy31415 requested changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the large obj files

@vivien-apple
[chip-tool-darwin] Add a method to configure the path of the kvs to a…
e83b6b9 
…void conflicts between chip-tool and chip-tool-darwin
@vivien-apple vivien-apple force-pushed the ChipToolDarwin_AllowKVSPathToBeCustomized branch from fa27a4d to e83b6b9 Compare March 9, 2022 15:46
@vivien-apple
Copy link
Contributor Author

Need to remove the large obj files

It has been rebased.

@vivien-apple vivien-apple requested a review from andy31415 March 9, 2022 15:47
@github-actions
Copy link

github-actions bot commented Mar 9, 2022 •
edited
Loading

PR #16005: Size comparison from b146c95 to e83b6b9

Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section b146c95 e83b6b9 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602114 602114 0 0.0
.app_xip_area 506632 506632 0 0.0
.bss 78172 78172 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560014 560014 0 0.0
.app_xip_area 466068 466068 0 0.0
.bss 76676 76676 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 569826 569826 0 0.0
.app_xip_area 466184 466184 0 0.0
.bss 86012 86012 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 922184 922184 0 0.0
(read/write) 128888 128888 0 0.0
.bss 126808 126808 0 0.0
.data 2080 2080 0 0.0
.text 922176 922176 0 0.0
BRD4161A+rpc (read only) 951004 951004 0 0.0
(read/write) 144844 144844 0 0.0
.bss 142584 142584 0 0.0
.data 2260 2260 0 0.0
.text 950996 950996 0 0.0
window-app BRD4161A (read only) 854428 854428 0 0.0
(read/write) 126852 126852 0 0.0
.bss 124936 124936 0 0.0
.data 1916 1916 0 0.0
.text 854420 854420 0 0.0
esp32 all-clusters-app c3devkit (read only) 958612 958612 0 0.0
(read/write) 1393770 1393770 0 0.0
.dram0.bss 63576 63576 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 197056 197056 0 0.0
.flash.text 958612 958612 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1013671 1013671 0 0.0
(read/write) 461028 461028 0 0.0
.dram0.bss 69096 69096 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226032 226032 0 0.0
.flash.text 1008287 1008287 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 695864 695864 0 0.0
.bss 77744 77744 0 0.0
.data 1964 1964 0 0.0
.text 610356 610356 0 0.0
lock k32w061+release (read/write) 696876 696876 0 0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 611408 611408 0 0.0
linux all-clusters-app debug (read only) 2432673 2432673 0 0.0
(read/write) 145872 145872 0 0.0
.bss 60352 60352 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78424 78424 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 205701 205701 0 0.0
.text 2063986 2063986 0 0.0
bridge-app debug+rpc (read only) 1737301 1737301 0 0.0
(read/write) 92784 92784 0 0.0
.bss 47624 47624 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 38064 38064 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141932 141932 0 0.0
.text 1479397 1479397 0 0.0
chip-tool debug (read only) 9936965 9936965 0 0.0
(read/write) 356152 356152 0 0.0
.bss 25640 25640 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 323336 323336 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514420 514420 0 0.0
.text 8644661 8644661 0 0.0
chip-tool-ipv6only arm64 (read only) 9585516 9585516 0 0.0
(read/write) 472945 472945 0 0.0
.bss 43953 43953 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 369312 369312 0 0.0
.dynamic 560 560 0 0.0
.got 54680 54680 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 490436 490436 0 0.0
.text 8050948 8050948 0 0.0
door-lock-app debug (read only) 1951601 1951601 0 0.0
(read/write) 119296 119296 0 0.0
.bss 50656 50656 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173820 173820 0 0.0
.text 1629138 1629138 0 0.0
lighting-app debug+rpc (read only) 2083881 2083881 0 0.0
(read/write) 124616 124616 0 0.0
.bss 51456 51456 0 0.0
.data 1536 1536 0 0.0
.data.rel.ro 66104 66104 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 165980 165980 0 0.0
.text 1762242 1762242 0 0.0
ota-provider-app debug (read only) 1884457 1884457 0 0.0
(read/write) 114896 114896 0 0.0
.bss 50464 50464 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 159059 159059 0 0.0
.text 1574674 1574674 0 0.0
ota-requestor-app debug (read only) 1911265 1911265 0 0.0
(read/write) 117832 117832 0 0.0
.bss 51552 51552 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 59368 59368 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 154796 154796 0 0.0
.text 1605954 1605954 0 0.0
shell debug (read only) 2398817 2398817 0 0.0
(read/write) 150088 150088 0 0.0
.bss 70472 70472 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73064 73064 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205618 205618 0 0.0
.text 2036626 2036626 0 0.0
thermostat-no-ble arm64 (read only) 2180300 2180300 0 0.0
(read/write) 148833 148833 0 0.0
.bss 65409 65409 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 75160 75160 0 0.0
.dynamic 560 560 0 0.0
.got 4240 4240 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133196 133196 0 0.0
.text 1828512 1828512 0 0.0
tv-app debug (read only) 2624697 2624697 0 0.0
(read/write) 251000 251000 0 0.0
.bss 168160 168160 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199645 199645 0 0.0
.text 2250962 2250962 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152959 1152959 0 0.0
bss 146848 146848 0 0.0
rodata 144392 144392 0 0.0
text 786464 786464 0 0.0
p6 all-clusters-app default (read/write) 2495712 2495712 0 0.0
.bss 119640 119640 0 0.0
.data 2680 2680 0 0.0
.text 1453976 1453976 0 0.0
light-app default (read/write) 2399096 2399096 0 0.0
.bss 113104 113104 0 0.0
.data 2536 2536 0 0.0
.text 1357360 1357360 0 0.0
lock-app default (read/write) 2362528 2362528 0 0.0
.bss 112848 112848 0 0.0
.data 2496 2496 0 0.0
.text 1320792 1320792 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 889646 889646 0 0.0
bss 86968 86968 0 0.0
noinit 37160 37160 0 0.0
text 628950 628950 0 0.0

@sagar-apple sagar-apple mentioned this pull request Mar 9, 2022
Closed
@vivien-apple vivien-apple merged commit a8567aa into project-chip:master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees

@vivien-apple vivien-apple

Labels
darwin examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivien-apple @andy31415 @Damian-Nordic