-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dont need bsdtar #1598
Merged
Merged
dont need bsdtar #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwalker-apple
requested review from
andy31415,
anush-apple,
BroderickCarlin,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk,
saurabhst and
woody-apple
as code owners
July 14, 2020 18:54
saurabhst
approved these changes
Jul 14, 2020
woody-apple
approved these changes
Jul 14, 2020
Size increase report for "nrf-example-build"
Full report output
|
Size increase report for "linux-example-build"
Full report output
|
Size increase report for "esp32-example-build"
Full report output
|
Size increase report for "gn_nrf-example-build"
Full report output
|
Size increase report for "gn_linux-example-build"
Full report output
|
andy31415
approved these changes
Jul 14, 2020
kedars
pushed a commit
to kedars/connectedhomeip
that referenced
this pull request
Jul 19, 2020
kedars
pushed a commit
to kedars/connectedhomeip
that referenced
this pull request
Jul 19, 2020
kedars
pushed a commit
to kedars/connectedhomeip
that referenced
this pull request
Jul 19, 2020
kedars
pushed a commit
to kedars/connectedhomeip
that referenced
this pull request
Jul 21, 2020
kedars
pushed a commit
to kedars/connectedhomeip
that referenced
this pull request
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
devcontainer Dockerfile asks for bsdtar, which isn't available in chip-build images
Summary of Changes
drop need for bsdtar, use unzip instead