-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chiptest] Wait for subprocess instead of polling #15968
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polling for subprocess return-code hogs CPU (chiptest Python process uses 100% CPU). Instead of polling it's better to use wait() call, which effectively puts Python process into sleep until subprocess terminates.
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple and
gjc13
March 8, 2022 16:08
pullapprove
bot
requested review from
LuDuda,
tecimovic,
msandstedt,
turon,
mspang,
vijs,
robszewczyk,
vivien-apple,
sagar-apple,
wbschiller,
saurabhst,
woody-apple,
selissia,
xylophone21,
yunhanw-google and
tcarmelveilleux
March 8, 2022 16:08
PR #15968: Size comparison from 2822511 to a9bb972 Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking testing updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Polling for subprocess return-code hogs CPU (chiptest Python process uses 100% CPU). Instead of polling it's better to use
wait()
call, which effectively puts Python process into sleep until subprocess terminates.Change overview
wait()
calls.Testing
Witch this changes, running
./scripts/tests/run_test_suite.py run
does not show 100% CPU usage for run_test_suite.py process.