-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Allow passing multiple data versions for attributes reads #15965
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_MultipleDataVersions
Mar 8, 2022
Merged
[chip-tool] Allow passing multiple data versions for attributes reads #15965
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_MultipleDataVersions
Mar 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton and
jepenven-silabs
March 8, 2022 15:30
pullapprove
bot
requested review from
vijs,
kpschoedel,
wbschiller,
lazarkov,
LuDuda,
woody-apple,
lzgrablic02,
xylophone21,
mrjerryjohns,
yunhanw-google,
msandstedt,
mspang,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux and
tecimovic
March 8, 2022 15:30
woody-apple
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast tracking tooling updates
vivien-apple
force-pushed
the
ChipTool_MultipleDataVersions
branch
from
March 8, 2022 16:03
54cf6fa
to
62d2371
Compare
PR #15965: Size comparison from 2822511 to 62d2371 Increases (2 builds for linux)
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
chip-tool
does not supports building requests with multiple data versions for attributes reads.Change overview
chip::DataVersion
optional argument to be a vectorTesting
Tried with: