-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable operational advertising (and CASE server) in Darwin framework. #15951
Merged
carol-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:darwin-advertise
Mar 9, 2022
Merged
Enable operational advertising (and CASE server) in Darwin framework. #15951
carol-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:darwin-advertise
Mar 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Operational advertising and a CASE server is needed for at least two things: 1. Subscriptions, so the other side can establish a CASE session if there isn't one already. 2. OTA provider server implementation. Chances are, things using the framework will want at leasts one of these things, so we just enable unconditionally when bringing up the Matter stack.
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost and
kpschoedel
March 8, 2022 07:04
pullapprove
bot
requested review from
lazarkov,
LuDuda,
mlepage-google,
msandstedt,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
wbschiller,
xylophone21 and
yufengwangca
March 8, 2022 07:04
PR #15951: Size comparison from 832fb4d to aa3ecfe Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Damian-Nordic
approved these changes
Mar 8, 2022
krypton36
approved these changes
Mar 9, 2022
carol-apple
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operational advertising and a CASE server is needed for at least two things:
Subscriptions, so the other side can establish a CASE session if
there isn't one already.
OTA provider server implementation.
Chances are, things using the framework will want at leasts one of
these things, so we just enable unconditionally when bringing up the
Matter stack.
Problem
Applications using the Darwin framework don't do operational advertising.
Change overview
Tell the controller factory to set that up.
Testing
Checked that the dns-sd records are published. Can't test actual CASE connection yet, because have not figured out what I need to do to an iOS app to allow that.