Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow modifying Illuminance, Humidity, and Occupancy sensors from the M5Stack #15940

Merged
merged 4 commits into from
Mar 8, 2022
Merged

Allow modifying Illuminance, Humidity, and Occupancy sensors from the M5Stack #15940

merged 4 commits into from
Mar 8, 2022

Conversation

sagar-apple
Copy link
Contributor

@sagar-apple sagar-apple commented Mar 8, 2022 •
edited
Loading

Problem

The UI is incomplete and modifying these sensors doesn't actually do anything.

Change overview

Fixed which clusters are updated when the UI tries to update values.

Testing

Tested with chip-tool + M5Stack

@woody-apple
Copy link
Contributor

Fast tracking platform changes.

@github-actions
Copy link

github-actions bot commented Mar 8, 2022 •
edited
Loading

PR #15940: Size comparison from 25571ca to 9a31a9e

Increases (25 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 25571ca 9a31a9e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601874 602062 188 0.0
.app_xip_area 506408 506596 188 0.0
lock cyw930739m2evb_01 (read/write) 559794 559982 188 0.0
.app_xip_area 465864 466052 188 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581982 582170 188 0.0
.app_xip_area 478372 478560 188 0.0
efr32 lighting-app BRD4161A (read only) 920996 921196 200 0.0
.text 920988 921188 200 0.0
BRD4161A+rpc (read only) 949832 950032 200 0.0
.text 949824 950024 200 0.0
window-app BRD4161A (read only) 854008 854224 216 0.0
.text 854000 854216 216 0.0
k32w light k32w061+release (read/write) 694776 694956 180 0.0
.text 609308 609488 180 0.0
lock k32w061+release (read/write) 696364 696560 196 0.0
.text 610920 611116 196 0.0
linux all-clusters-app debug (read only) 2427089 2427697 608 0.0
.rodata 205445 205509 64 0.0
.text 2058514 2059058 544 0.0
bridge-app debug+rpc (read only) 1732085 1732725 640 0.0
.rodata 141652 141748 96 0.1
.text 1474293 1474837 544 0.0
chip-tool debug (read only) 9760885 9761509 624 0.0
.rodata 510804 510868 64 0.0
.text 8510405 8510965 560 0.0
chip-tool-ipv6only arm64 (read only) 9432644 9433156 512 0.0
.text 7941796 7942308 512 0.0
door-lock-app debug (read only) 1946441 1947049 608 0.0
.rodata 173596 173660 64 0.0
.text 1624034 1624578 544 0.0
lighting-app debug+rpc (read only) 2078497 2079121 624 0.0
.rodata 165788 165852 64 0.0
.text 1756930 1757490 560 0.0
ota-provider-app debug (read only) 1879297 1879905 608 0.0
.rodata 158835 158899 64 0.0
.text 1569570 1570114 544 0.0
ota-requestor-app debug (read only) 1901281 1901905 624 0.0
.rodata 154124 154188 64 0.0
.text 1596930 1597490 560 0.0
shell debug (read only) 2393873 2394481 608 0.0
.rodata 205394 205458 64 0.0
.text 2031570 2032114 544 0.0
thermostat-no-ble arm64 (read only) 2174980 2175540 560 0.0
.rodata 132948 133012 64 0.0
.text 1823408 1823904 496 0.0
tv-app debug (read only) 2618905 2620025 1120 0.0
.rodata 199485 199549 64 0.0
.text 2245138 2246194 1056 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2350788 2350980 192 0.0
.text 1313388 1313580 192 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151739 1151915 176 0.0
rodata 144276 144340 64 0.0
text 785476 785584 108 0.0
p6 all-clusters-app default (read/write) 2494152 2494368 216 0.0
.text 1452416 1452632 216 0.0
light-app default (read/write) 2397600 2397816 216 0.0
.text 1355864 1356080 216 0.0
lock-app default (read/write) 2361032 2361248 216 0.0
.text 1319296 1319512 216 0.0
telink lighting-app tlsr9518adk80d (read/write) 888846 889050 204 0.0
text 628238 628374 136 0.0
Full report (25 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 25571ca 9a31a9e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601874 602062 188 0.0
.app_xip_area 506408 506596 188 0.0
.bss 78148 78148 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559794 559982 188 0.0
.app_xip_area 465864 466052 188 0.0
.bss 76652 76652 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581982 582170 188 0.0
.app_xip_area 478372 478560 188 0.0
.bss 85980 85980 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920996 921196 200 0.0
(read/write) 128848 128848 0 0.0
.bss 126768 126768 0 0.0
.data 2080 2080 0 0.0
.text 920988 921188 200 0.0
BRD4161A+rpc (read only) 949832 950032 200 0.0
(read/write) 144808 144808 0 0.0
.bss 142544 142544 0 0.0
.data 2260 2260 0 0.0
.text 949824 950024 200 0.0
window-app BRD4161A (read only) 854008 854224 216 0.0
(read/write) 126840 126840 0 0.0
.bss 124912 124912 0 0.0
.data 1924 1924 0 0.0
.text 854000 854216 216 0.0
k32w light k32w061+release (read/write) 694776 694956 180 0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 609308 609488 180 0.0
lock k32w061+release (read/write) 696364 696560 196 0.0
.bss 77672 77672 0 0.0
.data 1972 1972 0 0.0
.text 610920 611116 196 0.0
linux all-clusters-app debug (read only) 2427089 2427697 608 0.0
(read/write) 145760 145760 0 0.0
.bss 60128 60128 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78504 78504 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205445 205509 64 0.0
.text 2058514 2059058 544 0.0
bridge-app debug+rpc (read only) 1732085 1732725 640 0.0
(read/write) 92720 92720 0 0.0
.bss 47432 47432 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38144 38144 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141652 141748 96 0.1
.text 1474293 1474837 544 0.0
chip-tool debug (read only) 9760885 9761509 624 0.0
(read/write) 338776 338776 0 0.0
.bss 25544 25544 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 306048 306048 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 510804 510868 64 0.0
.text 8510405 8510965 560 0.0
chip-tool-ipv6only arm64 (read only) 9432644 9433156 512 0.0
(read/write) 454433 454433 0 0.0
.bss 43841 43841 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 351216 351216 0 0.0
.dynamic 560 560 0 0.0
.got 54376 54376 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 486604 486604 0 0.0
.text 7941796 7942308 512 0.0
door-lock-app debug (read only) 1946441 1947049 608 0.0
(read/write) 119136 119136 0 0.0
.bss 50432 50432 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62264 62264 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173596 173660 64 0.0
.text 1624034 1624578 544 0.0
lighting-app debug+rpc (read only) 2078497 2079121 624 0.0
(read/write) 124536 124536 0 0.0
.bss 51296 51296 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 66184 66184 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 165788 165852 64 0.0
.text 1756930 1757490 560 0.0
ota-provider-app debug (read only) 1879297 1879905 608 0.0
(read/write) 114768 114768 0 0.0
.bss 50240 50240 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57544 57544 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158835 158899 64 0.0
.text 1569570 1570114 544 0.0
ota-requestor-app debug (read only) 1901281 1901905 624 0.0
(read/write) 117512 117512 0 0.0
.bss 51296 51296 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 59256 59256 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 154124 154188 64 0.0
.text 1596930 1597490 560 0.0
shell debug (read only) 2393873 2394481 608 0.0
(read/write) 149976 149976 0 0.0
.bss 70216 70216 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73232 73232 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205394 205458 64 0.0
.text 2031570 2032114 544 0.0
thermostat-no-ble arm64 (read only) 2174980 2175540 560 0.0
(read/write) 148609 148609 0 0.0
.bss 65201 65201 0 0.0
.data 1080 1080 0 0.0
.data.rel.ro 75136 75136 0 0.0
.dynamic 560 560 0 0.0
.got 4224 4224 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132948 133012 64 0.0
.text 1823408 1823904 496 0.0
tv-app debug (read only) 2618905 2620025 1120 0.0
(read/write) 250872 250872 0 0.0
.bss 167936 167936 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73704 73704 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199485 199549 64 0.0
.text 2245138 2246194 1056 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350788 2350980 192 0.0
.bss 186084 186084 0 0.0
.data 5800 5800 0 0.0
.text 1313388 1313580 192 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151739 1151915 176 0.0
bss 146792 146792 0 0.0
rodata 144276 144340 64 0.0
text 785476 785584 108 0.0
p6 all-clusters-app default (read/write) 2494152 2494368 216 0.0
.bss 119504 119504 0 0.0
.data 2696 2696 0 0.0
.text 1452416 1452632 216 0.0
light-app default (read/write) 2397600 2397816 216 0.0
.bss 112976 112976 0 0.0
.data 2544 2544 0 0.0
.text 1355864 1356080 216 0.0
lock-app default (read/write) 2361032 2361248 216 0.0
.bss 112720 112720 0 0.0
.data 2504 2504 0 0.0
.text 1319296 1319512 216 0.0
telink lighting-app tlsr9518adk80d (read/write) 888846 889050 204 0.0
bss 86928 86928 0 0.0
noinit 37160 37160 0 0.0
text 628238 628374 136 0.0

@sagar-apple sagar-apple merged commit 3da5802 into project-chip:master Mar 8, 2022
@sagar-apple sagar-apple deleted the fix_sensor_screens branch March 8, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivi-apple nivi-apple nivi-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sagar-apple @woody-apple @nivi-apple