-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTA] Tear down CASE session during a timeout error #15939
Merged
carol-apple
merged 1 commit into
project-chip:master
from
carol-apple:ota_requestor_case_reestablish
Mar 9, 2022
Merged
[OTA] Tear down CASE session during a timeout error #15939
carol-apple
merged 1 commit into
project-chip:master
from
carol-apple:ota_requestor_case_reestablish
Mar 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02,
mlepage-google and
msandstedt
March 7, 2022 23:46
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
March 7, 2022 23:46
PR #15939: Size comparison from c0373bb to 4b8c85d Increases (25 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (28 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Mar 8, 2022
carol-apple
force-pushed
the
ota_requestor_case_reestablish
branch
from
March 8, 2022 22:27
4b8c85d
to
f3a16b9
Compare
PR #15939: Size comparison from a69fde3 to f3a16b9 Increases (9 builds for cyw30739, efr32, k32w, linux, nrfconnect)
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Mar 9, 2022
harsha-rajendran
approved these changes
Mar 9, 2022
selissia
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Once the Requestor establishes a CASE session with the Provider, it just assumes that session is good forever. Upon receiving a timeout error from the provider, nothing is being done to rectify this scenario.
Fixes: #15599
Change overview
Testing