Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not checkout submodules when spell checking #15915

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Do not checkout submodules when spell checking #15915

merged 2 commits into from
Mar 8, 2022

Conversation

andy31415
Copy link
Contributor

Problem

Spell check checkout is slow because it pulls submodules. There is not need to spellcheck submodules.

Change overview

Do not checkout submodules when running spellchecker

Testing

CI will validate (it will run spellcheck).

@github-actions
Copy link

github-actions bot commented Mar 7, 2022 •
edited
Loading

PR #15915: Size comparison from 796ba98 to dec31ed

Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 796ba98 dec31ed change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601654 601654 0 0.0
.app_xip_area 506188 506188 0 0.0
.bss 78148 78148 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559630 559630 0 0.0
.app_xip_area 465700 465700 0 0.0
.bss 76652 76652 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581826 581826 0 0.0
.app_xip_area 478216 478216 0 0.0
.bss 85980 85980 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920724 920724 0 0.0
(read/write) 128848 128848 0 0.0
.bss 126768 126768 0 0.0
.data 2080 2080 0 0.0
.text 920716 920716 0 0.0
BRD4161A+rpc (read only) 949560 949560 0 0.0
(read/write) 144808 144808 0 0.0
.bss 142544 142544 0 0.0
.data 2260 2260 0 0.0
.text 949552 949552 0 0.0
lock-app BRD4161A+wf200 (read only) 988692 988692 0 0.0
(read/write) 120368 120368 0 0.0
.bss 118436 118436 0 0.0
.data 1932 1932 0 0.0
.text 988684 988684 0 0.0
window-app BRD4161A (read only) 853784 853784 0 0.0
(read/write) 126840 126840 0 0.0
.bss 124912 124912 0 0.0
.data 1924 1924 0 0.0
.text 853776 853776 0 0.0
esp32 all-clusters-app c3devkit (read only) 957276 957276 0 0.0
(read/write) 1393586 1393586 0 0.0
.dram0.bss 63432 63432 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197000 197000 0 0.0
.flash.text 957276 957276 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012079 1012079 0 0.0
(read/write) 460692 460692 0 0.0
.dram0.bss 68960 68960 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225816 225816 0 0.0
.flash.text 1006695 1006695 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694616 694616 0 0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 609148 609148 0 0.0
lock k32w061+release (read/write) 696204 696204 0 0.0
.bss 77672 77672 0 0.0
.data 1972 1972 0 0.0
.text 610760 610760 0 0.0
linux all-clusters-app debug (read only) 2425521 2425521 0 0.0
(read/write) 145760 145760 0 0.0
.bss 60128 60128 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78504 78504 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205349 205349 0 0.0
.text 2057042 2057042 0 0.0
bridge-app debug+rpc (read only) 1730805 1730805 0 0.0
(read/write) 92720 92720 0 0.0
.bss 47432 47432 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38144 38144 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141652 141652 0 0.0
.text 1473013 1473013 0 0.0
chip-tool debug (read only) 9746901 9746901 0 0.0
(read/write) 338232 338232 0 0.0
.bss 25544 25544 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 305504 305504 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 509812 509812 0 0.0
.text 8498613 8498613 0 0.0
chip-tool-ipv6only arm64 (read only) 9420276 9420276 0 0.0
(read/write) 453761 453761 0 0.0
.bss 43841 43841 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 350648 350648 0 0.0
.dynamic 560 560 0 0.0
.got 54272 54272 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 485612 485612 0 0.0
.text 7931956 7931956 0 0.0
door-lock-app debug (read only) 1945161 1945161 0 0.0
(read/write) 119136 119136 0 0.0
.bss 50432 50432 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62264 62264 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173596 173596 0 0.0
.text 1622754 1622754 0 0.0
lighting-app debug+rpc (read only) 2076929 2076929 0 0.0
(read/write) 124536 124536 0 0.0
.bss 51296 51296 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 66184 66184 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 165692 165692 0 0.0
.text 1755458 1755458 0 0.0
ota-provider-app debug (read only) 1878017 1878017 0 0.0
(read/write) 114768 114768 0 0.0
.bss 50240 50240 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57544 57544 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158835 158835 0 0.0
.text 1568290 1568290 0 0.0
ota-requestor-app debug (read only) 1900081 1900081 0 0.0
(read/write) 117512 117512 0 0.0
.bss 51296 51296 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 59256 59256 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 154124 154124 0 0.0
.text 1595730 1595730 0 0.0
shell debug (read only) 2392305 2392305 0 0.0
(read/write) 149976 149976 0 0.0
.bss 70216 70216 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73232 73232 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205298 205298 0 0.0
.text 2030098 2030098 0 0.0
thermostat-no-ble arm64 (read only) 2174116 2174116 0 0.0
(read/write) 148609 148609 0 0.0
.bss 65201 65201 0 0.0
.data 1080 1080 0 0.0
.data.rel.ro 75136 75136 0 0.0
.dynamic 560 560 0 0.0
.got 4224 4224 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132948 132948 0 0.0
.text 1822544 1822544 0 0.0
tv-app debug (read only) 2617369 2617369 0 0.0
(read/write) 250872 250872 0 0.0
.bss 167936 167936 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73704 73704 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199389 199389 0 0.0
.text 2243698 2243698 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350468 2350468 0 0.0
.bss 186084 186084 0 0.0
.data 5800 5800 0 0.0
.text 1313068 1313068 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151515 1151515 0 0.0
bss 146792 146792 0 0.0
rodata 144276 144276 0 0.0
text 785260 785260 0 0.0
p6 all-clusters-app default (read/write) 2493880 2493880 0 0.0
.bss 119504 119504 0 0.0
.data 2696 2696 0 0.0
.text 1452144 1452144 0 0.0
light-app default (read/write) 2397328 2397328 0 0.0
.bss 112976 112976 0 0.0
.data 2544 2544 0 0.0
.text 1355592 1355592 0 0.0
lock-app default (read/write) 2360808 2360808 0 0.0
.bss 112720 112720 0 0.0
.data 2504 2504 0 0.0
.text 1319072 1319072 0 0.0
qpg lighting-app qpg6105+debug (read only) 603812 603812 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91080 91080 0 0.0
.data 1164 1164 0 0.0
.text 598492 598492 0 0.0
lock-app qpg6105+debug (read only) 569480 569480 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91088 91088 0 0.0
.data 1116 1116 0 0.0
.text 564160 564160 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888670 888670 0 0.0
bss 86928 86928 0 0.0
noinit 37160 37160 0 0.0
text 628058 628058 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking workflows

@woody-apple
Copy link
Contributor

/rebase

@github-actions
Copy link

github-actions bot commented Mar 7, 2022 •
edited
Loading

PR #15915: Size comparison from c0373bb to 9c1b08b

Full report (28 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c0373bb 9c1b08b change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601874 601874 0 0.0
.app_xip_area 506408 506408 0 0.0
.bss 78148 78148 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559794 559794 0 0.0
.app_xip_area 465864 465864 0 0.0
.bss 76652 76652 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581990 581990 0 0.0
.app_xip_area 478380 478380 0 0.0
.bss 85980 85980 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920996 920996 0 0.0
(read/write) 128848 128848 0 0.0
.bss 126768 126768 0 0.0
.data 2080 2080 0 0.0
.text 920988 920988 0 0.0
BRD4161A+rpc (read only) 949832 949832 0 0.0
(read/write) 144808 144808 0 0.0
.bss 142544 142544 0 0.0
.data 2260 2260 0 0.0
.text 949824 949824 0 0.0
lock-app BRD4161A+wf200 (read only) 988916 988916 0 0.0
(read/write) 120368 120368 0 0.0
.bss 118436 118436 0 0.0
.data 1932 1932 0 0.0
.text 988908 988908 0 0.0
window-app BRD4161A (read only) 854008 854008 0 0.0
(read/write) 126840 126840 0 0.0
.bss 124912 124912 0 0.0
.data 1924 1924 0 0.0
.text 854000 854000 0 0.0
esp32 all-clusters-app c3devkit (read only) 957470 957470 0 0.0
(read/write) 1393586 1393586 0 0.0
.dram0.bss 63432 63432 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197000 197000 0 0.0
.flash.text 957470 957470 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012379 1012379 0 0.0
(read/write) 460692 460692 0 0.0
.dram0.bss 68960 68960 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225816 225816 0 0.0
.flash.text 1006995 1006995 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694776 694776 0 0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 609308 609308 0 0.0
lock k32w061+release (read/write) 696364 696364 0 0.0
.bss 77672 77672 0 0.0
.data 1972 1972 0 0.0
.text 610920 610920 0 0.0
linux all-clusters-app debug (read only) 2427089 2427089 0 0.0
(read/write) 145760 145760 0 0.0
.bss 60128 60128 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78504 78504 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205445 205445 0 0.0
.text 2058514 2058514 0 0.0
bridge-app debug+rpc (read only) 1732085 1732085 0 0.0
(read/write) 92720 92720 0 0.0
.bss 47432 47432 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38144 38144 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141652 141652 0 0.0
.text 1474293 1474293 0 0.0
chip-tool debug (read only) 9760885 9760885 0 0.0
(read/write) 338776 338776 0 0.0
.bss 25544 25544 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 306048 306048 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 510804 510804 0 0.0
.text 8510405 8510405 0 0.0
chip-tool-ipv6only arm64 (read only) 9432644 9432644 0 0.0
(read/write) 454433 454433 0 0.0
.bss 43841 43841 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 351216 351216 0 0.0
.dynamic 560 560 0 0.0
.got 54376 54376 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 486604 486604 0 0.0
.text 7941796 7941796 0 0.0
door-lock-app debug (read only) 1946441 1946441 0 0.0
(read/write) 119136 119136 0 0.0
.bss 50432 50432 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62264 62264 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173596 173596 0 0.0
.text 1624034 1624034 0 0.0
lighting-app debug+rpc (read only) 2078497 2078497 0 0.0
(read/write) 124536 124536 0 0.0
.bss 51296 51296 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 66184 66184 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 165788 165788 0 0.0
.text 1756930 1756930 0 0.0
ota-provider-app debug (read only) 1879297 1879297 0 0.0
(read/write) 114768 114768 0 0.0
.bss 50240 50240 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57544 57544 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158835 158835 0 0.0
.text 1569570 1569570 0 0.0
ota-requestor-app debug (read only) 1901329 1901329 0 0.0
(read/write) 117512 117512 0 0.0
.bss 51296 51296 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 59256 59256 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 154124 154124 0 0.0
.text 1596978 1596978 0 0.0
shell debug (read only) 2393873 2393873 0 0.0
(read/write) 149976 149976 0 0.0
.bss 70216 70216 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73232 73232 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205394 205394 0 0.0
.text 2031570 2031570 0 0.0
thermostat-no-ble arm64 (read only) 2174980 2174980 0 0.0
(read/write) 148609 148609 0 0.0
.bss 65201 65201 0 0.0
.data 1080 1080 0 0.0
.data.rel.ro 75136 75136 0 0.0
.dynamic 560 560 0 0.0
.got 4224 4224 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132948 132948 0 0.0
.text 1823408 1823408 0 0.0
tv-app debug (read only) 2618905 2618905 0 0.0
(read/write) 250872 250872 0 0.0
.bss 167936 167936 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73704 73704 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199485 199485 0 0.0
.text 2245138 2245138 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350788 2350788 0 0.0
.bss 186084 186084 0 0.0
.data 5800 5800 0 0.0
.text 1313388 1313388 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151739 1151739 0 0.0
bss 146792 146792 0 0.0
rodata 144276 144276 0 0.0
text 785484 785484 0 0.0
p6 all-clusters-app default (read/write) 2494152 2494152 0 0.0
.bss 119504 119504 0 0.0
.data 2696 2696 0 0.0
.text 1452416 1452416 0 0.0
light-app default (read/write) 2397600 2397600 0 0.0
.bss 112976 112976 0 0.0
.data 2544 2544 0 0.0
.text 1355864 1355864 0 0.0
lock-app default (read/write) 2361032 2361032 0 0.0
.bss 112720 112720 0 0.0
.data 2504 2504 0 0.0
.text 1319296 1319296 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888846 888846 0 0.0
bss 86928 86928 0 0.0
noinit 37160 37160 0 0.0
text 628238 628238 0 0.0

@woody-apple woody-apple merged commit 25571ca into project-chip:master Mar 8, 2022
mykrupp referenced this pull request in mykrupp/connectedhomeip-1 Mar 8, 2022
@andy31415 @mykrupp
Do not checkout submodules when spell checking (#15915)
fdea203 
* Do not checkout submodules for spell check

* Noop to trigger spell checker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
github lib review - approved workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andy31415 @woody-apple @Damian-Nordic