-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Cancel the CHIPCallbacks when the chip-tool ends up to av… #15914
Merged
woody-apple
merged 1 commit into
project-chip:master
from
vivien-apple:Asan_chiptool_use_after_free_cancel_callbacks
Mar 8, 2022
Merged
[chip-tool] Cancel the CHIPCallbacks when the chip-tool ends up to av… #15914
woody-apple
merged 1 commit into
project-chip:master
from
vivien-apple:Asan_chiptool_use_after_free_cancel_callbacks
Mar 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oid a use-after-free if there is a timeout trying to get the device
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda and
lzgrablic02
March 7, 2022 15:23
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
March 7, 2022 15:23
andy31415
approved these changes
Mar 7, 2022
PR #15914: Size comparison from 5cefe19 to 4a7a8db Increases (2 builds for linux)
Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Mar 8, 2022
mykrupp
referenced
this pull request
in mykrupp/connectedhomeip-1
Mar 8, 2022
…oid a use-after-free if there is a timeout trying to get the device (#15914)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…oid a use-after-free if there is a timeout trying to get the device
Problem
Running the command
./out/debug/standalone/chip-tool basic subscribe node-label 0 100 0 0x12344321 0
where0x12344321
is not a known node id ends up into ause-after-free
.Change overview