Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenThread] ReceivePacket should use PBUF_LINK when allocating pbuf #1591

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

erjiaqing
Copy link
Contributor

Problem

Currently, GenericThreadStackManagerImpl_OpenThread_LwIP::ReceivePacket uses pbuf_alloc(PBUF_RAW) to allocate pbuf for lwip, however, according to lwip's doc, PBUF_RAW should be used for allocating L2 packets, but infact, this function reads L3 packets, which should use PBUF_LINK to avoid potential issues.

Summary of Changes

Change PBUF_RAW to PBUF_LINK

Copy link
Contributor

@bukepo bukepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize


Copy link
Contributor

@turon turon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@woody-apple woody-apple merged commit ffa6de3 into project-chip:master Jul 14, 2020
@erjiaqing erjiaqing deleted the ot-pbuf branch July 15, 2020 02:09
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants