-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenThread] ReceivePacket should use PBUF_LINK when allocating pbuf #1591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM:+1:
Size increase report for "gn_nrf-example-build"
Full report output
|
Size increase report for "gn_linux-example-build"
Full report output
|
Size increase report for "nrf-example-build"
Full report output
|
Size increase report for "linux-example-build"
Full report output
|
Size increase report for "esp32-example-build"
Full report output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Problem
Currently, GenericThreadStackManagerImpl_OpenThread_LwIP::ReceivePacket uses
pbuf_alloc(PBUF_RAW)
to allocate pbuf for lwip, however, according to lwip's doc,PBUF_RAW
should be used for allocating L2 packets, but infact, this function reads L3 packets, which should usePBUF_LINK
to avoid potential issues.Summary of Changes
Change
PBUF_RAW
toPBUF_LINK