-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[events] Refactor startup and shutdown event management #15909
Merged
Damian-Nordic
merged 2 commits into
project-chip:master
from
Damian-Nordic:shutdown-event
Mar 10, 2022
Merged
[events] Refactor startup and shutdown event management #15909
Damian-Nordic
merged 2 commits into
project-chip:master
from
Damian-Nordic:shutdown-event
Mar 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
lazarkov,
LuDuda,
lzgrablic02 and
msandstedt
March 7, 2022 13:41
pullapprove
bot
requested review from
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
March 7, 2022 13:41
PR #15909: Size comparison from 2b4e22d to 7107dfc Increases (10 builds for esp32, linux, nrfconnect)
Decreases (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Add PlatformMgr().HandleServerStarted() to handle post-init actions, such as emitting StartUp and BootReason events and call it explicitly inside Server::Init not to rely on any specific Matter stack initialization mechanism. Add PlatformMgr().HandleServerShuttingDown() to handle pre-shutdown actions, such as emitting Shutdown event. Use the method in the existing factory reset sequence, and in nRF Connect OTA image processor (other platforms should probably be updated, too).
Damian-Nordic
force-pushed
the
shutdown-event
branch
from
March 7, 2022 16:02
7107dfc
to
61d9eb1
Compare
PR #15909: Size comparison from 796ba98 to 61d9eb1 Increases (18 builds for esp32, linux, nrfconnect)
Decreases (38 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (39 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Mar 8, 2022
bzbarsky-apple
approved these changes
Mar 9, 2022
LuDuda
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Basic cluster's StartUp event may no be generated if an application doesn't follow a specific initialization order (see #15295)
Basic cluster's ShutDown event is not generated when restarting the device after applying a firmware upgrade.
Change overview
PlatformMgr().HandleServerStarted()
to handle post-init actions, such as emitting StartUp and BootReason events andcall it explicitly inside Server::Init not to rely on any specific Matter stack initialization mechanism.
the method in the existing factory reset sequence, and in nRF Connect OTA image processor (other platforms should
probably be updated, too).
Testing
Tested that both StartUp and ShutDown events are generated properly on nRF connect examples.
Fixes #15295