Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IM] Make CommandHandler::AddResponseData atomic #15906

Merged
merged 12 commits into from
Mar 29, 2022
Merged

[IM] Make CommandHandler::AddResponseData atomic #15906

merged 12 commits into from
Mar 29, 2022

Conversation

erjiaqing
Copy link
Contributor

Problem

Fixes #15685

CommandHandler::AddResponseData is not atomic, then we cannot encode status since the backed buffer might be corrupted and we are in a wrong state.

Change overview

  • Adds ResetResponse
  • Make AddResponseData atomic
  • Add AddResponseDataOrFailureStatus

Testing

  • Adds TestCommandHandlerCommandEncodeFailure, and TestCommandHandlerCommandEncodeExternalFailure

@boring-cyborg boring-cyborg bot added the app label Mar 7, 2022
@github-actions
Copy link

github-actions bot commented Mar 15, 2022 •
edited
Loading

PR #15906: Size comparison from b18b03a to 3ac709c

Increases above 0.2%:

platform target config section b18b03a 3ac709cf change % change
esp32 all-clusters-app c3devkit .dram0.bss 64056 64232 176 0.3
m5stack .dram0.bss 69576 69752 176 0.3
linux all-clusters-app debug (read only) 2465225 2471145 5920 0.2
.text 2091298 2097218 5920 0.3
shell debug (read only) 2411385 2416825 5440 0.2
.text 2047762 2053202 5440 0.3
Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b18b03a 3ac709cf change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602578 603106 528 0.1
.app_xip_area 509756 510124 368 0.1
.bss 75576 75736 160 0.2
lock cyw930739m2evb_01 (read/write) 560430 560894 464 0.1
.app_xip_area 469136 469440 304 0.1
.bss 74080 74240 160 0.2
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570498 570962 464 0.1
.app_xip_area 469556 469860 304 0.1
.bss 83384 83544 160 0.2
efr32 lighting-app BRD4161A (read only) 919652 920292 640 0.1
(read/write) 128672 128832 160 0.1
.bss 126664 126824 160 0.1
.text 919644 920284 640 0.1
BRD4161A+rpc (read only) 948440 949096 656 0.1
(read/write) 144632 144792 160 0.1
.bss 142440 142600 160 0.1
.text 948432 949088 656 0.1
window-app BRD4161A (read only) 850392 850936 544 0.1
(read/write) 126632 126792 160 0.1
.bss 124768 124928 160 0.1
.text 850384 850928 544 0.1
esp32 all-clusters-app c3devkit (read only) 961388 961988 600 0.1
(read/write) 1394938 1395114 176 0.0
.dram0.bss 64056 64232 176 0.3
.flash.text 961388 961988 600 0.1
m5stack (read only) 1017011 1017447 436 0.0
(read/write) 462148 462324 176 0.0
.dram0.bss 69576 69752 176 0.3
.flash.text 1011627 1012063 436 0.0
k32w light k32w061+release (read/write) 699340 699820 480 0.1
.bss 77560 77720 160 0.2
.text 614092 614412 320 0.1
lock k32w061+release (read/write) 699644 700124 480 0.1
.bss 77552 77712 160 0.2
.text 614384 614704 320 0.1
linux all-clusters-app debug (read only) 2465225 2471145 5920 0.2
.text 2091298 2097218 5920 0.3
bridge-app debug+rpc (read only) 1749757 1751661 1904 0.1
.text 1490901 1492805 1904 0.1
chip-tool debug (read only) 10095037 10095053 16 0.0
.text 8798789 8798805 16 0.0
chip-tool-ipv6only arm64 (read only) 9728092 9728108 16 0.0
.text 8186052 8186068 16 0.0
door-lock-app debug (read only) 1984385 1986769 2384 0.1
.text 1657090 1659474 2384 0.1
lighting-app debug+rpc (read only) 2115961 2119289 3328 0.2
.text 1789106 1792434 3328 0.2
ota-provider-app debug (read only) 1918537 1920921 2384 0.1
.text 1603266 1605650 2384 0.1
ota-requestor-app debug (read only) 1949249 1951153 1904 0.1
.text 1637570 1639474 1904 0.1
shell debug (read only) 2411385 2416825 5440 0.2
.text 2047762 2053202 5440 0.3
thermostat-no-ble arm64 (read only) 2207236 2209812 2576 0.1
.text 1851168 1853744 2576 0.1
tv-app debug (read only) 2656097 2659665 3568 0.1
.text 2277826 2281394 3568 0.2
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2352756 2353076 320 0.0
.bss 186652 186812 160 0.1
.text 1315356 1315676 320 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154011 1154667 656 0.1
bss 146644 146804 160 0.1
text 786976 787516 540 0.1
p6 all-clusters-app default (read/write) 2492152 2493016 864 0.0
.bss 120080 120240 160 0.1
.text 1450416 1451280 864 0.1
light-app default (read/write) 2396000 2396640 640 0.0
.bss 113544 113704 160 0.1
.text 1354264 1354904 640 0.0
lock-app default (read/write) 2359544 2360088 544 0.0
.bss 113288 113448 160 0.1
.text 1317808 1318352 544 0.0
telink lighting-app tlsr9518adk80d (read/write) 893770 894394 624 0.1
bss 87432 87608 176 0.2
text 631868 632320 452 0.1
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b18b03a 3ac709cf change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602578 603106 528 0.1
.app_xip_area 509756 510124 368 0.1
.bss 75576 75736 160 0.2
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560430 560894 464 0.1
.app_xip_area 469136 469440 304 0.1
.bss 74080 74240 160 0.2
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570498 570962 464 0.1
.app_xip_area 469556 469860 304 0.1
.bss 83384 83544 160 0.2
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919652 920292 640 0.1
(read/write) 128672 128832 160 0.1
.bss 126664 126824 160 0.1
.data 2008 2008 0 0.0
.text 919644 920284 640 0.1
BRD4161A+rpc (read only) 948440 949096 656 0.1
(read/write) 144632 144792 160 0.1
.bss 142440 142600 160 0.1
.data 2188 2188 0 0.0
.text 948432 949088 656 0.1
window-app BRD4161A (read only) 850392 850936 544 0.1
(read/write) 126632 126792 160 0.1
.bss 124768 124928 160 0.1
.data 1864 1864 0 0.0
.text 850384 850928 544 0.1
esp32 all-clusters-app c3devkit (read only) 961388 961988 600 0.1
(read/write) 1394938 1395114 176 0.0
.dram0.bss 64056 64232 176 0.3
.dram0.data 14188 14188 0 0.0
.flash.rodata 197776 197776 0 0.0
.flash.text 961388 961988 600 0.1
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017011 1017447 436 0.0
(read/write) 462148 462324 176 0.0
.dram0.bss 69576 69752 176 0.3
.dram0.data 34016 34016 0 0.0
.flash.rodata 226720 226720 0 0.0
.flash.text 1011627 1012063 436 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699340 699820 480 0.1
.bss 77560 77720 160 0.2
.data 1888 1888 0 0.0
.text 614092 614412 320 0.1
lock k32w061+release (read/write) 699644 700124 480 0.1
.bss 77552 77712 160 0.2
.data 1908 1908 0 0.0
.text 614384 614704 320 0.1
linux all-clusters-app debug (read only) 2465225 2471145 5920 0.2
(read/write) 146352 146352 0 0.0
.bss 60640 60640 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78728 78728 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 210693 210693 0 0.0
.text 2091298 2097218 5920 0.3
bridge-app debug+rpc (read only) 1749757 1751661 1904 0.1
(read/write) 92912 92912 0 0.0
.bss 47752 47752 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 38128 38128 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 143308 143308 0 0.0
.text 1490901 1492805 1904 0.1
chip-tool debug (read only) 10095037 10095053 16 0.0
(read/write) 357680 357680 0 0.0
.bss 25696 25696 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 324864 324864 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514997 514997 0 0.0
.text 8798789 8798805 16 0.0
chip-tool-ipv6only arm64 (read only) 9728092 9728108 16 0.0
(read/write) 475425 475425 0 0.0
.bss 44017 44017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371232 371232 0 0.0
.dynamic 560 560 0 0.0
.got 55256 55256 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492196 492196 0 0.0
.text 8186052 8186068 16 0.0
door-lock-app debug (read only) 1984385 1986769 2384 0.1
(read/write) 119776 119776 0 0.0
.bss 50944 50944 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 178396 178396 0 0.0
.text 1657090 1659474 2384 0.1
lighting-app debug+rpc (read only) 2115961 2119289 3328 0.2
(read/write) 125160 125160 0 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66408 66408 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 170940 170940 0 0.0
.text 1789106 1792434 3328 0.2
ota-provider-app debug (read only) 1918537 1920921 2384 0.1
(read/write) 115536 115536 0 0.0
.bss 50816 50816 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 57816 57816 0 0.0
.dynamic 608 608 0 0.0
.got 4360 4360 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 164267 164267 0 0.0
.text 1603266 1605650 2384 0.1
ota-requestor-app debug (read only) 1949249 1951153 1904 0.1
(read/write) 118568 118568 0 0.0
.bss 51840 51840 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 59880 59880 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 160452 160452 0 0.0
.text 1637570 1639474 1904 0.1
shell debug (read only) 2411385 2416825 5440 0.2
(read/write) 150184 150184 0 0.0
.bss 70600 70600 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73088 73088 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 207474 207474 0 0.0
.text 2047762 2053202 5440 0.3
thermostat-no-ble arm64 (read only) 2207236 2209812 2576 0.1
(read/write) 149377 149377 0 0.0
.bss 65649 65649 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75368 75368 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 136756 136756 0 0.0
.text 1851168 1853744 2576 0.1
tv-app debug (read only) 2656097 2659665 3568 0.1
(read/write) 250776 250776 0 0.0
.bss 167840 167840 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 73800 73800 0 0.0
.dynamic 592 592 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 204213 204213 0 0.0
.text 2277826 2281394 3568 0.2
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352756 2353076 320 0.0
.bss 186652 186812 160 0.1
.data 5752 5752 0 0.0
.text 1315356 1315676 320 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154011 1154667 656 0.1
bss 146644 146804 160 0.1
rodata 145276 145276 0 0.0
text 786976 787516 540 0.1
p6 all-clusters-app default (read/write) 2492152 2493016 864 0.0
.bss 120080 120240 160 0.1
.data 2632 2632 0 0.0
.text 1450416 1451280 864 0.1
light-app default (read/write) 2396000 2396640 640 0.0
.bss 113544 113704 160 0.1
.data 2488 2488 0 0.0
.text 1354264 1354904 640 0.0
lock-app default (read/write) 2359544 2360088 544 0.0
.bss 113288 113448 160 0.1
.data 2448 2448 0 0.0
.text 1317808 1318352 544 0.0
telink lighting-app tlsr9518adk80d (read/write) 893770 894394 624 0.1
bss 87432 87608 176 0.2
noinit 37160 37160 0 0.0
text 631868 632320 452 0.1

@github-actions
Copy link

github-actions bot commented Mar 15, 2022 •
edited
Loading

PR #15906: Size comparison from b18b03a to b641b12

Increases above 0.2%:

platform target config section b18b03a b641b12 change % change
esp32 all-clusters-app c3devkit .dram0.bss 64056 64232 176 0.3
m5stack .dram0.bss 69576 69752 176 0.3
linux all-clusters-app debug (read only) 2465225 2475945 10720 0.4
.text 2091298 2102018 10720 0.5
bridge-app debug+rpc .text 1490901 1494197 3296 0.2
door-lock-app debug (read only) 1984385 1988561 4176 0.2
.text 1657090 1661266 4176 0.3
lighting-app debug+rpc (read only) 2115961 2121881 5920 0.3
.text 1789106 1795026 5920 0.3
ota-provider-app debug (read only) 1918537 1922681 4144 0.2
.text 1603266 1607442 4176 0.3
ota-requestor-app debug .text 1637570 1640882 3312 0.2
shell debug (read only) 2411385 2421225 9840 0.4
.text 2047762 2057602 9840 0.5
tv-app debug (read only) 2656097 2662465 6368 0.2
.text 2277826 2284194 6368 0.3
Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b18b03a b641b12 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602578 603202 624 0.1
.app_xip_area 509756 510220 464 0.1
.bss 75576 75736 160 0.2
lock cyw930739m2evb_01 (read/write) 560430 560942 512 0.1
.app_xip_area 469136 469488 352 0.1
.bss 74080 74240 160 0.2
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570498 571002 504 0.1
.app_xip_area 469556 469900 344 0.1
.bss 83384 83544 160 0.2
efr32 lighting-app BRD4161A (read only) 919652 920644 992 0.1
(read/write) 128672 128832 160 0.1
.bss 126664 126824 160 0.1
.text 919644 920636 992 0.1
BRD4161A+rpc (read only) 948440 949432 992 0.1
(read/write) 144632 144792 160 0.1
.bss 142440 142600 160 0.1
.text 948432 949424 992 0.1
window-app BRD4161A (read only) 850392 851152 760 0.1
(read/write) 126632 126792 160 0.1
.bss 124768 124928 160 0.1
.text 850384 851144 760 0.1
esp32 all-clusters-app c3devkit (read only) 961388 962128 740 0.1
(read/write) 1394938 1395106 168 0.0
.dram0.bss 64056 64232 176 0.3
.flash.text 961388 962128 740 0.1
m5stack (read only) 1017011 1017555 544 0.1
(read/write) 462148 462316 168 0.0
.dram0.bss 69576 69752 176 0.3
.flash.text 1011627 1012171 544 0.1
k32w light k32w061+release (read/write) 699340 699868 528 0.1
.bss 77560 77720 160 0.2
.text 614092 614460 368 0.1
lock k32w061+release (read/write) 699644 700164 520 0.1
.bss 77552 77712 160 0.2
.text 614384 614744 360 0.1
linux all-clusters-app debug (read only) 2465225 2475945 10720 0.4
.text 2091298 2102018 10720 0.5
bridge-app debug+rpc (read only) 1749757 1753053 3296 0.2
.text 1490901 1494197 3296 0.2
chip-tool debug (read only) 10095037 10095053 16 0.0
.text 8798789 8798805 16 0.0
chip-tool-ipv6only arm64 (read only) 9728092 9728108 16 0.0
.text 8186052 8186068 16 0.0
door-lock-app debug (read only) 1984385 1988561 4176 0.2
.text 1657090 1661266 4176 0.3
lighting-app debug+rpc (read only) 2115961 2121881 5920 0.3
.text 1789106 1795026 5920 0.3
ota-provider-app debug (read only) 1918537 1922681 4144 0.2
.text 1603266 1607442 4176 0.3
ota-requestor-app debug (read only) 1949249 1952561 3312 0.2
.text 1637570 1640882 3312 0.2
shell debug (read only) 2411385 2421225 9840 0.4
.text 2047762 2057602 9840 0.5
thermostat-no-ble arm64 (read only) 2207236 2211620 4384 0.2
.text 1851168 1855552 4384 0.2
tv-app debug (read only) 2656097 2662465 6368 0.2
.text 2277826 2284194 6368 0.3
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2352756 2353132 376 0.0
.bss 186652 186812 160 0.1
.text 1315356 1315732 376 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154011 1154711 700 0.1
bss 146644 146804 160 0.1
text 786976 787564 588 0.1
p6 all-clusters-app default (read/write) 2492152 2493544 1392 0.1
.bss 120080 120240 160 0.1
.text 1450416 1451808 1392 0.1
light-app default (read/write) 2396000 2396984 984 0.0
.bss 113544 113704 160 0.1
.text 1354264 1355248 984 0.1
lock-app default (read/write) 2359544 2360304 760 0.0
.bss 113288 113448 160 0.1
.text 1317808 1318568 760 0.1
telink lighting-app tlsr9518adk80d (read/write) 893770 894502 732 0.1
bss 87432 87608 176 0.2
text 631868 632432 564 0.1
Decreases (4 builds for esp32, linux, nrfconnect)
platform target config section b18b03a b641b12 change % change
esp32 all-clusters-app c3devkit .flash.rodata 197776 197768 -8 -0.0
m5stack .flash.rodata 226720 226712 -8 -0.0
linux ota-provider-app debug .rodata 164267 164235 -32 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 145276 145272 -4 -0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b18b03a b641b12 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602578 603202 624 0.1
.app_xip_area 509756 510220 464 0.1
.bss 75576 75736 160 0.2
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560430 560942 512 0.1
.app_xip_area 469136 469488 352 0.1
.bss 74080 74240 160 0.2
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570498 571002 504 0.1
.app_xip_area 469556 469900 344 0.1
.bss 83384 83544 160 0.2
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919652 920644 992 0.1
(read/write) 128672 128832 160 0.1
.bss 126664 126824 160 0.1
.data 2008 2008 0 0.0
.text 919644 920636 992 0.1
BRD4161A+rpc (read only) 948440 949432 992 0.1
(read/write) 144632 144792 160 0.1
.bss 142440 142600 160 0.1
.data 2188 2188 0 0.0
.text 948432 949424 992 0.1
window-app BRD4161A (read only) 850392 851152 760 0.1
(read/write) 126632 126792 160 0.1
.bss 124768 124928 160 0.1
.data 1864 1864 0 0.0
.text 850384 851144 760 0.1
esp32 all-clusters-app c3devkit (read only) 961388 962128 740 0.1
(read/write) 1394938 1395106 168 0.0
.dram0.bss 64056 64232 176 0.3
.dram0.data 14188 14188 0 0.0
.flash.rodata 197776 197768 -8 -0.0
.flash.text 961388 962128 740 0.1
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017011 1017555 544 0.1
(read/write) 462148 462316 168 0.0
.dram0.bss 69576 69752 176 0.3
.dram0.data 34016 34016 0 0.0
.flash.rodata 226720 226712 -8 -0.0
.flash.text 1011627 1012171 544 0.1
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699340 699868 528 0.1
.bss 77560 77720 160 0.2
.data 1888 1888 0 0.0
.text 614092 614460 368 0.1
lock k32w061+release (read/write) 699644 700164 520 0.1
.bss 77552 77712 160 0.2
.data 1908 1908 0 0.0
.text 614384 614744 360 0.1
linux all-clusters-app debug (read only) 2465225 2475945 10720 0.4
(read/write) 146352 146352 0 0.0
.bss 60640 60640 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78728 78728 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 210693 210693 0 0.0
.text 2091298 2102018 10720 0.5
bridge-app debug+rpc (read only) 1749757 1753053 3296 0.2
(read/write) 92912 92912 0 0.0
.bss 47752 47752 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 38128 38128 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 143308 143308 0 0.0
.text 1490901 1494197 3296 0.2
chip-tool debug (read only) 10095037 10095053 16 0.0
(read/write) 357680 357680 0 0.0
.bss 25696 25696 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 324864 324864 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514997 514997 0 0.0
.text 8798789 8798805 16 0.0
chip-tool-ipv6only arm64 (read only) 9728092 9728108 16 0.0
(read/write) 475425 475425 0 0.0
.bss 44017 44017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371232 371232 0 0.0
.dynamic 560 560 0 0.0
.got 55256 55256 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492196 492196 0 0.0
.text 8186052 8186068 16 0.0
door-lock-app debug (read only) 1984385 1988561 4176 0.2
(read/write) 119776 119776 0 0.0
.bss 50944 50944 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 178396 178396 0 0.0
.text 1657090 1661266 4176 0.3
lighting-app debug+rpc (read only) 2115961 2121881 5920 0.3
(read/write) 125160 125160 0 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66408 66408 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 170940 170940 0 0.0
.text 1789106 1795026 5920 0.3
ota-provider-app debug (read only) 1918537 1922681 4144 0.2
(read/write) 115536 115536 0 0.0
.bss 50816 50816 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 57816 57816 0 0.0
.dynamic 608 608 0 0.0
.got 4360 4360 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 164267 164235 -32 -0.0
.text 1603266 1607442 4176 0.3
ota-requestor-app debug (read only) 1949249 1952561 3312 0.2
(read/write) 118568 118568 0 0.0
.bss 51840 51840 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 59880 59880 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 160452 160452 0 0.0
.text 1637570 1640882 3312 0.2
shell debug (read only) 2411385 2421225 9840 0.4
(read/write) 150184 150184 0 0.0
.bss 70600 70600 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73088 73088 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 207474 207474 0 0.0
.text 2047762 2057602 9840 0.5
thermostat-no-ble arm64 (read only) 2207236 2211620 4384 0.2
(read/write) 149377 149377 0 0.0
.bss 65649 65649 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75368 75368 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 136756 136756 0 0.0
.text 1851168 1855552 4384 0.2
tv-app debug (read only) 2656097 2662465 6368 0.2
(read/write) 250776 250776 0 0.0
.bss 167840 167840 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 73800 73800 0 0.0
.dynamic 592 592 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 204213 204213 0 0.0
.text 2277826 2284194 6368 0.3
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352756 2353132 376 0.0
.bss 186652 186812 160 0.1
.data 5752 5752 0 0.0
.text 1315356 1315732 376 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154011 1154711 700 0.1
bss 146644 146804 160 0.1
rodata 145276 145272 -4 -0.0
text 786976 787564 588 0.1
p6 all-clusters-app default (read/write) 2492152 2493544 1392 0.1
.bss 120080 120240 160 0.1
.data 2632 2632 0 0.0
.text 1450416 1451808 1392 0.1
light-app default (read/write) 2396000 2396984 984 0.0
.bss 113544 113704 160 0.1
.data 2488 2488 0 0.0
.text 1354264 1355248 984 0.1
lock-app default (read/write) 2359544 2360304 760 0.0
.bss 113288 113448 160 0.1
.data 2448 2448 0 0.0
.text 1317808 1318568 760 0.1
telink lighting-app tlsr9518adk80d (read/write) 893770 894502 732 0.1
bss 87432 87608 176 0.2
noinit 37160 37160 0 0.0
text 631868 632432 564 0.1

@andy31415
Copy link
Contributor

@bzbarsky-apple - are your comments addressed? The comment history seems to indicate that.

@bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple - are your comments addressed?

Will review tomorrow.

@bzbarsky-apple bzbarsky-apple mentioned this pull request Mar 25, 2022
Merged
bzbarsky-apple
bzbarsky-apple approved these changes Mar 25, 2022
View reviewed changes
examples/ota-provider-app/ota-provider-common/OTAProviderExample.cpp Outdated Show resolved Hide resolved
examples/ota-provider-app/ota-provider-common/OTAProviderExample.cpp Outdated Show resolved Hide resolved
src/app/CommandHandler.cpp Outdated Show resolved Hide resolved
src/app/CommandHandler.cpp Outdated Show resolved Hide resolved
src/app/CommandHandler.h Outdated Show resolved Hide resolved
src/app/clusters/test-cluster-server/test-cluster-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/test-cluster-server/test-cluster-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/test-cluster-server/test-cluster-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/test-cluster-server/test-cluster-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/test-cluster-server/test-cluster-server.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Mar 28, 2022 •
edited
Loading

PR #15906: Size comparison from 58cd5fb to d9c959d

Increases above 0.2%:

platform target config section 58cd5fb d9c959d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 604818 606498 1680 0.3
.app_xip_area 511988 513508 1520 0.3
esp32 all-clusters-app c3devkit (read only) 966138 968488 2350 0.2
.dram0.bss 62000 62176 176 0.3
.flash.text 966138 968488 2350 0.2
m5stack .dram0.bss 67528 67704 176 0.3
linux thermostat-no-ble arm64 (read only) 2273828 2280148 6320 0.3
.data.rel.ro 77000 77240 240 0.3
.text 1910688 1916928 6240 0.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 781660 783664 2004 0.3
telink lighting-app tlsr9518adk80d text 635054 636730 1676 0.3
Increases (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 58cd5fb d9c959d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 604818 606498 1680 0.3
.app_xip_area 511988 513508 1520 0.3
.bss 75576 75736 160 0.2
lock cyw930739m2evb_01 (read/write) 562630 563694 1064 0.2
.app_xip_area 471328 472232 904 0.2
.bss 74080 74240 160 0.2
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574890 575978 1088 0.2
.app_xip_area 473940 474868 928 0.2
.bss 83408 83568 160 0.2
efr32 lighting-app BRD4161A (read only) 925760 926912 1152 0.1
(read/write) 128712 128872 160 0.1
.bss 126712 126872 160 0.1
.text 925752 926904 1152 0.1
BRD4161A+rpc (read only) 954576 955736 1160 0.1
(read/write) 144664 144824 160 0.1
.bss 142488 142648 160 0.1
.text 954568 955728 1160 0.1
window-app BRD4161A (read only) 855180 856028 848 0.1
(read/write) 126672 126832 160 0.1
.bss 124800 124960 160 0.1
.text 855172 856020 848 0.1
esp32 all-clusters-app c3devkit (read only) 966138 968488 2350 0.2
.dram0.bss 62000 62176 176 0.3
.flash.text 966138 968488 2350 0.2
m5stack (read only) 1022583 1023787 1204 0.1
.dram0.bss 67528 67704 176 0.3
.flash.text 1017199 1018403 1204 0.1
k32w light k32w061+release (read/write) 703320 704432 1112 0.2
.bss 77568 77728 160 0.2
.text 618076 619028 952 0.2
lock k32w061+release (read/write) 702436 703524 1088 0.2
.bss 77544 77704 160 0.2
.text 617176 618104 928 0.2
linux chip-tool-ipv6only arm64 (read only) 9813772 9813820 48 0.0
.rodata 493972 493988 16 0.0
.text 8266628 8266660 32 0.0
thermostat-no-ble arm64 (read only) 2273828 2280148 6320 0.3
(read/write) 148353 148593 240 0.2
.data.rel.ro 77000 77240 240 0.3
.text 1910688 1916928 6240 0.3
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2354996 2355700 704 0.0
.bss 184620 184780 160 0.1
.text 1317596 1318300 704 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1141091 1142911 1820 0.2
bss 142500 142660 160 0.1
text 781660 783664 2004 0.3
p6 all-clusters-app default (read/write) 2497544 2499440 1896 0.1
.bss 118040 118200 160 0.1
.text 1455808 1457704 1896 0.1
light-app default (read/write) 2399976 2401128 1152 0.0
.bss 111512 111672 160 0.1
.text 1358240 1359392 1152 0.1
lock-app default (read/write) 2363512 2364368 856 0.0
.bss 111256 111416 160 0.1
.text 1321776 1322632 856 0.1
telink lighting-app tlsr9518adk80d (read/write) 897670 899330 1660 0.2
bss 87356 87532 176 0.2
text 635054 636730 1676 0.3
Decreases (4 builds for esp32, linux, nrfconnect)
platform target config section 58cd5fb d9c959d change % change
esp32 all-clusters-app c3devkit (read/write) 1394306 1394170 -136 -0.0
.flash.rodata 199192 198880 -312 -0.2
m5stack (read/write) 462076 461948 -128 -0.0
.flash.rodata 228688 228384 -304 -0.1
linux thermostat-no-ble arm64 .rodata 139780 139620 -160 -0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 142060 141752 -308 -0.2
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 58cd5fb d9c959d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 604818 606498 1680 0.3
.app_xip_area 511988 513508 1520 0.3
.bss 75576 75736 160 0.2
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 562630 563694 1064 0.2
.app_xip_area 471328 472232 904 0.2
.bss 74080 74240 160 0.2
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574890 575978 1088 0.2
.app_xip_area 473940 474868 928 0.2
.bss 83408 83568 160 0.2
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 925760 926912 1152 0.1
(read/write) 128712 128872 160 0.1
.bss 126712 126872 160 0.1
.data 1996 1996 0 0.0
.text 925752 926904 1152 0.1
BRD4161A+rpc (read only) 954576 955736 1160 0.1
(read/write) 144664 144824 160 0.1
.bss 142488 142648 160 0.1
.data 2176 2176 0 0.0
.text 954568 955728 1160 0.1
window-app BRD4161A (read only) 855180 856028 848 0.1
(read/write) 126672 126832 160 0.1
.bss 124800 124960 160 0.1
.data 1872 1872 0 0.0
.text 855172 856020 848 0.1
esp32 all-clusters-app c3devkit (read only) 966138 968488 2350 0.2
(read/write) 1394306 1394170 -136 -0.0
.dram0.bss 62000 62176 176 0.3
.dram0.data 14204 14204 0 0.0
.flash.rodata 199192 198880 -312 -0.2
.flash.text 966138 968488 2350 0.2
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1022583 1023787 1204 0.1
(read/write) 462076 461948 -128 -0.0
.dram0.bss 67528 67704 176 0.3
.dram0.data 34024 34024 0 0.0
.flash.rodata 228688 228384 -304 -0.1
.flash.text 1017199 1018403 1204 0.1
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 703320 704432 1112 0.2
.bss 77568 77728 160 0.2
.data 1876 1876 0 0.0
.text 618076 619028 952 0.2
lock k32w061+release (read/write) 702436 703524 1088 0.2
.bss 77544 77704 160 0.2
.data 1916 1916 0 0.0
.text 617176 618104 928 0.2
linux chip-tool-ipv6only arm64 (read only) 9813772 9813820 48 0.0
(read/write) 473697 473697 0 0.0
.bss 40737 40737 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372656 372656 0 0.0
.dynamic 560 560 0 0.0
.got 55352 55352 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493972 493988 16 0.0
.text 8266628 8266660 32 0.0
thermostat-no-ble arm64 (read only) 2273828 2280148 6320 0.3
(read/write) 148353 148593 240 0.2
.bss 62801 62801 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77000 77240 240 0.3
.dynamic 560 560 0 0.0
.got 4504 4504 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139780 139620 -160 -0.1
.text 1910688 1916928 6240 0.3
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2354996 2355700 704 0.0
.bss 184620 184780 160 0.1
.data 5760 5760 0 0.0
.text 1317596 1318300 704 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1141091 1142911 1820 0.2
bss 142500 142660 160 0.1
rodata 142060 141752 -308 -0.2
text 781660 783664 2004 0.3
p6 all-clusters-app default (read/write) 2497544 2499440 1896 0.1
.bss 118040 118200 160 0.1
.data 2640 2640 0 0.0
.text 1455808 1457704 1896 0.1
light-app default (read/write) 2399976 2401128 1152 0.0
.bss 111512 111672 160 0.1
.data 2496 2496 0 0.0
.text 1358240 1359392 1152 0.1
lock-app default (read/write) 2363512 2364368 856 0.0
.bss 111256 111416 160 0.1
.data 2456 2456 0 0.0
.text 1321776 1322632 856 0.1
telink lighting-app tlsr9518adk80d (read/write) 897670 899330 1660 0.2
bss 87356 87532 176 0.2
noinit 37160 37160 0 0.0
text 635054 636730 1676 0.3

@github-actions
Copy link

github-actions bot commented Mar 28, 2022 •
edited
Loading

PR #15906: Size comparison from 58cd5fb to 7be9a8d

Increases above 0.2%:

platform target config section 58cd5fb 7be9a8d9 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 604818 607098 2280 0.4
.app_xip_area 511988 513868 1880 0.4
.bss 75576 75976 400 0.5
lock cyw930739m2evb_01 (read/write) 562630 564302 1672 0.3
.app_xip_area 471328 472600 1272 0.3
.bss 74080 74480 400 0.5
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574890 576586 1696 0.3
.app_xip_area 473940 475236 1296 0.3
.bss 83408 83808 400 0.5
efr32 lighting-app BRD4161A (read/write) 128712 129112 400 0.3
.bss 126712 127112 400 0.3
BRD4161A+rpc (read/write) 144664 145064 400 0.3
.bss 142488 142888 400 0.3
window-app BRD4161A (read/write) 126672 127072 400 0.3
.bss 124800 125200 400 0.3
esp32 all-clusters-app c3devkit (read only) 966138 969076 2938 0.3
.dram0.bss 62000 62416 416 0.7
.flash.text 966138 969076 2938 0.3
m5stack .dram0.bss 67528 67944 416 0.6
k32w light k32w061+release (read/write) 703320 705368 2048 0.3
.bss 77568 77968 400 0.5
.text 618076 619724 1648 0.3
lock k32w061+release (read/write) 702436 704460 2024 0.3
.bss 77544 77944 400 0.5
.text 617176 618800 1624 0.3
linux thermostat-no-ble arm64 (read only) 2273828 2281492 7664 0.3
.data.rel.ro 77000 77240 240 0.3
.text 1910688 1918016 7328 0.4
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1141091 1145203 4112 0.4
bss 142500 143052 552 0.4
text 781660 785240 3580 0.5
p6 all-clusters-app default .bss 118040 118440 400 0.3
light-app default .bss 111512 111912 400 0.4
lock-app default .bss 111256 111656 400 0.4
telink lighting-app tlsr9518adk80d (read/write) 897670 900410 2740 0.3
bss 87356 87772 416 0.5
text 635054 637312 2258 0.4
Increases (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 58cd5fb 7be9a8d9 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 604818 607098 2280 0.4
.app_xip_area 511988 513868 1880 0.4
.bss 75576 75976 400 0.5
lock cyw930739m2evb_01 (read/write) 562630 564302 1672 0.3
.app_xip_area 471328 472600 1272 0.3
.bss 74080 74480 400 0.5
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574890 576586 1696 0.3
.app_xip_area 473940 475236 1296 0.3
.bss 83408 83808 400 0.5
efr32 lighting-app BRD4161A (read only) 925760 927752 1992 0.2
(read/write) 128712 129112 400 0.3
.bss 126712 127112 400 0.3
.text 925752 927744 1992 0.2
BRD4161A+rpc (read only) 954576 956576 2000 0.2
(read/write) 144664 145064 400 0.3
.bss 142488 142888 400 0.3
.text 954568 956568 2000 0.2
window-app BRD4161A (read only) 855180 856868 1688 0.2
(read/write) 126672 127072 400 0.3
.bss 124800 125200 400 0.3
.text 855172 856860 1688 0.2
esp32 all-clusters-app c3devkit (read only) 966138 969076 2938 0.3
(read/write) 1394306 1394674 368 0.0
.dram0.bss 62000 62416 416 0.7
.flash.text 966138 969076 2938 0.3
m5stack (read only) 1022583 1024367 1784 0.2
(read/write) 462076 462444 368 0.1
.dram0.bss 67528 67944 416 0.6
.flash.text 1017199 1018983 1784 0.2
k32w light k32w061+release (read/write) 703320 705368 2048 0.3
.bss 77568 77968 400 0.5
.text 618076 619724 1648 0.3
lock k32w061+release (read/write) 702436 704460 2024 0.3
.bss 77544 77944 400 0.5
.text 617176 618800 1624 0.3
linux chip-tool-ipv6only arm64 (read only) 9813772 9815596 1824 0.0
.rodata 493972 494228 256 0.1
.text 8266628 8268196 1568 0.0
thermostat-no-ble arm64 (read only) 2273828 2281492 7664 0.3
(read/write) 148353 148609 256 0.2
.bss 62801 62817 16 0.0
.data.rel.ro 77000 77240 240 0.3
.rodata 139780 139876 96 0.1
.text 1910688 1918016 7328 0.4
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2354996 2356412 1416 0.1
.bss 184620 185020 400 0.2
.text 1317596 1319012 1416 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1141091 1145203 4112 0.4
bss 142500 143052 552 0.4
text 781660 785240 3580 0.5
p6 all-clusters-app default (read/write) 2497544 2500280 2736 0.1
.bss 118040 118440 400 0.3
.text 1455808 1458544 2736 0.2
light-app default (read/write) 2399976 2401968 1992 0.1
.bss 111512 111912 400 0.4
.text 1358240 1360232 1992 0.1
lock-app default (read/write) 2363512 2365208 1696 0.1
.bss 111256 111656 400 0.4
.text 1321776 1323472 1696 0.1
telink lighting-app tlsr9518adk80d (read/write) 897670 900410 2740 0.3
bss 87356 87772 416 0.5
text 635054 637312 2258 0.4
Decreases (2 builds for esp32)
platform target config section 58cd5fb 7be9a8d9 change % change
esp32 all-clusters-app c3devkit .flash.rodata 199192 199144 -48 -0.0
m5stack .flash.rodata 228688 228640 -48 -0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 58cd5fb 7be9a8d9 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 604818 607098 2280 0.4
.app_xip_area 511988 513868 1880 0.4
.bss 75576 75976 400 0.5
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 562630 564302 1672 0.3
.app_xip_area 471328 472600 1272 0.3
.bss 74080 74480 400 0.5
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574890 576586 1696 0.3
.app_xip_area 473940 475236 1296 0.3
.bss 83408 83808 400 0.5
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 925760 927752 1992 0.2
(read/write) 128712 129112 400 0.3
.bss 126712 127112 400 0.3
.data 1996 1996 0 0.0
.text 925752 927744 1992 0.2
BRD4161A+rpc (read only) 954576 956576 2000 0.2
(read/write) 144664 145064 400 0.3
.bss 142488 142888 400 0.3
.data 2176 2176 0 0.0
.text 954568 956568 2000 0.2
window-app BRD4161A (read only) 855180 856868 1688 0.2
(read/write) 126672 127072 400 0.3
.bss 124800 125200 400 0.3
.data 1872 1872 0 0.0
.text 855172 856860 1688 0.2
esp32 all-clusters-app c3devkit (read only) 966138 969076 2938 0.3
(read/write) 1394306 1394674 368 0.0
.dram0.bss 62000 62416 416 0.7
.dram0.data 14204 14204 0 0.0
.flash.rodata 199192 199144 -48 -0.0
.flash.text 966138 969076 2938 0.3
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1022583 1024367 1784 0.2
(read/write) 462076 462444 368 0.1
.dram0.bss 67528 67944 416 0.6
.dram0.data 34024 34024 0 0.0
.flash.rodata 228688 228640 -48 -0.0
.flash.text 1017199 1018983 1784 0.2
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 703320 705368 2048 0.3
.bss 77568 77968 400 0.5
.data 1876 1876 0 0.0
.text 618076 619724 1648 0.3
lock k32w061+release (read/write) 702436 704460 2024 0.3
.bss 77544 77944 400 0.5
.data 1916 1916 0 0.0
.text 617176 618800 1624 0.3
linux chip-tool-ipv6only arm64 (read only) 9813772 9815596 1824 0.0
(read/write) 473697 473697 0 0.0
.bss 40737 40737 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372656 372656 0 0.0
.dynamic 560 560 0 0.0
.got 55352 55352 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493972 494228 256 0.1
.text 8266628 8268196 1568 0.0
thermostat-no-ble arm64 (read only) 2273828 2281492 7664 0.3
(read/write) 148353 148609 256 0.2
.bss 62801 62817 16 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77000 77240 240 0.3
.dynamic 560 560 0 0.0
.got 4504 4504 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139780 139876 96 0.1
.text 1910688 1918016 7328 0.4
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2354996 2356412 1416 0.1
.bss 184620 185020 400 0.2
.data 5760 5760 0 0.0
.text 1317596 1319012 1416 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1141091 1145203 4112 0.4
bss 142500 143052 552 0.4
rodata 142060 142060 0 0.0
text 781660 785240 3580 0.5
p6 all-clusters-app default (read/write) 2497544 2500280 2736 0.1
.bss 118040 118440 400 0.3
.data 2640 2640 0 0.0
.text 1455808 1458544 2736 0.2
light-app default (read/write) 2399976 2401968 1992 0.1
.bss 111512 111912 400 0.4
.data 2496 2496 0 0.0
.text 1358240 1360232 1992 0.1
lock-app default (read/write) 2363512 2365208 1696 0.1
.bss 111256 111656 400 0.4
.data 2456 2456 0 0.0
.text 1321776 1323472 1696 0.1
telink lighting-app tlsr9518adk80d (read/write) 897670 900410 2740 0.3
bss 87356 87772 416 0.5
noinit 37160 37160 0 0.0
text 635054 637312 2258 0.4

bzbarsky-apple
bzbarsky-apple reviewed Mar 28, 2022
View reviewed changes
src/app/CommandHandler.cpp Outdated Show resolved Hide resolved
src/app/CommandHandler.h Outdated Show resolved Hide resolved
src/app/CommandHandler.h Outdated Show resolved Hide resolved
src/app/CommandHandler.h Outdated Show resolved Hide resolved
src/app/clusters/groups-server/groups-server.cpp Show resolved Hide resolved
@bzbarsky-apple bzbarsky-apple merged commit 8da5d03 into project-chip:master Mar 29, 2022
rochaferraz pushed a commit to rochaferraz/connectedhomeip that referenced this pull request Mar 31, 2022
@erjiaqing @rochaferraz
[IM] Make CommandHandler::AddResponseData atomic (project-chip#15906)
f0ef0b1 
* Add encode failure tests

* [IM] Make CommandHandler::AddResponseData atomic

* Reset -> Rollback

* Rename: AddResponseData -> AddResponse

* Address comments

* Update cluster code

* 50 ms is too short on CI

* Fix

* Fix
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@erjiaqing @andrei-menzopol
[IM] Make CommandHandler::AddResponseData atomic (project-chip#15906)
e01184a 
* Add encode failure tests

* [IM] Make CommandHandler::AddResponseData atomic

* Reset -> Rollback

* Rename: AddResponseData -> AddResponse

* Address comments

* Update cluster code

* 50 ms is too short on CI

* Fix

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns left review comments

@woody-apple woody-apple woody-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app controller examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix error-handling around AddResponseData
6 participants
@erjiaqing @andy31415 @bzbarsky-apple @mrjerryjohns @yunhanw-google @woody-apple