Stop using the immediate default response bits in OTA provider.

[bzbarsky-apple]

Problem

The OTA Provider cluster is using emberAfSendImmediateDefaultResponse, which uses ambient state, instead of just using the arguments it's passed to send responses. This requires that ambient state to be maintained, which we would like to stop doing.

Change overview

Stop calling emberAfSendImmediateDefaultResponse and call AddStatus on the command handler instead.

Testing

No behavior changes.

[github-actions]

PR #15885: Size comparison from 4f47a33 to 97eba62

Increases (3 builds for linux)

platform	target	config	section	4f47a33	97eba62	change	% change
linux	ota-provider-app	debug	(read only)	1877225	1877545	320	0.0
			.text	1567618	1567938	320	0.0
	thermostat-no-ble	arm64	(read only)	2173748	2173860	112	0.0
			.text	1822352	1822464	112	0.0
	tv-app	debug	(read only)	2616625	2616929	304	0.0
			.text	2243074	2243378	304	0.0

Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	4f47a33	97eba62	change	% change
cyw30739	light	cyw930739m2evb_01	(read/write)	601438	601438	0	0.0
			.app_xip_area	505980	505980	0	0.0
			.bss	78140	78140	0	0.0
			.data	660	660	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	lock	cyw930739m2evb_01	(read/write)	559414	559414	0	0.0
			.app_xip_area	465492	465492	0	0.0
			.bss	76644	76644	0	0.0
			.data	624	624	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	ota-requestor	cyw930739m2evb_01	(read/write)	581370	581370	0	0.0
			.app_xip_area	477776	477776	0	0.0
			.bss	85964	85964	0	0.0
			.data	592	592	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
efr32	lighting-app	BRD4161A	(read only)	920148	920148	0	0.0
			(read/write)	128832	128832	0	0.0
			.bss	126752	126752	0	0.0
			.data	2080	2080	0	0.0
			.text	920140	920140	0	0.0
		BRD4161A+rpc	(read only)	948960	948960	0	0.0
			(read/write)	144792	144792	0	0.0
			.bss	142528	142528	0	0.0
			.data	2260	2260	0	0.0
			.text	948952	948952	0	0.0
	lock-app	BRD4161A+wf200	(read only)	988380	988380	0	0.0
			(read/write)	120360	120360	0	0.0
			.bss	118428	118428	0	0.0
			.data	1932	1932	0	0.0
			.text	988372	988372	0	0.0
	window-app	BRD4161A	(read only)	853456	853456	0	0.0
			(read/write)	126832	126832	0	0.0
			.bss	124904	124904	0	0.0
			.data	1924	1924	0	0.0
			.text	853448	853448	0	0.0
esp32	all-clusters-app	c3devkit	(read only)	957122	957122	0	0.0
			(read/write)	1393570	1393570	0	0.0
			.dram0.bss	63424	63424	0	0.0
			.dram0.data	14236	14236	0	0.0
			.flash.rodata	197000	197000	0	0.0
			.flash.text	957122	957122	0	0.0
			.iram0.text	62016	62016	0	0.0
		m5stack	(read only)	1011831	1011831	0	0.0
			(read/write)	460684	460684	0	0.0
			.dram0.bss	68952	68952	0	0.0
			.dram0.data	34080	34080	0	0.0
			.flash.rodata	225816	225816	0	0.0
			.flash.text	1006447	1006447	0	0.0
			.iram0.text	123107	123107	0	0.0
k32w	light	k32w061+release	(read/write)	694204	694204	0	0.0
			.bss	77688	77688	0	0.0
			.data	1964	1964	0	0.0
			.text	608752	608752	0	0.0
	lock	k32w061+release	(read/write)	696032	696032	0	0.0
			.bss	77664	77664	0	0.0
			.data	1972	1972	0	0.0
			.text	610596	610596	0	0.0
linux	all-clusters-app	debug	(read only)	2424961	2424961	0	0.0
			(read/write)	145656	145656	0	0.0
			.bss	60128	60128	0	0.0
			.data	1392	1392	0	0.0
			.data.rel.ro	78408	78408	0	0.0
			.dynamic	592	592	0	0.0
			.got	4176	4176	0	0.0
			.init	27	27	0	0.0
			.init_array	912	912	0	0.0
			.rodata	205381	205381	0	0.0
			.text	2056594	2056594	0	0.0
	bridge-app	debug+rpc	(read only)	1730381	1730381	0	0.0
			(read/write)	92624	92624	0	0.0
			.bss	47432	47432	0	0.0
			.data	2048	2048	0	0.0
			.data.rel.ro	38056	38056	0	0.0
			.dynamic	592	592	0	0.0
			.got	3928	3928	0	0.0
			.init	27	27	0	0.0
			.init_array	544	544	0	0.0
			.rodata	141684	141684	0	0.0
			.text	1472677	1472677	0	0.0
	chip-tool	debug	(read only)	9535229	9535229	0	0.0
			(read/write)	330608	330608	0	0.0
			.bss	25536	25536	0	0.0
			.data	1136	1136	0	0.0
			.data.rel.ro	297888	297888	0	0.0
			.dynamic	608	608	0	0.0
			.got	4776	4776	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	499477	499477	0	0.0
			.text	8314021	8314021	0	0.0
	chip-tool-ipv6only	arm64	(read only)	9221908	9221908	0	0.0
			(read/write)	443473	443473	0	0.0
			.bss	43841	43841	0	0.0
			.data	1192	1192	0	0.0
			.data.rel.ro	342696	342696	0	0.0
			.dynamic	560	560	0	0.0
			.got	51952	51952	0	0.0
			.init	24	24	0	0.0
			.init_array	192	192	0	0.0
			.rodata	475260	475260	0	0.0
			.text	7767892	7767892	0	0.0
	door-lock-app	debug	(read only)	1944689	1944689	0	0.0
			(read/write)	119072	119072	0	0.0
			.bss	50432	50432	0	0.0
			.data	1056	1056	0	0.0
			.data.rel.ro	62184	62184	0	0.0
			.dynamic	592	592	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	664	664	0	0.0
			.rodata	173596	173596	0	0.0
			.text	1622402	1622402	0	0.0
	lighting-app	debug+rpc	(read only)	2076337	2076337	0	0.0
			(read/write)	124368	124368	0	0.0
			.bss	51264	51264	0	0.0
			.data	1536	1536	0	0.0
			.data.rel.ro	66088	66088	0	0.0
			.dynamic	608	608	0	0.0
			.got	4144	4144	0	0.0
			.init	27	27	0	0.0
			.init_array	712	712	0	0.0
			.rodata	165692	165692	0	0.0
			.text	1755010	1755010	0	0.0
	ota-provider-app	debug	(read only)	1877225	1877545	320	0.0
			(read/write)	114704	114704	0	0.0
			.bss	50240	50240	0	0.0
			.data	1352	1352	0	0.0
			.data.rel.ro	57464	57464	0	0.0
			.dynamic	608	608	0	0.0
			.got	4368	4368	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	158835	158835	0	0.0
			.text	1567618	1567938	320	0.0
	ota-requestor-app	debug	(read only)	1898705	1898705	0	0.0
			(read/write)	117408	117408	0	0.0
			.bss	51296	51296	0	0.0
			.data	1512	1512	0	0.0
			.data.rel.ro	59160	59160	0	0.0
			.dynamic	592	592	0	0.0
			.got	4160	4160	0	0.0
			.init	27	27	0	0.0
			.init_array	632	632	0	0.0
			.rodata	153996	153996	0	0.0
			.text	1594626	1594626	0	0.0
	shell	debug	(read only)	2391729	2391729	0	0.0
			(read/write)	149904	149904	0	0.0
			.bss	70216	70216	0	0.0
			.data	864	864	0	0.0
			.data.rel.ro	73144	73144	0	0.0
			.dynamic	592	592	0	0.0
			.got	4160	4160	0	0.0
			.init	27	27	0	0.0
			.init_array	896	896	0	0.0
			.rodata	205330	205330	0	0.0
			.text	2029634	2029634	0	0.0
	thermostat-no-ble	arm64	(read only)	2173748	2173860	112	0.0
			(read/write)	148513	148513	0	0.0
			.bss	65201	65201	0	0.0
			.data	1072	1072	0	0.0
			.data.rel.ro	75048	75048	0	0.0
			.dynamic	560	560	0	0.0
			.got	4216	4216	0	0.0
			.init	24	24	0	0.0
			.init_array	352	352	0	0.0
			.rodata	132964	132964	0	0.0
			.text	1822352	1822464	112	0.0
	tv-app	debug	(read only)	2616625	2616929	304	0.0
			(read/write)	250776	250776	0	0.0
			.bss	167936	167936	0	0.0
			.data	3200	3200	0	0.0
			.data.rel.ro	73616	73616	0	0.0
			.dynamic	592	592	0	0.0
			.got	4544	4544	0	0.0
			.init	27	27	0	0.0
			.init_array	880	880	0	0.0
			.rodata	199389	199389	0	0.0
			.text	2243074	2243378	304	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2350324	2350324	0	0.0
			.bss	186076	186076	0	0.0
			.data	5800	5800	0	0.0
			.text	1312924	1312924	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1151135	1151135	0	0.0
			bss	146776	146776	0	0.0
			rodata	144248	144248	0	0.0
			text	784896	784896	0	0.0
p6	all-clusters-app	default	(read/write)	2493552	2493552	0	0.0
			.bss	119496	119496	0	0.0
			.data	2696	2696	0	0.0
			.text	1451816	1451816	0	0.0
	light-app	default	(read/write)	2397016	2397016	0	0.0
			.bss	112968	112968	0	0.0
			.data	2544	2544	0	0.0
			.text	1355280	1355280	0	0.0
	lock-app	default	(read/write)	2360480	2360480	0	0.0
			.bss	112712	112712	0	0.0
			.data	2504	2504	0	0.0
			.text	1318744	1318744	0	0.0
qpg	lighting-app	qpg6105+debug	(read only)	603396	603396	0	0.0
			(read/write)	146936	146936	0	0.0
			.bss	91064	91064	0	0.0
			.data	1164	1164	0	0.0
			.text	598076	598076	0	0.0
	lock-app	qpg6105+debug	(read only)	569056	569056	0	0.0
			(read/write)	146936	146936	0	0.0
			.bss	91072	91072	0	0.0
			.data	1116	1116	0	0.0
			.text	563736	563736	0	0.0
	persistent-storage-app	qpg6105+debug	(read only)	99520	99520	0	0.0
			(read/write)	146940	146940	0	0.0
			.bss	24004	24004	0	0.0
			.data	176	176	0	0.0
			.text	94200	94200	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	888466	888466	0	0.0
			bss	86920	86920	0	0.0
			noinit	37160	37160	0	0.0
			text	627864	627864	0	0.0