Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data race in GenericPlatformManagerImpl_POSIX.ipp #1588

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Fix data race in GenericPlatformManagerImpl_POSIX.ipp #1588

merged 2 commits into from
Jul 14, 2020

Conversation

mspang
Copy link
Contributor

@mspang mspang commented Jul 14, 2020

The mShouldRunEventLoop member variable is used for cross thread
communication without synchronization. This is a data race unless an
atomic variable is used. Make it so.

Noticed while fixing #1584.

@mspang
Fix data race in GenericPlatformManagerImpl_POSIX.ipp
dc47451 
The mShouldRunEventLoop member variable is used for cross thread
communication without synchronization. This is a data race unless an
atomic variable is used. Make it so.
@restyled-io restyled-io bot mentioned this pull request Jul 14, 2020
Closed
@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize

@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize

@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize

turon
turon approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@turon turon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@woody-apple woody-apple merged commit 4bd83a5 into project-chip:master Jul 14, 2020
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
@mspang @restyled-commits @kedars
Fix data race in GenericPlatformManagerImpl_POSIX.ipp (project-chip#1588
a531b3e 
)

* Fix data race in GenericPlatformManagerImpl_POSIX.ipp

The mShouldRunEventLoop member variable is used for cross thread
communication without synchronization. This is a data race unless an
atomic variable is used. Make it so.

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
@mspang @restyled-commits @kedars
Fix data race in GenericPlatformManagerImpl_POSIX.ipp (project-chip#1588
ec130d6 
)

* Fix data race in GenericPlatformManagerImpl_POSIX.ipp

The mShouldRunEventLoop member variable is used for cross thread
communication without synchronization. This is a data race unless an
atomic variable is used. Make it so.

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
@mspang @restyled-commits @kedars
Fix data race in GenericPlatformManagerImpl_POSIX.ipp (project-chip#1588
7cba458 
)

* Fix data race in GenericPlatformManagerImpl_POSIX.ipp

The mShouldRunEventLoop member variable is used for cross thread
communication without synchronization. This is a data race unless an
atomic variable is used. Make it so.

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
@mspang @restyled-commits @kedars
Fix data race in GenericPlatformManagerImpl_POSIX.ipp (project-chip#1588
d5e7d30 
)

* Fix data race in GenericPlatformManagerImpl_POSIX.ipp

The mShouldRunEventLoop member variable is used for cross thread
communication without synchronization. This is a data race unless an
atomic variable is used. Make it so.

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
@mspang @restyled-commits @kedars
Fix data race in GenericPlatformManagerImpl_POSIX.ipp (project-chip#1588
7cf0d80 
)

* Fix data race in GenericPlatformManagerImpl_POSIX.ipp

The mShouldRunEventLoop member variable is used for cross thread
communication without synchronization. This is a data race unless an
atomic variable is used. Make it so.

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
@mspang mspang deleted the for-chip/race branch August 14, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turon turon turon approved these changes

@andy31415 andy31415 andy31415 approved these changes

@saurabhst saurabhst saurabhst approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mspang @turon @andy31415 @saurabhst @woody-apple @restyled-commits