Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Darwin methods to use attribute cache #15877

Merged
merged 1 commit into from
Mar 5, 2022
Merged

Add Darwin methods to use attribute cache #15877

merged 1 commit into from
Mar 5, 2022

Conversation

kpark-apple
Copy link
Contributor

Problem

  • Enables use of attribute cache in Darwin platform.

Change overview

  • Define new object CHIPAttributeCacheContainer
    to represent cache per node
  • Add new method to Darwin cluster library template
    to read attribute from cache object
  • Add a method in the cache object to read attribute
    with generic path
  • Add XPC protocol to support new method
  • Fix CHIPDevice subscription handling errors and
    automatic resubscription by replacing callback bridge
    with implementation which can handle errors and by
    retaining attribute path object.
  • Implement deregistering CHIPDevice subscriptions
    in order to support testing with clean states.

Testing

  • Unit tests were added to test new XPC methods.
  • Integration tests were added to test new object working with the underlying AttributeCache class.

@boring-cyborg boring-cyborg bot added the darwin label Mar 4, 2022
@kpark-apple kpark-apple mentioned this pull request Mar 4, 2022
Merged
@github-actions
Copy link

github-actions bot commented Mar 4, 2022 •
edited
Loading

PR #15877: Size comparison from 2ecc827 to 2750b65

Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 2ecc827 2750b65c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601498 601498 0 0.0
.app_xip_area 506040 506040 0 0.0
.bss 78140 78140 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559418 559418 0 0.0
.app_xip_area 465496 465496 0 0.0
.bss 76644 76644 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581374 581374 0 0.0
.app_xip_area 477780 477780 0 0.0
.bss 85964 85964 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920212 920212 0 0.0
(read/write) 128832 128832 0 0.0
.bss 126752 126752 0 0.0
.data 2080 2080 0 0.0
.text 920204 920204 0 0.0
BRD4161A+rpc (read only) 949024 949024 0 0.0
(read/write) 144792 144792 0 0.0
.bss 142528 142528 0 0.0
.data 2260 2260 0 0.0
.text 949016 949016 0 0.0
lock-app BRD4161A+wf200 (read only) 988396 988396 0 0.0
(read/write) 120360 120360 0 0.0
.bss 118428 118428 0 0.0
.data 1932 1932 0 0.0
.text 988388 988388 0 0.0
window-app BRD4161A (read only) 853472 853472 0 0.0
(read/write) 126832 126832 0 0.0
.bss 124904 124904 0 0.0
.data 1924 1924 0 0.0
.text 853464 853464 0 0.0
esp32 all-clusters-app c3devkit (read only) 957178 957178 0 0.0
(read/write) 1393570 1393570 0 0.0
.dram0.bss 63424 63424 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197000 197000 0 0.0
.flash.text 957178 957178 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1011927 1011927 0 0.0
(read/write) 460684 460684 0 0.0
.dram0.bss 68952 68952 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225816 225816 0 0.0
.flash.text 1006543 1006543 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694204 694204 0 0.0
.bss 77688 77688 0 0.0
.data 1964 1964 0 0.0
.text 608752 608752 0 0.0
lock k32w061+release (read/write) 696032 696032 0 0.0
.bss 77664 77664 0 0.0
.data 1972 1972 0 0.0
.text 610596 610596 0 0.0
linux all-clusters-app debug (read only) 2425537 2425537 0 0.0
(read/write) 145656 145656 0 0.0
.bss 60128 60128 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78408 78408 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 205477 205477 0 0.0
.text 2057074 2057074 0 0.0
bridge-app debug+rpc (read only) 1730429 1730429 0 0.0
(read/write) 92624 92624 0 0.0
.bss 47432 47432 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38056 38056 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141684 141684 0 0.0
.text 1472725 1472725 0 0.0
chip-tool debug (read only) 9535117 9535117 0 0.0
(read/write) 330608 330608 0 0.0
.bss 25536 25536 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 297888 297888 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 499381 499381 0 0.0
.text 8314005 8314005 0 0.0
chip-tool-ipv6only arm64 (read only) 9221684 9221684 0 0.0
(read/write) 443473 443473 0 0.0
.bss 43841 43841 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 342696 342696 0 0.0
.dynamic 560 560 0 0.0
.got 51952 51952 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 475196 475196 0 0.0
.text 7767732 7767732 0 0.0
door-lock-app debug (read only) 1944737 1944737 0 0.0
(read/write) 119072 119072 0 0.0
.bss 50432 50432 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173596 173596 0 0.0
.text 1622450 1622450 0 0.0
lighting-app debug+rpc (read only) 2076929 2076929 0 0.0
(read/write) 124368 124368 0 0.0
.bss 51264 51264 0 0.0
.data 1536 1536 0 0.0
.data.rel.ro 66088 66088 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 165788 165788 0 0.0
.text 1755506 1755506 0 0.0
ota-provider-app debug (read only) 1877273 1877273 0 0.0
(read/write) 114704 114704 0 0.0
.bss 50240 50240 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158835 158835 0 0.0
.text 1567666 1567666 0 0.0
ota-requestor-app debug (read only) 1898753 1898753 0 0.0
(read/write) 117408 117408 0 0.0
.bss 51296 51296 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 59160 59160 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 153996 153996 0 0.0
.text 1594674 1594674 0 0.0
shell debug (read only) 2392321 2392321 0 0.0
(read/write) 149904 149904 0 0.0
.bss 70216 70216 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73144 73144 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 205426 205426 0 0.0
.text 2030130 2030130 0 0.0
thermostat-no-ble arm64 (read only) 2173812 2173812 0 0.0
(read/write) 148513 148513 0 0.0
.bss 65201 65201 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75048 75048 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132964 132964 0 0.0
.text 1822416 1822416 0 0.0
tv-app debug (read only) 2615457 2615457 0 0.0
(read/write) 250776 250776 0 0.0
.bss 167936 167936 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73616 73616 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199453 199453 0 0.0
.text 2241842 2241842 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350324 2350324 0 0.0
.bss 186076 186076 0 0.0
.data 5800 5800 0 0.0
.text 1312924 1312924 0 0.0
p6 all-clusters-app default (read/write) 2493616 2493616 0 0.0
.bss 119496 119496 0 0.0
.data 2696 2696 0 0.0
.text 1451880 1451880 0 0.0
light-app default (read/write) 2397080 2397080 0 0.0
.bss 112968 112968 0 0.0
.data 2544 2544 0 0.0
.text 1355344 1355344 0 0.0
lock-app default (read/write) 2360512 2360512 0 0.0
.bss 112712 112712 0 0.0
.data 2504 2504 0 0.0
.text 1318776 1318776 0 0.0
qpg lighting-app qpg6105+debug (read only) 603444 603444 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91064 91064 0 0.0
.data 1164 1164 0 0.0
.text 598124 598124 0 0.0
lock-app qpg6105+debug (read only) 569064 569064 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91072 91072 0 0.0
.data 1116 1116 0 0.0
.text 563744 563744 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888522 888522 0 0.0
bss 86920 86920 0 0.0
noinit 37160 37160 0 0.0
text 627914 627914 0 0.0

woody-apple
woody-apple approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking platform changes.

@kpark-apple kpark-apple marked this pull request as ready for review March 4, 2022 20:57
@woody-apple
Copy link
Contributor

/rebase

@kpark-apple
Add Darwin methods to use attribute cache
8b5d9cc 
* Define new object CHIPAttributeCacheContainer
  to represent cache per node
* Add new method to Darwin cluster library template
  to read attribute from cache object
* Add a method in the cache object to read attribute
  with generic path
* Add XPC protocol to support new method
* Fix CHIPDevice subscription handling errors and
  automatic resubscription by replacing callback bridge
  with implementation which can handle errors and by
  retaining attribute path object.
* Implement deregistering CHIPDevice subscriptions
  in order to support testing with clean states.
@kpark-apple kpark-apple force-pushed the dev/kpark/20220225-attrib-cache branch from 2750b65 to 8b5d9cc Compare March 4, 2022 23:59
@github-actions
Copy link

github-actions bot commented Mar 5, 2022 •
edited
Loading

PR #15877: Size comparison from 4f47a33 to 8b5d9cc

Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 4f47a33 8b5d9cc change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601438 601438 0 0.0
.app_xip_area 505980 505980 0 0.0
.bss 78140 78140 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559414 559414 0 0.0
.app_xip_area 465492 465492 0 0.0
.bss 76644 76644 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581370 581370 0 0.0
.app_xip_area 477776 477776 0 0.0
.bss 85964 85964 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920148 920148 0 0.0
(read/write) 128832 128832 0 0.0
.bss 126752 126752 0 0.0
.data 2080 2080 0 0.0
.text 920140 920140 0 0.0
BRD4161A+rpc (read only) 948960 948960 0 0.0
(read/write) 144792 144792 0 0.0
.bss 142528 142528 0 0.0
.data 2260 2260 0 0.0
.text 948952 948952 0 0.0
lock-app BRD4161A+wf200 (read only) 988380 988380 0 0.0
(read/write) 120360 120360 0 0.0
.bss 118428 118428 0 0.0
.data 1932 1932 0 0.0
.text 988372 988372 0 0.0
window-app BRD4161A (read only) 853456 853456 0 0.0
(read/write) 126832 126832 0 0.0
.bss 124904 124904 0 0.0
.data 1924 1924 0 0.0
.text 853448 853448 0 0.0
esp32 all-clusters-app c3devkit (read only) 957122 957122 0 0.0
(read/write) 1393570 1393570 0 0.0
.dram0.bss 63424 63424 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197000 197000 0 0.0
.flash.text 957122 957122 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1011831 1011831 0 0.0
(read/write) 460684 460684 0 0.0
.dram0.bss 68952 68952 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225816 225816 0 0.0
.flash.text 1006447 1006447 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694204 694204 0 0.0
.bss 77688 77688 0 0.0
.data 1964 1964 0 0.0
.text 608752 608752 0 0.0
lock k32w061+release (read/write) 696032 696032 0 0.0
.bss 77664 77664 0 0.0
.data 1972 1972 0 0.0
.text 610596 610596 0 0.0
linux all-clusters-app debug (read only) 2424961 2424961 0 0.0
(read/write) 145656 145656 0 0.0
.bss 60128 60128 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78408 78408 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 205381 205381 0 0.0
.text 2056594 2056594 0 0.0
bridge-app debug+rpc (read only) 1730381 1730381 0 0.0
(read/write) 92624 92624 0 0.0
.bss 47432 47432 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38056 38056 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141684 141684 0 0.0
.text 1472677 1472677 0 0.0
chip-tool debug (read only) 9535229 9535229 0 0.0
(read/write) 330608 330608 0 0.0
.bss 25536 25536 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 297888 297888 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 499477 499477 0 0.0
.text 8314021 8314021 0 0.0
chip-tool-ipv6only arm64 (read only) 9221908 9221908 0 0.0
(read/write) 443473 443473 0 0.0
.bss 43841 43841 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 342696 342696 0 0.0
.dynamic 560 560 0 0.0
.got 51952 51952 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 475260 475260 0 0.0
.text 7767892 7767892 0 0.0
door-lock-app debug (read only) 1944689 1944689 0 0.0
(read/write) 119072 119072 0 0.0
.bss 50432 50432 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173596 173596 0 0.0
.text 1622402 1622402 0 0.0
lighting-app debug+rpc (read only) 2076337 2076337 0 0.0
(read/write) 124368 124368 0 0.0
.bss 51264 51264 0 0.0
.data 1536 1536 0 0.0
.data.rel.ro 66088 66088 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 165692 165692 0 0.0
.text 1755010 1755010 0 0.0
ota-provider-app debug (read only) 1877225 1877225 0 0.0
(read/write) 114704 114704 0 0.0
.bss 50240 50240 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158835 158835 0 0.0
.text 1567618 1567618 0 0.0
ota-requestor-app debug (read only) 1898705 1898705 0 0.0
(read/write) 117408 117408 0 0.0
.bss 51296 51296 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 59160 59160 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 153996 153996 0 0.0
.text 1594626 1594626 0 0.0
shell debug (read only) 2391729 2391729 0 0.0
(read/write) 149904 149904 0 0.0
.bss 70216 70216 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73144 73144 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 205330 205330 0 0.0
.text 2029634 2029634 0 0.0
thermostat-no-ble arm64 (read only) 2173748 2173748 0 0.0
(read/write) 148513 148513 0 0.0
.bss 65201 65201 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75048 75048 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132964 132964 0 0.0
.text 1822352 1822352 0 0.0
tv-app debug (read only) 2616625 2616625 0 0.0
(read/write) 250776 250776 0 0.0
.bss 167936 167936 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73616 73616 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199389 199389 0 0.0
.text 2243074 2243074 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350324 2350324 0 0.0
.bss 186076 186076 0 0.0
.data 5800 5800 0 0.0
.text 1312924 1312924 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151135 1151135 0 0.0
bss 146776 146776 0 0.0
rodata 144248 144248 0 0.0
text 784896 784896 0 0.0
p6 all-clusters-app default (read/write) 2493552 2493552 0 0.0
.bss 119496 119496 0 0.0
.data 2696 2696 0 0.0
.text 1451816 1451816 0 0.0
light-app default (read/write) 2397016 2397016 0 0.0
.bss 112968 112968 0 0.0
.data 2544 2544 0 0.0
.text 1355280 1355280 0 0.0
lock-app default (read/write) 2360480 2360480 0 0.0
.bss 112712 112712 0 0.0
.data 2504 2504 0 0.0
.text 1318744 1318744 0 0.0
qpg lighting-app qpg6105+debug (read only) 603396 603396 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91064 91064 0 0.0
.data 1164 1164 0 0.0
.text 598076 598076 0 0.0
lock-app qpg6105+debug (read only) 569056 569056 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91072 91072 0 0.0
.data 1116 1116 0 0.0
.text 563736 563736 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888466 888466 0 0.0
bss 86920 86920 0 0.0
noinit 37160 37160 0 0.0
text 627864 627864 0 0.0

@woody-apple woody-apple merged commit 0048ee2 into project-chip:master Mar 5, 2022
@kpark-apple kpark-apple deleted the dev/kpark/20220225-attrib-cache branch March 5, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin fast track review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpark-apple @woody-apple @andy31415