Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESP32] Fix commissioning of esp32 #15856

Merged
merged 1 commit into from
Mar 4, 2022
Merged

[ESP32] Fix commissioning of esp32 #15856

merged 1 commit into from
Mar 4, 2022

Conversation

jadhavrohit924
Copy link
Contributor

@jadhavrohit924 jadhavrohit924 commented Mar 4, 2022 •
edited
Loading

Problem

Change overview

Returned CHIP_ERROR_PERSISTED_STORAGE_VALUE_NOT_FOUND for error CHIP_ERROR_KEY_NOT_FOUND

Testing

Manually tested esp32 all-clusters-app

@github-actions
Copy link

github-actions bot commented Mar 4, 2022 •
edited
Loading

PR #15856: Size comparison from c116381 to 34f594f

Increases (7 builds for k32w, linux, qpg, telink)
platform target config section c116381 34f594f change % change
k32w light k32w061+release (read/write) 693992 694008 16 0.0
.text 608540 608556 16 0.0
lock k32w061+release (read/write) 695744 695760 16 0.0
.text 610356 610372 16 0.0
linux chip-tool-ipv6only arm64 (read only) 9097876 9098020 144 0.0
.text 7706356 7706500 144 0.0
thermostat-no-ble arm64 (read only) 2169220 2169348 128 0.0
.text 1817888 1818016 128 0.0
qpg lighting-app qpg6105+debug (read only) 603136 603152 16 0.0
.text 597816 597832 16 0.0
lock-app qpg6105+debug (read only) 568820 568836 16 0.0
.text 563500 563516 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 887438 887462 24 0.0
text 626964 626986 22 0.0
Full report (13 builds for cyw30739, k32w, linux, mbed, nrfconnect, qpg, telink)
platform target config section c116381 34f594f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600294 600294 0 0.0
.app_xip_area 505316 505316 0 0.0
.bss 77660 77660 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 558290 558290 0 0.0
.app_xip_area 464848 464848 0 0.0
.bss 76164 76164 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 580290 580290 0 0.0
.app_xip_area 477128 477128 0 0.0
.bss 85524 85524 0 0.0
.data 600 600 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 693992 694008 16 0.0
.bss 77680 77680 0 0.0
.data 1972 1972 0 0.0
.text 608540 608556 16 0.0
lock k32w061+release (read/write) 695744 695760 16 0.0
.bss 77616 77616 0 0.0
.data 1972 1972 0 0.0
.text 610356 610372 16 0.0
linux chip-tool-ipv6only arm64 (read only) 9097876 9098020 144 0.0
(read/write) 418545 418545 0 0.0
.bss 43761 43761 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 317936 317936 0 0.0
.dynamic 560 560 0 0.0
.got 51856 51856 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473628 473628 0 0.0
.text 7706356 7706500 144 0.0
thermostat-no-ble arm64 (read only) 2169220 2169348 128 0.0
(read/write) 148433 148433 0 0.0
.bss 65121 65121 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75048 75048 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132900 132900 0 0.0
.text 1817888 1818016 128 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350772 2350772 0 0.0
.bss 187036 187036 0 0.0
.data 5784 5784 0 0.0
.text 1313372 1313372 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1078139 1078139 0 0.0
bss 128900 128900 0 0.0
rodata 142036 142036 0 0.0
text 731912 731912 0 0.0
qpg lighting-app qpg6105+debug (read only) 603136 603152 16 0.0
(read/write) 146936 146936 0 0.0
.bss 91056 91056 0 0.0
.data 1172 1172 0 0.0
.text 597816 597832 16 0.0
lock-app qpg6105+debug (read only) 568820 568836 16 0.0
(read/write) 146936 146936 0 0.0
.bss 91064 91064 0 0.0
.data 1124 1124 0 0.0
.text 563500 563516 16 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 887438 887462 24 0.0
bss 86864 86864 0 0.0
noinit 37160 37160 0 0.0
text 626964 626986 22 0.0

@jadhavrohit924 jadhavrohit924 changed the title [ESP32] EnableNetwork call return if already connected to a network [ESP32] Merged #15841 failing ble commissioning of esp32 Mar 4, 2022
@github-actions
Copy link

github-actions bot commented Mar 4, 2022 •
edited
Loading

PR #15856: Size comparison from a0a73a1 to 2702fe4

Full report (25 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a0a73a1 2702fe4 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600286 600286 0 0.0
.app_xip_area 505308 505308 0 0.0
.bss 77660 77660 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 558282 558282 0 0.0
.app_xip_area 464840 464840 0 0.0
.bss 76164 76164 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 580210 580210 0 0.0
.app_xip_area 477096 477096 0 0.0
.bss 85484 85484 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 693896 693896 0 0.0
.bss 77640 77640 0 0.0
.data 1964 1964 0 0.0
.text 608492 608492 0 0.0
lock k32w061+release (read/write) 695744 695744 0 0.0
.bss 77616 77616 0 0.0
.data 1972 1972 0 0.0
.text 610356 610356 0 0.0
linux all-clusters-app debug (read only) 2402833 2402833 0 0.0
(read/write) 144632 144632 0 0.0
.bss 59104 59104 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78408 78408 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 205093 205093 0 0.0
.text 2034754 2034754 0 0.0
bridge-app debug+rpc (read only) 1728637 1728637 0 0.0
(read/write) 92592 92592 0 0.0
.bss 47400 47400 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38056 38056 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141652 141652 0 0.0
.text 1470965 1470965 0 0.0
chip-tool debug (read only) 9399349 9399349 0 0.0
(read/write) 305768 305768 0 0.0
.bss 25440 25440 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 273168 273168 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 497781 497781 0 0.0
.text 8240293 8240293 0 0.0
chip-tool-ipv6only arm64 (read only) 9097860 9097860 0 0.0
(read/write) 418545 418545 0 0.0
.bss 43761 43761 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 317936 317936 0 0.0
.dynamic 560 560 0 0.0
.got 51856 51856 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473628 473628 0 0.0
.text 7706340 7706340 0 0.0
door-lock-app debug (read only) 1943265 1943265 0 0.0
(read/write) 119040 119040 0 0.0
.bss 50400 50400 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173596 173596 0 0.0
.text 1620978 1620978 0 0.0
lighting-app debug+rpc (read only) 2074561 2074561 0 0.0
(read/write) 124336 124336 0 0.0
.bss 51232 51232 0 0.0
.data 1536 1536 0 0.0
.data.rel.ro 66088 66088 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 165692 165692 0 0.0
.text 1753234 1753234 0 0.0
ota-provider-app debug (read only) 1875481 1875481 0 0.0
(read/write) 114672 114672 0 0.0
.bss 50208 50208 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158835 158835 0 0.0
.text 1565874 1565874 0 0.0
ota-requestor-app debug (read only) 1891569 1891569 0 0.0
(read/write) 116984 116984 0 0.0
.bss 51200 51200 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 58856 58856 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 152972 152972 0 0.0
.text 1589186 1589186 0 0.0
shell debug (read only) 2371857 2371857 0 0.0
(read/write) 146864 146864 0 0.0
.bss 67176 67176 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73144 73144 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 205074 205074 0 0.0
.text 2010018 2010018 0 0.0
thermostat-no-ble arm64 (read only) 2169220 2169220 0 0.0
(read/write) 148433 148433 0 0.0
.bss 65121 65121 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75048 75048 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132900 132900 0 0.0
.text 1817888 1817888 0 0.0
tv-app debug (read only) 2610161 2610161 0 0.0
(read/write) 250744 250744 0 0.0
.bss 167904 167904 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73616 73616 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199133 199133 0 0.0
.text 2236866 2236866 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349940 2349940 0 0.0
.bss 186028 186028 0 0.0
.data 5800 5800 0 0.0
.text 1312540 1312540 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1077995 1077995 0 0.0
bss 128844 128844 0 0.0
rodata 142036 142036 0 0.0
text 731888 731888 0 0.0
p6 all-clusters-app default (read/write) 2489624 2489624 0 0.0
.bss 118608 118608 0 0.0
.data 2696 2696 0 0.0
.text 1447888 1447888 0 0.0
light-app default (read/write) 2396728 2396728 0 0.0
.bss 112920 112920 0 0.0
.data 2544 2544 0 0.0
.text 1354992 1354992 0 0.0
lock-app default (read/write) 2360240 2360240 0 0.0
.bss 112664 112664 0 0.0
.data 2504 2504 0 0.0
.text 1318504 1318504 0 0.0
qpg lighting-app qpg6105+debug (read only) 603096 603096 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91016 91016 0 0.0
.data 1164 1164 0 0.0
.text 597776 597776 0 0.0
lock-app qpg6105+debug (read only) 568796 568796 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91024 91024 0 0.0
.data 1116 1116 0 0.0
.text 563476 563476 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 887454 887454 0 0.0
bss 86864 86864 0 0.0
noinit 37160 37160 0 0.0
text 626978 626978 0 0.0

@jadhavrohit924 jadhavrohit924 changed the title [ESP32] Merged #15841 failing ble commissioning of esp32 [ESP32] Fix commissioning of esp32 Mar 4, 2022
@github-actions
Copy link

github-actions bot commented Mar 4, 2022 •
edited
Loading

PR #15856: Size comparison from 08ca987 to 8912df0

Increases (1 build for esp32)
platform target config section 08ca987 8912df0 change % change
esp32 all-clusters-app c3devkit (read only) 953148 953150 2 0.0
.flash.text 953148 953150 2 0.0
Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 08ca987 8912df0 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600286 600286 0 0.0
.app_xip_area 505308 505308 0 0.0
.bss 77660 77660 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 558282 558282 0 0.0
.app_xip_area 464840 464840 0 0.0
.bss 76164 76164 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 580226 580226 0 0.0
.app_xip_area 477112 477112 0 0.0
.bss 85484 85484 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919740 919740 0 0.0
(read/write) 128784 128784 0 0.0
.bss 126704 126704 0 0.0
.data 2080 2080 0 0.0
.text 919732 919732 0 0.0
BRD4161A+rpc (read only) 948560 948560 0 0.0
(read/write) 144744 144744 0 0.0
.bss 142480 142480 0 0.0
.data 2260 2260 0 0.0
.text 948552 948552 0 0.0
lock-app BRD4161A+wf200 (read only) 988140 988140 0 0.0
(read/write) 120312 120312 0 0.0
.bss 118380 118380 0 0.0
.data 1932 1932 0 0.0
.text 988132 988132 0 0.0
window-app BRD4161A (read only) 853120 853120 0 0.0
(read/write) 126784 126784 0 0.0
.bss 124856 124856 0 0.0
.data 1924 1924 0 0.0
.text 853112 853112 0 0.0
esp32 all-clusters-app c3devkit (read only) 953148 953150 2 0.0
(read/write) 1392586 1392586 0 0.0
.dram0.bss 62536 62536 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 196896 196896 0 0.0
.flash.text 953148 953150 2 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1008319 1008319 0 0.0
(read/write) 459700 459700 0 0.0
.dram0.bss 68056 68056 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225728 225728 0 0.0
.flash.text 1002935 1002935 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 693896 693896 0 0.0
.bss 77640 77640 0 0.0
.data 1964 1964 0 0.0
.text 608492 608492 0 0.0
lock k32w061+release (read/write) 695744 695744 0 0.0
.bss 77616 77616 0 0.0
.data 1972 1972 0 0.0
.text 610356 610356 0 0.0
linux all-clusters-app debug (read only) 2402833 2402833 0 0.0
(read/write) 144632 144632 0 0.0
.bss 59104 59104 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78408 78408 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 205093 205093 0 0.0
.text 2034754 2034754 0 0.0
bridge-app debug+rpc (read only) 1728637 1728637 0 0.0
(read/write) 92592 92592 0 0.0
.bss 47400 47400 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38056 38056 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141652 141652 0 0.0
.text 1470965 1470965 0 0.0
chip-tool debug (read only) 9400493 9400493 0 0.0
(read/write) 305832 305832 0 0.0
.bss 25440 25440 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 273232 273232 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 497845 497845 0 0.0
.text 8241349 8241349 0 0.0
chip-tool-ipv6only arm64 (read only) 9099044 9099044 0 0.0
(read/write) 418593 418593 0 0.0
.bss 43761 43761 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 317984 317984 0 0.0
.dynamic 560 560 0 0.0
.got 51856 51856 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473660 473660 0 0.0
.text 7707460 7707460 0 0.0
door-lock-app debug (read only) 1943265 1943265 0 0.0
(read/write) 119040 119040 0 0.0
.bss 50400 50400 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173596 173596 0 0.0
.text 1620978 1620978 0 0.0
lighting-app debug+rpc (read only) 2074561 2074561 0 0.0
(read/write) 124336 124336 0 0.0
.bss 51232 51232 0 0.0
.data 1536 1536 0 0.0
.data.rel.ro 66088 66088 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 165692 165692 0 0.0
.text 1753234 1753234 0 0.0
ota-provider-app debug (read only) 1875481 1875481 0 0.0
(read/write) 114672 114672 0 0.0
.bss 50208 50208 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158835 158835 0 0.0
.text 1565874 1565874 0 0.0
ota-requestor-app debug (read only) 1891585 1891585 0 0.0
(read/write) 116984 116984 0 0.0
.bss 51200 51200 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 58856 58856 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 152972 152972 0 0.0
.text 1589202 1589202 0 0.0
shell debug (read only) 2371857 2371857 0 0.0
(read/write) 146864 146864 0 0.0
.bss 67176 67176 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73144 73144 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 205074 205074 0 0.0
.text 2010018 2010018 0 0.0
thermostat-no-ble arm64 (read only) 2169220 2169220 0 0.0
(read/write) 148433 148433 0 0.0
.bss 65121 65121 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75048 75048 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132900 132900 0 0.0
.text 1817888 1817888 0 0.0
tv-app debug (read only) 2610001 2610001 0 0.0
(read/write) 250744 250744 0 0.0
.bss 167904 167904 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73616 73616 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199133 199133 0 0.0
.text 2236706 2236706 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349940 2349940 0 0.0
.bss 186028 186028 0 0.0
.data 5800 5800 0 0.0
.text 1312540 1312540 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1147627 1147627 0 0.0
bss 145884 145884 0 0.0
rodata 144180 144180 0 0.0
text 782356 782356 0 0.0
p6 all-clusters-app default (read/write) 2489624 2489624 0 0.0
.bss 118608 118608 0 0.0
.data 2696 2696 0 0.0
.text 1447888 1447888 0 0.0
light-app default (read/write) 2396728 2396728 0 0.0
.bss 112920 112920 0 0.0
.data 2544 2544 0 0.0
.text 1354992 1354992 0 0.0
lock-app default (read/write) 2360240 2360240 0 0.0
.bss 112664 112664 0 0.0
.data 2504 2504 0 0.0
.text 1318504 1318504 0 0.0
qpg lighting-app qpg6105+debug (read only) 603112 603112 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91016 91016 0 0.0
.data 1164 1164 0 0.0
.text 597792 597792 0 0.0
lock-app qpg6105+debug (read only) 568796 568796 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91024 91024 0 0.0
.data 1116 1116 0 0.0
.text 563476 563476 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 887454 887454 0 0.0
bss 86864 86864 0 0.0
noinit 37160 37160 0 0.0
text 626978 626978 0 0.0

@andy31415 andy31415 merged commit 8e8f419 into project-chip:master Mar 4, 2022
@jadhavrohit924 jadhavrohit924 deleted the key branch August 16, 2022 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@msandstedt msandstedt Awaiting requested review from msandstedt

Assignees
No one assigned
Labels
esp32 platform review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jadhavrohit924 @andy31415 @msandstedt