-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32: Add platform mdns support (browse and resolve) #15852
Merged
woody-apple
merged 7 commits into
project-chip:master
from
wqx6:add_platform_mdns_support_esp
Apr 1, 2022
Merged
ESP32: Add platform mdns support (browse and resolve) #15852
woody-apple
merged 7 commits into
project-chip:master
from
wqx6:add_platform_mdns_support_esp
Apr 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
lazarkov and
LuDuda
March 4, 2022 09:32
/rebase |
woody-apple
force-pushed
the
add_platform_mdns_support_esp
branch
from
March 24, 2022 07:12
5912bba
to
f8a2c2a
Compare
wqx6
force-pushed
the
add_platform_mdns_support_esp
branch
from
March 24, 2022 07:27
f8a2c2a
to
912cdd4
Compare
dhrishi
reviewed
Mar 24, 2022
PR #15852: Size comparison from 026e01d to 912cdd4 Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
|
PR #15852: Size comparison from 026e01d to b46b857 Increases above 0.2%:
Increases (24 builds for cyw30739, efr32, k32w, linux, mbed, p6, telink)
Decreases (13 builds for cyw30739, efr32, k32w, mbed, p6, telink)
Full report (24 builds for cyw30739, efr32, k32w, linux, mbed, p6, telink)
|
PR #15852: Size comparison from 026e01d to f794dad Increases above 0.2%:
Increases (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
Decreases (15 builds for cyw30739, efr32, esp32, k32w, mbed, p6, telink)
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
|
gjc13
reviewed
Mar 30, 2022
gjc13
approved these changes
Mar 30, 2022
wqx6
force-pushed
the
add_platform_mdns_support_esp
branch
from
March 30, 2022 06:47
63cf033
to
9865f88
Compare
PR #15852: Size comparison from e784f35 to 9865f88 Increases above 0.2%:
Increases (2 builds for esp32)
Decreases (2 builds for esp32)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
chshu
approved these changes
Apr 1, 2022
yunhanw-google
approved these changes
Apr 1, 2022
woody-apple
approved these changes
Apr 1, 2022
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
…5852) * Add platform mdns support for esp32 * Restyled by gn * Async query for browse and resolve * Restyled by clang-format * Change default USE_MINIMAL_MDNS value in Kconfig * CI errors fix * format changes Co-authored-by: Restyled.io <[email protected]>
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
…5852) * Add platform mdns support for esp32 * Restyled by gn * Async query for browse and resolve * Restyled by clang-format * Change default USE_MINIMAL_MDNS value in Kconfig * CI errors fix * format changes Co-authored-by: Restyled.io <[email protected]>
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…5852) * Add platform mdns support for esp32 * Restyled by gn * Async query for browse and resolve * Restyled by clang-format * Change default USE_MINIMAL_MDNS value in Kconfig * CI errors fix * format changes Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Need to add platform mdns support for ESP32 platform
Change overview
Add browse and resolve mdns platform function for ESP32 platform
Testing
Tested on ESP32C3.
Publish service on Linux with
avahi-publish-service FA93546B21F5FB54 _matterc._udp 5540 PI= PH=33 CM=1 D=3840 CRI=3000 CRA=4000 T=1 VP=65521+32769
Browse it on chip-shell with
matter dns browse commissionable
Publish service on Linux with
avahi-publish-service 87E1B004E235A130-8FC7772401CD0696 _matter._tcp 22222 CRI=3000 CRA=4000 T=1
Resolve it on chip-shell with
matter dns resolve 9791300599901692208 10360380464321857174