-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix activate.sh to find CHIP_ROOT #1585
Fix activate.sh to find CHIP_ROOT #1585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Outed as a zsh user :)
Should fix scripts/bootstrap.sh as well. |
updated |
Size increase report for "gn_nrf-example-build"
Full report output
|
Size increase report for "gn_linux-example-build"
Full report output
|
Size increase report for "nrf-example-build"
Full report output
|
Size increase report for "linux-example-build"
Full report output
|
Size increase report for "esp32-example-build"
Full report output
|
* fix activate.sh * fix bootstrap.sh, too
* fix activate.sh * fix bootstrap.sh, too
* fix activate.sh * fix bootstrap.sh, too
* fix activate.sh * fix bootstrap.sh, too
* fix activate.sh * fix bootstrap.sh, too
Problem
if CHIP_ROOT is unset when sourcing activate.sh from bash, activate.sh erroneously uses $0 (which is "bash" when in bash) to locate the tree
Summary of Changes
fix for bash (tested with zsh, too)