Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix activate.sh to find CHIP_ROOT #1585

Merged
merged 2 commits into from
Jul 14, 2020

Conversation

rwalker-apple
Copy link
Contributor

Problem

if CHIP_ROOT is unset when sourcing activate.sh from bash, activate.sh erroneously uses $0 (which is "bash" when in bash) to locate the tree

source <(echo echo $0)

Summary of Changes

fix for bash (tested with zsh, too)

Copy link
Contributor

@mspang mspang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Outed as a zsh user :)

@mspang
Copy link
Contributor

mspang commented Jul 13, 2020

Should fix scripts/bootstrap.sh as well.

@rwalker-apple
Copy link
Contributor Author

Should fix scripts/bootstrap.sh as well.

updated

@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize


@woody-apple woody-apple merged commit 7df78e5 into project-chip:master Jul 14, 2020
@rwalker-apple rwalker-apple deleted the fix-activate.sh branch July 14, 2020 16:10
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
* fix activate.sh

* fix bootstrap.sh, too
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
* fix activate.sh

* fix bootstrap.sh, too
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
* fix activate.sh

* fix bootstrap.sh, too
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
* fix activate.sh

* fix bootstrap.sh, too
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
* fix activate.sh

* fix bootstrap.sh, too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants