Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MaxMeasuredValue is out of range Temperature Measurement Cluster #15821

Merged
merged 3 commits into from
Mar 7, 2022
Merged

Fix MaxMeasuredValue is out of range Temperature Measurement Cluster #15821

merged 3 commits into from
Mar 7, 2022

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

Change overview

Fix MaxMeasuredValue is out of range Temperature Measurement Cluster

Testing

How was this tested? (at least one bullet point required)

yufengw@yufengw-SEi:~/connectedhomeip/out/debug/standalone$ ./chip-tool temperaturemeasurement read measured-value 
.....
[1646333860.006585][34569:34574] CHIP:DMG: ReportDataMessage =
[1646333860.006589][34569:34574] CHIP:DMG: {
[1646333860.006592][34569:34574] CHIP:DMG: 	AttributeReportIBs =
[1646333860.006598][34569:34574] CHIP:DMG: 	[
[1646333860.006601][34569:34574] CHIP:DMG: 		AttributeReportIB =
[1646333860.006606][34569:34574] CHIP:DMG: 		{
[1646333860.006610][34569:34574] CHIP:DMG: 			AttributeDataIB =
[1646333860.006614][34569:34574] CHIP:DMG: 			{
[1646333860.006618][34569:34574] CHIP:DMG: 				DataVersion = 0x9651a08a,
[1646333860.006622][34569:34574] CHIP:DMG: 				AttributePathIB =
[1646333860.006626][34569:34574] CHIP:DMG: 				{
[1646333860.006630][34569:34574] CHIP:DMG: 					Endpoint = 0x1,
[1646333860.006634][34569:34574] CHIP:DMG: 					Cluster = 0x402,
[1646333860.006638][34569:34574] CHIP:DMG: 					Attribute = 0x0000_0000,
[1646333860.006642][34569:34574] CHIP:DMG: 				}
[1646333860.006646][34569:34574] CHIP:DMG: 					
[1646333860.006650][34569:34574] CHIP:DMG: 					Data = NULL
[1646333860.006654][34569:34574] CHIP:DMG: 			},
[1646333860.006658][34569:34574] CHIP:DMG: 			
[1646333860.006662][34569:34574] CHIP:DMG: 		},
[1646333860.006666][34569:34574] CHIP:DMG: 		
[1646333860.006670][34569:34574] CHIP:DMG: 	],
[1646333860.006674][34569:34574] CHIP:DMG: 	
[1646333860.006678][34569:34574] CHIP:DMG: 	SuppressResponse = true, 
[1646333860.006681][34569:34574] CHIP:DMG: 	InteractionModelRevision = 1
[1646333860.006684][34569:34574] CHIP:DMG: }
[1646333860.006739][34569:34574] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0402 Attribute 0x0000_0000DataVersion: 2521931914
[1646333860.006759][34569:34574] CHIP:TOO:   MeasuredValue: null

@yufengwangca yufengwangca changed the title Pr/cluster/tempmeasure Fix MaxMeasuredValue is out of range Temperature Measurement Cluster Mar 3, 2022
@github-actions
Copy link

github-actions bot commented Mar 3, 2022 •
edited
Loading

PR #15821: Size comparison from 3b83461 to c347d0a

Increases above 0.2%:

platform target config section 3b83461 c347d0a change % change
linux all-clusters-app debug .init_array 912 920 8 0.9
shell debug .init_array 896 904 8 0.9
Increases (8 builds for esp32, linux, nrfconnect, p6)
platform target config section 3b83461 c347d0a change % change
esp32 all-clusters-app c3devkit (read only) 953072 953388 316 0.0
.flash.text 953072 953388 316 0.0
m5stack (read only) 1008339 1008639 300 0.0
(read/write) 459684 459692 8 0.0
.flash.rodata 225712 225720 8 0.0
.flash.text 1002955 1003255 300 0.0
linux all-clusters-app debug (read only) 2402161 2403881 1720 0.1
(read/write) 144600 144608 8 0.0
.data.rel.ro 78392 78408 16 0.0
.init_array 912 920 8 0.9
.rodata 204997 205285 288 0.1
.text 2034418 2035778 1360 0.1
chip-tool debug (read only) 9398141 9398189 48 0.0
.text 8239317 8239365 48 0.0
chip-tool-ipv6only arm64 (read only) 9096660 9096820 160 0.0
.text 7705412 7705572 160 0.0
shell debug (read only) 2371193 2372881 1688 0.1
(read/write) 146832 146872 40 0.0
.data.rel.ro 73128 73160 32 0.0
.init_array 896 904 8 0.9
.rodata 204978 205234 256 0.1
.text 2009682 2011042 1360 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1076519 1076731 212 0.0
rodata 141664 141668 4 0.0
text 730784 731004 220 0.0
p6 all-clusters-app default (read/write) 2489552 2489816 264 0.0
.text 1447816 1448080 264 0.0
Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3b83461 c347d0a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600234 600234 0 0.0
.app_xip_area 505256 505256 0 0.0
.bss 77660 77660 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 558230 558230 0 0.0
.app_xip_area 464788 464788 0 0.0
.bss 76164 76164 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578858 578858 0 0.0
.app_xip_area 475720 475720 0 0.0
.bss 85532 85532 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 918280 918280 0 0.0
(read/write) 128816 128816 0 0.0
.bss 126760 126760 0 0.0
.data 2056 2056 0 0.0
.text 918272 918272 0 0.0
BRD4161A+rpc (read only) 948364 948364 0 0.0
(read/write) 145756 145756 0 0.0
.bss 143536 143536 0 0.0
.data 2220 2220 0 0.0
.text 948356 948356 0 0.0
lock-app BRD4161A+wf200 (read only) 988084 988084 0 0.0
(read/write) 120312 120312 0 0.0
.bss 118380 118380 0 0.0
.data 1932 1932 0 0.0
.text 988076 988076 0 0.0
window-app BRD4161A (read only) 853064 853064 0 0.0
(read/write) 126784 126784 0 0.0
.bss 124856 124856 0 0.0
.data 1924 1924 0 0.0
.text 853056 853056 0 0.0
esp32 all-clusters-app c3devkit (read only) 953072 953388 316 0.0
(read/write) 1392562 1392562 0 0.0
.dram0.bss 62536 62536 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 196872 196872 0 0.0
.flash.text 953072 953388 316 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1008339 1008639 300 0.0
(read/write) 459684 459692 8 0.0
.dram0.bss 68056 68056 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225712 225720 8 0.0
.flash.text 1002955 1003255 300 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 692556 692556 0 0.0
.bss 77688 77688 0 0.0
.data 1932 1932 0 0.0
.text 607136 607136 0 0.0
lock k32w061+release (read/write) 695708 695708 0 0.0
.bss 77616 77616 0 0.0
.data 1972 1972 0 0.0
.text 610320 610320 0 0.0
linux all-clusters-app debug (read only) 2402161 2403881 1720 0.1
(read/write) 144600 144608 8 0.0
.bss 59104 59104 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78392 78408 16 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 912 920 8 0.9
.rodata 204997 205285 288 0.1
.text 2034418 2035778 1360 0.1
bridge-app debug+rpc (read only) 1728141 1728141 0 0.0
(read/write) 92560 92560 0 0.0
.bss 47400 47400 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38040 38040 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141652 141652 0 0.0
.text 1470709 1470709 0 0.0
chip-tool debug (read only) 9398141 9398189 48 0.0
(read/write) 305736 305736 0 0.0
.bss 25440 25440 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 273152 273152 0 0.0
.dynamic 608 608 0 0.0
.got 4760 4760 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 497781 497781 0 0.0
.text 8239317 8239365 48 0.0
chip-tool-ipv6only arm64 (read only) 9096660 9096820 160 0.0
(read/write) 418497 418497 0 0.0
.bss 43761 43761 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 317920 317920 0 0.0
.dynamic 560 560 0 0.0
.got 51848 51848 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473580 473580 0 0.0
.text 7705412 7705572 160 0.0
door-lock-app debug (read only) 1942697 1942697 0 0.0
(read/write) 119008 119008 0 0.0
.bss 50400 50400 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62168 62168 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173596 173596 0 0.0
.text 1620642 1620642 0 0.0
lighting-app debug+rpc (read only) 2078145 2078145 0 0.0
(read/write) 124400 124400 0 0.0
.bss 51328 51328 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66136 66136 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 165980 165980 0 0.0
.text 1756738 1756738 0 0.0
ota-provider-app debug (read only) 1875009 1875009 0 0.0
(read/write) 114640 114640 0 0.0
.bss 50208 50208 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57448 57448 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158835 158835 0 0.0
.text 1565634 1565634 0 0.0
ota-requestor-app debug (read only) 1886217 1886217 0 0.0
(read/write) 116952 116952 0 0.0
.bss 51360 51360 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 58696 58696 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 152356 152356 0 0.0
.text 1585026 1585026 0 0.0
shell debug (read only) 2371193 2372881 1688 0.1
(read/write) 146832 146872 40 0.0
.bss 67176 67176 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73128 73160 32 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 896 904 8 0.9
.rodata 204978 205234 256 0.1
.text 2009682 2011042 1360 0.1
thermostat-no-ble arm64 (read only) 2168772 2168772 0 0.0
(read/write) 148385 148385 0 0.0
.bss 65121 65121 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75032 75032 0 0.0
.dynamic 560 560 0 0.0
.got 4208 4208 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132900 132900 0 0.0
.text 1817664 1817664 0 0.0
tv-app debug (read only) 2609073 2609073 0 0.0
(read/write) 250744 250744 0 0.0
.bss 167904 167904 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73608 73608 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199133 199133 0 0.0
.text 2236034 2236034 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350708 2350708 0 0.0
.bss 187036 187036 0 0.0
.data 5784 5784 0 0.0
.text 1313308 1313308 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1076519 1076731 212 0.0
bss 128876 128876 0 0.0
rodata 141664 141668 4 0.0
text 730784 731004 220 0.0
p6 all-clusters-app default (read/write) 2489552 2489816 264 0.0
.bss 118608 118608 0 0.0
.data 2696 2696 0 0.0
.text 1447816 1448080 264 0.0
light-app default (read/write) 2396688 2396688 0 0.0
.bss 112920 112920 0 0.0
.data 2544 2544 0 0.0
.text 1354952 1354952 0 0.0
lock-app default (read/write) 2360200 2360200 0 0.0
.bss 112664 112664 0 0.0
.data 2504 2504 0 0.0
.text 1318464 1318464 0 0.0
qpg lighting-app qpg6105+debug (read only) 601768 601768 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91064 91064 0 0.0
.data 1132 1132 0 0.0
.text 596448 596448 0 0.0
lock-app qpg6105+debug (read only) 567468 567468 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91072 91072 0 0.0
.data 1084 1084 0 0.0
.text 562148 562148 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883754 883754 0 0.0
bss 86280 86280 0 0.0
noinit 37160 37160 0 0.0
text 625014 625014 0 0.0

@github-actions
Copy link

github-actions bot commented Mar 4, 2022 •
edited
Loading

PR #15821: Size comparison from 2ecc827 to 203987c

Increases above 0.2%:

platform target config section 2ecc827 203987c change % change
linux all-clusters-app debug .init_array 912 920 8 0.9
shell debug .init_array 896 904 8 0.9
Increases (7 builds for esp32, linux, p6)
platform target config section 2ecc827 203987c change % change
esp32 all-clusters-app c3devkit (read only) 957178 957554 376 0.0
.flash.text 957178 957554 376 0.0
m5stack (read only) 1011927 1012319 392 0.0
(read/write) 460684 460692 8 0.0
.flash.rodata 225816 225824 8 0.0
.flash.text 1006543 1006935 392 0.0
linux all-clusters-app debug (read only) 2425537 2427433 1896 0.1
(read/write) 145656 145664 8 0.0
.data.rel.ro 78408 78424 16 0.0
.init_array 912 920 8 0.9
.rodata 205477 205733 256 0.1
.text 2057074 2058642 1568 0.1
chip-tool debug (read only) 9535117 9535165 48 0.0
.text 8314005 8314053 48 0.0
chip-tool-ipv6only arm64 (read only) 9221684 9221844 160 0.0
.text 7767732 7767892 160 0.0
shell debug (read only) 2392321 2394217 1896 0.1
(read/write) 149904 149944 40 0.0
.data.rel.ro 73144 73176 32 0.0
.init_array 896 904 8 0.9
.rodata 205426 205682 256 0.1
.text 2030130 2031698 1568 0.1
p6 all-clusters-app default (read/write) 2493616 2493920 304 0.0
.text 1451880 1452184 304 0.0
Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 2ecc827 203987c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601498 601498 0 0.0
.app_xip_area 506040 506040 0 0.0
.bss 78140 78140 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559418 559418 0 0.0
.app_xip_area 465496 465496 0 0.0
.bss 76644 76644 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581374 581374 0 0.0
.app_xip_area 477780 477780 0 0.0
.bss 85964 85964 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920212 920212 0 0.0
(read/write) 128832 128832 0 0.0
.bss 126752 126752 0 0.0
.data 2080 2080 0 0.0
.text 920204 920204 0 0.0
BRD4161A+rpc (read only) 949024 949024 0 0.0
(read/write) 144792 144792 0 0.0
.bss 142528 142528 0 0.0
.data 2260 2260 0 0.0
.text 949016 949016 0 0.0
lock-app BRD4161A+wf200 (read only) 988396 988396 0 0.0
(read/write) 120360 120360 0 0.0
.bss 118428 118428 0 0.0
.data 1932 1932 0 0.0
.text 988388 988388 0 0.0
window-app BRD4161A (read only) 853472 853472 0 0.0
(read/write) 126832 126832 0 0.0
.bss 124904 124904 0 0.0
.data 1924 1924 0 0.0
.text 853464 853464 0 0.0
esp32 all-clusters-app c3devkit (read only) 957178 957554 376 0.0
(read/write) 1393570 1393570 0 0.0
.dram0.bss 63424 63424 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197000 197000 0 0.0
.flash.text 957178 957554 376 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1011927 1012319 392 0.0
(read/write) 460684 460692 8 0.0
.dram0.bss 68952 68952 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225816 225824 8 0.0
.flash.text 1006543 1006935 392 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694204 694204 0 0.0
.bss 77688 77688 0 0.0
.data 1964 1964 0 0.0
.text 608752 608752 0 0.0
lock k32w061+release (read/write) 696032 696032 0 0.0
.bss 77664 77664 0 0.0
.data 1972 1972 0 0.0
.text 610596 610596 0 0.0
linux all-clusters-app debug (read only) 2425537 2427433 1896 0.1
(read/write) 145656 145664 8 0.0
.bss 60128 60128 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78408 78424 16 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 912 920 8 0.9
.rodata 205477 205733 256 0.1
.text 2057074 2058642 1568 0.1
bridge-app debug+rpc (read only) 1730429 1730429 0 0.0
(read/write) 92624 92624 0 0.0
.bss 47432 47432 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38056 38056 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141684 141684 0 0.0
.text 1472725 1472725 0 0.0
chip-tool debug (read only) 9535117 9535165 48 0.0
(read/write) 330608 330608 0 0.0
.bss 25536 25536 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 297888 297888 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 499381 499381 0 0.0
.text 8314005 8314053 48 0.0
chip-tool-ipv6only arm64 (read only) 9221684 9221844 160 0.0
(read/write) 443473 443473 0 0.0
.bss 43841 43841 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 342696 342696 0 0.0
.dynamic 560 560 0 0.0
.got 51952 51952 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 475196 475196 0 0.0
.text 7767732 7767892 160 0.0
door-lock-app debug (read only) 1944737 1944737 0 0.0
(read/write) 119072 119072 0 0.0
.bss 50432 50432 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173596 173596 0 0.0
.text 1622450 1622450 0 0.0
lighting-app debug+rpc (read only) 2076929 2076929 0 0.0
(read/write) 124368 124368 0 0.0
.bss 51264 51264 0 0.0
.data 1536 1536 0 0.0
.data.rel.ro 66088 66088 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 165788 165788 0 0.0
.text 1755506 1755506 0 0.0
ota-provider-app debug (read only) 1877273 1877273 0 0.0
(read/write) 114704 114704 0 0.0
.bss 50240 50240 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158835 158835 0 0.0
.text 1567666 1567666 0 0.0
ota-requestor-app debug (read only) 1898753 1898753 0 0.0
(read/write) 117408 117408 0 0.0
.bss 51296 51296 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 59160 59160 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 153996 153996 0 0.0
.text 1594674 1594674 0 0.0
shell debug (read only) 2392321 2394217 1896 0.1
(read/write) 149904 149944 40 0.0
.bss 70216 70216 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73144 73176 32 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 896 904 8 0.9
.rodata 205426 205682 256 0.1
.text 2030130 2031698 1568 0.1
thermostat-no-ble arm64 (read only) 2173812 2173812 0 0.0
(read/write) 148513 148513 0 0.0
.bss 65201 65201 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75048 75048 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132964 132964 0 0.0
.text 1822416 1822416 0 0.0
tv-app debug (read only) 2615457 2615457 0 0.0
(read/write) 250776 250776 0 0.0
.bss 167936 167936 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73616 73616 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199453 199453 0 0.0
.text 2241842 2241842 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350324 2350324 0 0.0
.bss 186076 186076 0 0.0
.data 5800 5800 0 0.0
.text 1312924 1312924 0 0.0
p6 all-clusters-app default (read/write) 2493616 2493920 304 0.0
.bss 119496 119496 0 0.0
.data 2696 2696 0 0.0
.text 1451880 1452184 304 0.0
light-app default (read/write) 2397080 2397080 0 0.0
.bss 112968 112968 0 0.0
.data 2544 2544 0 0.0
.text 1355344 1355344 0 0.0
lock-app default (read/write) 2360512 2360512 0 0.0
.bss 112712 112712 0 0.0
.data 2504 2504 0 0.0
.text 1318776 1318776 0 0.0
qpg lighting-app qpg6105+debug (read only) 603444 603444 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91064 91064 0 0.0
.data 1164 1164 0 0.0
.text 598124 598124 0 0.0
lock-app qpg6105+debug (read only) 569064 569064 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91072 91072 0 0.0
.data 1116 1116 0 0.0
.text 563744 563744 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888522 888522 0 0.0
bss 86920 86920 0 0.0
noinit 37160 37160 0 0.0
text 627914 627914 0 0.0

@yufengwangca
Copy link
Contributor Author

Per sync offline, we will not enforce the range check in SDK, but just assume that the device maker will not set the invalid value. All temperature attributes shall be null if their value is unknown.

@github-actions
Copy link

github-actions bot commented Mar 5, 2022 •
edited
Loading

PR #15821: Size comparison from d6bf695 to 8e371db

Increases (1 build for esp32)
platform target config section d6bf695 8e371db change % change
esp32 all-clusters-app m5stack (read only) 1011955 1011967 12 0.0
.flash.text 1006571 1006583 12 0.0
Full report (20 builds for cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section d6bf695 8e371db change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601546 601546 0 0.0
.app_xip_area 506088 506088 0 0.0
.bss 78140 78140 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559522 559522 0 0.0
.app_xip_area 465600 465600 0 0.0
.bss 76644 76644 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581718 581718 0 0.0
.app_xip_area 478116 478116 0 0.0
.bss 85972 85972 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920508 920508 0 0.0
(read/write) 128840 128840 0 0.0
.bss 126760 126760 0 0.0
.data 2080 2080 0 0.0
.text 920500 920500 0 0.0
BRD4161A+rpc (read only) 949344 949344 0 0.0
(read/write) 144800 144800 0 0.0
.bss 142536 142536 0 0.0
.data 2260 2260 0 0.0
.text 949336 949336 0 0.0
lock-app BRD4161A+wf200 (read only) 988492 988492 0 0.0
(read/write) 120360 120360 0 0.0
.bss 118428 118428 0 0.0
.data 1932 1932 0 0.0
.text 988484 988484 0 0.0
window-app BRD4161A (read only) 853568 853568 0 0.0
(read/write) 126832 126832 0 0.0
.bss 124904 124904 0 0.0
.data 1924 1924 0 0.0
.text 853560 853560 0 0.0
esp32 all-clusters-app c3devkit (read only) 957240 957240 0 0.0
(read/write) 1393570 1393570 0 0.0
.dram0.bss 63424 63424 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197000 197000 0 0.0
.flash.text 957240 957240 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1011955 1011967 12 0.0
(read/write) 460684 460684 0 0.0
.dram0.bss 68952 68952 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225816 225816 0 0.0
.flash.text 1006571 1006583 12 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694556 694556 0 0.0
.bss 77696 77696 0 0.0
.data 1964 1964 0 0.0
.text 609096 609096 0 0.0
lock k32w061+release (read/write) 696144 696144 0 0.0
.bss 77664 77664 0 0.0
.data 1972 1972 0 0.0
.text 610708 610708 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350468 2350468 0 0.0
.bss 186076 186076 0 0.0
.data 5800 5800 0 0.0
.text 1313068 1313068 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151479 1151479 0 0.0
bss 146784 146784 0 0.0
rodata 144272 144272 0 0.0
text 785228 785228 0 0.0
p6 all-clusters-app default (read/write) 2493680 2493680 0 0.0
.bss 119496 119496 0 0.0
.data 2696 2696 0 0.0
.text 1451944 1451944 0 0.0
light-app default (read/write) 2397128 2397128 0 0.0
.bss 112968 112968 0 0.0
.data 2544 2544 0 0.0
.text 1355392 1355392 0 0.0
lock-app default (read/write) 2360608 2360608 0 0.0
.bss 112712 112712 0 0.0
.data 2504 2504 0 0.0
.text 1318872 1318872 0 0.0
qpg lighting-app qpg6105+debug (read only) 603740 603740 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91072 91072 0 0.0
.data 1164 1164 0 0.0
.text 598420 598420 0 0.0
lock-app qpg6105+debug (read only) 569400 569400 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91080 91080 0 0.0
.data 1116 1116 0 0.0
.text 564080 564080 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888594 888594 0 0.0
bss 86920 86920 0 0.0
noinit 37160 37160 0 0.0
text 627988 627988 0 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Mar 5, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-actions
Copy link

github-actions bot commented Mar 7, 2022

PR #15821: Size comparison from 5e4a98c to a964839

Increases (1 build for linux)
platform target config section 5e4a98c a964839 change % change
linux chip-tool-ipv6only arm64 (read only) 9397540 9397716 176 0.0
.text 7908500 7908676 176 0.0
Full report (16 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5e4a98c a964839 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601546 601546 0 0.0
.app_xip_area 506088 506088 0 0.0
.bss 78140 78140 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559522 559522 0 0.0
.app_xip_area 465600 465600 0 0.0
.bss 76644 76644 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581718 581718 0 0.0
.app_xip_area 478116 478116 0 0.0
.bss 85972 85972 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 694556 694556 0 0.0
.bss 77696 77696 0 0.0
.data 1964 1964 0 0.0
.text 609096 609096 0 0.0
lock k32w061+release (read/write) 696144 696144 0 0.0
.bss 77664 77664 0 0.0
.data 1972 1972 0 0.0
.text 610708 610708 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9397540 9397716 176 0.0
(read/write) 454017 454017 0 0.0
.bss 43841 43841 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 350904 350904 0 0.0
.dynamic 560 560 0 0.0
.got 54288 54288 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 485756 485756 0 0.0
.text 7908500 7908676 176 0.0
thermostat-no-ble arm64 (read only) 2174068 2174068 0 0.0
(read/write) 148513 148513 0 0.0
.bss 65201 65201 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75048 75048 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132964 132964 0 0.0
.text 1822672 1822672 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350468 2350468 0 0.0
.bss 186076 186076 0 0.0
.data 5800 5800 0 0.0
.text 1313068 1313068 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151479 1151479 0 0.0
bss 146784 146784 0 0.0
rodata 144272 144272 0 0.0
text 785228 785228 0 0.0
p6 all-clusters-app default (read/write) 2493680 2493680 0 0.0
.bss 119496 119496 0 0.0
.data 2696 2696 0 0.0
.text 1451944 1451944 0 0.0
light-app default (read/write) 2397128 2397128 0 0.0
.bss 112968 112968 0 0.0
.data 2544 2544 0 0.0
.text 1355392 1355392 0 0.0
lock-app default (read/write) 2360608 2360608 0 0.0
.bss 112712 112712 0 0.0
.data 2504 2504 0 0.0
.text 1318872 1318872 0 0.0
qpg lighting-app qpg6105+debug (read only) 603740 603740 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91072 91072 0 0.0
.data 1164 1164 0 0.0
.text 598420 598420 0 0.0
lock-app qpg6105+debug (read only) 569400 569400 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91080 91080 0 0.0
.data 1116 1116 0 0.0
.text 564080 564080 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888594 888594 0 0.0
bss 86920 86920 0 0.0
noinit 37160 37160 0 0.0
text 627988 627988 0 0.0

@boring-cyborg boring-cyborg bot added the android label Mar 7, 2022
@github-actions
Copy link

github-actions bot commented Mar 7, 2022 •
edited
Loading

PR #15821: Size comparison from 5e4a98c to 0181118

Increases (2 builds for esp32, linux)
platform target config section 5e4a98c 0181118 change % change
esp32 all-clusters-app m5stack (read only) 1011955 1011967 12 0.0
.flash.text 1006571 1006583 12 0.0
linux chip-tool-ipv6only arm64 (read only) 9397540 9397716 176 0.0
.text 7908500 7908676 176 0.0
Full report (22 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5e4a98c 0181118 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601546 601546 0 0.0
.app_xip_area 506088 506088 0 0.0
.bss 78140 78140 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559522 559522 0 0.0
.app_xip_area 465600 465600 0 0.0
.bss 76644 76644 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581718 581718 0 0.0
.app_xip_area 478116 478116 0 0.0
.bss 85972 85972 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920508 920508 0 0.0
(read/write) 128840 128840 0 0.0
.bss 126760 126760 0 0.0
.data 2080 2080 0 0.0
.text 920500 920500 0 0.0
BRD4161A+rpc (read only) 949344 949344 0 0.0
(read/write) 144800 144800 0 0.0
.bss 142536 142536 0 0.0
.data 2260 2260 0 0.0
.text 949336 949336 0 0.0
lock-app BRD4161A+wf200 (read only) 988492 988492 0 0.0
(read/write) 120360 120360 0 0.0
.bss 118428 118428 0 0.0
.data 1932 1932 0 0.0
.text 988484 988484 0 0.0
window-app BRD4161A (read only) 853568 853568 0 0.0
(read/write) 126832 126832 0 0.0
.bss 124904 124904 0 0.0
.data 1924 1924 0 0.0
.text 853560 853560 0 0.0
esp32 all-clusters-app c3devkit (read only) 957240 957240 0 0.0
(read/write) 1393570 1393570 0 0.0
.dram0.bss 63424 63424 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197000 197000 0 0.0
.flash.text 957240 957240 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1011955 1011967 12 0.0
(read/write) 460684 460684 0 0.0
.dram0.bss 68952 68952 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225816 225816 0 0.0
.flash.text 1006571 1006583 12 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694556 694556 0 0.0
.bss 77696 77696 0 0.0
.data 1964 1964 0 0.0
.text 609096 609096 0 0.0
lock k32w061+release (read/write) 696144 696144 0 0.0
.bss 77664 77664 0 0.0
.data 1972 1972 0 0.0
.text 610708 610708 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9397540 9397716 176 0.0
(read/write) 454017 454017 0 0.0
.bss 43841 43841 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 350904 350904 0 0.0
.dynamic 560 560 0 0.0
.got 54288 54288 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 485756 485756 0 0.0
.text 7908500 7908676 176 0.0
thermostat-no-ble arm64 (read only) 2174068 2174068 0 0.0
(read/write) 148513 148513 0 0.0
.bss 65201 65201 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75048 75048 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132964 132964 0 0.0
.text 1822672 1822672 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350468 2350468 0 0.0
.bss 186076 186076 0 0.0
.data 5800 5800 0 0.0
.text 1313068 1313068 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151479 1151479 0 0.0
bss 146784 146784 0 0.0
rodata 144272 144272 0 0.0
text 785228 785228 0 0.0
p6 all-clusters-app default (read/write) 2493680 2493680 0 0.0
.bss 119496 119496 0 0.0
.data 2696 2696 0 0.0
.text 1451944 1451944 0 0.0
light-app default (read/write) 2397128 2397128 0 0.0
.bss 112968 112968 0 0.0
.data 2544 2544 0 0.0
.text 1355392 1355392 0 0.0
lock-app default (read/write) 2360608 2360608 0 0.0
.bss 112712 112712 0 0.0
.data 2504 2504 0 0.0
.text 1318872 1318872 0 0.0
qpg lighting-app qpg6105+debug (read only) 603740 603740 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91072 91072 0 0.0
.data 1164 1164 0 0.0
.text 598420 598420 0 0.0
lock-app qpg6105+debug (read only) 569400 569400 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91080 91080 0 0.0
.data 1116 1116 0 0.0
.text 564080 564080 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888594 888594 0 0.0
bss 86920 86920 0 0.0
noinit 37160 37160 0 0.0
text 627988 627988 0 0.0

@andy31415 andy31415 merged commit 65440ab into project-chip:master Mar 7, 2022
@yufengwangca yufengwangca deleted the pr/cluster/tempmeasure branch March 8, 2022 02:35
This was referenced May 4, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
android app controller darwin examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Temperature Measurement Cluster - mandatory attribute: MaxMeasuredValue is out of range
4 participants
@yufengwangca @andy31415 @woody-apple @bzbarsky-apple