-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some configuration differences between GN & automake #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standalone project configs now apply unless specifically overriden, which matches configure's behavior. Previously the project configs were disabled by default, so the defaults inline in CHIPConfig.h applied. Note there are at 3 sources of defaults here which lead to this confusion: (1) The defaults used by scripts/build/bootstrap.sh, which calls configure with very few arguments. This uses the standalone project configs and builds tests. (2) The defaults used by config/standalone/standalone-chip.mk, which calls configure and overrides a few arguments. This uses the standalone project configs, but disables some components, and does not build tests. (3) The defaults specified directly in CHIPConfig.h et al. These defaults may have no effect because configure always overrides them using BuildConfig.h. GN currently doesn't use BuildConfig.h, but uses the command line to get the same result.
mspang
requested review from
andy31415,
anush-apple,
BroderickCarlin,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk,
saurabhst and
woody-apple
as code owners
July 13, 2020 18:02
Size increase report for "nrf-example-build"
Full report output
|
Size increase report for "linux-example-build"
Full report output
|
Size increase report for "esp32-example-build"
Full report output
|
Size increase report for "gn_nrf-example-build"
Full report output
|
Size increase report for "gn_linux-example-build"
Full report output
|
andy31415
approved these changes
Jul 14, 2020
saurabhst
approved these changes
Jul 14, 2020
woody-apple
approved these changes
Jul 14, 2020
kedars
pushed a commit
to kedars/connectedhomeip
that referenced
this pull request
Jul 19, 2020
…p#1582) The standalone project configs now apply unless specifically overriden, which matches configure's behavior. Previously the project configs were disabled by default, so the defaults inline in CHIPConfig.h applied. Note there are at 3 sources of defaults here which lead to this confusion: (1) The defaults used by scripts/build/bootstrap.sh, which calls configure with very few arguments. This uses the standalone project configs and builds tests. (2) The defaults used by config/standalone/standalone-chip.mk, which calls configure and overrides a few arguments. This uses the standalone project configs, but disables some components, and does not build tests. (3) The defaults specified directly in CHIPConfig.h et al. These defaults may have no effect because configure always overrides them using BuildConfig.h. GN currently doesn't use BuildConfig.h, but uses the command line to get the same result.
kedars
pushed a commit
to kedars/connectedhomeip
that referenced
this pull request
Jul 19, 2020
…p#1582) The standalone project configs now apply unless specifically overriden, which matches configure's behavior. Previously the project configs were disabled by default, so the defaults inline in CHIPConfig.h applied. Note there are at 3 sources of defaults here which lead to this confusion: (1) The defaults used by scripts/build/bootstrap.sh, which calls configure with very few arguments. This uses the standalone project configs and builds tests. (2) The defaults used by config/standalone/standalone-chip.mk, which calls configure and overrides a few arguments. This uses the standalone project configs, but disables some components, and does not build tests. (3) The defaults specified directly in CHIPConfig.h et al. These defaults may have no effect because configure always overrides them using BuildConfig.h. GN currently doesn't use BuildConfig.h, but uses the command line to get the same result.
kedars
pushed a commit
to kedars/connectedhomeip
that referenced
this pull request
Jul 19, 2020
…p#1582) The standalone project configs now apply unless specifically overriden, which matches configure's behavior. Previously the project configs were disabled by default, so the defaults inline in CHIPConfig.h applied. Note there are at 3 sources of defaults here which lead to this confusion: (1) The defaults used by scripts/build/bootstrap.sh, which calls configure with very few arguments. This uses the standalone project configs and builds tests. (2) The defaults used by config/standalone/standalone-chip.mk, which calls configure and overrides a few arguments. This uses the standalone project configs, but disables some components, and does not build tests. (3) The defaults specified directly in CHIPConfig.h et al. These defaults may have no effect because configure always overrides them using BuildConfig.h. GN currently doesn't use BuildConfig.h, but uses the command line to get the same result.
kedars
pushed a commit
to kedars/connectedhomeip
that referenced
this pull request
Jul 21, 2020
…p#1582) The standalone project configs now apply unless specifically overriden, which matches configure's behavior. Previously the project configs were disabled by default, so the defaults inline in CHIPConfig.h applied. Note there are at 3 sources of defaults here which lead to this confusion: (1) The defaults used by scripts/build/bootstrap.sh, which calls configure with very few arguments. This uses the standalone project configs and builds tests. (2) The defaults used by config/standalone/standalone-chip.mk, which calls configure and overrides a few arguments. This uses the standalone project configs, but disables some components, and does not build tests. (3) The defaults specified directly in CHIPConfig.h et al. These defaults may have no effect because configure always overrides them using BuildConfig.h. GN currently doesn't use BuildConfig.h, but uses the command line to get the same result.
kedars
pushed a commit
to kedars/connectedhomeip
that referenced
this pull request
Jul 21, 2020
…p#1582) The standalone project configs now apply unless specifically overriden, which matches configure's behavior. Previously the project configs were disabled by default, so the defaults inline in CHIPConfig.h applied. Note there are at 3 sources of defaults here which lead to this confusion: (1) The defaults used by scripts/build/bootstrap.sh, which calls configure with very few arguments. This uses the standalone project configs and builds tests. (2) The defaults used by config/standalone/standalone-chip.mk, which calls configure and overrides a few arguments. This uses the standalone project configs, but disables some components, and does not build tests. (3) The defaults specified directly in CHIPConfig.h et al. These defaults may have no effect because configure always overrides them using BuildConfig.h. GN currently doesn't use BuildConfig.h, but uses the command line to get the same result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standalone project configs now apply unless specifically overriden,
which matches configure's behavior. Previously the project configs were
disabled by default, so the defaults inline in CHIPConfig.h applied.
Note there are at 3 sources of defaults here which lead to this
confusion:
(1) The defaults used by scripts/build/bootstrap.sh, which calls
configure with few arguments. This uses the standalone
project configs and builds tests.
(2) The defaults used by config/standalone/standalone-chip.mk, which
calls configure and overrides some arguments. This uses the
standalone project configs, but disables some components, and
does not build tests.
(3) The defaults specified directly in CHIPConfig.h et al. These
defaults may have no effect because configure always overrides
them using BuildConfig.h. GN currently doesn't use BuildConfig.h,
but uses the command line to get the same result.