-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement browse retries for minimal mdns #15813
Conversation
PR #15813: Size comparison from 3b83461 to a5c0d3a Increases above 0.2%:
Increases (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg)
Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #15813: Size comparison from 08ca987 to feab4b3 Increases above 0.2%:
Increases (24 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (25 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #15813: Size comparison from 08ca987 to f424585 Increases above 0.2%:
Increases (24 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (25 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
/rebase |
- adds ability to track browse requests in the ActiveResolveAttempts class - Changes minimal impl to retry browse attempts using the same mechanism as resolves - adds tests - moves the ActiveResolveAttempts file out of minimal - reasoning: althought this is used only by minimal, other impls could use this and the minimal folder was meant to not include any Matter specific details like peer id or discovery filter. - adds tests. - tested by running a discover where there are no matter devices advertising
f424585
to
4262812
Compare
PR #15813: Size comparison from 65440ab to 4262812 Increases above 0.2%:
Increases (25 builds for cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (27 builds for cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #15813: Size comparison from 65440ab to c0d1e5c Increases above 0.2%:
Increases (25 builds for cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (27 builds for cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #15813: Size comparison from 2822511 to e0450ca Increases above 0.2%:
Increases (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
|
Problem
Minimal mDNS will retry on a failing resolve command, but not on a failing browse command. This is especially important for minimal, which relies on legacy unicast responses for the first attempt.
Change overview
as resolves
althought this is used only by minimal, other impls could use
this and the minimal folder was meant to not include any Matter
specific details like peer id or discovery filter.
Testing