Placeholder unable to pair #15801
Merged
Placeholder unable to pair #15801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel and
lazarkov
pullapprove
bot
requested review from
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
Damian-Nordic
approved these changes
Mar 3, 2022
woody-apple
approved these changes
Mar 3, 2022
krypton36
pushed a commit
to krypton36/connectedhomeip
that referenced
this pull request
Mar 3, 2022
* Update placeholder app1 port to be 5543 by default * Update zap files to contains the necessary attributes for commissioning * Update generated content
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Sep 1, 2022
PR project-chip#15801 changed the port to 5543, but the documentation was not updated. Just use "pairing code" to avoid problems like that. Fixes project-chip#22312
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Sep 1, 2022
PR project-chip#15801 changed the port to 5543, but the documentation was not updated. Just use "pairing code" to avoid problems like that. Fixes project-chip#22312
andy31415
pushed a commit
that referenced
this pull request
Sep 1, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* Fix documentation for chip-app1 commisioning. PR project-chip#15801 changed the port to 5543, but the documentation was not updated. Just use "pairing code" to avoid problems like that. Fixes project-chip#22312 * Fix review comments: add missing node id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
app1can not be paired anymore.Change overview
Testing
I have updated the code until pairing works locally.