-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Add support for multiple reads/subscribes into a single exchange #15787
[chip-tool] Add support for multiple reads/subscribes into a single exchange #15787
Conversation
PR #15787: Size comparison from 2c4fb91 to 140a030 Increases above 0.2%:
Increases (2 builds for linux, nrfconnect)
Full report (22 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
140a030
to
f858ef7
Compare
PR #15787: Size comparison from 8895bdb to f858ef7 Increases above 0.2%:
Increases (3 builds for linux, nrfconnect)
Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Fast tracking tooling changes |
…xchange (project-chip#15787) * [chip-tool] Add support for multiple reads/subscribes into a single exchange * Update generated content
chip::AttributeId attributeId, chip::app::ReadClient::InteractionType interactionType, | ||
uint16_t minInterval = 0, uint16_t maxInterval = 0, | ||
CHIP_ERROR ReportAttribute(ChipDevice * device, std::vector<chip::EndpointId> endpointIds, | ||
std::vector<chip::ClusterId> clusterIds, std::vector<chip::AttributeId> attributeIds, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vivien-apple when you add vector support for multiple attribute in chip-tool, could you help extend vector support for the below optional DataVersion, DataVersion filter is per path.
Problem
chip-tool
can not issue requests with multiple attributes in a single exchange.Change overview
Testing
Locally tested with commands such as:
There is a little bit of code duplication in the
ReportEvent
andReportAttribute
method but that could be unified later.