-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YAML] Remove GetUniqueDiscriminator since cross-talks seems to be gone now #15784
Merged
vivien-apple
merged 2 commits into
project-chip:master
from
vivien-apple:YAML_RemoveGetUniqueDiscriminator
Mar 3, 2022
Merged
[YAML] Remove GetUniqueDiscriminator since cross-talks seems to be gone now #15784
vivien-apple
merged 2 commits into
project-chip:master
from
vivien-apple:YAML_RemoveGetUniqueDiscriminator
Mar 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivien-apple
changed the title
Yaml remove get unique discriminator
[YAML] Remove GetUniqueDiscriminator since cross-talks seems to be gone now
Mar 3, 2022
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel and
lazarkov
March 3, 2022 09:06
pullapprove
bot
requested review from
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
March 3, 2022 09:06
woody-apple
approved these changes
Mar 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking testing changes
bzbarsky-apple
approved these changes
Mar 3, 2022
PR #15784: Size comparison from 2c4fb91 to 2de86ef Increases above 0.2%:
Increases (1 build for nrfconnect)
Decreases (1 build for linux)
Full report (22 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
GetUniqueDiscriminator
method in YAML was used as a way to workaround the collisions between instances mdns advertisement on CI. Mdns advertisement are now broadcasting only onto the local interface so this method can be removed.Change overview
GetUniqueDiscriminator