-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sprintf type issue in TlvJson #15772
Merged
woody-apple
merged 1 commit into
project-chip:master
from
mrjerryjohns:fix-master-tlv-json
Mar 3, 2022
Merged
Fix sprintf type issue in TlvJson #15772
woody-apple
merged 1 commit into
project-chip:master
from
mrjerryjohns:fix-master-tlv-json
Mar 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd4664e
to
87dacd6
Compare
woody-apple
approved these changes
Mar 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving pending CI
Note: This build has failed in master, but not on a PR due to limited coverage of PRs on this platform. Suggest reverting to previous behavior. |
PR #15772: Size comparison from 1fd382d to 87dacd6 Full report (19 builds for cyw30739, efr32, esp32, k32w, linux, p6, qpg, telink)
|
woody-apple
added a commit
that referenced
this pull request
Mar 3, 2022
This reverts commit 878550f.
woody-apple
added a commit
that referenced
this pull request
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Builds on MbedOS are failing due to mismatched type in a
sprintf
call insideTlvJson.cpp
.