Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable reset watermark for software diagnostics on Window cover app #15758

Merged
merged 2 commits into from
Mar 3, 2022
Merged

Enable reset watermark for software diagnostics on Window cover app #15758

merged 2 commits into from
Mar 3, 2022

Conversation

mkardous-silabs
Copy link
Contributor

Problem

  • ResetWatermarks for SoftwareDiagnostics was not enabled on window cover app

Change overview

  • Enable ResetWatermarks on the window cover app

Testing

  • Manual tests running the command on efr32 mg12

@github-actions
Copy link

github-actions bot commented Mar 2, 2022 •
edited
Loading

PR #15758: Size comparison from 654104c to fdcde6a

Increases above 0.2%:

platform target config section 654104c fdcde6a change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1040115 1076387 36272 3.5
bss 125828 127680 1852 1.5
rodata 135820 141724 5904 4.3
text 701220 729580 28360 4.0
Increases (2 builds for efr32, nrfconnect)
platform target config section 654104c fdcde6a change % change
efr32 window-app BRD4161A (read only) 851804 852348 544 0.1
.text 851796 852340 544 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1040115 1076387 36272 3.5
bss 125828 127680 1852 1.5
rodata 135820 141724 5904 4.3
text 701220 729580 28360 4.0
Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 654104c fdcde6a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600618 600618 0 0.0
.app_xip_area 505392 505392 0 0.0
.bss 77908 77908 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 558614 558614 0 0.0
.app_xip_area 464924 464924 0 0.0
.bss 76412 76412 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 579026 579026 0 0.0
.app_xip_area 475904 475904 0 0.0
.bss 85516 85516 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 917852 917852 0 0.0
(read/write) 128672 128672 0 0.0
.bss 126616 126616 0 0.0
.data 2056 2056 0 0.0
.text 917844 917844 0 0.0
BRD4161A+rpc (read only) 947944 947944 0 0.0
(read/write) 145616 145616 0 0.0
.bss 143392 143392 0 0.0
.data 2220 2220 0 0.0
.text 947936 947936 0 0.0
lock-app BRD4161A+wf200 (read only) 987676 987676 0 0.0
(read/write) 120432 120432 0 0.0
.bss 118500 118500 0 0.0
.data 1932 1932 0 0.0
.text 987668 987668 0 0.0
window-app BRD4161A (read only) 851804 852348 544 0.1
(read/write) 126908 126908 0 0.0
.bss 124984 124984 0 0.0
.data 1924 1924 0 0.0
.text 851796 852340 544 0.1
esp32 all-clusters-app m5stack (read only) 1006047 1006047 0 0.0
(read/write) 458264 458264 0 0.0
.dram0.bss 68168 68168 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 224520 224520 0 0.0
.flash.text 1000663 1000663 0 0.0
.iram0.text 122767 122767 0 0.0
k32w light k32w061+release (read/write) 692856 692856 0 0.0
.bss 77544 77544 0 0.0
.data 1932 1932 0 0.0
.text 607580 607580 0 0.0
lock k32w061+release (read/write) 696200 696200 0 0.0
.bss 77744 77744 0 0.0
.data 1972 1972 0 0.0
.text 610684 610684 0 0.0
linux all-clusters-app debug (read only) 2403185 2403185 0 0.0
(read/write) 144824 144824 0 0.0
.bss 59328 59328 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78392 78392 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 205061 205061 0 0.0
.text 2035378 2035378 0 0.0
bridge-app debug+rpc (read only) 1728717 1728717 0 0.0
(read/write) 92784 92784 0 0.0
.bss 47624 47624 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38040 38040 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141652 141652 0 0.0
.text 1471285 1471285 0 0.0
chip-tool debug (read only) 9355253 9355253 0 0.0
(read/write) 287912 287912 0 0.0
.bss 25408 25408 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 255328 255328 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 497557 497557 0 0.0
.text 8236261 8236261 0 0.0
chip-tool-ipv6only arm64 (read only) 9044500 9044500 0 0.0
(read/write) 401521 401521 0 0.0
.bss 43745 43745 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 300984 300984 0 0.0
.dynamic 560 560 0 0.0
.got 51816 51816 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473324 473324 0 0.0
.text 7692596 7692596 0 0.0
door-lock-app debug (read only) 1943769 1943769 0 0.0
(read/write) 119232 119232 0 0.0
.bss 50624 50624 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62168 62168 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173692 173692 0 0.0
.text 1621618 1621618 0 0.0
lighting-app debug+rpc (read only) 2079601 2079601 0 0.0
(read/write) 124624 124624 0 0.0
.bss 51552 51552 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66120 66120 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 166460 166460 0 0.0
.text 1757714 1757714 0 0.0
ota-provider-app debug (read only) 1875889 1875889 0 0.0
(read/write) 114864 114864 0 0.0
.bss 50432 50432 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57448 57448 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158899 158899 0 0.0
.text 1566450 1566450 0 0.0
ota-requestor-app debug (read only) 1887097 1887097 0 0.0
(read/write) 116888 116888 0 0.0
.bss 51296 51296 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 58696 58696 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 152804 152804 0 0.0
.text 1585458 1585458 0 0.0
shell debug (read only) 2371657 2371657 0 0.0
(read/write) 147248 147248 0 0.0
.bss 67624 67624 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73112 73112 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 204978 204978 0 0.0
.text 2010146 2010146 0 0.0
thermostat-no-ble arm64 (read only) 2169572 2169572 0 0.0
(read/write) 148625 148625 0 0.0
.bss 65345 65345 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75032 75032 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132996 132996 0 0.0
.text 1818352 1818352 0 0.0
tv-app debug (read only) 2608017 2608017 0 0.0
(read/write) 250840 250840 0 0.0
.bss 168096 168096 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73512 73512 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199165 199165 0 0.0
.text 2235186 2235186 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350996 2350996 0 0.0
.bss 187156 187156 0 0.0
.data 5784 5784 0 0.0
.text 1313596 1313596 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1040115 1076387 36272 3.5
bss 125828 127680 1852 1.5
rodata 135820 141724 5904 4.3
text 701220 729580 28360 4.0
p6 all-clusters-app default (read/write) 2489552 2489552 0 0.0
.bss 118736 118736 0 0.0
.data 2696 2696 0 0.0
.text 1447816 1447816 0 0.0
light-app default (read/write) 2396728 2396728 0 0.0
.bss 113048 113048 0 0.0
.data 2544 2544 0 0.0
.text 1354992 1354992 0 0.0
lock-app default (read/write) 2360240 2360240 0 0.0
.bss 112792 112792 0 0.0
.data 2504 2504 0 0.0
.text 1318504 1318504 0 0.0
qpg lighting-app qpg6105+debug (read only) 602180 602180 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90928 90928 0 0.0
.data 1132 1132 0 0.0
.text 596860 596860 0 0.0
lock-app qpg6105+debug (read only) 567896 567896 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90936 90936 0 0.0
.data 1084 1084 0 0.0
.text 562576 562576 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 884222 884222 0 0.0
bss 86408 86408 0 0.0
noinit 37160 37160 0 0.0
text 625174 625174 0 0.0

@woody-apple woody-apple merged commit cb08301 into project-chip:master Mar 3, 2022
@mkardous-silabs mkardous-silabs deleted the fix/window_soft branch March 3, 2022 13:23
jmeg-sfy pushed a commit that referenced this pull request Mar 8, 2022
@mkardous-silabs @jmeg-sfy
Enable reset watermark for software diagnostics on Window cover app (#…
6b69e66 
…15758)

* add reset watermarks to window app

* generated files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkardous-silabs @woody-apple