Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup redundant helper function in localization configuration server #15744

Merged
merged 2 commits into from
Mar 3, 2022
Merged

Cleanup redundant helper function in localization configuration server #15744

merged 2 commits into from
Mar 3, 2022

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

  • helper function in localization configuration server is redundant, it just return the constant status code.

Change overview

Cleanup redundant helper function in localization configuration server

Testing

How was this tested? (at least one bullet point required)

  • cleanup only, no logic change

@boring-cyborg boring-cyborg bot added the app label Mar 2, 2022
@github-actions
Copy link

github-actions bot commented Mar 2, 2022 •
edited
Loading

PR #15744: Size comparison from cd7fd48 to d52befb

Increases above 0.2%:

platform target config section cd7fd48 d52befb change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039967 1076235 36268 3.5
bss 125828 127680 1852 1.5
rodata 135736 141636 5900 4.3
text 701156 729516 28360 4.0
Increases (1 build for nrfconnect)
platform target config section cd7fd48 d52befb change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039967 1076235 36268 3.5
bss 125828 127680 1852 1.5
rodata 135736 141636 5900 4.3
text 701156 729516 28360 4.0
Decreases (13 builds for efr32, linux, p6)
platform target config section cd7fd48 d52befb change % change
efr32 lighting-app BRD4161A+rpc (read only) 947788 947772 -16 -0.0
.text 947780 947764 -16 -0.0
lock-app BRD4161A+wf200 (read only) 987536 987520 -16 -0.0
.text 987528 987512 -16 -0.0
window-app BRD4161A (read only) 851648 851632 -16 -0.0
.text 851640 851624 -16 -0.0
linux all-clusters-app debug (read only) 2402705 2402641 -64 -0.0
.text 2034994 2034930 -64 -0.0
bridge-app debug+rpc (read only) 1728237 1728173 -64 -0.0
.text 1470901 1470837 -64 -0.0
door-lock-app debug (read only) 1943289 1943225 -64 -0.0
.text 1621234 1621170 -64 -0.0
lighting-app debug+rpc (read only) 2079121 2079057 -64 -0.0
.text 1757330 1757266 -64 -0.0
ota-provider-app debug (read only) 1875409 1875345 -64 -0.0
.text 1566066 1566002 -64 -0.0
ota-requestor-app debug (read only) 1886385 1886321 -64 -0.0
.text 1585058 1584994 -64 -0.0
shell debug (read only) 2371177 2371113 -64 -0.0
.text 2009762 2009698 -64 -0.0
thermostat-no-ble arm64 (read only) 2169396 2169332 -64 -0.0
.text 1818176 1818112 -64 -0.0
tv-app debug (read only) 2607737 2607673 -64 -0.0
.text 2234850 2234786 -64 -0.0
p6 light-app default (read/write) 2396568 2396552 -16 -0.0
.text 1354832 1354816 -16 -0.0
Full report (28 builds for cyw30739, efr32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section cd7fd48 d52befb change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600590 600590 0 0.0
.app_xip_area 505364 505364 0 0.0
.bss 77908 77908 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 558586 558586 0 0.0
.app_xip_area 464896 464896 0 0.0
.bss 76412 76412 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578998 578998 0 0.0
.app_xip_area 475876 475876 0 0.0
.bss 85516 85516 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 917696 917696 0 0.0
(read/write) 128672 128672 0 0.0
.bss 126616 126616 0 0.0
.data 2056 2056 0 0.0
.text 917688 917688 0 0.0
BRD4161A+rpc (read only) 947788 947772 -16 -0.0
(read/write) 145612 145612 0 0.0
.bss 143392 143392 0 0.0
.data 2220 2220 0 0.0
.text 947780 947764 -16 -0.0
lock-app BRD4161A+wf200 (read only) 987536 987520 -16 -0.0
(read/write) 120436 120436 0 0.0
.bss 118500 118500 0 0.0
.data 1932 1932 0 0.0
.text 987528 987512 -16 -0.0
window-app BRD4161A (read only) 851648 851632 -16 -0.0
(read/write) 126912 126912 0 0.0
.bss 124984 124984 0 0.0
.data 1924 1924 0 0.0
.text 851640 851624 -16 -0.0
k32w light k32w061+release (read/write) 692704 692704 0 0.0
.bss 77544 77544 0 0.0
.data 1932 1932 0 0.0
.text 607428 607428 0 0.0
lock k32w061+release (read/write) 696048 696048 0 0.0
.bss 77744 77744 0 0.0
.data 1972 1972 0 0.0
.text 610532 610532 0 0.0
linux all-clusters-app debug (read only) 2402705 2402641 -64 -0.0
(read/write) 144824 144824 0 0.0
.bss 59328 59328 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78392 78392 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 204965 204965 0 0.0
.text 2034994 2034930 -64 -0.0
bridge-app debug+rpc (read only) 1728237 1728173 -64 -0.0
(read/write) 92784 92784 0 0.0
.bss 47624 47624 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38040 38040 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141556 141556 0 0.0
.text 1470901 1470837 -64 -0.0
chip-tool debug (read only) 9008789 9008789 0 0.0
(read/write) 283496 283496 0 0.0
.bss 25408 25408 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 250912 250912 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 480245 480245 0 0.0
.text 7920357 7920357 0 0.0
chip-tool-ipv6only arm64 (read only) 8763140 8763140 0 0.0
(read/write) 397105 397105 0 0.0
.bss 43745 43745 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 296568 296568 0 0.0
.dynamic 560 560 0 0.0
.got 51816 51816 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 457900 457900 0 0.0
.text 7439908 7439908 0 0.0
door-lock-app debug (read only) 1943289 1943225 -64 -0.0
(read/write) 119232 119232 0 0.0
.bss 50624 50624 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62168 62168 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173596 173596 0 0.0
.text 1621234 1621170 -64 -0.0
lighting-app debug+rpc (read only) 2079121 2079057 -64 -0.0
(read/write) 124624 124624 0 0.0
.bss 51552 51552 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66120 66120 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 166364 166364 0 0.0
.text 1757330 1757266 -64 -0.0
ota-provider-app debug (read only) 1875409 1875345 -64 -0.0
(read/write) 114864 114864 0 0.0
.bss 50432 50432 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57448 57448 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158803 158803 0 0.0
.text 1566066 1566002 -64 -0.0
ota-requestor-app debug (read only) 1886385 1886321 -64 -0.0
(read/write) 116632 116632 0 0.0
.bss 51296 51296 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 58696 58696 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 152516 152516 0 0.0
.text 1585058 1584994 -64 -0.0
shell debug (read only) 2371177 2371113 -64 -0.0
(read/write) 147248 147248 0 0.0
.bss 67624 67624 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73112 73112 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 204882 204882 0 0.0
.text 2009762 2009698 -64 -0.0
thermostat-no-ble arm64 (read only) 2169396 2169332 -64 -0.0
(read/write) 148625 148625 0 0.0
.bss 65345 65345 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75032 75032 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132996 132996 0 0.0
.text 1818176 1818112 -64 -0.0
tv-app debug (read only) 2607737 2607673 -64 -0.0
(read/write) 250904 250904 0 0.0
.bss 168096 168096 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73576 73576 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199101 199101 0 0.0
.text 2234850 2234786 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039967 1076235 36268 3.5
bss 125828 127680 1852 1.5
rodata 135736 141636 5900 4.3
text 701156 729516 28360 4.0
p6 all-clusters-app default (read/write) 2489400 2489400 0 0.0
.bss 118736 118736 0 0.0
.data 2696 2696 0 0.0
.text 1447664 1447664 0 0.0
light-app default (read/write) 2396568 2396552 -16 -0.0
.bss 113048 113048 0 0.0
.data 2544 2544 0 0.0
.text 1354832 1354816 -16 -0.0
lock-app default (read/write) 2360080 2360080 0 0.0
.bss 112792 112792 0 0.0
.data 2504 2504 0 0.0
.text 1318344 1318344 0 0.0
qpg lighting-app qpg6105+debug (read only) 602140 602140 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90928 90928 0 0.0
.data 1132 1132 0 0.0
.text 596820 596820 0 0.0
lock-app qpg6105+debug (read only) 567856 567856 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90936 90936 0 0.0
.data 1084 1084 0 0.0
.text 562536 562536 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 884190 884190 0 0.0
bss 86408 86408 0 0.0
noinit 37160 37160 0 0.0
text 625148 625148 0 0.0

@yufengwangca @bzbarsky-apple
Update src/app/clusters/localization-configuration-server/localizatio…
d911ad0 
…n-configuration-server.cpp

Co-authored-by: Boris Zbarsky <[email protected]>
@github-actions
Copy link

github-actions bot commented Mar 3, 2022 •
edited
Loading

PR #15744: Size comparison from e0a5a75 to d911ad0

Decreases (12 builds for efr32, linux, p6)
platform target config section e0a5a75 d911ad0 change % change
efr32 lock-app BRD4161A+wf200 (read only) 987964 987948 -16 -0.0
.text 987956 987940 -16 -0.0
window-app BRD4161A (read only) 852696 852680 -16 -0.0
.text 852688 852672 -16 -0.0
linux all-clusters-app debug (read only) 2402065 2402001 -64 -0.0
.text 2034290 2034226 -64 -0.0
bridge-app debug+rpc (read only) 1728061 1727997 -64 -0.0
.text 1470597 1470533 -64 -0.0
door-lock-app debug (read only) 1942569 1942505 -64 -0.0
.text 1620514 1620450 -64 -0.0
lighting-app debug+rpc (read only) 2078017 2077953 -64 -0.0
.text 1756610 1756546 -64 -0.0
ota-provider-app debug (read only) 1874913 1874849 -64 -0.0
.text 1565506 1565442 -64 -0.0
ota-requestor-app debug (read only) 1886121 1886057 -64 -0.0
.text 1584898 1584834 -64 -0.0
shell debug (read only) 2371097 2371033 -64 -0.0
.text 2009554 2009490 -64 -0.0
thermostat-no-ble arm64 (read only) 2168708 2168644 -64 -0.0
.text 1817568 1817504 -64 -0.0
tv-app debug (read only) 2608977 2608913 -64 -0.0
.text 2235906 2235842 -64 -0.0
p6 lock-app default (read/write) 2360080 2360064 -16 -0.0
.text 1318344 1318328 -16 -0.0
Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e0a5a75 d911ad0 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600166 600166 0 0.0
.app_xip_area 505188 505188 0 0.0
.bss 77660 77660 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 558170 558170 0 0.0
.app_xip_area 464728 464728 0 0.0
.bss 76164 76164 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578798 578798 0 0.0
.app_xip_area 475660 475660 0 0.0
.bss 85532 85532 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 918160 918160 0 0.0
(read/write) 128816 128816 0 0.0
.bss 126760 126760 0 0.0
.data 2056 2056 0 0.0
.text 918152 918152 0 0.0
BRD4161A+rpc (read only) 948228 948228 0 0.0
(read/write) 145756 145756 0 0.0
.bss 143536 143536 0 0.0
.data 2220 2220 0 0.0
.text 948220 948220 0 0.0
lock-app BRD4161A+wf200 (read only) 987964 987948 -16 -0.0
(read/write) 120312 120312 0 0.0
.bss 118380 118380 0 0.0
.data 1932 1932 0 0.0
.text 987956 987940 -16 -0.0
window-app BRD4161A (read only) 852696 852680 -16 -0.0
(read/write) 126784 126784 0 0.0
.bss 124856 124856 0 0.0
.data 1924 1924 0 0.0
.text 852688 852672 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 952974 952974 0 0.0
(read/write) 1392586 1392586 0 0.0
.dram0.bss 62536 62536 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 196896 196896 0 0.0
.flash.text 952974 952974 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1008183 1008183 0 0.0
(read/write) 459708 459708 0 0.0
.dram0.bss 68056 68056 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225736 225736 0 0.0
.flash.text 1002799 1002799 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 692500 692500 0 0.0
.bss 77688 77688 0 0.0
.data 1932 1932 0 0.0
.text 607080 607080 0 0.0
lock k32w061+release (read/write) 695652 695652 0 0.0
.bss 77616 77616 0 0.0
.data 1972 1972 0 0.0
.text 610264 610264 0 0.0
linux all-clusters-app debug (read only) 2402065 2402001 -64 -0.0
(read/write) 144600 144600 0 0.0
.bss 59104 59104 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78392 78392 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 205029 205029 0 0.0
.text 2034290 2034226 -64 -0.0
bridge-app debug+rpc (read only) 1728061 1727997 -64 -0.0
(read/write) 92560 92560 0 0.0
.bss 47400 47400 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38040 38040 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141684 141684 0 0.0
.text 1470597 1470533 -64 -0.0
chip-tool debug (read only) 9398141 9398141 0 0.0
(read/write) 305736 305736 0 0.0
.bss 25440 25440 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 273152 273152 0 0.0
.dynamic 608 608 0 0.0
.got 4760 4760 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 497781 497781 0 0.0
.text 8239317 8239317 0 0.0
chip-tool-ipv6only arm64 (read only) 9096660 9096660 0 0.0
(read/write) 418497 418497 0 0.0
.bss 43761 43761 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 317920 317920 0 0.0
.dynamic 560 560 0 0.0
.got 51848 51848 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473580 473580 0 0.0
.text 7705412 7705412 0 0.0
door-lock-app debug (read only) 1942569 1942505 -64 -0.0
(read/write) 119008 119008 0 0.0
.bss 50400 50400 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62168 62168 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173596 173596 0 0.0
.text 1620514 1620450 -64 -0.0
lighting-app debug+rpc (read only) 2078017 2077953 -64 -0.0
(read/write) 124400 124400 0 0.0
.bss 51328 51328 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66136 66136 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 165980 165980 0 0.0
.text 1756610 1756546 -64 -0.0
ota-provider-app debug (read only) 1874913 1874849 -64 -0.0
(read/write) 114640 114640 0 0.0
.bss 50208 50208 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57448 57448 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158867 158867 0 0.0
.text 1565506 1565442 -64 -0.0
ota-requestor-app debug (read only) 1886121 1886057 -64 -0.0
(read/write) 116952 116952 0 0.0
.bss 51360 51360 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 58696 58696 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 152388 152388 0 0.0
.text 1584898 1584834 -64 -0.0
shell debug (read only) 2371097 2371033 -64 -0.0
(read/write) 146832 146832 0 0.0
.bss 67176 67176 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73128 73128 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 205010 205010 0 0.0
.text 2009554 2009490 -64 -0.0
thermostat-no-ble arm64 (read only) 2168708 2168644 -64 -0.0
(read/write) 148385 148385 0 0.0
.bss 65121 65121 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75032 75032 0 0.0
.dynamic 560 560 0 0.0
.got 4208 4208 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132932 132932 0 0.0
.text 1817568 1817504 -64 -0.0
tv-app debug (read only) 2608977 2608913 -64 -0.0
(read/write) 250744 250744 0 0.0
.bss 167904 167904 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73608 73608 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199165 199165 0 0.0
.text 2235906 2235842 -64 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350668 2350668 0 0.0
.bss 187036 187036 0 0.0
.data 5784 5784 0 0.0
.text 1313268 1313268 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1076419 1076419 0 0.0
bss 128876 128876 0 0.0
rodata 141692 141692 0 0.0
text 730656 730656 0 0.0
p6 all-clusters-app default (read/write) 2489416 2489416 0 0.0
.bss 118608 118608 0 0.0
.data 2696 2696 0 0.0
.text 1447680 1447680 0 0.0
light-app default (read/write) 2396552 2396552 0 0.0
.bss 112920 112920 0 0.0
.data 2544 2544 0 0.0
.text 1354816 1354816 0 0.0
lock-app default (read/write) 2360080 2360064 -16 -0.0
.bss 112664 112664 0 0.0
.data 2504 2504 0 0.0
.text 1318344 1318328 -16 -0.0
qpg lighting-app qpg6105+debug (read only) 601704 601704 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91064 91064 0 0.0
.data 1132 1132 0 0.0
.text 596384 596384 0 0.0
lock-app qpg6105+debug (read only) 567404 567404 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91072 91072 0 0.0
.data 1084 1084 0 0.0
.text 562084 562084 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883682 883682 0 0.0
bss 86280 86280 0 0.0
noinit 37160 37160 0 0.0
text 624918 624918 0 0.0

@andy31415 andy31415 merged commit 050b4a7 into project-chip:master Mar 3, 2022
@yufengwangca yufengwangca deleted the pr/cluster/localization branch March 8, 2022 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yufengwangca @andy31415 @woody-apple @bzbarsky-apple