Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EFR32][Groups] Add group commands support to light-switch example #15727

Merged

Conversation

mkardous-silabs
Copy link
Contributor

Problem

  • Light-switch did not support group bindings / commands
  • Missings InvokeCommand function to send a group command from a device

Change overview

  • Added shell support for group commands
  • Added InvokeCommand for group commands

Known issues

  • Shell commands dont support specifying a groupId or nodeId so the command will be sent to all bindings matching the clusterId and fabric index
  • Commands can only be sent to fabric index 1 and endpoint 1 until shell commands can take inputs

Testing

  • Manual tests with three devices sending unicast and group commands from light-switch to lighting-apps

@github-actions
Copy link

github-actions bot commented Mar 3, 2022

PR #15727: Size comparison from 4ab9f60 to 724a233

Increases above 0.2%:

platform target config section 4ab9f60 724a233 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1040163 1078063 37900 3.6
bss 126760 128900 2140 1.7
rodata 135884 142024 6140 4.5
text 702452 731848 29396 4.2
Increases (1 build for nrfconnect)
platform target config section 4ab9f60 724a233 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1040163 1078063 37900 3.6
bss 126760 128900 2140 1.7
rodata 135884 142024 6140 4.5
text 702452 731848 29396 4.2
Decreases (1 build for mbed)
platform target config section 4ab9f60 724a233 change % change
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2350972 2350708 -264 -0.0
.text 1313572 1313308 -264 -0.0
Full report (2 builds for mbed, nrfconnect)
platform target config section 4ab9f60 724a233 change % change
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350972 2350708 -264 -0.0
.bss 187036 187036 0 0.0
.data 5784 5784 0 0.0
.text 1313572 1313308 -264 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1040163 1078063 37900 3.6
bss 126760 128900 2140 1.7
rodata 135884 142024 6140 4.5
text 702452 731848 29396 4.2

@mkardous-silabs mkardous-silabs force-pushed the feature/group_binding branch from 724a233 to f769792 Compare March 4, 2022 19:27
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

PR #15727: Size comparison from 2ecc827 to f769792

Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 2ecc827 f769792 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601498 601498 0 0.0
.app_xip_area 506040 506040 0 0.0
.bss 78140 78140 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559418 559418 0 0.0
.app_xip_area 465496 465496 0 0.0
.bss 76644 76644 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581374 581374 0 0.0
.app_xip_area 477780 477780 0 0.0
.bss 85964 85964 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920212 920212 0 0.0
(read/write) 128832 128832 0 0.0
.bss 126752 126752 0 0.0
.data 2080 2080 0 0.0
.text 920204 920204 0 0.0
BRD4161A+rpc (read only) 949024 949024 0 0.0
(read/write) 144792 144792 0 0.0
.bss 142528 142528 0 0.0
.data 2260 2260 0 0.0
.text 949016 949016 0 0.0
lock-app BRD4161A+wf200 (read only) 988396 988396 0 0.0
(read/write) 120360 120360 0 0.0
.bss 118428 118428 0 0.0
.data 1932 1932 0 0.0
.text 988388 988388 0 0.0
window-app BRD4161A (read only) 853472 853472 0 0.0
(read/write) 126832 126832 0 0.0
.bss 124904 124904 0 0.0
.data 1924 1924 0 0.0
.text 853464 853464 0 0.0
esp32 all-clusters-app c3devkit (read only) 957178 957178 0 0.0
(read/write) 1393570 1393570 0 0.0
.dram0.bss 63424 63424 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197000 197000 0 0.0
.flash.text 957178 957178 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1011927 1011927 0 0.0
(read/write) 460684 460684 0 0.0
.dram0.bss 68952 68952 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225816 225816 0 0.0
.flash.text 1006543 1006543 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694204 694204 0 0.0
.bss 77688 77688 0 0.0
.data 1964 1964 0 0.0
.text 608752 608752 0 0.0
lock k32w061+release (read/write) 696032 696032 0 0.0
.bss 77664 77664 0 0.0
.data 1972 1972 0 0.0
.text 610596 610596 0 0.0
linux all-clusters-app debug (read only) 2425537 2425537 0 0.0
(read/write) 145656 145656 0 0.0
.bss 60128 60128 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78408 78408 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 205477 205477 0 0.0
.text 2057074 2057074 0 0.0
bridge-app debug+rpc (read only) 1730429 1730429 0 0.0
(read/write) 92624 92624 0 0.0
.bss 47432 47432 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38056 38056 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141684 141684 0 0.0
.text 1472725 1472725 0 0.0
chip-tool debug (read only) 9535117 9535117 0 0.0
(read/write) 330608 330608 0 0.0
.bss 25536 25536 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 297888 297888 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 499381 499381 0 0.0
.text 8314005 8314005 0 0.0
chip-tool-ipv6only arm64 (read only) 9221684 9221684 0 0.0
(read/write) 443473 443473 0 0.0
.bss 43841 43841 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 342696 342696 0 0.0
.dynamic 560 560 0 0.0
.got 51952 51952 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 475196 475196 0 0.0
.text 7767732 7767732 0 0.0
door-lock-app debug (read only) 1944737 1944737 0 0.0
(read/write) 119072 119072 0 0.0
.bss 50432 50432 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173596 173596 0 0.0
.text 1622450 1622450 0 0.0
lighting-app debug+rpc (read only) 2076929 2076929 0 0.0
(read/write) 124368 124368 0 0.0
.bss 51264 51264 0 0.0
.data 1536 1536 0 0.0
.data.rel.ro 66088 66088 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 165788 165788 0 0.0
.text 1755506 1755506 0 0.0
ota-provider-app debug (read only) 1877273 1877273 0 0.0
(read/write) 114704 114704 0 0.0
.bss 50240 50240 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158835 158835 0 0.0
.text 1567666 1567666 0 0.0
ota-requestor-app debug (read only) 1898753 1898753 0 0.0
(read/write) 117408 117408 0 0.0
.bss 51296 51296 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 59160 59160 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 153996 153996 0 0.0
.text 1594674 1594674 0 0.0
shell debug (read only) 2392321 2392321 0 0.0
(read/write) 149904 149904 0 0.0
.bss 70216 70216 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73144 73144 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 205426 205426 0 0.0
.text 2030130 2030130 0 0.0
thermostat-no-ble arm64 (read only) 2173812 2173812 0 0.0
(read/write) 148513 148513 0 0.0
.bss 65201 65201 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75048 75048 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132964 132964 0 0.0
.text 1822416 1822416 0 0.0
tv-app debug (read only) 2615457 2615457 0 0.0
(read/write) 250776 250776 0 0.0
.bss 167936 167936 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73616 73616 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199453 199453 0 0.0
.text 2241842 2241842 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350324 2350324 0 0.0
.bss 186076 186076 0 0.0
.data 5800 5800 0 0.0
.text 1312924 1312924 0 0.0
p6 all-clusters-app default (read/write) 2493616 2493616 0 0.0
.bss 119496 119496 0 0.0
.data 2696 2696 0 0.0
.text 1451880 1451880 0 0.0
light-app default (read/write) 2397080 2397080 0 0.0
.bss 112968 112968 0 0.0
.data 2544 2544 0 0.0
.text 1355344 1355344 0 0.0
lock-app default (read/write) 2360512 2360512 0 0.0
.bss 112712 112712 0 0.0
.data 2504 2504 0 0.0
.text 1318776 1318776 0 0.0
qpg lighting-app qpg6105+debug (read only) 603444 603444 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91064 91064 0 0.0
.data 1164 1164 0 0.0
.text 598124 598124 0 0.0
lock-app qpg6105+debug (read only) 569064 569064 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91072 91072 0 0.0
.data 1116 1116 0 0.0
.text 563744 563744 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888522 888522 0 0.0
bss 86920 86920 0 0.0
noinit 37160 37160 0 0.0
text 627914 627914 0 0.0

@woody-apple
Copy link
Contributor

/rebase

@woody-apple woody-apple force-pushed the feature/group_binding branch from f769792 to 0c0079f Compare March 5, 2022 00:38
@github-actions
Copy link

github-actions bot commented Mar 5, 2022

PR #15727: Size comparison from dbbc6e9 to 0c0079f

Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section dbbc6e9 0c0079f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601546 601546 0 0.0
.app_xip_area 506088 506088 0 0.0
.bss 78140 78140 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559522 559522 0 0.0
.app_xip_area 465600 465600 0 0.0
.bss 76644 76644 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581478 581478 0 0.0
.app_xip_area 477884 477884 0 0.0
.bss 85964 85964 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920260 920260 0 0.0
(read/write) 128832 128832 0 0.0
.bss 126752 126752 0 0.0
.data 2080 2080 0 0.0
.text 920252 920252 0 0.0
BRD4161A+rpc (read only) 949072 949072 0 0.0
(read/write) 144792 144792 0 0.0
.bss 142528 142528 0 0.0
.data 2260 2260 0 0.0
.text 949064 949064 0 0.0
lock-app BRD4161A+wf200 (read only) 988492 988492 0 0.0
(read/write) 120360 120360 0 0.0
.bss 118428 118428 0 0.0
.data 1932 1932 0 0.0
.text 988484 988484 0 0.0
window-app BRD4161A (read only) 853568 853568 0 0.0
(read/write) 126832 126832 0 0.0
.bss 124904 124904 0 0.0
.data 1924 1924 0 0.0
.text 853560 853560 0 0.0
esp32 all-clusters-app c3devkit (read only) 957240 957240 0 0.0
(read/write) 1393570 1393570 0 0.0
.dram0.bss 63424 63424 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197000 197000 0 0.0
.flash.text 957240 957240 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1011955 1011955 0 0.0
(read/write) 460684 460684 0 0.0
.dram0.bss 68952 68952 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225816 225816 0 0.0
.flash.text 1006571 1006571 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694316 694316 0 0.0
.bss 77688 77688 0 0.0
.data 1964 1964 0 0.0
.text 608864 608864 0 0.0
lock k32w061+release (read/write) 696144 696144 0 0.0
.bss 77664 77664 0 0.0
.data 1972 1972 0 0.0
.text 610708 610708 0 0.0
linux all-clusters-app debug (read only) 2425553 2425553 0 0.0
(read/write) 145656 145656 0 0.0
.bss 60128 60128 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78408 78408 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 205381 205381 0 0.0
.text 2057186 2057186 0 0.0
bridge-app debug+rpc (read only) 1730989 1730989 0 0.0
(read/write) 92624 92624 0 0.0
.bss 47432 47432 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38056 38056 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141684 141684 0 0.0
.text 1473285 1473285 0 0.0
chip-tool debug (read only) 9628077 9628077 0 0.0
(read/write) 337392 337392 0 0.0
.bss 25536 25536 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 304672 304672 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 501941 501941 0 0.0
.text 8389621 8389621 0 0.0
chip-tool-ipv6only arm64 (read only) 9306740 9306740 0 0.0
(read/write) 451473 451473 0 0.0
.bss 43841 43841 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 349768 349768 0 0.0
.dynamic 560 560 0 0.0
.got 52880 52880 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 477964 477964 0 0.0
.text 7832164 7832164 0 0.0
door-lock-app debug (read only) 1945281 1945281 0 0.0
(read/write) 119072 119072 0 0.0
.bss 50432 50432 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173596 173596 0 0.0
.text 1622994 1622994 0 0.0
lighting-app debug+rpc (read only) 2076929 2076929 0 0.0
(read/write) 124368 124368 0 0.0
.bss 51264 51264 0 0.0
.data 1536 1536 0 0.0
.data.rel.ro 66088 66088 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 165692 165692 0 0.0
.text 1755602 1755602 0 0.0
ota-provider-app debug (read only) 1877833 1877833 0 0.0
(read/write) 114704 114704 0 0.0
.bss 50240 50240 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158835 158835 0 0.0
.text 1568226 1568226 0 0.0
ota-requestor-app debug (read only) 1899313 1899313 0 0.0
(read/write) 117408 117408 0 0.0
.bss 51296 51296 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 59160 59160 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 153996 153996 0 0.0
.text 1595234 1595234 0 0.0
shell debug (read only) 2392337 2392337 0 0.0
(read/write) 149904 149904 0 0.0
.bss 70216 70216 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73144 73144 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 205330 205330 0 0.0
.text 2030242 2030242 0 0.0
thermostat-no-ble arm64 (read only) 2174068 2174068 0 0.0
(read/write) 148513 148513 0 0.0
.bss 65201 65201 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75048 75048 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132964 132964 0 0.0
.text 1822672 1822672 0 0.0
tv-app debug (read only) 2617217 2617217 0 0.0
(read/write) 250776 250776 0 0.0
.bss 167936 167936 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73616 73616 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199389 199389 0 0.0
.text 2243666 2243666 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350468 2350468 0 0.0
.bss 186076 186076 0 0.0
.data 5800 5800 0 0.0
.text 1313068 1313068 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151247 1151247 0 0.0
bss 146776 146776 0 0.0
rodata 144248 144248 0 0.0
text 785008 785008 0 0.0
p6 all-clusters-app default (read/write) 2493680 2493680 0 0.0
.bss 119496 119496 0 0.0
.data 2696 2696 0 0.0
.text 1451944 1451944 0 0.0
light-app default (read/write) 2397128 2397128 0 0.0
.bss 112968 112968 0 0.0
.data 2544 2544 0 0.0
.text 1355392 1355392 0 0.0
lock-app default (read/write) 2360608 2360608 0 0.0
.bss 112712 112712 0 0.0
.data 2504 2504 0 0.0
.text 1318872 1318872 0 0.0
qpg lighting-app qpg6105+debug (read only) 603508 603508 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91064 91064 0 0.0
.data 1164 1164 0 0.0
.text 598188 598188 0 0.0
lock-app qpg6105+debug (read only) 569168 569168 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91072 91072 0 0.0
.data 1116 1116 0 0.0
.text 563848 563848 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888594 888594 0 0.0
bss 86920 86920 0 0.0
noinit 37160 37160 0 0.0
text 627988 627988 0 0.0

@woody-apple
Copy link
Contributor

/rebase

@github-actions
Copy link

github-actions bot commented Mar 5, 2022

PR #15727: Size comparison from d6bf695 to ce20d0c

Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d6bf695 ce20d0c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601546 601546 0 0.0
.app_xip_area 506088 506088 0 0.0
.bss 78140 78140 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559522 559522 0 0.0
.app_xip_area 465600 465600 0 0.0
.bss 76644 76644 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581718 581718 0 0.0
.app_xip_area 478116 478116 0 0.0
.bss 85972 85972 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920508 920508 0 0.0
(read/write) 128840 128840 0 0.0
.bss 126760 126760 0 0.0
.data 2080 2080 0 0.0
.text 920500 920500 0 0.0
BRD4161A+rpc (read only) 949344 949344 0 0.0
(read/write) 144800 144800 0 0.0
.bss 142536 142536 0 0.0
.data 2260 2260 0 0.0
.text 949336 949336 0 0.0
lock-app BRD4161A+wf200 (read only) 988492 988492 0 0.0
(read/write) 120360 120360 0 0.0
.bss 118428 118428 0 0.0
.data 1932 1932 0 0.0
.text 988484 988484 0 0.0
window-app BRD4161A (read only) 853568 853568 0 0.0
(read/write) 126832 126832 0 0.0
.bss 124904 124904 0 0.0
.data 1924 1924 0 0.0
.text 853560 853560 0 0.0
esp32 all-clusters-app c3devkit (read only) 957240 957240 0 0.0
(read/write) 1393570 1393570 0 0.0
.dram0.bss 63424 63424 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197000 197000 0 0.0
.flash.text 957240 957240 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1011955 1011955 0 0.0
(read/write) 460684 460684 0 0.0
.dram0.bss 68952 68952 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225816 225816 0 0.0
.flash.text 1006571 1006571 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694556 694556 0 0.0
.bss 77696 77696 0 0.0
.data 1964 1964 0 0.0
.text 609096 609096 0 0.0
lock k32w061+release (read/write) 696144 696144 0 0.0
.bss 77664 77664 0 0.0
.data 1972 1972 0 0.0
.text 610708 610708 0 0.0
linux all-clusters-app debug (read only) 2425689 2425689 0 0.0
(read/write) 145664 145664 0 0.0
.bss 60128 60128 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78408 78408 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205381 205381 0 0.0
.text 2057298 2057298 0 0.0
bridge-app debug+rpc (read only) 1730989 1730989 0 0.0
(read/write) 92624 92624 0 0.0
.bss 47432 47432 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38056 38056 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141684 141684 0 0.0
.text 1473285 1473285 0 0.0
chip-tool debug (read only) 9628077 9628077 0 0.0
(read/write) 337392 337392 0 0.0
.bss 25536 25536 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 304672 304672 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 501941 501941 0 0.0
.text 8389621 8389621 0 0.0
chip-tool-ipv6only arm64 (read only) 9306740 9306740 0 0.0
(read/write) 451473 451473 0 0.0
.bss 43841 43841 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 349768 349768 0 0.0
.dynamic 560 560 0 0.0
.got 52880 52880 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 477964 477964 0 0.0
.text 7832164 7832164 0 0.0
door-lock-app debug (read only) 1945281 1945281 0 0.0
(read/write) 119072 119072 0 0.0
.bss 50432 50432 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173596 173596 0 0.0
.text 1622994 1622994 0 0.0
lighting-app debug+rpc (read only) 2077065 2077065 0 0.0
(read/write) 124376 124376 0 0.0
.bss 51264 51264 0 0.0
.data 1536 1536 0 0.0
.data.rel.ro 66088 66088 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 165692 165692 0 0.0
.text 1755714 1755714 0 0.0
ota-provider-app debug (read only) 1877833 1877833 0 0.0
(read/write) 114704 114704 0 0.0
.bss 50240 50240 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158835 158835 0 0.0
.text 1568226 1568226 0 0.0
ota-requestor-app debug (read only) 1900233 1900233 0 0.0
(read/write) 117416 117416 0 0.0
.bss 51296 51296 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 59160 59160 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 154156 154156 0 0.0
.text 1595970 1595970 0 0.0
shell debug (read only) 2392457 2392457 0 0.0
(read/write) 149912 149912 0 0.0
.bss 70216 70216 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73144 73144 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205330 205330 0 0.0
.text 2030338 2030338 0 0.0
thermostat-no-ble arm64 (read only) 2174068 2174068 0 0.0
(read/write) 148513 148513 0 0.0
.bss 65201 65201 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75048 75048 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132964 132964 0 0.0
.text 1822672 1822672 0 0.0
tv-app debug (read only) 2617217 2617217 0 0.0
(read/write) 250776 250776 0 0.0
.bss 167936 167936 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73616 73616 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199389 199389 0 0.0
.text 2243666 2243666 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350468 2350468 0 0.0
.bss 186076 186076 0 0.0
.data 5800 5800 0 0.0
.text 1313068 1313068 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151479 1151479 0 0.0
bss 146784 146784 0 0.0
rodata 144272 144272 0 0.0
text 785228 785228 0 0.0
p6 all-clusters-app default (read/write) 2493680 2493680 0 0.0
.bss 119496 119496 0 0.0
.data 2696 2696 0 0.0
.text 1451944 1451944 0 0.0
light-app default (read/write) 2397128 2397128 0 0.0
.bss 112968 112968 0 0.0
.data 2544 2544 0 0.0
.text 1355392 1355392 0 0.0
lock-app default (read/write) 2360608 2360608 0 0.0
.bss 112712 112712 0 0.0
.data 2504 2504 0 0.0
.text 1318872 1318872 0 0.0
qpg lighting-app qpg6105+debug (read only) 603740 603740 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91072 91072 0 0.0
.data 1164 1164 0 0.0
.text 598420 598420 0 0.0
lock-app qpg6105+debug (read only) 569400 569400 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91080 91080 0 0.0
.data 1116 1116 0 0.0
.text 564080 564080 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888594 888594 0 0.0
bss 86920 86920 0 0.0
noinit 37160 37160 0 0.0
text 627988 627988 0 0.0

@mkardous-silabs mkardous-silabs force-pushed the feature/group_binding branch from ee3c71c to 2f63ec3 Compare March 7, 2022 14:27
@github-actions
Copy link

github-actions bot commented Mar 7, 2022

PR #15727: Size comparison from 65440ab to 2f63ec3

Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 65440ab 2f63ec3 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601654 601654 0 0.0
.app_xip_area 506188 506188 0 0.0
.bss 78148 78148 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559630 559630 0 0.0
.app_xip_area 465700 465700 0 0.0
.bss 76652 76652 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581826 581826 0 0.0
.app_xip_area 478216 478216 0 0.0
.bss 85980 85980 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920724 920724 0 0.0
(read/write) 128848 128848 0 0.0
.bss 126768 126768 0 0.0
.data 2080 2080 0 0.0
.text 920716 920716 0 0.0
BRD4161A+rpc (read only) 949560 949560 0 0.0
(read/write) 144808 144808 0 0.0
.bss 142544 142544 0 0.0
.data 2260 2260 0 0.0
.text 949552 949552 0 0.0
lock-app BRD4161A+wf200 (read only) 988692 988692 0 0.0
(read/write) 120368 120368 0 0.0
.bss 118436 118436 0 0.0
.data 1932 1932 0 0.0
.text 988684 988684 0 0.0
window-app BRD4161A (read only) 853784 853784 0 0.0
(read/write) 126840 126840 0 0.0
.bss 124912 124912 0 0.0
.data 1924 1924 0 0.0
.text 853776 853776 0 0.0
esp32 all-clusters-app c3devkit (read only) 957276 957276 0 0.0
(read/write) 1393586 1393586 0 0.0
.dram0.bss 63432 63432 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197000 197000 0 0.0
.flash.text 957276 957276 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012079 1012079 0 0.0
(read/write) 460692 460692 0 0.0
.dram0.bss 68960 68960 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225816 225816 0 0.0
.flash.text 1006695 1006695 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694616 694616 0 0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 609148 609148 0 0.0
lock k32w061+release (read/write) 696204 696204 0 0.0
.bss 77672 77672 0 0.0
.data 1972 1972 0 0.0
.text 610760 610760 0 0.0
linux all-clusters-app debug (read only) 2425521 2425521 0 0.0
(read/write) 145760 145760 0 0.0
.bss 60128 60128 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78504 78504 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205349 205349 0 0.0
.text 2057042 2057042 0 0.0
bridge-app debug+rpc (read only) 1730805 1730805 0 0.0
(read/write) 92720 92720 0 0.0
.bss 47432 47432 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38144 38144 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141652 141652 0 0.0
.text 1473013 1473013 0 0.0
chip-tool debug (read only) 9746901 9746901 0 0.0
(read/write) 338232 338232 0 0.0
.bss 25544 25544 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 305504 305504 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 509812 509812 0 0.0
.text 8498613 8498613 0 0.0
chip-tool-ipv6only arm64 (read only) 9420276 9420276 0 0.0
(read/write) 453761 453761 0 0.0
.bss 43841 43841 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 350648 350648 0 0.0
.dynamic 560 560 0 0.0
.got 54272 54272 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 485612 485612 0 0.0
.text 7931956 7931956 0 0.0
door-lock-app debug (read only) 1945161 1945161 0 0.0
(read/write) 119136 119136 0 0.0
.bss 50432 50432 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62264 62264 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173596 173596 0 0.0
.text 1622754 1622754 0 0.0
lighting-app debug+rpc (read only) 2076929 2076929 0 0.0
(read/write) 124536 124536 0 0.0
.bss 51296 51296 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 66184 66184 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 165692 165692 0 0.0
.text 1755458 1755458 0 0.0
ota-provider-app debug (read only) 1877713 1877713 0 0.0
(read/write) 114768 114768 0 0.0
.bss 50240 50240 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57544 57544 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158835 158835 0 0.0
.text 1567986 1567986 0 0.0
ota-requestor-app debug (read only) 1900081 1900081 0 0.0
(read/write) 117512 117512 0 0.0
.bss 51296 51296 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 59256 59256 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 154124 154124 0 0.0
.text 1595730 1595730 0 0.0
shell debug (read only) 2392305 2392305 0 0.0
(read/write) 149976 149976 0 0.0
.bss 70216 70216 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73232 73232 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205298 205298 0 0.0
.text 2030098 2030098 0 0.0
thermostat-no-ble arm64 (read only) 2174004 2174004 0 0.0
(read/write) 148609 148609 0 0.0
.bss 65201 65201 0 0.0
.data 1080 1080 0 0.0
.data.rel.ro 75136 75136 0 0.0
.dynamic 560 560 0 0.0
.got 4224 4224 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132948 132948 0 0.0
.text 1822432 1822432 0 0.0
tv-app debug (read only) 2617065 2617065 0 0.0
(read/write) 250872 250872 0 0.0
.bss 167936 167936 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73704 73704 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199389 199389 0 0.0
.text 2243394 2243394 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350468 2350468 0 0.0
.bss 186084 186084 0 0.0
.data 5800 5800 0 0.0
.text 1313068 1313068 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151515 1151515 0 0.0
bss 146792 146792 0 0.0
rodata 144276 144276 0 0.0
text 785260 785260 0 0.0
p6 all-clusters-app default (read/write) 2493880 2493880 0 0.0
.bss 119504 119504 0 0.0
.data 2696 2696 0 0.0
.text 1452144 1452144 0 0.0
light-app default (read/write) 2397328 2397328 0 0.0
.bss 112976 112976 0 0.0
.data 2544 2544 0 0.0
.text 1355592 1355592 0 0.0
lock-app default (read/write) 2360808 2360808 0 0.0
.bss 112720 112720 0 0.0
.data 2504 2504 0 0.0
.text 1319072 1319072 0 0.0
qpg lighting-app qpg6105+debug (read only) 603812 603812 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91080 91080 0 0.0
.data 1164 1164 0 0.0
.text 598492 598492 0 0.0
lock-app qpg6105+debug (read only) 569480 569480 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91088 91088 0 0.0
.data 1116 1116 0 0.0
.text 564160 564160 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888670 888670 0 0.0
bss 86928 86928 0 0.0
noinit 37160 37160 0 0.0
text 628058 628058 0 0.0

@github-actions
Copy link

github-actions bot commented Mar 7, 2022

PR #15727: Size comparison from 48eabd3 to 914e191

Full report (22 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 48eabd3 914e191 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601654 601654 0 0.0
.app_xip_area 506188 506188 0 0.0
.bss 78148 78148 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559630 559630 0 0.0
.app_xip_area 465700 465700 0 0.0
.bss 76652 76652 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581826 581826 0 0.0
.app_xip_area 478216 478216 0 0.0
.bss 85980 85980 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920724 920724 0 0.0
(read/write) 128848 128848 0 0.0
.bss 126768 126768 0 0.0
.data 2080 2080 0 0.0
.text 920716 920716 0 0.0
BRD4161A+rpc (read only) 949560 949560 0 0.0
(read/write) 144808 144808 0 0.0
.bss 142544 142544 0 0.0
.data 2260 2260 0 0.0
.text 949552 949552 0 0.0
lock-app BRD4161A+wf200 (read only) 988692 988692 0 0.0
(read/write) 120368 120368 0 0.0
.bss 118436 118436 0 0.0
.data 1932 1932 0 0.0
.text 988684 988684 0 0.0
window-app BRD4161A (read only) 853784 853784 0 0.0
(read/write) 126840 126840 0 0.0
.bss 124912 124912 0 0.0
.data 1924 1924 0 0.0
.text 853776 853776 0 0.0
esp32 all-clusters-app c3devkit (read only) 957276 957276 0 0.0
(read/write) 1393586 1393586 0 0.0
.dram0.bss 63432 63432 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197000 197000 0 0.0
.flash.text 957276 957276 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012079 1012079 0 0.0
(read/write) 460692 460692 0 0.0
.dram0.bss 68960 68960 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225816 225816 0 0.0
.flash.text 1006695 1006695 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694616 694616 0 0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 609148 609148 0 0.0
lock k32w061+release (read/write) 696204 696204 0 0.0
.bss 77672 77672 0 0.0
.data 1972 1972 0 0.0
.text 610760 610760 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9420420 9420420 0 0.0
(read/write) 453761 453761 0 0.0
.bss 43841 43841 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 350648 350648 0 0.0
.dynamic 560 560 0 0.0
.got 54272 54272 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 485612 485612 0 0.0
.text 7932100 7932100 0 0.0
thermostat-no-ble arm64 (read only) 2174116 2174116 0 0.0
(read/write) 148609 148609 0 0.0
.bss 65201 65201 0 0.0
.data 1080 1080 0 0.0
.data.rel.ro 75136 75136 0 0.0
.dynamic 560 560 0 0.0
.got 4224 4224 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132948 132948 0 0.0
.text 1822544 1822544 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350468 2350468 0 0.0
.bss 186084 186084 0 0.0
.data 5800 5800 0 0.0
.text 1313068 1313068 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151515 1151515 0 0.0
bss 146792 146792 0 0.0
rodata 144276 144276 0 0.0
text 785260 785260 0 0.0
p6 all-clusters-app default (read/write) 2493880 2493880 0 0.0
.bss 119504 119504 0 0.0
.data 2696 2696 0 0.0
.text 1452144 1452144 0 0.0
light-app default (read/write) 2397328 2397328 0 0.0
.bss 112976 112976 0 0.0
.data 2544 2544 0 0.0
.text 1355592 1355592 0 0.0
lock-app default (read/write) 2360808 2360808 0 0.0
.bss 112720 112720 0 0.0
.data 2504 2504 0 0.0
.text 1319072 1319072 0 0.0
qpg lighting-app qpg6105+debug (read only) 603812 603812 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91080 91080 0 0.0
.data 1164 1164 0 0.0
.text 598492 598492 0 0.0
lock-app qpg6105+debug (read only) 569480 569480 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91088 91088 0 0.0
.data 1116 1116 0 0.0
.text 564160 564160 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888670 888670 0 0.0
bss 86928 86928 0 0.0
noinit 37160 37160 0 0.0
text 628058 628058 0 0.0

@jmartinez-silabs jmartinez-silabs merged commit d2f5008 into project-chip:master Mar 7, 2022
mykrupp referenced this pull request in mykrupp/connectedhomeip-1 Mar 8, 2022
…15727)

* Refactor commands structure for light-switch

* Add group command support to light-switch

* generated files

* PR review comments

* read me update

* regen

* fix mispelled work
@mkardous-silabs mkardous-silabs deleted the feature/group_binding branch April 22, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants