-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EFR32][Groups] Add group commands support to light-switch example #15727
Merged
jmartinez-silabs
merged 8 commits into
project-chip:master
from
mkardous-silabs:feature/group_binding
Mar 7, 2022
Merged
[EFR32][Groups] Add group commands support to light-switch example #15727
jmartinez-silabs
merged 8 commits into
project-chip:master
from
mkardous-silabs:feature/group_binding
Mar 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda and
lzgrablic02
March 2, 2022 16:01
PR #15727: Size comparison from 4ab9f60 to 724a233 Increases above 0.2%:
Increases (1 build for nrfconnect)
Decreases (1 build for mbed)
Full report (2 builds for mbed, nrfconnect)
|
mkardous-silabs
force-pushed
the
feature/group_binding
branch
from
March 4, 2022 19:27
724a233
to
f769792
Compare
PR #15727: Size comparison from 2ecc827 to f769792 Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
/rebase |
woody-apple
force-pushed
the
feature/group_binding
branch
from
March 5, 2022 00:38
f769792
to
0c0079f
Compare
PR #15727: Size comparison from dbbc6e9 to 0c0079f Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
/rebase |
woody-apple
force-pushed
the
feature/group_binding
branch
from
March 5, 2022 02:20
0c0079f
to
ce20d0c
Compare
PR #15727: Size comparison from d6bf695 to ce20d0c Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
mkardous-silabs
force-pushed
the
feature/group_binding
branch
from
March 7, 2022 14:15
ce20d0c
to
9494128
Compare
mkardous-silabs
force-pushed
the
feature/group_binding
branch
from
March 7, 2022 14:27
ee3c71c
to
2f63ec3
Compare
PR #15727: Size comparison from 65440ab to 2f63ec3 Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #15727: Size comparison from 48eabd3 to 914e191 Full report (22 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmartinez-silabs
approved these changes
Mar 7, 2022
mykrupp
referenced
this pull request
in mykrupp/connectedhomeip-1
Mar 8, 2022
…15727) * Refactor commands structure for light-switch * Add group command support to light-switch * generated files * PR review comments * read me update * regen * fix mispelled work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Known issues
Testing