-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32: Fix onnetwork pairing when disabling CHIPoBLE #15707
Merged
Damian-Nordic
merged 1 commit into
project-chip:master
from
wqx6:fix_onnetwork_pairing_disable_CHIPOBLE
Mar 2, 2022
Merged
ESP32: Fix onnetwork pairing when disabling CHIPoBLE #15707
Damian-Nordic
merged 1 commit into
project-chip:master
from
wqx6:fix_onnetwork_pairing_disable_CHIPOBLE
Mar 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
lzgrablic02 and
mrjerryjohns
March 2, 2022 06:13
pullapprove
bot
requested review from
msandstedt,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
March 2, 2022 06:13
PR #15707: Size comparison from cd44d83 to 7569dd3 Increases above 0.2%:
Increases (1 build for nrfconnect)
Full report (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Mar 2, 2022
Damian-Nordic
approved these changes
Mar 2, 2022
dhrishi
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Onnetwork commissioning will fail on ESP32 when we disable config
ENABLE_CHIPOBLE
in menuconfig .Change overview
Fix the bug
Testing
Test all-clusters-app on ESP32C3 after disabling
ENABLE_CHIPOBLE
, usingmatter wifi connect ssid password
to connect ESP32C3 to an AP, then using chip-tool to finish on-network commissioning.