Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing headers to //src/platform #1569

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

mspang
Copy link
Contributor

@mspang mspang commented Jul 11, 2020

These were missed due to being outside the src/platform directory.

These were missed due to being outside the src/platform directory.
@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize


@andy31415 andy31415 merged commit db9b861 into project-chip:master Jul 13, 2020
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
These were missed due to being outside the src/platform directory.
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
These were missed due to being outside the src/platform directory.
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
These were missed due to being outside the src/platform directory.
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
These were missed due to being outside the src/platform directory.
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
These were missed due to being outside the src/platform directory.
@mspang mspang deleted the for-chip/missing-includes branch August 14, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants