Move cluster-defined enums/bitmaps into a separate header. #15686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcarmelveilleux
approved these changes
Mar 1, 2022
bzbarsky-apple
force-pushed
the
factor-out-cluster-enums
branch
from
c6b3108 to
6c5ce13
Compare
carol-apple
approved these changes
Mar 1, 2022
pullapprove
bot
requested review from
Byungjoo-Lee,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
hawk248,
harsha-rajendran,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
msandstedt,
saurabhst,
selissia,
tecimovic,
vijs,
wbschiller and
xylophone21
|
PR #15686: Size comparison from e87c25d to 6c5ce13 Increases above 0.2%:
Increases (1 build for nrfconnect)
Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
This was referenced Mar 1, 2022
|
/rebase |
woody-apple
force-pushed
the
factor-out-cluster-enums
branch
from
6c5ce13 to
7ab47db
Compare
|
PR #15686: Size comparison from b250d9a to 7ab47db Increases above 0.2%:
Increases (1 build for nrfconnect)
Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
We want to put basic cluster-defined constants (enums/bitmaps) into a header we can use from anywhere (just like data model concepts like NodeId and whatnot). But we don't want that for the C++ structs in cluster-objects, which can have ABI issues. Move the constants into a separate header, put that header into src/lib/core in terms of include dependencies.
bzbarsky-apple
force-pushed
the
factor-out-cluster-enums
branch
from
7ab47db to
0999282
Compare
|
PR #15686: Size comparison from cd44d83 to 0999282 Increases above 0.2%:
Increases (1 build for nrfconnect)
Full report (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to put basic cluster-defined constants (enums/bitmaps) into a
header we can use from anywhere (just like data model concepts like
NodeId and whatnot). But we don't want that for the C++ structs in
cluster-objects, which can have ABI issues.
Move the constants into a separate header, put that header into
src/lib/core in terms of include dependencies. Add an actual src/lib/core header people should be including.
Problem
Want to use cluster-defined constants in "platform" and whatnot code, but the dependencies are not our friends.
Change overview
Move these constants into a separate file which depends only on stdint.h and can be treated as a core header.
Testing
Tree compiles.