-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] Invert the logic for getting the path to use for the KVS as … #15676
[Darwin] Invert the logic for getting the path to use for the KVS as … #15676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks
PR #15676: Size comparison from 18ab5f4 to 3163dd8 Increases above 0.2%:
Increases (1 build for nrfconnect)
Full report (26 builds for cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
ToT generated template is out of sync again: #15680 |
Fast tracking based on this is just a platform change. |
3163dd8
to
1785749
Compare
PR #15676: Size comparison from d2dffce to 1785749 Increases above 0.2%:
Increases (1 build for nrfconnect)
Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
/rebase |
…it was inverted by mistake in project-chip#15586
1785749
to
cee4461
Compare
PR #15676: Size comparison from cd44d83 to cee4461 Increases above 0.2%:
Increases (1 build for nrfconnect)
Full report (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
…it was inverted by mistake in #15586
Problem
In 15586 the if/else logic was accidentally reversed.
Change overview