Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PersistentStorageDelegate APIs to be consistent about error reporting #15675

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Fix PersistentStorageDelegate APIs to be consistent about error reporting #15675

merged 1 commit into from
Mar 2, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Fixes #15671

Problem

Storage delegate has unclear API contract, implementation violate parts of it anyway.

Change overview

Define contract more clearly, fix violations.

Testing

Should not affect existing code. Should allow new code being added to not have to check for multiple possible error returns for the same situation.

@github-actions
Copy link

github-actions bot commented Mar 1, 2022 •
edited
Loading

PR #15675: Size comparison from 18ab5f4 to ee77cb7

Increases above 0.2%:

platform target config section 18ab5f4 ee77cb7 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039383 1075619 36236 3.5
bss 125820 127672 1852 1.5
rodata 135904 141772 5868 4.3
text 700432 728764 28332 4.0
Increases (5 builds for cyw30739, linux, nrfconnect)
platform target config section 18ab5f4 ee77cb7 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599990 600042 52 0.0
.app_xip_area 504764 504816 52 0.0
lock cyw930739m2evb_01 (read/write) 557978 558030 52 0.0
.app_xip_area 464288 464340 52 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578398 578450 52 0.0
.app_xip_area 475276 475328 52 0.0
linux chip-tool-ipv6only arm64 (read only) 8723412 8723716 304 0.0
.text 7405140 7405444 304 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039383 1075619 36236 3.5
bss 125820 127672 1852 1.5
rodata 135904 141772 5868 4.3
text 700432 728764 28332 4.0
Decreases (11 builds for esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 18ab5f4 ee77cb7 change % change
esp32 all-clusters-app m5stack (read only) 1005099 1005063 -36 -0.0
(read/write) 458336 458304 -32 -0.0
.flash.rodata 224600 224568 -32 -0.0
.flash.text 999715 999679 -36 -0.0
k32w light k32w061+release (read/write) 692176 692124 -52 -0.0
.text 606900 606848 -52 -0.0
lock k32w061+release (read/write) 695536 695468 -68 -0.0
.text 610020 609952 -68 -0.0
linux thermostat-no-ble arm64 (read only) 2164884 2164788 -96 -0.0
.rodata 133124 133092 -32 -0.0
.text 1813440 1813376 -64 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2350404 2350364 -40 -0.0
.text 1313004 1312964 -40 -0.0
p6 all-clusters-app default (read/write) 2488576 2488528 -48 -0.0
.text 1446840 1446792 -48 -0.0
light-app default (read/write) 2395784 2395728 -56 -0.0
.text 1354048 1353992 -56 -0.0
lock-app default (read/write) 2359312 2359240 -72 -0.0
.text 1317576 1317504 -72 -0.0
qpg lighting-app qpg6105+debug (read only) 601576 601560 -16 -0.0
.text 596256 596240 -16 -0.0
lock-app qpg6105+debug (read only) 567292 567276 -16 -0.0
.text 561972 561956 -16 -0.0
telink lighting-app tlsr9518adk80d (read/write) 883586 883526 -60 -0.0
text 624368 624346 -22 -0.0
Full report (17 builds for cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 18ab5f4 ee77cb7 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599990 600042 52 0.0
.app_xip_area 504764 504816 52 0.0
.bss 77908 77908 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557978 558030 52 0.0
.app_xip_area 464288 464340 52 0.0
.bss 76412 76412 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578398 578450 52 0.0
.app_xip_area 475276 475328 52 0.0
.bss 85516 85516 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app m5stack (read only) 1005099 1005063 -36 -0.0
(read/write) 458336 458304 -32 -0.0
.dram0.bss 68160 68160 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 224600 224568 -32 -0.0
.flash.text 999715 999679 -36 -0.0
.iram0.text 122767 122767 0 0.0
k32w light k32w061+release (read/write) 692176 692124 -52 -0.0
.bss 77544 77544 0 0.0
.data 1932 1932 0 0.0
.text 606900 606848 -52 -0.0
lock k32w061+release (read/write) 695536 695468 -68 -0.0
.bss 77744 77744 0 0.0
.data 1972 1972 0 0.0
.text 610020 609952 -68 -0.0
linux chip-tool-ipv6only arm64 (read only) 8723412 8723716 304 0.0
(read/write) 395713 395713 0 0.0
.bss 43617 43617 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 295760 295760 0 0.0
.dynamic 560 560 0 0.0
.got 51368 51368 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 455964 455964 0 0.0
.text 7405140 7405444 304 0.0
thermostat-no-ble arm64 (read only) 2164884 2164788 -96 -0.0
(read/write) 148657 148657 0 0.0
.bss 65329 65329 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75088 75088 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133124 133092 -32 -0.0
.text 1813440 1813376 -64 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350404 2350364 -40 -0.0
.bss 187156 187156 0 0.0
.data 5784 5784 0 0.0
.text 1313004 1312964 -40 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039383 1075619 36236 3.5
bss 125820 127672 1852 1.5
rodata 135904 141772 5868 4.3
text 700432 728764 28332 4.0
p6 all-clusters-app default (read/write) 2488576 2488528 -48 -0.0
.bss 118728 118728 0 0.0
.data 2696 2696 0 0.0
.text 1446840 1446792 -48 -0.0
light-app default (read/write) 2395784 2395728 -56 -0.0
.bss 113048 113048 0 0.0
.data 2544 2544 0 0.0
.text 1354048 1353992 -56 -0.0
lock-app default (read/write) 2359312 2359240 -72 -0.0
.bss 112792 112792 0 0.0
.data 2504 2504 0 0.0
.text 1317576 1317504 -72 -0.0
qpg lighting-app qpg6105+debug (read only) 601576 601560 -16 -0.0
(read/write) 146936 146936 0 0.0
.bss 90928 90928 0 0.0
.data 1132 1132 0 0.0
.text 596256 596240 -16 -0.0
lock-app qpg6105+debug (read only) 567292 567276 -16 -0.0
(read/write) 146936 146936 0 0.0
.bss 90936 90936 0 0.0
.data 1084 1084 0 0.0
.text 561972 561956 -16 -0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883586 883526 -60 -0.0
bss 86400 86400 0 0.0
noinit 37160 37160 0 0.0
text 624368 624346 -22 -0.0

@bzbarsky-apple bzbarsky-apple force-pushed the storage-delegate-api-clarity branch from ee77cb7 to 937fa4f Compare March 1, 2022 17:01
@restyled-io restyled-io bot mentioned this pull request Mar 1, 2022
Closed
@bzbarsky-apple
Copy link
Contributor Author

/rebase

@woody-apple woody-apple force-pushed the storage-delegate-api-clarity branch from 937fa4f to a964b0a Compare March 1, 2022 17:22
@bzbarsky-apple bzbarsky-apple force-pushed the storage-delegate-api-clarity branch from a964b0a to 30af653 Compare March 1, 2022 17:23
@github-actions
Copy link

github-actions bot commented Mar 1, 2022 •
edited
Loading

PR #15675: Size comparison from d2dffce to 30af653

Increases above 0.2%:

platform target config section d2dffce 30af653 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039383 1075619 36236 3.5
bss 125820 127672 1852 1.5
rodata 135904 141772 5868 4.3
text 700432 728764 28332 4.0
Increases (9 builds for cyw30739, efr32, linux, nrfconnect)
platform target config section d2dffce 30af653 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599990 600042 52 0.0
.app_xip_area 504764 504816 52 0.0
lock cyw930739m2evb_01 (read/write) 557978 558030 52 0.0
.app_xip_area 464288 464340 52 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578398 578450 52 0.0
.app_xip_area 475276 475328 52 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 120432 120436 4 0.0
window-app BRD4161A (read/write) 126908 126912 4 0.0
linux chip-tool debug (read only) 8962485 8962821 336 0.0
.text 7877669 7878005 336 0.0
chip-tool-ipv6only arm64 (read only) 8723412 8723716 304 0.0
.text 7405140 7405444 304 0.0
shell debug (read only) 2365369 2365401 32 0.0
.text 2003794 2003858 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039383 1075619 36236 3.5
bss 125820 127672 1852 1.5
rodata 135904 141772 5868 4.3
text 700432 728764 28332 4.0
Decreases (23 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section d2dffce 30af653 change % change
efr32 lighting-app BRD4161A (read only) 916916 916864 -52 -0.0
.text 916908 916856 -52 -0.0
BRD4161A+rpc (read only) 947000 946948 -52 -0.0
(read/write) 145616 145612 -4 -0.0
.text 946992 946940 -52 -0.0
lock-app BRD4161A+wf200 (read only) 986748 986680 -68 -0.0
.text 986740 986672 -68 -0.0
window-app BRD4161A (read only) 850844 850792 -52 -0.0
.text 850836 850784 -52 -0.0
esp32 all-clusters-app m5stack (read only) 1005099 1005063 -36 -0.0
(read/write) 458336 458304 -32 -0.0
.flash.rodata 224600 224568 -32 -0.0
.flash.text 999715 999679 -36 -0.0
k32w light k32w061+release (read/write) 692176 692124 -52 -0.0
.text 606900 606848 -52 -0.0
lock k32w061+release (read/write) 695536 695468 -68 -0.0
.text 610020 609952 -68 -0.0
linux all-clusters-app debug (read only) 2397185 2397041 -144 -0.0
.rodata 205029 204997 -32 -0.0
.text 2029314 2029202 -112 -0.0
bridge-app debug+rpc (read only) 1722765 1722589 -176 -0.0
.rodata 141652 141588 -64 -0.0
.text 1465237 1465125 -112 -0.0
door-lock-app debug (read only) 1937913 1937769 -144 -0.0
.rodata 173692 173660 -32 -0.0
.text 1615666 1615554 -112 -0.0
lighting-app debug+rpc (read only) 2073745 2073569 -176 -0.0
.rodata 166460 166396 -64 -0.0
.text 1751762 1751650 -112 -0.0
ota-provider-app debug (read only) 1870017 1869873 -144 -0.0
.rodata 158867 158835 -32 -0.0
.text 1560514 1560402 -112 -0.0
ota-requestor-app debug (read only) 1881025 1880849 -176 -0.0
.rodata 152612 152548 -64 -0.0
.text 1579506 1579394 -112 -0.0
shell debug .rodata 204946 204914 -32 -0.0
thermostat-no-ble arm64 (read only) 2164884 2164788 -96 -0.0
.rodata 133124 133092 -32 -0.0
.text 1813440 1813376 -64 -0.0
tv-app debug (read only) 2592169 2592121 -48 -0.0
.rodata 198909 198877 -32 -0.0
.text 2219426 2219410 -16 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2350404 2350364 -40 -0.0
.text 1313004 1312964 -40 -0.0
p6 all-clusters-app default (read/write) 2488576 2488528 -48 -0.0
.text 1446840 1446792 -48 -0.0
light-app default (read/write) 2395784 2395728 -56 -0.0
.text 1354048 1353992 -56 -0.0
lock-app default (read/write) 2359312 2359240 -72 -0.0
.text 1317576 1317504 -72 -0.0
qpg lighting-app qpg6105+debug (read only) 601576 601560 -16 -0.0
.text 596256 596240 -16 -0.0
lock-app qpg6105+debug (read only) 567292 567276 -16 -0.0
.text 561972 561956 -16 -0.0
telink lighting-app tlsr9518adk80d (read/write) 883586 883526 -60 -0.0
text 624368 624346 -22 -0.0
Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d2dffce 30af653 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599990 600042 52 0.0
.app_xip_area 504764 504816 52 0.0
.bss 77908 77908 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557978 558030 52 0.0
.app_xip_area 464288 464340 52 0.0
.bss 76412 76412 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578398 578450 52 0.0
.app_xip_area 475276 475328 52 0.0
.bss 85516 85516 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916916 916864 -52 -0.0
(read/write) 128672 128672 0 0.0
.bss 126616 126616 0 0.0
.data 2056 2056 0 0.0
.text 916908 916856 -52 -0.0
BRD4161A+rpc (read only) 947000 946948 -52 -0.0
(read/write) 145616 145612 -4 -0.0
.bss 143392 143392 0 0.0
.data 2220 2220 0 0.0
.text 946992 946940 -52 -0.0
lock-app BRD4161A+wf200 (read only) 986748 986680 -68 -0.0
(read/write) 120432 120436 4 0.0
.bss 118500 118500 0 0.0
.data 1932 1932 0 0.0
.text 986740 986672 -68 -0.0
window-app BRD4161A (read only) 850844 850792 -52 -0.0
(read/write) 126908 126912 4 0.0
.bss 124984 124984 0 0.0
.data 1924 1924 0 0.0
.text 850836 850784 -52 -0.0
esp32 all-clusters-app m5stack (read only) 1005099 1005063 -36 -0.0
(read/write) 458336 458304 -32 -0.0
.dram0.bss 68160 68160 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 224600 224568 -32 -0.0
.flash.text 999715 999679 -36 -0.0
.iram0.text 122767 122767 0 0.0
k32w light k32w061+release (read/write) 692176 692124 -52 -0.0
.bss 77544 77544 0 0.0
.data 1932 1932 0 0.0
.text 606900 606848 -52 -0.0
lock k32w061+release (read/write) 695536 695468 -68 -0.0
.bss 77744 77744 0 0.0
.data 1972 1972 0 0.0
.text 610020 609952 -68 -0.0
linux all-clusters-app debug (read only) 2397185 2397041 -144 -0.0
(read/write) 144824 144824 0 0.0
.bss 59296 59296 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78424 78424 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 205029 204997 -32 -0.0
.text 2029314 2029202 -112 -0.0
bridge-app debug+rpc (read only) 1722765 1722589 -176 -0.0
(read/write) 92848 92848 0 0.0
.bss 47624 47624 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38104 38104 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141652 141588 -64 -0.0
.text 1465237 1465125 -112 -0.0
chip-tool debug (read only) 8962485 8962821 336 0.0
(read/write) 282560 282560 0 0.0
.bss 25248 25248 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 250152 250152 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 600 600 0 0.0
.rodata 478261 478261 0 0.0
.text 7877669 7878005 336 0.0
chip-tool-ipv6only arm64 (read only) 8723412 8723716 304 0.0
(read/write) 395713 395713 0 0.0
.bss 43617 43617 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 295760 295760 0 0.0
.dynamic 560 560 0 0.0
.got 51368 51368 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 455964 455964 0 0.0
.text 7405140 7405444 304 0.0
door-lock-app debug (read only) 1937913 1937769 -144 -0.0
(read/write) 119296 119296 0 0.0
.bss 50624 50624 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62232 62232 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173692 173660 -32 -0.0
.text 1615666 1615554 -112 -0.0
lighting-app debug+rpc (read only) 2073745 2073569 -176 -0.0
(read/write) 124656 124656 0 0.0
.bss 51552 51552 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66152 66152 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 166460 166396 -64 -0.0
.text 1751762 1751650 -112 -0.0
ota-provider-app debug (read only) 1870017 1869873 -144 -0.0
(read/write) 114928 114928 0 0.0
.bss 50432 50432 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57512 57512 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158867 158835 -32 -0.0
.text 1560514 1560402 -112 -0.0
ota-requestor-app debug (read only) 1881025 1880849 -176 -0.0
(read/write) 116696 116696 0 0.0
.bss 51296 51296 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 58760 58760 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 152612 152548 -64 -0.0
.text 1579506 1579394 -112 -0.0
shell debug (read only) 2365369 2365401 32 0.0
(read/write) 147272 147272 0 0.0
.bss 67616 67616 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73144 73144 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 204946 204914 -32 -0.0
.text 2003794 2003858 64 0.0
thermostat-no-ble arm64 (read only) 2164884 2164788 -96 -0.0
(read/write) 148657 148657 0 0.0
.bss 65329 65329 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75088 75088 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133124 133092 -32 -0.0
.text 1813440 1813376 -64 -0.0
tv-app debug (read only) 2592169 2592121 -48 -0.0
(read/write) 148760 148760 0 0.0
.bss 65888 65888 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73640 73640 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 198909 198877 -32 -0.0
.text 2219426 2219410 -16 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350404 2350364 -40 -0.0
.bss 187156 187156 0 0.0
.data 5784 5784 0 0.0
.text 1313004 1312964 -40 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039383 1075619 36236 3.5
bss 125820 127672 1852 1.5
rodata 135904 141772 5868 4.3
text 700432 728764 28332 4.0
p6 all-clusters-app default (read/write) 2488576 2488528 -48 -0.0
.bss 118728 118728 0 0.0
.data 2696 2696 0 0.0
.text 1446840 1446792 -48 -0.0
light-app default (read/write) 2395784 2395728 -56 -0.0
.bss 113048 113048 0 0.0
.data 2544 2544 0 0.0
.text 1354048 1353992 -56 -0.0
lock-app default (read/write) 2359312 2359240 -72 -0.0
.bss 112792 112792 0 0.0
.data 2504 2504 0 0.0
.text 1317576 1317504 -72 -0.0
qpg lighting-app qpg6105+debug (read only) 601576 601560 -16 -0.0
(read/write) 146936 146936 0 0.0
.bss 90928 90928 0 0.0
.data 1132 1132 0 0.0
.text 596256 596240 -16 -0.0
lock-app qpg6105+debug (read only) 567292 567276 -16 -0.0
(read/write) 146936 146936 0 0.0
.bss 90936 90936 0 0.0
.data 1084 1084 0 0.0
.text 561972 561956 -16 -0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883586 883526 -60 -0.0
bss 86400 86400 0 0.0
noinit 37160 37160 0 0.0
text 624368 624346 -22 -0.0

@bzbarsky-apple
Copy link
Contributor Author

/rebase

@woody-apple woody-apple force-pushed the storage-delegate-api-clarity branch from 30af653 to a3b9a54 Compare March 1, 2022 22:47
@github-actions
Copy link

github-actions bot commented Mar 1, 2022 •
edited
Loading

PR #15675: Size comparison from b250d9a to a3b9a54

Increases above 0.2%:

platform target config section b250d9a a3b9a54 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039415 1075667 36252 3.5
bss 125820 127672 1852 1.5
rodata 135904 141772 5868 4.3
text 700476 728812 28336 4.0
Increases (9 builds for cyw30739, efr32, linux, nrfconnect)
platform target config section b250d9a a3b9a54 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600038 600090 52 0.0
.app_xip_area 504812 504864 52 0.0
lock cyw930739m2evb_01 (read/write) 558026 558078 52 0.0
.app_xip_area 464336 464388 52 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578446 578498 52 0.0
.app_xip_area 475324 475376 52 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 120432 120436 4 0.0
window-app BRD4161A (read/write) 126908 126912 4 0.0
linux chip-tool debug (read only) 8963125 8963461 336 0.0
.text 7878309 7878645 336 0.0
chip-tool-ipv6only arm64 (read only) 8723956 8724276 320 0.0
.text 7405684 7406004 320 0.0
shell debug (read only) 2365801 2365833 32 0.0
.text 2004194 2004258 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039415 1075667 36252 3.5
bss 125820 127672 1852 1.5
rodata 135904 141772 5868 4.3
text 700476 728812 28336 4.0
Decreases (23 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section b250d9a a3b9a54 change % change
efr32 lighting-app BRD4161A (read only) 917028 916976 -52 -0.0
.text 917020 916968 -52 -0.0
BRD4161A+rpc (read only) 947112 947044 -68 -0.0
(read/write) 145616 145612 -4 -0.0
.text 947104 947036 -68 -0.0
lock-app BRD4161A+wf200 (read only) 986844 986792 -52 -0.0
.text 986836 986784 -52 -0.0
window-app BRD4161A (read only) 850956 850904 -52 -0.0
.text 850948 850896 -52 -0.0
esp32 all-clusters-app m5stack (read only) 1005143 1005107 -36 -0.0
(read/write) 458336 458304 -32 -0.0
.flash.rodata 224600 224568 -32 -0.0
.flash.text 999759 999723 -36 -0.0
k32w light k32w061+release (read/write) 692224 692172 -52 -0.0
.text 606948 606896 -52 -0.0
lock k32w061+release (read/write) 695584 695516 -68 -0.0
.text 610068 610000 -68 -0.0
linux all-clusters-app debug (read only) 2397585 2397441 -144 -0.0
.rodata 205029 204997 -32 -0.0
.text 2029714 2029602 -112 -0.0
bridge-app debug+rpc (read only) 1723165 1723021 -144 -0.0
.rodata 141652 141620 -32 -0.0
.text 1465637 1465525 -112 -0.0
door-lock-app debug (read only) 1938345 1938169 -176 -0.0
.rodata 173724 173660 -64 -0.0
.text 1616066 1615954 -112 -0.0
lighting-app debug+rpc (read only) 2074145 2074001 -144 -0.0
.rodata 166460 166428 -32 -0.0
.text 1752162 1752050 -112 -0.0
ota-provider-app debug (read only) 1870449 1870305 -144 -0.0
.rodata 158899 158867 -32 -0.0
.text 1560914 1560802 -112 -0.0
ota-requestor-app debug (read only) 1881425 1881249 -176 -0.0
.rodata 152612 152548 -64 -0.0
.text 1579906 1579794 -112 -0.0
shell debug .rodata 204978 204946 -32 -0.0
thermostat-no-ble arm64 (read only) 2165364 2165236 -128 -0.0
.rodata 133140 133092 -48 -0.0
.text 1813904 1813824 -80 -0.0
tv-app debug (read only) 2592809 2592793 -16 -0.0
.text 2220066 2220050 -16 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2350468 2350364 -104 -0.0
.text 1313068 1312964 -104 -0.0
p6 all-clusters-app default (read/write) 2488688 2488624 -64 -0.0
.text 1446952 1446888 -64 -0.0
light-app default (read/write) 2395896 2395840 -56 -0.0
.text 1354160 1354104 -56 -0.0
lock-app default (read/write) 2359424 2359352 -72 -0.0
.text 1317688 1317616 -72 -0.0
qpg lighting-app qpg6105+debug (read only) 601624 601608 -16 -0.0
.text 596304 596288 -16 -0.0
lock-app qpg6105+debug (read only) 567340 567324 -16 -0.0
.text 562020 562004 -16 -0.0
telink lighting-app tlsr9518adk80d (read/write) 883642 883582 -60 -0.0
text 624426 624404 -22 -0.0
Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b250d9a a3b9a54 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600038 600090 52 0.0
.app_xip_area 504812 504864 52 0.0
.bss 77908 77908 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 558026 558078 52 0.0
.app_xip_area 464336 464388 52 0.0
.bss 76412 76412 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578446 578498 52 0.0
.app_xip_area 475324 475376 52 0.0
.bss 85516 85516 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 917028 916976 -52 -0.0
(read/write) 128672 128672 0 0.0
.bss 126616 126616 0 0.0
.data 2056 2056 0 0.0
.text 917020 916968 -52 -0.0
BRD4161A+rpc (read only) 947112 947044 -68 -0.0
(read/write) 145616 145612 -4 -0.0
.bss 143392 143392 0 0.0
.data 2220 2220 0 0.0
.text 947104 947036 -68 -0.0
lock-app BRD4161A+wf200 (read only) 986844 986792 -52 -0.0
(read/write) 120432 120436 4 0.0
.bss 118500 118500 0 0.0
.data 1932 1932 0 0.0
.text 986836 986784 -52 -0.0
window-app BRD4161A (read only) 850956 850904 -52 -0.0
(read/write) 126908 126912 4 0.0
.bss 124984 124984 0 0.0
.data 1924 1924 0 0.0
.text 850948 850896 -52 -0.0
esp32 all-clusters-app m5stack (read only) 1005143 1005107 -36 -0.0
(read/write) 458336 458304 -32 -0.0
.dram0.bss 68160 68160 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 224600 224568 -32 -0.0
.flash.text 999759 999723 -36 -0.0
.iram0.text 122767 122767 0 0.0
k32w light k32w061+release (read/write) 692224 692172 -52 -0.0
.bss 77544 77544 0 0.0
.data 1932 1932 0 0.0
.text 606948 606896 -52 -0.0
lock k32w061+release (read/write) 695584 695516 -68 -0.0
.bss 77744 77744 0 0.0
.data 1972 1972 0 0.0
.text 610068 610000 -68 -0.0
linux all-clusters-app debug (read only) 2397585 2397441 -144 -0.0
(read/write) 144824 144824 0 0.0
.bss 59296 59296 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78424 78424 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 205029 204997 -32 -0.0
.text 2029714 2029602 -112 -0.0
bridge-app debug+rpc (read only) 1723165 1723021 -144 -0.0
(read/write) 92848 92848 0 0.0
.bss 47624 47624 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38104 38104 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141652 141620 -32 -0.0
.text 1465637 1465525 -112 -0.0
chip-tool debug (read only) 8963125 8963461 336 0.0
(read/write) 282560 282560 0 0.0
.bss 25248 25248 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 250152 250152 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 600 600 0 0.0
.rodata 478261 478261 0 0.0
.text 7878309 7878645 336 0.0
chip-tool-ipv6only arm64 (read only) 8723956 8724276 320 0.0
(read/write) 395713 395713 0 0.0
.bss 43617 43617 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 295760 295760 0 0.0
.dynamic 560 560 0 0.0
.got 51368 51368 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 455964 455964 0 0.0
.text 7405684 7406004 320 0.0
door-lock-app debug (read only) 1938345 1938169 -176 -0.0
(read/write) 119296 119296 0 0.0
.bss 50624 50624 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62232 62232 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173724 173660 -64 -0.0
.text 1616066 1615954 -112 -0.0
lighting-app debug+rpc (read only) 2074145 2074001 -144 -0.0
(read/write) 124656 124656 0 0.0
.bss 51552 51552 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66152 66152 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 166460 166428 -32 -0.0
.text 1752162 1752050 -112 -0.0
ota-provider-app debug (read only) 1870449 1870305 -144 -0.0
(read/write) 114928 114928 0 0.0
.bss 50432 50432 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57512 57512 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158899 158867 -32 -0.0
.text 1560914 1560802 -112 -0.0
ota-requestor-app debug (read only) 1881425 1881249 -176 -0.0
(read/write) 116696 116696 0 0.0
.bss 51296 51296 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 58760 58760 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 152612 152548 -64 -0.0
.text 1579906 1579794 -112 -0.0
shell debug (read only) 2365801 2365833 32 0.0
(read/write) 147272 147272 0 0.0
.bss 67616 67616 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73144 73144 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 204978 204946 -32 -0.0
.text 2004194 2004258 64 0.0
thermostat-no-ble arm64 (read only) 2165364 2165236 -128 -0.0
(read/write) 148657 148657 0 0.0
.bss 65329 65329 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75088 75088 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133140 133092 -48 -0.0
.text 1813904 1813824 -80 -0.0
tv-app debug (read only) 2592809 2592793 -16 -0.0
(read/write) 148760 148760 0 0.0
.bss 65888 65888 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73640 73640 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 198909 198909 0 0.0
.text 2220066 2220050 -16 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350468 2350364 -104 -0.0
.bss 187156 187156 0 0.0
.data 5784 5784 0 0.0
.text 1313068 1312964 -104 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039415 1075667 36252 3.5
bss 125820 127672 1852 1.5
rodata 135904 141772 5868 4.3
text 700476 728812 28336 4.0
p6 all-clusters-app default (read/write) 2488688 2488624 -64 -0.0
.bss 118728 118728 0 0.0
.data 2696 2696 0 0.0
.text 1446952 1446888 -64 -0.0
light-app default (read/write) 2395896 2395840 -56 -0.0
.bss 113048 113048 0 0.0
.data 2544 2544 0 0.0
.text 1354160 1354104 -56 -0.0
lock-app default (read/write) 2359424 2359352 -72 -0.0
.bss 112792 112792 0 0.0
.data 2504 2504 0 0.0
.text 1317688 1317616 -72 -0.0
qpg lighting-app qpg6105+debug (read only) 601624 601608 -16 -0.0
(read/write) 146936 146936 0 0.0
.bss 90928 90928 0 0.0
.data 1132 1132 0 0.0
.text 596304 596288 -16 -0.0
lock-app qpg6105+debug (read only) 567340 567324 -16 -0.0
(read/write) 146936 146936 0 0.0
.bss 90936 90936 0 0.0
.data 1084 1084 0 0.0
.text 562020 562004 -16 -0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883642 883582 -60 -0.0
bss 86400 86400 0 0.0
noinit 37160 37160 0 0.0
text 624426 624404 -22 -0.0

@woody-apple woody-apple merged commit 0ab62f9 into project-chip:master Mar 2, 2022
@bzbarsky-apple bzbarsky-apple deleted the storage-delegate-api-clarity branch March 2, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepenven-silabs jepenven-silabs jepenven-silabs approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller darwin examples lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unify error code for Persistent Storage Delegate
3 participants
@bzbarsky-apple @woody-apple @jepenven-silabs