-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTA] Serve the file specified by the file designator #15662
Merged
woody-apple
merged 1 commit into
project-chip:master
from
carol-apple:ota_requestor_file_designator
Mar 3, 2022
Merged
[OTA] Serve the file specified by the file designator #15662
woody-apple
merged 1 commit into
project-chip:master
from
carol-apple:ota_requestor_file_designator
Mar 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt and
sagar-apple
February 28, 2022 23:28
pullapprove
bot
requested review from
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 28, 2022 23:28
PR #15662: Size comparison from 29db0f4 to 8b12a5a Full report (2 builds for linux)
|
shubhamdp
reviewed
Mar 1, 2022
carol-apple
force-pushed
the
ota_requestor_file_designator
branch
from
March 1, 2022 20:29
8b12a5a
to
3fda2f3
Compare
PR #15662: Size comparison from e87c25d to 3fda2f3 Increases above 0.2%:
Increases (12 builds for cyw30739, efr32, k32w, linux, nrfconnect, qpg)
Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
carol-apple
force-pushed
the
ota_requestor_file_designator
branch
from
March 1, 2022 23:03
3fda2f3
to
52965f6
Compare
PR #15662: Size comparison from b250d9a to 52965f6 Increases above 0.2%:
Increases (12 builds for cyw30739, efr32, k32w, linux, nrfconnect, qpg)
Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
isiu-apple
reviewed
Mar 1, 2022
carol-apple
force-pushed
the
ota_requestor_file_designator
branch
from
March 2, 2022 04:35
52965f6
to
f7ea1e7
Compare
PR #15662: Size comparison from 883528d to f7ea1e7 Increases above 0.2%:
Increases (12 builds for cyw30739, efr32, k32w, linux, nrfconnect, qpg)
Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
isiu-apple
approved these changes
Mar 2, 2022
harsha-rajendran
approved these changes
Mar 2, 2022
carol-apple
force-pushed
the
ota_requestor_file_designator
branch
from
March 2, 2022 23:18
f7ea1e7
to
11fc6d8
Compare
PR #15662: Size comparison from 654104c to 11fc6d8 Increases above 0.2%:
Increases (12 builds for cyw30739, efr32, k32w, linux, nrfconnect, qpg)
Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the OTA Requestor sets the file designator as a hard coded value
test.txt
in the current location where the application is launched. Also, the OTA Provider is serving the image file specified by the command line arg when the ota-provider-app is launched.The Requestor should set the file designator appropriately during the BDX transfer. The Provider should be using the file designator field in the
ReceiveInit
message to serve the image fileChange overview
ReceiveInit
message when BDX transfer begins and uses this filepath to serve the image inBlockQuery
messagesBdxOtaSender::SetFilepath
as the image file path should be set by the file designator and not by external callerTesting