Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes in access control event logging #15658

Merged
merged 3 commits into from
Mar 3, 2022
Merged

Small fixes in access control event logging #15658

merged 3 commits into from
Mar 3, 2022

Conversation

mlepage-google
Copy link
Contributor

@mlepage-google mlepage-google commented Feb 28, 2022 •
edited
Loading

Problem

Noticed these issues while inspecting the event logging code.

  • Subjects now need to be transcoded via a convert function (but aren't)
  • PASE subject should go into adminPasscodeID field (but it's going into adminNodeID which is for CASE)

Change overview

  • Subjects now transcoded via a convert function
  • PASE subject goes into adminPasscodeID field

Testing

  • Built and ran.
  • Comprehensive event testing will come in the future.

@mlepage-google
Small fixes in access control event logging
8204a34 
Noticed these issues while inspecting the event logging code.

- Subjects now need to be transcoded via a convert function
- PASE subject should go into adminPasscodeID field
@boring-cyborg boring-cyborg bot added the app label Feb 28, 2022
@github-actions
Copy link

github-actions bot commented Feb 28, 2022 •
edited
Loading

PR #15658: Size comparison from 4ba01f6 to 8204a34

Increases above 0.2%:

platform target config section 4ba01f6 8204a34 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038939 1075359 36420 3.5
bss 125756 127608 1852 1.5
rodata 135900 141776 5876 4.3
text 700076 728560 28484 4.1
Increases (20 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 4ba01f6 8204a34 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599582 599630 48 0.0
.app_xip_area 504428 504476 48 0.0
lock cyw930739m2evb_01 (read/write) 557614 557670 56 0.0
.app_xip_area 463996 464052 56 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578138 578194 56 0.0
.app_xip_area 475088 475144 56 0.0
efr32 lighting-app BRD4161A (read only) 916516 916636 120 0.0
.text 916508 916628 120 0.0
BRD4161A+rpc (read only) 946604 946724 120 0.0
.text 946596 946716 120 0.0
lock-app BRD4161A+wf200 (read only) 986436 986556 120 0.0
.text 986428 986548 120 0.0
window-app BRD4161A (read only) 850596 850716 120 0.0
.text 850588 850708 120 0.0
esp32 all-clusters-app c3devkit (read only) 956574 956642 68 0.0
.flash.text 956574 956642 68 0.0
m5stack (read only) 1004711 1004791 80 0.0
.flash.text 999327 999407 80 0.0
k32w light k32w061+release (read/write) 691904 691960 56 0.0
.text 606700 606756 56 0.0
lock k32w061+release (read/write) 695176 695232 56 0.0
.text 609724 609780 56 0.0
linux thermostat-no-ble arm64 (read only) 2163236 2163284 48 0.0
.text 1811968 1812048 80 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2350140 2350180 40 0.0
.text 1312740 1312780 40 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038939 1075359 36420 3.5
bss 125756 127608 1852 1.5
rodata 135900 141776 5876 4.3
text 700076 728560 28484 4.1
p6 all-clusters-app default (read/write) 2488104 2488224 120 0.0
.text 1446368 1446488 120 0.0
light-app default (read/write) 2395304 2395440 136 0.0
.text 1353568 1353704 136 0.0
lock-app default (read/write) 2358880 2359000 120 0.0
.text 1317144 1317264 120 0.0
qpg lighting-app qpg6105+debug (read only) 601200 601256 56 0.0
.text 595880 595936 56 0.0
lock-app qpg6105+debug (read only) 566964 567020 56 0.0
.text 561644 561700 56 0.0
telink lighting-app tlsr9518adk80d (read/write) 883126 883174 48 0.0
text 623982 624054 72 0.0
Decreases (3 builds for esp32, linux)
platform target config section 4ba01f6 8204a34 change % change
esp32 all-clusters-app c3devkit (read/write) 1392986 1392962 -24 -0.0
.flash.rodata 197248 197224 -24 -0.0
m5stack (read/write) 458264 458240 -24 -0.0
.flash.rodata 224600 224576 -24 -0.0
linux thermostat-no-ble arm64 .rodata 132964 132932 -32 -0.0
Full report (22 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 4ba01f6 8204a34 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599582 599630 48 0.0
.app_xip_area 504428 504476 48 0.0
.bss 77844 77844 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557614 557670 56 0.0
.app_xip_area 463996 464052 56 0.0
.bss 76348 76348 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578138 578194 56 0.0
.app_xip_area 475088 475144 56 0.0
.bss 85452 85452 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916516 916636 120 0.0
(read/write) 128608 128608 0 0.0
.bss 126560 126560 0 0.0
.data 2048 2048 0 0.0
.text 916508 916628 120 0.0
BRD4161A+rpc (read only) 946604 946724 120 0.0
(read/write) 145548 145548 0 0.0
.bss 143336 143336 0 0.0
.data 2212 2212 0 0.0
.text 946596 946716 120 0.0
lock-app BRD4161A+wf200 (read only) 986436 986556 120 0.0
(read/write) 120360 120360 0 0.0
.bss 118436 118436 0 0.0
.data 1924 1924 0 0.0
.text 986428 986548 120 0.0
window-app BRD4161A (read only) 850596 850716 120 0.0
(read/write) 126844 126844 0 0.0
.bss 124928 124928 0 0.0
.data 1916 1916 0 0.0
.text 850588 850708 120 0.0
esp32 all-clusters-app c3devkit (read only) 956574 956642 68 0.0
(read/write) 1392986 1392962 -24 -0.0
.dram0.bss 62592 62592 0 0.0
.dram0.data 14228 14228 0 0.0
.flash.rodata 197248 197224 -24 -0.0
.flash.text 956574 956642 68 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1004711 1004791 80 0.0
(read/write) 458264 458240 -24 -0.0
.dram0.bss 68096 68096 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 224600 224576 -24 -0.0
.flash.text 999327 999407 80 0.0
.iram0.text 122767 122767 0 0.0
k32w light k32w061+release (read/write) 691904 691960 56 0.0
.bss 77480 77480 0 0.0
.data 1924 1924 0 0.0
.text 606700 606756 56 0.0
lock k32w061+release (read/write) 695176 695232 56 0.0
.bss 77688 77688 0 0.0
.data 1964 1964 0 0.0
.text 609724 609780 56 0.0
linux chip-tool-ipv6only arm64 (read only) 8757484 8757484 0 0.0
(read/write) 412049 412049 0 0.0
.bss 58673 58673 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 296840 296840 0 0.0
.dynamic 560 560 0 0.0
.got 51512 51512 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 457028 457028 0 0.0
.text 7435172 7435172 0 0.0
thermostat-no-ble arm64 (read only) 2163236 2163284 48 0.0
(read/write) 148577 148577 0 0.0
.bss 65265 65265 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 75080 75080 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132964 132932 -32 -0.0
.text 1811968 1812048 80 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350140 2350180 40 0.0
.bss 187092 187092 0 0.0
.data 5776 5776 0 0.0
.text 1312740 1312780 40 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038939 1075359 36420 3.5
bss 125756 127608 1852 1.5
rodata 135900 141776 5876 4.3
text 700076 728560 28484 4.1
p6 all-clusters-app default (read/write) 2488104 2488224 120 0.0
.bss 118664 118664 0 0.0
.data 2688 2688 0 0.0
.text 1446368 1446488 120 0.0
light-app default (read/write) 2395304 2395440 136 0.0
.bss 112984 112984 0 0.0
.data 2536 2536 0 0.0
.text 1353568 1353704 136 0.0
lock-app default (read/write) 2358880 2359000 120 0.0
.bss 112728 112728 0 0.0
.data 2496 2496 0 0.0
.text 1317144 1317264 120 0.0
qpg lighting-app qpg6105+debug (read only) 601200 601256 56 0.0
(read/write) 146936 146936 0 0.0
.bss 90904 90904 0 0.0
.data 1124 1124 0 0.0
.text 595880 595936 56 0.0
lock-app qpg6105+debug (read only) 566964 567020 56 0.0
(read/write) 146936 146936 0 0.0
.bss 90912 90912 0 0.0
.data 1076 1076 0 0.0
.text 561644 561700 56 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883126 883174 48 0.0
bss 86336 86336 0 0.0
noinit 37160 37160 0 0.0
text 623982 624054 72 0.0

@mlepage-google
Merge branch 'master' into small-fixes-in-access-control-event-logging
7847262
@mlepage-google
Use tmp struct and node id when converting subject
9087509 
Break out the steps so it's clearer what is happening.

Verified that writing group subjects 4444, 5555, and 6666
properly got converted to node IDs 0xFFFFFFFFFFFF115C,
0xFFFFFFFFFFFF15B3, and 0xFFFFFFFFFFFF1A0A, and reading
them properly converted them back.
@mlepage-google mlepage-google mentioned this pull request Mar 3, 2022
Closed
@github-actions
Copy link

github-actions bot commented Mar 3, 2022 •
edited
Loading

PR #15658: Size comparison from c275d1f to 9087509

Increases above 0.2%:

platform target config section c275d1f 9087509 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039911 1076783 36872 3.5
bss 125700 128876 3176 2.5
rodata 135792 141784 5992 4.4
text 701180 730928 29748 4.2
Increases (28 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c275d1f 9087509 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600170 600226 56 0.0
.app_xip_area 505192 505248 56 0.0
lock cyw930739m2evb_01 (read/write) 558170 558226 56 0.0
.app_xip_area 464728 464784 56 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578802 578858 56 0.0
.app_xip_area 475664 475720 56 0.0
efr32 lighting-app BRD4161A (read only) 918160 918280 120 0.0
.text 918152 918272 120 0.0
BRD4161A+rpc (read only) 948228 948348 120 0.0
.text 948220 948340 120 0.0
lock-app BRD4161A+wf200 (read only) 987964 988068 104 0.0
.text 987956 988060 104 0.0
window-app BRD4161A (read only) 852696 852800 104 0.0
.text 852688 852792 104 0.0
esp32 all-clusters-app c3devkit (read only) 953232 953316 84 0.0
.flash.text 953232 953316 84 0.0
m5stack (read only) 1008419 1008511 92 0.0
.flash.text 1003035 1003127 92 0.0
k32w light k32w061+release (read/write) 692780 692836 56 0.0
.text 607360 607416 56 0.0
lock k32w061+release (read/write) 695932 695988 56 0.0
.text 610544 610600 56 0.0
linux all-clusters-app debug (read only) 2402593 2402673 80 0.0
.text 2034690 2034802 112 0.0
bridge-app debug+rpc (read only) 1728061 1728141 80 0.0
.text 1470597 1470709 112 0.0
door-lock-app debug (read only) 1943097 1943225 128 0.0
.text 1620914 1621042 128 0.0
lighting-app debug+rpc (read only) 2078545 2078657 112 0.0
.text 1757010 1757122 112 0.0
ota-provider-app debug (read only) 1875441 1875521 80 0.0
.text 1565906 1566018 112 0.0
ota-requestor-app debug (read only) 1886649 1886745 96 0.0
.text 1585298 1585426 128 0.0
shell debug (read only) 2371225 2371305 80 0.0
.text 2009554 2009666 112 0.0
thermostat-no-ble arm64 (read only) 2169076 2169156 80 0.0
.text 1817824 1817920 96 0.0
tv-app debug (read only) 2609505 2609601 96 0.0
.text 2236306 2236434 128 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2350972 2351012 40 0.0
.text 1313572 1313612 40 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039911 1076783 36872 3.5
bss 125700 128876 3176 2.5
rodata 135792 141784 5992 4.4
text 701180 730928 29748 4.2
p6 all-clusters-app default (read/write) 2489872 2489976 104 0.0
.text 1448136 1448240 104 0.0
light-app default (read/write) 2397016 2397120 104 0.0
.text 1355280 1355384 104 0.0
lock-app default (read/write) 2360528 2360648 120 0.0
.text 1318792 1318912 120 0.0
qpg lighting-app qpg6105+debug (read only) 601984 602040 56 0.0
.text 596664 596720 56 0.0
lock-app qpg6105+debug (read only) 567684 567740 56 0.0
.text 562364 562420 56 0.0
telink lighting-app tlsr9518adk80d (read/write) 883982 884046 64 0.0
text 625098 625186 88 0.0
Decreases (9 builds for esp32, linux)
platform target config section c275d1f 9087509 change % change
esp32 all-clusters-app c3devkit (read/write) 1392714 1392690 -24 -0.0
.flash.rodata 197024 197000 -24 -0.0
m5stack (read/write) 459828 459804 -24 -0.0
.flash.rodata 225856 225832 -24 -0.0
linux all-clusters-app debug .rodata 205157 205125 -32 -0.0
bridge-app debug+rpc .rodata 141684 141652 -32 -0.0
ota-provider-app debug .rodata 158995 158963 -32 -0.0
ota-requestor-app debug .rodata 152516 152484 -32 -0.0
shell debug .rodata 205138 205106 -32 -0.0
thermostat-no-ble arm64 .rodata 133044 133028 -16 -0.0
tv-app debug .rodata 199293 199261 -32 -0.0
Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c275d1f 9087509 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600170 600226 56 0.0
.app_xip_area 505192 505248 56 0.0
.bss 77660 77660 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 558170 558226 56 0.0
.app_xip_area 464728 464784 56 0.0
.bss 76164 76164 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578802 578858 56 0.0
.app_xip_area 475664 475720 56 0.0
.bss 85532 85532 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 918160 918280 120 0.0
(read/write) 128816 128816 0 0.0
.bss 126760 126760 0 0.0
.data 2056 2056 0 0.0
.text 918152 918272 120 0.0
BRD4161A+rpc (read only) 948228 948348 120 0.0
(read/write) 145756 145756 0 0.0
.bss 143536 143536 0 0.0
.data 2220 2220 0 0.0
.text 948220 948340 120 0.0
lock-app BRD4161A+wf200 (read only) 987964 988068 104 0.0
(read/write) 120312 120312 0 0.0
.bss 118380 118380 0 0.0
.data 1932 1932 0 0.0
.text 987956 988060 104 0.0
window-app BRD4161A (read only) 852696 852800 104 0.0
(read/write) 126784 126784 0 0.0
.bss 124856 124856 0 0.0
.data 1924 1924 0 0.0
.text 852688 852792 104 0.0
esp32 all-clusters-app c3devkit (read only) 953232 953316 84 0.0
(read/write) 1392714 1392690 -24 -0.0
.dram0.bss 62536 62536 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197024 197000 -24 -0.0
.flash.text 953232 953316 84 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1008419 1008511 92 0.0
(read/write) 459828 459804 -24 -0.0
.dram0.bss 68056 68056 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225856 225832 -24 -0.0
.flash.text 1003035 1003127 92 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 692780 692836 56 0.0
.bss 77688 77688 0 0.0
.data 1932 1932 0 0.0
.text 607360 607416 56 0.0
lock k32w061+release (read/write) 695932 695988 56 0.0
.bss 77616 77616 0 0.0
.data 1972 1972 0 0.0
.text 610544 610600 56 0.0
linux all-clusters-app debug (read only) 2402593 2402673 80 0.0
(read/write) 144600 144600 0 0.0
.bss 59104 59104 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78392 78392 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 205157 205125 -32 -0.0
.text 2034690 2034802 112 0.0
bridge-app debug+rpc (read only) 1728061 1728141 80 0.0
(read/write) 92560 92560 0 0.0
.bss 47400 47400 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38040 38040 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141684 141652 -32 -0.0
.text 1470597 1470709 112 0.0
chip-tool debug (read only) 9299085 9299085 0 0.0
(read/write) 288008 288008 0 0.0
.bss 25440 25440 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 255424 255424 0 0.0
.dynamic 608 608 0 0.0
.got 4760 4760 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 497045 497045 0 0.0
.text 8180789 8180789 0 0.0
chip-tool-ipv6only arm64 (read only) 9000804 9000804 0 0.0
(read/write) 400753 400753 0 0.0
.bss 43761 43761 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 300192 300192 0 0.0
.dynamic 560 560 0 0.0
.got 51832 51832 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473020 473020 0 0.0
.text 7650052 7650052 0 0.0
door-lock-app debug (read only) 1943097 1943225 128 0.0
(read/write) 119008 119008 0 0.0
.bss 50400 50400 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62168 62168 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173724 173724 0 0.0
.text 1620914 1621042 128 0.0
lighting-app debug+rpc (read only) 2078545 2078657 112 0.0
(read/write) 124400 124400 0 0.0
.bss 51328 51328 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66136 66136 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 166108 166108 0 0.0
.text 1757010 1757122 112 0.0
ota-provider-app debug (read only) 1875441 1875521 80 0.0
(read/write) 114640 114640 0 0.0
.bss 50208 50208 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57448 57448 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158995 158963 -32 -0.0
.text 1565906 1566018 112 0.0
ota-requestor-app debug (read only) 1886649 1886745 96 0.0
(read/write) 116952 116952 0 0.0
.bss 51360 51360 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 58696 58696 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 152516 152484 -32 -0.0
.text 1585298 1585426 128 0.0
shell debug (read only) 2371225 2371305 80 0.0
(read/write) 146832 146832 0 0.0
.bss 67176 67176 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73128 73128 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 205138 205106 -32 -0.0
.text 2009554 2009666 112 0.0
thermostat-no-ble arm64 (read only) 2169076 2169156 80 0.0
(read/write) 148385 148385 0 0.0
.bss 65121 65121 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75032 75032 0 0.0
.dynamic 560 560 0 0.0
.got 4208 4208 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133044 133028 -16 -0.0
.text 1817824 1817920 96 0.0
tv-app debug (read only) 2609505 2609601 96 0.0
(read/write) 250744 250744 0 0.0
.bss 167904 167904 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73608 73608 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199293 199261 -32 -0.0
.text 2236306 2236434 128 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350972 2351012 40 0.0
.bss 187036 187036 0 0.0
.data 5784 5784 0 0.0
.text 1313572 1313612 40 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039911 1076783 36872 3.5
bss 125700 128876 3176 2.5
rodata 135792 141784 5992 4.4
text 701180 730928 29748 4.2
p6 all-clusters-app default (read/write) 2489872 2489976 104 0.0
.bss 118608 118608 0 0.0
.data 2696 2696 0 0.0
.text 1448136 1448240 104 0.0
light-app default (read/write) 2397016 2397120 104 0.0
.bss 112920 112920 0 0.0
.data 2544 2544 0 0.0
.text 1355280 1355384 104 0.0
lock-app default (read/write) 2360528 2360648 120 0.0
.bss 112664 112664 0 0.0
.data 2504 2504 0 0.0
.text 1318792 1318912 120 0.0
qpg lighting-app qpg6105+debug (read only) 601984 602040 56 0.0
(read/write) 146936 146936 0 0.0
.bss 91064 91064 0 0.0
.data 1132 1132 0 0.0
.text 596664 596720 56 0.0
lock-app qpg6105+debug (read only) 567684 567740 56 0.0
(read/write) 146936 146936 0 0.0
.bss 91072 91072 0 0.0
.data 1084 1084 0 0.0
.text 562364 562420 56 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883982 884046 64 0.0
bss 86280 86280 0 0.0
noinit 37160 37160 0 0.0
text 625098 625186 88 0.0

@mlepage-google mlepage-google merged commit 3b83461 into project-chip:master Mar 3, 2022
@mlepage-google mlepage-google deleted the small-fixes-in-access-control-event-logging branch March 3, 2022 17:33
krypton36 pushed a commit to krypton36/connectedhomeip that referenced this pull request Mar 3, 2022
@mlepage-google @krypton36
Small fixes in access control event logging (project-chip#15658)
148aabe 
Noticed these issues while inspecting the event logging code.

- Subjects now need to be transcoded via a convert function
- PASE subject should go into adminPasscodeID field

Verified that writing group subjects 4444, 5555, and 6666
properly got converted to node IDs 0xFFFFFFFFFFFF115C,
0xFFFFFFFFFFFF15B3, and 0xFFFFFFFFFFFF1A0A, and reading
them properly converted them back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@andy31415 andy31415 andy31415 approved these changes

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mlepage-google @andy31415 @yunhanw-google @bzbarsky-apple