Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC: Add RPC to ESP temperature example #15641

Merged
merged 1 commit into from
Mar 1, 2022
Merged

RPC: Add RPC to ESP temperature example #15641

merged 1 commit into from
Mar 1, 2022

Conversation

rgoliver
Copy link

Problem

RPC variant of the temperature app is needed for testing.

Change overview

  • Add Attribute, Button, Descriptor, Device, and Wifi RPC services to the temperature app (when built with RPCs)
  • Add new RPC build target for temp app.

Testing

Built the RPC variant for DevC board, flashed and verified the RPCs worked with the console.

@github-actions
Copy link

github-actions bot commented Feb 28, 2022 •
edited
Loading

PR #15641: Size comparison from e904a90 to 89aa2ee

Increases above 0.2%:

platform target config section e904a90 89aa2ee change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038939 1075259 36320 3.5
bss 125756 127608 1852 1.5
rodata 135900 141804 5904 4.3
text 700076 728436 28360 4.1
Increases (1 build for nrfconnect)
platform target config section e904a90 89aa2ee change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038939 1075259 36320 3.5
bss 125756 127608 1852 1.5
rodata 135900 141804 5904 4.3
text 700076 728436 28360 4.1
Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section e904a90 89aa2ee change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599582 599582 0 0.0
.app_xip_area 504428 504428 0 0.0
.bss 77844 77844 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557614 557614 0 0.0
.app_xip_area 463996 463996 0 0.0
.bss 76348 76348 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578138 578138 0 0.0
.app_xip_area 475088 475088 0 0.0
.bss 85452 85452 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916516 916516 0 0.0
(read/write) 128608 128608 0 0.0
.bss 126560 126560 0 0.0
.data 2048 2048 0 0.0
.text 916508 916508 0 0.0
BRD4161A+rpc (read only) 946604 946604 0 0.0
(read/write) 145548 145548 0 0.0
.bss 143336 143336 0 0.0
.data 2212 2212 0 0.0
.text 946596 946596 0 0.0
lock-app BRD4161A+wf200 (read only) 986436 986436 0 0.0
(read/write) 120360 120360 0 0.0
.bss 118436 118436 0 0.0
.data 1924 1924 0 0.0
.text 986428 986428 0 0.0
window-app BRD4161A (read only) 850596 850596 0 0.0
(read/write) 126844 126844 0 0.0
.bss 124928 124928 0 0.0
.data 1916 1916 0 0.0
.text 850588 850588 0 0.0
esp32 all-clusters-app c3devkit (read only) 956574 956574 0 0.0
(read/write) 1392986 1392986 0 0.0
.dram0.bss 62592 62592 0 0.0
.dram0.data 14228 14228 0 0.0
.flash.rodata 197248 197248 0 0.0
.flash.text 956574 956574 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1004711 1004711 0 0.0
(read/write) 458264 458264 0 0.0
.dram0.bss 68096 68096 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 224600 224600 0 0.0
.flash.text 999327 999327 0 0.0
.iram0.text 122767 122767 0 0.0
k32w light k32w061+release (read/write) 691904 691904 0 0.0
.bss 77480 77480 0 0.0
.data 1924 1924 0 0.0
.text 606700 606700 0 0.0
lock k32w061+release (read/write) 695176 695176 0 0.0
.bss 77688 77688 0 0.0
.data 1964 1964 0 0.0
.text 609724 609724 0 0.0
linux all-clusters-app debug (read only) 2395017 2395017 0 0.0
(read/write) 144696 144696 0 0.0
.bss 59232 59232 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78392 78392 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 204869 204869 0 0.0
.text 2027378 2027378 0 0.0
bridge-app debug+rpc (read only) 1720741 1720741 0 0.0
(read/write) 92744 92744 0 0.0
.bss 47552 47552 0 0.0
.data 2042 2042 0 0.0
.data.rel.ro 38088 38088 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141460 141460 0 0.0
.text 1463477 1463477 0 0.0
chip-tool debug (read only) 9003269 9003269 0 0.0
(read/write) 298816 298816 0 0.0
.bss 40448 40448 0 0.0
.data 1164 1164 0 0.0
.data.rel.ro 251144 251144 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 481173 481173 0 0.0
.text 7913189 7913189 0 0.0
chip-tool-ipv6only arm64 (read only) 8757372 8757372 0 0.0
(read/write) 412049 412049 0 0.0
.bss 58673 58673 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 296840 296840 0 0.0
.dynamic 560 560 0 0.0
.got 51512 51512 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 456996 456996 0 0.0
.text 7435092 7435092 0 0.0
door-lock-app debug (read only) 1936305 1936305 0 0.0
(read/write) 119136 119136 0 0.0
.bss 50496 50496 0 0.0
.data 1050 1050 0 0.0
.data.rel.ro 62200 62200 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173532 173532 0 0.0
.text 1614290 1614290 0 0.0
lighting-app debug+rpc (read only) 2071505 2071505 0 0.0
(read/write) 124496 124496 0 0.0
.bss 51424 51424 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66144 66144 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 166225 166225 0 0.0
.text 1749826 1749826 0 0.0
ota-provider-app debug (read only) 1868393 1868393 0 0.0
(read/write) 114800 114800 0 0.0
.bss 50368 50368 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57480 57480 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158707 158707 0 0.0
.text 1559122 1559122 0 0.0
ota-requestor-app debug (read only) 1879369 1879369 0 0.0
(read/write) 116568 116568 0 0.0
.bss 51232 51232 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 58744 58744 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 152420 152420 0 0.0
.text 1578114 1578114 0 0.0
shell debug (read only) 2363201 2363201 0 0.0
(read/write) 147176 147176 0 0.0
.bss 67552 67552 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73096 73096 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 204786 204786 0 0.0
.text 2001858 2001858 0 0.0
thermostat-no-ble arm64 (read only) 2163236 2163236 0 0.0
(read/write) 148577 148577 0 0.0
.bss 65265 65265 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 75080 75080 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132964 132964 0 0.0
.text 1811968 1811968 0 0.0
tv-app debug (read only) 2589505 2589505 0 0.0
(read/write) 148632 148632 0 0.0
.bss 65824 65824 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 198653 198653 0 0.0
.text 2217090 2217090 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038939 1075259 36320 3.5
bss 125756 127608 1852 1.5
rodata 135900 141804 5904 4.3
text 700076 728436 28360 4.1
p6 all-clusters-app default (read/write) 2488104 2488104 0 0.0
.bss 118664 118664 0 0.0
.data 2688 2688 0 0.0
.text 1446368 1446368 0 0.0
light-app default (read/write) 2395304 2395304 0 0.0
.bss 112984 112984 0 0.0
.data 2536 2536 0 0.0
.text 1353568 1353568 0 0.0
lock-app default (read/write) 2358880 2358880 0 0.0
.bss 112728 112728 0 0.0
.data 2496 2496 0 0.0
.text 1317144 1317144 0 0.0
qpg lighting-app qpg6105+debug (read only) 601200 601200 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90904 90904 0 0.0
.data 1124 1124 0 0.0
.text 595880 595880 0 0.0
lock-app qpg6105+debug (read only) 566964 566964 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90912 90912 0 0.0
.data 1076 1076 0 0.0
.text 561644 561644 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883126 883126 0 0.0
bss 86336 86336 0 0.0
noinit 37160 37160 0 0.0
text 623982 623982 0 0.0

@andy31415
Copy link
Contributor

/rebase

@andy31415
RPC: Add RPCs to ESP temperature example
0ebb4b7 
- Add Attribute, Button, Desciptor, Device, Wifi services.
- Add new RPC build target for temp app.
@github-actions
Copy link

github-actions bot commented Feb 28, 2022 •
edited
Loading

PR #15641: Size comparison from 9e480df to 0ebb4b7

Increases above 0.2%:

platform target config section 9e480df 0ebb4b7 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038939 1075259 36320 3.5
bss 125756 127608 1852 1.5
rodata 135900 141804 5904 4.3
text 700076 728436 28360 4.1
Increases (1 build for nrfconnect)
platform target config section 9e480df 0ebb4b7 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038939 1075259 36320 3.5
bss 125756 127608 1852 1.5
rodata 135900 141804 5904 4.3
text 700076 728436 28360 4.1
Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 9e480df 0ebb4b7 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599582 599582 0 0.0
.app_xip_area 504428 504428 0 0.0
.bss 77844 77844 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557614 557614 0 0.0
.app_xip_area 463996 463996 0 0.0
.bss 76348 76348 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578138 578138 0 0.0
.app_xip_area 475088 475088 0 0.0
.bss 85452 85452 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916516 916516 0 0.0
(read/write) 128608 128608 0 0.0
.bss 126560 126560 0 0.0
.data 2048 2048 0 0.0
.text 916508 916508 0 0.0
BRD4161A+rpc (read only) 946604 946604 0 0.0
(read/write) 145548 145548 0 0.0
.bss 143336 143336 0 0.0
.data 2212 2212 0 0.0
.text 946596 946596 0 0.0
lock-app BRD4161A+wf200 (read only) 986436 986436 0 0.0
(read/write) 120360 120360 0 0.0
.bss 118436 118436 0 0.0
.data 1924 1924 0 0.0
.text 986428 986428 0 0.0
window-app BRD4161A (read only) 850596 850596 0 0.0
(read/write) 126844 126844 0 0.0
.bss 124928 124928 0 0.0
.data 1916 1916 0 0.0
.text 850588 850588 0 0.0
esp32 all-clusters-app c3devkit (read only) 956574 956574 0 0.0
(read/write) 1392986 1392986 0 0.0
.dram0.bss 62592 62592 0 0.0
.dram0.data 14228 14228 0 0.0
.flash.rodata 197248 197248 0 0.0
.flash.text 956574 956574 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1004711 1004711 0 0.0
(read/write) 458264 458264 0 0.0
.dram0.bss 68096 68096 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 224600 224600 0 0.0
.flash.text 999327 999327 0 0.0
.iram0.text 122767 122767 0 0.0
k32w light k32w061+release (read/write) 691904 691904 0 0.0
.bss 77480 77480 0 0.0
.data 1924 1924 0 0.0
.text 606700 606700 0 0.0
lock k32w061+release (read/write) 695176 695176 0 0.0
.bss 77688 77688 0 0.0
.data 1964 1964 0 0.0
.text 609724 609724 0 0.0
linux all-clusters-app debug (read only) 2395017 2395017 0 0.0
(read/write) 144696 144696 0 0.0
.bss 59232 59232 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78392 78392 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 204869 204869 0 0.0
.text 2027378 2027378 0 0.0
bridge-app debug+rpc (read only) 1720741 1720741 0 0.0
(read/write) 92744 92744 0 0.0
.bss 47552 47552 0 0.0
.data 2042 2042 0 0.0
.data.rel.ro 38088 38088 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141460 141460 0 0.0
.text 1463477 1463477 0 0.0
chip-tool debug (read only) 9003445 9003445 0 0.0
(read/write) 298816 298816 0 0.0
.bss 40448 40448 0 0.0
.data 1164 1164 0 0.0
.data.rel.ro 251144 251144 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 481205 481205 0 0.0
.text 7913333 7913333 0 0.0
chip-tool-ipv6only arm64 (read only) 8757484 8757484 0 0.0
(read/write) 412049 412049 0 0.0
.bss 58673 58673 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 296840 296840 0 0.0
.dynamic 560 560 0 0.0
.got 51512 51512 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 457028 457028 0 0.0
.text 7435172 7435172 0 0.0
door-lock-app debug (read only) 1936305 1936305 0 0.0
(read/write) 119136 119136 0 0.0
.bss 50496 50496 0 0.0
.data 1050 1050 0 0.0
.data.rel.ro 62200 62200 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173532 173532 0 0.0
.text 1614290 1614290 0 0.0
lighting-app debug+rpc (read only) 2071505 2071505 0 0.0
(read/write) 124496 124496 0 0.0
.bss 51424 51424 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66144 66144 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 166225 166225 0 0.0
.text 1749826 1749826 0 0.0
ota-provider-app debug (read only) 1868393 1868393 0 0.0
(read/write) 114800 114800 0 0.0
.bss 50368 50368 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57480 57480 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158707 158707 0 0.0
.text 1559122 1559122 0 0.0
ota-requestor-app debug (read only) 1879369 1879369 0 0.0
(read/write) 116568 116568 0 0.0
.bss 51232 51232 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 58744 58744 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 152420 152420 0 0.0
.text 1578114 1578114 0 0.0
shell debug (read only) 2363201 2363201 0 0.0
(read/write) 147176 147176 0 0.0
.bss 67552 67552 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73096 73096 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 204786 204786 0 0.0
.text 2001858 2001858 0 0.0
thermostat-no-ble arm64 (read only) 2163236 2163236 0 0.0
(read/write) 148577 148577 0 0.0
.bss 65265 65265 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 75080 75080 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132964 132964 0 0.0
.text 1811968 1811968 0 0.0
tv-app debug (read only) 2589505 2589505 0 0.0
(read/write) 148632 148632 0 0.0
.bss 65824 65824 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 198653 198653 0 0.0
.text 2217090 2217090 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350140 2350140 0 0.0
.bss 187092 187092 0 0.0
.data 5776 5776 0 0.0
.text 1312740 1312740 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038939 1075259 36320 3.5
bss 125756 127608 1852 1.5
rodata 135900 141804 5904 4.3
text 700076 728436 28360 4.1
p6 all-clusters-app default (read/write) 2488104 2488104 0 0.0
.bss 118664 118664 0 0.0
.data 2688 2688 0 0.0
.text 1446368 1446368 0 0.0
light-app default (read/write) 2395304 2395304 0 0.0
.bss 112984 112984 0 0.0
.data 2536 2536 0 0.0
.text 1353568 1353568 0 0.0
lock-app default (read/write) 2358880 2358880 0 0.0
.bss 112728 112728 0 0.0
.data 2496 2496 0 0.0
.text 1317144 1317144 0 0.0
qpg lighting-app qpg6105+debug (read only) 601200 601200 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90904 90904 0 0.0
.data 1124 1124 0 0.0
.text 595880 595880 0 0.0
lock-app qpg6105+debug (read only) 566964 566964 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90912 90912 0 0.0
.data 1076 1076 0 0.0
.text 561644 561644 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883126 883126 0 0.0
bss 86336 86336 0 0.0
noinit 37160 37160 0 0.0
text 623982 623982 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 235a4ac into project-chip:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
examples review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rgoliver @andy31415 @bzbarsky-apple